Extension Settings API: make it so that when leveldb storage areas fail to be

chrome/browser/extensions/settings/settings_backend.h

Index: chrome/browser/extensions/settings/settings_backend.h
diff --git a/chrome/browser/extensions/settings/settings_backend.h b/chrome/browser/extensions/settings/settings_backend.h
index 58f1d0200518500bf5a4172bcb291838e8ea789b..1c6366fc5c2ce234aa9355e5a9cf9317f7eed7c9 100644
--- a/chrome/browser/extensions/settings/settings_backend.h
+++ b/chrome/browser/extensions/settings/settings_backend.h
@@ -12,6 +12,7 @@
 #include "base/memory/ref_counted.h"
 #include "base/observer_list_threadsafe.h"
 #include "base/task.h"
+#include "chrome/browser/extensions/settings/settings_leveldb_storage.h"
 #include "chrome/browser/extensions/settings/settings_observer.h"
 #include "chrome/browser/extensions/settings/syncable_settings_storage.h"
 #include "chrome/browser/sync/api/syncable_service.h"
@@ -23,10 +24,13 @@ namespace extensions {
 // Lives entirely on the FILE thread.
 class SettingsBackend : public SyncableService {
  public:
+  // |storage_factory| is use to create leveldb storage areas.
   // |base_path| is the base of the extension settings directory, so the
   // databases will be at base_path/extension_id.
   // |observers| is the list of observers to settings changes.
   explicit SettingsBackend(
+      // Ownership NOT taken.
+      SettingsStorageFactory* storage_factory,
       const FilePath& base_path,
       const scoped_refptr<SettingsObserverList>& observers);
 
@@ -68,6 +72,9 @@ class SettingsBackend : public SyncableService {
   // installed extensions.
   std::set<std::string> GetKnownExtensionIDs() const;
 
+  // The Factory to use for creating leveldb storage areas.  Not owned.
+  SettingsStorageFactory* const storage_factory_;

[Matt Perry, 2011/11/11 00:49:38]

Is there a reason this is const? This will just prevent you from pointing
storage_factory_ at a different object. Did you mean "const
SettingsStorageFactory*" (which will prevent you from modifying the data of the
object being pointed to)?

[not at google - send to devlin, 2011/11/12 02:10:27]

Yep that was deliberate.  It could be "const SettingsStoargeFactory* const
storage_factory_" but "const SettingsStorageFactory" isn't really that
interesting, it would mean I'd need to add const to the ::Create methods, which
is just boring.

I... like to add const to pointers in the same way that I like putting final to
members in Java... just documentation that this won't change.

+
   // The base file path to create any leveldb databases at.
   const FilePath base_path_;