Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5136)

Unified Diff: chrome/browser/extensions/settings/settings_api.cc

Issue 8497065: Extension Settings API: make it so that when leveldb storage areas fail to be (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings/settings_api.cc
diff --git a/chrome/browser/extensions/settings/settings_api.cc b/chrome/browser/extensions/settings/settings_api.cc
index 1a7916a1221f8c46763e4bcf801ecc700bcfa83e..a927a01287754a7b18b88a387426d397768f47e7 100644
--- a/chrome/browser/extensions/settings/settings_api.cc
+++ b/chrome/browser/extensions/settings/settings_api.cc
@@ -2,10 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/browser/extensions/settings/settings_api.h"
+
#include "base/bind.h"
#include "base/values.h"
#include "chrome/browser/extensions/extension_service.h"
-#include "chrome/browser/extensions/settings/settings_api.h"
+#include "chrome/browser/extensions/settings/settings_frontend.h"
#include "chrome/browser/profiles/profile.h"
#include "content/public/browser/browser_thread.h"
@@ -35,10 +37,7 @@ void SettingsFunction::RunWithStorageOnFileThread(
scoped_refptr<SettingsObserverList> observers,
SettingsStorage* storage) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
- bool success = false;
- if (storage) {
- success = RunWithStorage(observers.get(), storage);
- }
+ bool success = RunWithStorage(observers.get(), storage);
not at google - send to devlin 2011/11/10 06:59:33 (storage can't be NULL)
BrowserThread::PostTask(
BrowserThread::UI,
FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698