Extension Settings API: make it so that when leveldb storage areas fail to be

chrome/browser/extensions/settings/settings_storage_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/settings/settings_storage_unittest.h"
 
 #include "base/json/json_writer.h"
 #include "base/file_util.h"
 #include "base/values.h"
 
@@ skipping 116 matching lines @@
     }
     if (!ValuesEqual(expected_change.old_value(), it->old_value(), &error)) {
       return testing::AssertionFailure() <<
           "Old value for " << it->key() << " was unexpected: " << error;
     }
   }
 
   return testing::AssertionSuccess();
 }
 
-SettingsStorageTest::SettingsStorageTest()
+ExtensionSettingsStorageTest::ExtensionSettingsStorageTest()
     : key1_("foo"),
       key2_("bar"),
       key3_("baz"),
       empty_dict_(new DictionaryValue()),
       dict1_(new DictionaryValue()),
       dict3_(new DictionaryValue()),
       dict12_(new DictionaryValue()),
       dict123_(new DictionaryValue()),
       ui_thread_(BrowserThread::UI, MessageLoop::current()),
       file_thread_(BrowserThread::FILE, MessageLoop::current()) {
@@ skipping 21 matching lines @@
 
   dict1_->Set(key1_, val1_->DeepCopy());
   dict3_->Set(key3_, val3_->DeepCopy());
   dict12_->Set(key1_, val1_->DeepCopy());
   dict12_->Set(key2_, val2_->DeepCopy());
   dict123_->Set(key1_, val1_->DeepCopy());
   dict123_->Set(key2_, val2_->DeepCopy());
   dict123_->Set(key3_, val3_->DeepCopy());
 }
 
-SettingsStorageTest::~SettingsStorageTest() {}
+ExtensionSettingsStorageTest::~ExtensionSettingsStorageTest() {}
 
-void SettingsStorageTest::SetUp() {
+void ExtensionSettingsStorageTest::SetUp() {
   ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
   storage_.reset((GetParam())(temp_dir_.path(), "fakeExtension"));
   ASSERT_TRUE(storage_.get());
 }
 
-void SettingsStorageTest::TearDown() {
+void ExtensionSettingsStorageTest::TearDown() {
   storage_.reset();
 }
 
-TEST_P(SettingsStorageTest, GetWhenEmpty) {
+TEST_P(ExtensionSettingsStorageTest, GetWhenEmpty) {
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(empty_list_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(list123_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get());
 }
 
-TEST_P(SettingsStorageTest, GetWithSingleValue) {
+TEST_P(ExtensionSettingsStorageTest, GetWithSingleValue) {
   {
     SettingChangeList changes;
     changes.push_back(SettingChange(key1_, NULL, val1_->DeepCopy()));
     EXPECT_PRED_FORMAT2(ChangesEq, changes, storage_->Set(key1_, *val1_));
   }
 
   EXPECT_PRED_FORMAT2(SettingsEq, *dict1_, storage_->Get(key1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key2_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key3_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(empty_list_));
   EXPECT_PRED_FORMAT2(SettingsEq, *dict1_, storage_->Get(list123_));
   EXPECT_PRED_FORMAT2(SettingsEq, *dict1_, storage_->Get());
 }
 
-TEST_P(SettingsStorageTest, GetWithMultipleValues) {
+TEST_P(ExtensionSettingsStorageTest, GetWithMultipleValues) {
   {
     SettingChangeList changes;
     changes.push_back(SettingChange(key1_, NULL, val1_->DeepCopy()));
     changes.push_back(SettingChange(key2_, NULL, val2_->DeepCopy()));
     EXPECT_PRED_FORMAT2(ChangesEq, changes, storage_->Set(*dict12_));
   }
 
   EXPECT_PRED_FORMAT2(SettingsEq, *dict1_, storage_->Get(key1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key3_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(empty_list_));
   EXPECT_PRED_FORMAT2(SettingsEq, *dict12_, storage_->Get(list123_));
   EXPECT_PRED_FORMAT2(SettingsEq, *dict12_, storage_->Get());
 }
 
-TEST_P(SettingsStorageTest, RemoveWhenEmpty) {
+TEST_P(ExtensionSettingsStorageTest, RemoveWhenEmpty) {
   EXPECT_PRED_FORMAT2(ChangesEq,
       SettingChangeList(), storage_->Remove(key1_));
 
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(list1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get());
 }
 
-TEST_P(SettingsStorageTest, RemoveWithSingleValue) {
+TEST_P(ExtensionSettingsStorageTest, RemoveWithSingleValue) {
   storage_->Set(*dict1_);
   {
     SettingChangeList changes;
     changes.push_back(SettingChange(key1_, val1_->DeepCopy(), NULL));
     EXPECT_PRED_FORMAT2(ChangesEq, changes, storage_->Remove(key1_));
   }
 
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key2_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(list1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(list12_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get());
 }
 
-TEST_P(SettingsStorageTest, RemoveWithMultipleValues) {
+TEST_P(ExtensionSettingsStorageTest, RemoveWithMultipleValues) {
   storage_->Set(*dict123_);
   {
     SettingChangeList changes;
     changes.push_back(SettingChange(key3_, val3_->DeepCopy(), NULL));
     EXPECT_PRED_FORMAT2(ChangesEq, changes, storage_->Remove(key3_));
   }
 
   EXPECT_PRED_FORMAT2(SettingsEq, *dict1_, storage_->Get(key1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key3_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(empty_list_));
@@ skipping 13 matching lines @@
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key3_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(empty_list_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(list1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(list12_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(list13_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(list123_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get());
 }
 
-TEST_P(SettingsStorageTest, SetWhenOverwriting) {
+TEST_P(ExtensionSettingsStorageTest, SetWhenOverwriting) {
   storage_->Set(key1_, *val2_);
   {
     SettingChangeList changes;
     changes.push_back(
         SettingChange(key1_, val2_->DeepCopy(), val1_->DeepCopy()));
     changes.push_back(SettingChange(key2_, NULL, val2_->DeepCopy()));
     EXPECT_PRED_FORMAT2(ChangesEq, changes, storage_->Set(*dict12_));
   }
 
   EXPECT_PRED_FORMAT2(SettingsEq, *dict1_, storage_->Get(key1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key3_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(empty_list_));
   EXPECT_PRED_FORMAT2(SettingsEq, *dict1_, storage_->Get(list1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *dict12_, storage_->Get(list12_));
   EXPECT_PRED_FORMAT2(SettingsEq, *dict1_, storage_->Get(list13_));
   EXPECT_PRED_FORMAT2(SettingsEq, *dict12_, storage_->Get(list123_));
   EXPECT_PRED_FORMAT2(SettingsEq, *dict12_, storage_->Get());
 }
 
-TEST_P(SettingsStorageTest, ClearWhenEmpty) {
+TEST_P(ExtensionSettingsStorageTest, ClearWhenEmpty) {
   EXPECT_PRED_FORMAT2(ChangesEq,
       SettingChangeList(), storage_->Clear());
 
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(empty_list_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(list123_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get());
 }
 
-TEST_P(SettingsStorageTest, ClearWhenNotEmpty) {
+TEST_P(ExtensionSettingsStorageTest, ClearWhenNotEmpty) {
   storage_->Set(*dict12_);
   {
     SettingChangeList changes;
     changes.push_back(SettingChange(key1_, val1_->DeepCopy(), NULL));
     changes.push_back(SettingChange(key2_, val2_->DeepCopy(), NULL));
     EXPECT_PRED_FORMAT2(ChangesEq, changes, storage_->Clear());
   }
 
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(key1_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(empty_list_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(list123_));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get());
 }
 
 // Dots should be allowed in key names; they shouldn't be interpreted as
 // indexing into a dictionary.
-TEST_P(SettingsStorageTest, DotsInKeyNames) {
+TEST_P(ExtensionSettingsStorageTest, DotsInKeyNames) {
   std::string dot_key("foo.bar");
   StringValue dot_value("baz.qux");
   std::vector<std::string> dot_list;
   dot_list.push_back(dot_key);
   DictionaryValue dot_dict;
   dot_dict.SetWithoutPathExpansion(dot_key, dot_value.DeepCopy());
 
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(dot_key));
 
   {
@@ skipping 29 matching lines @@
     SettingChangeList changes;
     changes.push_back(
         SettingChange(dot_key, dot_value.DeepCopy(), NULL));
     EXPECT_PRED_FORMAT2(ChangesEq, changes, storage_->Remove(dot_list));
   }
 
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get(dot_key));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get());
 }
 
-TEST_P(SettingsStorageTest, DotsInKeyNamesWithDicts) {
+TEST_P(ExtensionSettingsStorageTest, DotsInKeyNamesWithDicts) {
   DictionaryValue outer_dict;
   DictionaryValue* inner_dict = new DictionaryValue();
   outer_dict.Set("foo", inner_dict);
   inner_dict->SetString("bar", "baz");
 
   {
     SettingChangeList changes;
     changes.push_back(
         SettingChange("foo", NULL, inner_dict->DeepCopy()));
     EXPECT_PRED_FORMAT2(ChangesEq, changes, storage_->Set(outer_dict));
   }
 
   EXPECT_PRED_FORMAT2(SettingsEq, outer_dict, storage_->Get("foo"));
   EXPECT_PRED_FORMAT2(SettingsEq, *empty_dict_, storage_->Get("foo.bar"));
 }
 
-TEST_P(SettingsStorageTest, ComplexChangedKeysScenarios) {
+TEST_P(ExtensionSettingsStorageTest, ComplexChangedKeysScenarios) {
   // Test:
   //   - Setting over missing/changed/same keys, combinations.
   //   - Removing over missing and present keys, combinations.
   //   - Clearing.
   std::vector<std::string> complex_list;
   DictionaryValue complex_changed_dict;
 
   storage_->Set(key1_, *val1_);
   EXPECT_PRED_FORMAT2(ChangesEq,
       SettingChangeList(), storage_->Set(key1_, *val1_));
@@ skipping 71 matching lines @@
     changes.push_back(SettingChange(key3_, val3_->DeepCopy(), NULL));
     changes.push_back(
         SettingChange("qwerty", val3_->DeepCopy(), NULL));
     EXPECT_PRED_FORMAT2(ChangesEq, changes, storage_->Clear());
     EXPECT_PRED_FORMAT2(ChangesEq,
         SettingChangeList(), storage_->Clear());
   }
 }
 
 }  // namespace extensions