Issue 8497048: Fix invalid reads detected by Valgrind when the frame size changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8497048: Fix invalid reads detected by Valgrind when the frame size changes. (Closed)

Created:
9 years, 1 month ago by acolwell GONE FROM CHROMIUM

Modified:
9 years, 1 month ago

Reviewers:
rbultje1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/

Visibility:
Public.

Description

Fix invalid reads detected by Valgrind when the frame size changes. BUG=102789 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109319

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -5 lines)			Patch
M	third_party/ffmpeg/README.chromium	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	third_party/ffmpeg/patches/README	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	third_party/ffmpeg/patches/to_upstream/50_vp8_fix_frame_size_changes.patch	View	1 chunk	+50 lines, -0 lines	0 comments	Download
M	third_party/ffmpeg/source/patched-ffmpeg/libavcodec/pthread.c	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	third_party/ffmpeg/source/patched-ffmpeg/libavcodec/vp8.c	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

9 years, 1 month ago (2011-11-09 19:23:18 UTC) #3

On 2011/11/09 19:15:59, rbultje1 wrote:
> Awesome, LGTM.
> 
> (Why are the trybots red?)
Thanks. They are red because I foolishly tried to initiate the try from the
chrome/deps/ directory so the patch didn't apply cleanly. I'm going to try
again. ;)

Expand Messages | Collapse Messages