Issue 8497041: Tighten handling of pthread_create errors on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8497041: Tighten handling of pthread_create errors on Linux. (Closed)

Created:
9 years, 1 month ago by kisg

Modified:
9 years, 1 month ago

Reviewers:
Paul Lind, Vitaly Repeshko, danno

CC:
v8-dev

Visibility:
Public.

Description

Tighten handling of pthread_create errors on Linux. The return value of pthread_create is now checked to be 0. Tests on MIPS boards had some silent and hard to find timeouts and errors related to this. This ensures a proper error message and shutdown if a thread could not be started. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9945

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/platform-linux.cc	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kisg

We ran into this issue when tried to fix the test-locker failures on MIPS, which ...

9 years, 1 month ago (2011-11-09 11:49:20 UTC) #1

Vitaly Repeshko

9 years, 1 month ago (2011-11-09 19:03:47 UTC) #2

LGTM. Landed in r9945.


Thanks,
Vitaly

http://codereview.chromium.org/8497041/diff/1/src/platform-linux.cc
File src/platform-linux.cc (left):

http://codereview.chromium.org/8497041/diff/1/src/platform-linux.cc#oldcode772
src/platform-linux.cc:772: ASSERT(data_->thread_ != kNoThread);
Let's keep the assert.

Expand Messages | Collapse Messages