Issue 8497034: Add tests to make sure gpu blacklist actually block gpu features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8497034: Add tests to make sure gpu blacklist actually block gpu features. (Closed)

Created:
9 years, 1 month ago by Zhenyao Mo

Modified:
9 years, 1 month ago

Reviewers:
apatrick_chromium, jbates

CC:
chromium-reviews, jam, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., nduca, jamesr

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add tests to make sure gpu blacklist actually block gpu features. The general idea is to use jbates's newly added tracing: if a feature is blacklisted, we check the tracing data to make sure gpu process hasn't launched. BUG=101222 TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109328

Patch Set 1 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+263 lines, -0 lines)			Patch
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/gpu/feature_canvas2d.html	View	1 chunk	+35 lines, -0 lines	0 comments	Download
A	chrome/test/data/gpu/feature_compositing.html	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	chrome/test/data/gpu/feature_webgl.html	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	chrome/test/gpu/gpu_feature_browsertest.cc	View	1 chunk	+171 lines, -0 lines	0 comments	Download
M	content/browser/gpu/gpu_process_host.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Zhenyao Mo

The long-waited tests are finally coming. John, Al, please review.

9 years, 1 month ago (2011-11-09 01:14:57 UTC) #1

lgtm

Expand Messages | Collapse Messages