This includes small updates to the inspectedWindow.html documentation.

This includes small updates to the inspectedWindow.html documentation.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109618

[caseq, 2011-11-09 10:24:07]

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
File chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html
(right):

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:413:
This method if powerful when used in the right context,
if -> is
also, are you sure we need comma before dependent clause?

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:415: In
key instances,
"key instances" sounds a bit unclear (what are they?)

Can we be more imperative here, like "Use the
<code>chrome.tabs.executeScript()</code> method unless you need the specific
functionality the <code>eval()</code> method provides."?

[kathyw, 2011-11-09 17:43:21]

a few picky comments...

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
File chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html
(right):

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:392:
the inspected window: obtain tab ID for the inspected page, evaluate the code
tab ID -> the tab ID

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:394:
obtain the list of resources within the page.
we need a conjunction ("or"?) to finish off this list. If the list isn't
complete, you could add ", and so on"

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:403:
provides the tab identifier that may be used with the <a href="tabs.html">
may be used with the -> you can use if you need to make

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:415: In
key instances,
caseq's suggestion sounds good to me.

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:429:
Tools console API</a> (e.g. <code>inspect()</code>, <code>$0</code> etc).
We avoid Latin abbreviations ("e.g.", "i.e.", "etc.", etc.).

So maybe something like:

...API; for example, the code can use inspect() and $0.

 (but formatted better)

[caseq, 2011-11-09 18:22:41]

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
File chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html
(right):

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:403:
provides the tab identifier that may be used with the <a href="tabs.html">
On 2011/11/09 17:43:22, kathyw wrote:
> may be used with the -> you can use if you need to make

just "you can use with the", perhaps?

[mkearney, 2011-11-09 21:19:15]

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
File chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html
(right):

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:392:
the inspected window: obtain tab ID for the inspected page, evaluate the code
On 2011/11/09 17:43:22, kathyw wrote:
> tab ID -> the tab ID

Done.

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:394:
obtain the list of resources within the page.
On 2011/11/09 17:43:22, kathyw wrote:
> we need a conjunction ("or"?) to finish off this list. If the list isn't
> complete, you could add ", and so on"

Done.

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:403:
provides the tab identifier that may be used with the <a href="tabs.html">
On 2011/11/09 17:43:22, kathyw wrote:
> may be used with the -> you can use if you need to make

worded a little differently - that you can use if needed with the...

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:403:
provides the tab identifier that may be used with the <a href="tabs.html">
On 2011/11/09 18:22:41, caseq wrote:
> On 2011/11/09 17:43:22, kathyw wrote:
> > may be used with the -> you can use if you need to make
> 
> just "you can use with the", perhaps?

Done.

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:413:
This method if powerful when used in the right context,
On 2011/11/09 10:24:07, caseq wrote:
> if -> is
> also, are you sure we need comma before dependent clause?

Done.

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:415: In
key instances,
On 2011/11/09 10:24:07, caseq wrote:
> "key instances" sounds a bit unclear (what are they?)
> 
> Can we be more imperative here, like "Use the
> <code>chrome.tabs.executeScript()</code> method unless you need the specific
> functionality the <code>eval()</code> method provides."?

Done.

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:415: In
key instances,
On 2011/11/09 17:43:22, kathyw wrote:
> caseq's suggestion sounds good to me.

Done.

http://codereview.chromium.org/8497027/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:429:
Tools console API</a> (e.g. <code>inspect()</code>, <code>$0</code> etc).
On 2011/11/09 17:43:22, kathyw wrote:
> We avoid Latin abbreviations ("e.g.", "i.e.", "etc.", etc.).
> 
> So maybe something like:
> 
> ...API; for example, the code can use inspect() and $0.
> 
>  (but formatted better)

Done.

[caseq1, 2011-11-10 11:49:21]

lgtm

[mkearney, 2011-11-10 17:40:11]

Kathy,

Can you submit this one for me?

Thanks very much.

Meggin

On Thu, Nov 10, 2011 at 3:49 AM, <caseq@google.com> wrote:

> lgtm
>
>
http://codereview.chromium.**org/8497027/<http://codereview.chromium.org/8497...
>

[commit-bot: I haz the power, 2011-11-10 18:01:20]

No LGTM from valid reviewers yet.

[kathyw, 2011-11-10 18:21:56]

just one nit

http://codereview.chromium.org/8497027/diff/8001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html
(right):

http://codereview.chromium.org/8497027/diff/8001/chrome/common/extensions/doc...
chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html:415:
This method if powerful when used in the right context
if -> is

[mkearney, 2011-11-10 18:37:16]

Somehow missed that one - Andrey raised it as well.

Fixed now.

[kathyw, 2011-11-10 20:35:47]

lgtm

[commit-bot: I haz the power, 2011-11-11 10:58:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkearney@google.com/8497027/17001

[commit-bot: I haz the power, 2011-11-11 12:05:26]

Change committed as 109618