Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1878)

Unified Diff: chrome/browser/resources/file_manager/main.html

Issue 8497009: Simplifying loading file JS and CSS files from external source. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/file_manager/js/metadata_provider.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/main.html
diff --git a/chrome/browser/resources/file_manager/main.html b/chrome/browser/resources/file_manager/main.html
index 117c18e48852eb840cbee016307fcdc7b9d6c722..ecd5018e02857b2f5b319e648e8b9e117cd31979 100644
--- a/chrome/browser/resources/file_manager/main.html
+++ b/chrome/browser/resources/file_manager/main.html
@@ -9,7 +9,35 @@
<!-- metrics.js initiates load performance tracking
Vladislav Kaznacheev 2011/11/10 11:35:51 This is from a different patch. Something wrong wi
SeRya 2011/11/10 14:38:59 There is no difference with head in this place.
so we want to parse it as early as possible -->
<script src="js/metrics.js"></script>
-
+ <if expr="0">
+ <!-- <if ... /if> is removed while flattening HTML. -->
+ <script>
+ // Instruction for enabling loading file manager files remotely (speeds up
+ // development cycle):
+ //
+ // 1. Find the IDR_FILE_MANAGER_MAIN resource in
+ // chrome/browser/resources/component_extension_resources.grd.
+ // Change the "flattenhtml" attribute to false.
+ //
+ // 2. Build and run the Chromium OS.
+ //
+ // 3. Make source files available via the HTTP protocol:
+ // twistd web --path chrome/browser/resources/file_manager --port 1080
+ //
+ // 4. Open the File Manager. Execute the following JS code in its context
+ // using DevTools:
+ // localStorage['base'] = 'http://youmachine:1080/'
+ //
+ // Since that the File Manager will use frash JS and CSS files. HTML
+ // files and JS files for WebWorkers are still need rebuild to update.
Vladislav Kaznacheev 2011/11/10 11:35:51 Lets put it this way: This will make the File Mana
SeRya 2011/11/10 14:38:59 Done.
+
+ if (localStorage['base']) {
+ var base = document.createElement('base');
+ base.setAttribute('href', localStorage['base']);
+ document.head.appendChild(base);
+ }
+ </script>
+ </if>
<script>
// Resources from shared locations are loaded dynamically, so we can
// get them from file:// when running as a normal web page, and from
« no previous file with comments | « chrome/browser/resources/file_manager/js/metadata_provider.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698