Simplifying loading file JS and CSS files from external source.

Simplifying loading file JS and CSS files from external source.

File manager may load its external from external source (for instance from chrome source files made available via HTTP protocol).
To achieve that file manager's mail.html flattening should be switched off (flattenhtml="false" for IDR_FILE_MANAGER_MAIN in chrome/browser/resources/component_extension_resources.grd)
and source base in the file manager must be spectified:

localStorage['base'] = 'http://youmachine:1080/' // to run in the context of the file manager using dev tools

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109601

[SeRya, 2011-11-10 10:04:08]

Made fixed discussed verbally.

[Vladislav Kaznacheev, 2011-11-10 11:35:50]

LGTM with comments

http://codereview.chromium.org/8497009/diff/2001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/main.html (right):

http://codereview.chromium.org/8497009/diff/2001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/main.html:9: <!-- metrics.js initiates
load performance tracking
This is from a different patch. Something wrong with merge.

http://codereview.chromium.org/8497009/diff/2001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/main.html:32: // files and JS files for
WebWorkers are still need rebuild to update.
Lets put it this way:
This will make the File Manager use fresh JS and CSS files from the development
machine. HTML files and JS files for WebWorkers would still need a rebuild to
update.

[SeRya, 2011-11-10 14:38:59]

http://codereview.chromium.org/8497009/diff/2001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/main.html (right):

http://codereview.chromium.org/8497009/diff/2001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/main.html:9: <!-- metrics.js initiates
load performance tracking
On 2011/11/10 11:35:51, Vladislav Kaznacheev wrote:
> This is from a different patch. Something wrong with merge.

There is no difference with head in this place.

http://codereview.chromium.org/8497009/diff/2001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/main.html:32: // files and JS files for
WebWorkers are still need rebuild to update.
On 2011/11/10 11:35:51, Vladislav Kaznacheev wrote:
> Lets put it this way:
> This will make the File Manager use fresh JS and CSS files from the
development
> machine. HTML files and JS files for WebWorkers would still need a rebuild to
> update.

Done.

[commit-bot: I haz the power, 2011-11-10 14:39:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/serya@chromium.org/8497009/8001

[commit-bot: I haz the power, 2011-11-10 15:50:11]

Can't apply patch for file
chrome/browser/resources/file_manager/js/metadata_provider.js.
While running patch -p1 --forward --force;
patching file chrome/browser/resources/file_manager/js/metadata_provider.js
Hunk #2 FAILED at 106.
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/resources/file_manager/js/metadata_provider.js.rej