Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: chrome/browser/ui/views/extensions/extension_dialog.cc

Issue 8497008: Implement Bookmark All Tabs Dialog with WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fix Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_dialog.cc
diff --git a/chrome/browser/ui/views/extensions/extension_dialog.cc b/chrome/browser/ui/views/extensions/extension_dialog.cc
index c2bc0b60e090f673eb0bba3f50be5093f3826a99..fc04756dfc5851f6617bb64f6560900be816ea81 100644
--- a/chrome/browser/ui/views/extensions/extension_dialog.cc
+++ b/chrome/browser/ui/views/extensions/extension_dialog.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/ui/views/extensions/extension_dialog.h"
+#include "base/utf_string_conversions.h"
mazda 2011/11/10 06:03:46 This is no longer necessary.
yoshiki 2011/11/10 07:54:38 Done.
#include "chrome/browser/extensions/extension_host.h"
#include "chrome/browser/extensions/extension_process_manager.h"
#include "chrome/browser/profiles/profile.h"
@@ -63,6 +64,7 @@ ExtensionDialog* ExtensionDialog::Show(
TabContents* tab_contents,
int width,
int height,
+ const string16& title,
ExtensionDialogObserver* observer) {
CHECK(browser);
ExtensionHost* host = CreateExtensionHost(url, browser);
@@ -71,6 +73,7 @@ ExtensionDialog* ExtensionDialog::Show(
host->set_associated_tab_contents(tab_contents);
ExtensionDialog* dialog = new ExtensionDialog(host, observer);
+ dialog->set_title(title);
dialog->InitWindow(browser, width, height);
// Ensure the DOM JavaScript can respond immediately to keyboard shortcuts.
host->render_view_host()->view()->Focus();
@@ -129,7 +132,11 @@ bool ExtensionDialog::IsModal() const {
}
bool ExtensionDialog::ShouldShowWindowTitle() const {
- return false;
+ return !window_title_.empty();
+}
+
+string16 ExtensionDialog::GetWindowTitle() const {
+ return window_title_;
}
void ExtensionDialog::DeleteDelegate() {

Powered by Google App Engine
This is Rietveld 408576698