OLD | NEW |
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/chromeos/dbus/cros_disks_client.h" | 5 #include "chrome/browser/chromeos/dbus/cros_disks_client.h" |
6 | 6 |
7 #include "base/bind.h" | 7 #include "base/bind.h" |
8 #include "base/memory/scoped_vector.h" | 8 #include "base/stl_util.h" |
9 #include "chrome/browser/chromeos/system/runtime_environment.h" | 9 #include "chrome/browser/chromeos/system/runtime_environment.h" |
10 #include "dbus/bus.h" | 10 #include "dbus/bus.h" |
11 #include "dbus/message.h" | 11 #include "dbus/message.h" |
12 #include "dbus/object_proxy.h" | 12 #include "dbus/object_proxy.h" |
13 #include "third_party/cros_system_api/dbus/service_constants.h" | 13 #include "third_party/cros_system_api/dbus/service_constants.h" |
14 | 14 |
15 namespace chromeos { | 15 namespace chromeos { |
16 | 16 |
17 namespace { | 17 namespace { |
18 | 18 |
(...skipping 450 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
469 // } | 469 // } |
470 // ] | 470 // ] |
471 void DiskInfo::InitializeFromResponse(dbus::Response* response) { | 471 void DiskInfo::InitializeFromResponse(dbus::Response* response) { |
472 dbus::MessageReader response_reader(response); | 472 dbus::MessageReader response_reader(response); |
473 dbus::MessageReader array_reader(response); | 473 dbus::MessageReader array_reader(response); |
474 if (!response_reader.PopArray(&array_reader)) { | 474 if (!response_reader.PopArray(&array_reader)) { |
475 LOG(ERROR) << "Invalid response: " << response->ToString(); | 475 LOG(ERROR) << "Invalid response: " << response->ToString(); |
476 return; | 476 return; |
477 } | 477 } |
478 // TODO(satorux): Rework this code using Protocol Buffers. crosbug.com/22626 | 478 // TODO(satorux): Rework this code using Protocol Buffers. crosbug.com/22626 |
479 ScopedVector<dbus::MessageReader> value_readers_owner; | 479 typedef std::map<std::string, dbus::MessageReader*> PropertiesMap; |
480 std::map<std::string, dbus::MessageReader*> properties; | 480 PropertiesMap properties; |
| 481 STLValueDeleter<PropertiesMap> properties_value_deleter(&properties); |
481 while (array_reader.HasMoreData()) { | 482 while (array_reader.HasMoreData()) { |
482 // |value_readers_owner| is responsible to delete |value_reader|. | |
483 dbus::MessageReader* value_reader = new dbus::MessageReader(response); | 483 dbus::MessageReader* value_reader = new dbus::MessageReader(response); |
484 value_readers_owner.push_back(value_reader); | |
485 dbus::MessageReader dict_entry_reader(response); | 484 dbus::MessageReader dict_entry_reader(response); |
486 std::string key; | 485 std::string key; |
487 if (!array_reader.PopDictEntry(&dict_entry_reader) || | 486 if (!array_reader.PopDictEntry(&dict_entry_reader) || |
488 !dict_entry_reader.PopString(&key) || | 487 !dict_entry_reader.PopString(&key) || |
489 !dict_entry_reader.PopVariant(value_reader)) { | 488 !dict_entry_reader.PopVariant(value_reader)) { |
490 LOG(ERROR) << "Invalid response: " << response->ToString(); | 489 LOG(ERROR) << "Invalid response: " << response->ToString(); |
491 return; | 490 return; |
492 } | 491 } |
493 properties[key] = value_reader; | 492 properties[key] = value_reader; |
494 } | 493 } |
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
527 | 526 |
528 // static | 527 // static |
529 CrosDisksClient* CrosDisksClient::Create(dbus::Bus* bus) { | 528 CrosDisksClient* CrosDisksClient::Create(dbus::Bus* bus) { |
530 if (system::runtime_environment::IsRunningOnChromeOS()) | 529 if (system::runtime_environment::IsRunningOnChromeOS()) |
531 return new CrosDisksClientImpl(bus); | 530 return new CrosDisksClientImpl(bus); |
532 else | 531 else |
533 return new CrosDisksClientStubImpl(); | 532 return new CrosDisksClientStubImpl(); |
534 } | 533 } |
535 | 534 |
536 } // namespace chromeos | 535 } // namespace chromeos |
OLD | NEW |