LayoutTests/http/tests/media/video-buffering-repaints-controls.html - Issue 8496044: Repaint video controls when buffering during pause.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/media/video-buffering-repaints-controls.html

Issue 8496044: Repaint video controls when buffering during pause. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Added layout test. Fixed nits. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | LayoutTests/http/tests/media/video-buffering-repaints-controls-expected.txt » ('j') | LayoutTests/http/tests/media/video-buffering-repaints-controls-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script>

	4 var painted = false;

	5 function start() {

	6 if (window.layoutTestController)

	7 layoutTestController.waitUntilDone();

	8

	9 var video = document.getElementsByTagName('video')[0];

	10

	11 video.addEventListener('progress', function(event) {

	12 // Each progress event should correlate to a repaint. Check

	13 // by watching for a repaint between progress events.

	14 if (painted) {

	15 layoutTestController.notifyDone();

	16 } else {

	17 layoutTestController.display();

	18 painted = true;

	19 }

	20 }, false);

	21

	22 // Don't actually play since we're testing via an image diff.

	23 video.src = 'http://127.0.0.1:8000/media/video-throttled-load.cg i?&name=resources/test.ogv&throttle=20&type=video/ogg'
	scherkus (not reviewing) 2011/11/28 22:21:19 take a look at other http/tests/media tests where take a look at other http/tests/media tests where we have a function that chooses the correct filename and MIME type based on platform support DaleCurtis 2011/11/28 23:49:40 Ah, I saw that, but misunderstood what it was doin Ah, I saw that, but misunderstood what it was doing. I'll fix it. On 2011/11/28 22:21:19, scherkus wrote: Show quoted text > take a look at other http/tests/media tests where we have a function that > chooses the correct filename and MIME type based on platform support
	24 }

	25 </script>

	26 </head>

	27

	28 <body onload="start();">

	29 <p>Test that media controls repaint correctly during paused states when new data is buffered.</p>
	scherkus (not reviewing) 2011/11/28 22:21:19 maybe: s/during paused states/while paused/ ? maybe: s/during paused states/while paused/ ? DaleCurtis 2011/11/28 23:49:40 I said paused states instead of paused because I w Show quoted text On 2011/11/28 22:21:19, scherkus wrote: > maybe: s/during paused states/while paused/ ? I said paused states instead of paused because I was trying to differentiate between a never played pause state versus a playing->paused state. Happy to drop it if that's a useless differentiation.
	30 <video controls preload></video><br/>

	31 </body>

	32 </html>

OLD	NEW