Repaint video controls when buffering during pause.

Source/WebCore/html/shadow/MediaControlRootElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 298 matching lines @@
     updateTimeDisplay();
 
     if (m_mediaElement->isFullscreen())
         startHideFullscreenControlsTimer();
 }
 
 void MediaControlRootElement::playbackProgressed()
 {
     m_timeline->setPosition(m_mediaElement->currentTime());
     updateTimeDisplay();
-    
+
     if (!m_isMouseOverControls && m_mediaElement->hasVideo())
         makeTransparent();
 }
 
 void MediaControlRootElement::playbackStopped()
 {
     m_playButton->updateDisplayType();
     m_timeline->setPosition(m_mediaElement->currentTime());
     updateTimeDisplay();
     makeOpaque();
-    
+
     stopHideFullscreenControlsTimer();
 }
 
 void MediaControlRootElement::updateTimeDisplay()
 {
     float now = m_mediaElement->currentTime();
     float duration = m_mediaElement->duration();
 
     Page* page = document()->page();
     if (!page)
@@ skipping 92 matching lines @@
     m_seekForwardButton->show();
     m_returnToRealTimeButton->show();
 
     m_panel->setCanBeDragged(false);
 
     // We will keep using the panel, but we want it to go back to the standard position.
     // This will matter right away because we use the panel even when not fullscreen.
     // And if we reenter fullscreen we also want the panel in the standard position.
     m_panel->resetPosition();
 
-    stopHideFullscreenControlsTimer();    
+    stopHideFullscreenControlsTimer();
 }
 
 void MediaControlRootElement::showVolumeSlider()
 {
     if (!m_mediaElement->hasAudio())
         return;
 
     if (m_volumeSliderContainer)
         m_volumeSliderContainer->show();
 }
@@ skipping 39 matching lines @@
             if (shouldHideControls())
                 startHideFullscreenControlsTimer();
         }
     }
 }
 
 void MediaControlRootElement::startHideFullscreenControlsTimer()
 {
     if (!m_mediaElement->isFullscreen())
         return;
-    
+
     m_hideFullscreenControlsTimer.startOneShot(timeWithoutMouseMovementBeforeHidingControls);
 }
 
 void MediaControlRootElement::hideFullscreenControlsTimerFired(Timer<MediaControlRootElement>*)
 {
     if (!m_mediaElement->isPlaying())
         return;
-    
+
     if (!m_mediaElement->isFullscreen())
         return;
-    
+
     if (!shouldHideControls())
         return;
 
     if (Page* page = m_mediaElement->document()->page())
         page->chrome()->setCursorHiddenUntilMouseMoves(true);
 
     makeTransparent();
 }
 
 void MediaControlRootElement::stopHideFullscreenControlsTimer()
 {
     m_hideFullscreenControlsTimer.stop();
 }
 
 const AtomicString& MediaControlRootElement::shadowPseudoId() const
 {
     DEFINE_STATIC_LOCAL(AtomicString, id, ("-webkit-media-controls"));
     return id;
 }
 
+void MediaControlRootElement::bufferingProgressed()
+{
+    // We only need to update buffering progress when paused, during normal
+    // playback playbackProgressed() will take care of it.
+    if (m_mediaElement->paused())
+      m_timeline->setPosition(m_mediaElement->currentTime());

[scherkus (not reviewing), 2011/11/23 02:43:22]

wk uses 4 space indents

[scherkus (not reviewing), 2011/11/23 02:43:22]

why do we need to reset the position?

[DaleCurtis, 2011/11/24 00:03:23]

Done.

[DaleCurtis, 2011/11/24 00:03:23]

It's the simplest (only?) way to ensure a repaint occurs and it's used above in
the pause/play states 

Another option might be to create a new DOM event (or reuse an existing one) and
call the control's defaultEventHandler(). I didn't see any existing pattern or
obvious event choices, so I stuck with setPosition().

+}
+
 }
 
 #endif