Repaint video controls when buffering during pause.

webkit/glue/webmediaplayer_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/webmediaplayer_impl.h"
 
 #include <limits>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 782 matching lines @@
       SetNetworkState(WebMediaPlayer::DecodeError);
       break;
   }
 
   // Repaint to trigger UI update.
   Repaint();
 }
 
 void WebMediaPlayerImpl::OnNetworkEvent(bool is_downloading_data) {
   DCHECK_EQ(main_loop_, MessageLoop::current());
-  if (is_downloading_data)
+  if (is_downloading_data) {
     SetNetworkState(WebKit::WebMediaPlayer::Loading);
-  else
+    // Issue repaint so buffering progress stays up to date when paused.
+    if (paused_)
+      Repaint();

[scherkus (not reviewing), 2011/11/09 03:47:33]

also I wonder whether a repaint() here is the right course of action

there's a slim possibility that it'll chew up resources while
paused-yet-buffering

is there something we can call on GetClient() to signal that the amount buffered
has changed? perhaps that way we can issue a repaint for just the controls as
opposed to the entire video surface

note that we can add/remove methods to WebMediaPlayerClient interface if need be

[DaleCurtis, 2011/11/09 18:30:02]

Would a comparison to host->GetBufferedBytes() and buffered_bytes_ prior to the
host->SetBufferedBytes(...)  call in BufferedDataSource::NetworkEventCallback()
be sufficient?

When paused these should be monotonically increasing right?

On 2011/11/09 03:47:33, scherkus wrote:

+  } else

[scherkus (not reviewing), 2011/11/09 03:45:28]

nit: use return and exit early instead of else

[DaleCurtis, 2011/11/09 18:30:02]

Done.

     SetNetworkState(WebKit::WebMediaPlayer::Idle);
 }
 
 void WebMediaPlayerImpl::OnDemuxerOpened() {
   DCHECK_EQ(main_loop_, MessageLoop::current());
 
   GetClient()->sourceOpened();
 }
 
 void WebMediaPlayerImpl::SetNetworkState(
@@ skipping 52 matching lines @@
   return client_;
 }
 
 void WebMediaPlayerImpl::IncrementExternallyAllocatedMemory() {
   DCHECK_EQ(main_loop_, MessageLoop::current());
   incremented_externally_allocated_memory_ = true;
   v8::V8::AdjustAmountOfExternalAllocatedMemory(kPlayerExtraMemory);
 }
 
 }  // namespace webkit_glue