Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: net/base/transport_security_state.cc

Issue 8496033: net: remove public key pins for Twitter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/transport_security_state.h" 5 #include "net/base/transport_security_state.h"
6 6
7 #if defined(USE_OPENSSL) 7 #if defined(USE_OPENSSL)
8 #include <openssl/ecdsa.h> 8 #include <openssl/ecdsa.h>
9 #include <openssl/ssl.h> 9 #include <openssl/ssl.h>
10 #else // !defined(USE_OPENSSL) 10 #else // !defined(USE_OPENSSL)
(...skipping 1113 matching lines...) Expand 10 before | Expand all | Expand 10 after
1124 {10, false, "\004kyps\003net", true, kNoPins, DOMAIN_NOT_PINNED }, 1124 {10, false, "\004kyps\003net", true, kNoPins, DOMAIN_NOT_PINNED },
1125 {14, false, "\003www\004kyps\003net", true, kNoPins, DOMAIN_NOT_PINNED }, 1125 {14, false, "\003www\004kyps\003net", true, kNoPins, DOMAIN_NOT_PINNED },
1126 {17, true, "\003app\007recurly\003com", true, kNoPins, DOMAIN_NOT_PINNED }, 1126 {17, true, "\003app\007recurly\003com", true, kNoPins, DOMAIN_NOT_PINNED },
1127 {17, true, "\003api\007recurly\003com", true, kNoPins, DOMAIN_NOT_PINNED }, 1127 {17, true, "\003api\007recurly\003com", true, kNoPins, DOMAIN_NOT_PINNED },
1128 {13, false, "\007greplin\003com", true, kNoPins, DOMAIN_NOT_PINNED }, 1128 {13, false, "\007greplin\003com", true, kNoPins, DOMAIN_NOT_PINNED },
1129 {17, false, "\003www\007greplin\003com", true, kNoPins, DOMAIN_NOT_PINNED }, 1129 {17, false, "\003www\007greplin\003com", true, kNoPins, DOMAIN_NOT_PINNED },
1130 {27, true, "\006luneta\016nearbuysystems\003com", true, kNoPins, 1130 {27, true, "\006luneta\016nearbuysystems\003com", true, kNoPins,
1131 DOMAIN_NOT_PINNED }, 1131 DOMAIN_NOT_PINNED },
1132 {12, true, "\006ubertt\003org", true, kNoPins, DOMAIN_NOT_PINNED }, 1132 {12, true, "\006ubertt\003org", true, kNoPins, DOMAIN_NOT_PINNED },
1133 1133
1134 #if 0
1135 // Twitter pins disabled in order to track down pinning failures --agl
1134 {13, false, "\007twitter\003com", kTwitterHSTS, 1136 {13, false, "\007twitter\003com", kTwitterHSTS,
1135 kTwitterComPins, DOMAIN_TWITTER_COM }, 1137 kTwitterComPins, DOMAIN_TWITTER_COM },
1136 {17, true, "\003www\007twitter\003com", kTwitterHSTS, 1138 {17, true, "\003www\007twitter\003com", kTwitterHSTS,
1137 kTwitterComPins, DOMAIN_TWITTER_COM }, 1139 kTwitterComPins, DOMAIN_TWITTER_COM },
1138 {17, true, "\003api\007twitter\003com", kTwitterHSTS, 1140 {17, true, "\003api\007twitter\003com", kTwitterHSTS,
1139 kTwitterComPins, DOMAIN_TWITTER_COM }, 1141 kTwitterComPins, DOMAIN_TWITTER_COM },
1140 {19, true, "\005oauth\007twitter\003com", kTwitterHSTS, 1142 {19, true, "\005oauth\007twitter\003com", kTwitterHSTS,
1141 kTwitterComPins, DOMAIN_TWITTER_COM }, 1143 kTwitterComPins, DOMAIN_TWITTER_COM },
1142 {20, true, "\006mobile\007twitter\003com", kTwitterHSTS, 1144 {20, true, "\006mobile\007twitter\003com", kTwitterHSTS,
1143 kTwitterComPins, DOMAIN_TWITTER_COM }, 1145 kTwitterComPins, DOMAIN_TWITTER_COM },
1144 {17, true, "\003dev\007twitter\003com", kTwitterHSTS, 1146 {17, true, "\003dev\007twitter\003com", kTwitterHSTS,
1145 kTwitterComPins, DOMAIN_TWITTER_COM }, 1147 kTwitterComPins, DOMAIN_TWITTER_COM },
1146 {22, true, "\010business\007twitter\003com", kTwitterHSTS, 1148 {22, true, "\010business\007twitter\003com", kTwitterHSTS,
1147 kTwitterComPins, DOMAIN_TWITTER_COM }, 1149 kTwitterComPins, DOMAIN_TWITTER_COM },
1148 #if 0
1149 // Twitter CDN pins disabled in order to track down pinning failures --agl
1150 {22, true, "\010platform\007twitter\003com", false, 1150 {22, true, "\010platform\007twitter\003com", false,
1151 kTwitterCDNPins, DOMAIN_TWITTER_COM }, 1151 kTwitterCDNPins, DOMAIN_TWITTER_COM },
1152 {15, true, "\003si0\005twimg\003com", false, kTwitterCDNPins, 1152 {15, true, "\003si0\005twimg\003com", false, kTwitterCDNPins,
1153 DOMAIN_TWIMG_COM }, 1153 DOMAIN_TWIMG_COM },
1154 {23, true, "\010twimg0-a\010akamaihd\003net", false, 1154 {23, true, "\010twimg0-a\010akamaihd\003net", false,
1155 kTwitterCDNPins, DOMAIN_AKAMAIHD_NET }, 1155 kTwitterCDNPins, DOMAIN_AKAMAIHD_NET },
1156 #endif 1156 #endif
1157 }; 1157 };
1158 static const size_t kNumPreloadedSTS = ARRAYSIZE_UNSAFE(kPreloadedSTS); 1158 static const size_t kNumPreloadedSTS = ARRAYSIZE_UNSAFE(kPreloadedSTS);
1159 1159
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
1337 } 1337 }
1338 1338
1339 LOG(ERROR) << "Rejecting public key chain for domain " << domain 1339 LOG(ERROR) << "Rejecting public key chain for domain " << domain
1340 << ". Validated chain: " << HashesToBase64String(hashes) 1340 << ". Validated chain: " << HashesToBase64String(hashes)
1341 << ", expected: " << HashesToBase64String(public_key_hashes); 1341 << ", expected: " << HashesToBase64String(public_key_hashes);
1342 1342
1343 return false; 1343 return false;
1344 } 1344 }
1345 1345
1346 } // namespace 1346 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698