Issue 8496017: cros proxy: fix bug to use default port whenever its input field is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8496017: cros proxy: fix bug to use default port whenever its input field is empty. (Closed)

Created:
9 years, 1 month ago by kuan

Modified:
9 years, 1 month ago

Reviewers:
xiyuan

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

cros proxy: fix bug to use default port whenever its input field is empty. BUG=chromium-os:21435 TEST=verify per bug rpt. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109100

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	chrome/browser/chromeos/proxy_cros_settings_provider.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/proxy_cros_settings_provider.cc	View		2 chunks	+10 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/8496017/1

9 years, 1 month ago (2011-11-08 19:40:16 UTC) #3

Change committed as 109100