Report ERR_CONTENT_LENGTH_MISMATCH when the count of bytes received doesn't match Content-Length.

webkit/glue/weburlloader_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // An implementation of WebURLLoader in terms of ResourceLoaderBridge.
 
 #include "webkit/glue/weburlloader_impl.h"
 
 #include "base/file_path.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 574 matching lines @@
   }
 }
 
 void WebURLLoaderImpl::Context::OnReceivedCachedMetadata(
     const char* data, int len) {
   if (client_)
     client_->didReceiveCachedMetadata(loader_, data, len);
 }
 
 void WebURLLoaderImpl::Context::OnCompletedRequest(
-    const net::URLRequestStatus& status,
+    const net::URLRequestStatus& original_status,
     const std::string& security_info,
     const base::Time& completion_time) {
   if (ftp_listing_delegate_.get()) {
     ftp_listing_delegate_->OnCompletedRequest();
     ftp_listing_delegate_.reset(NULL);
   } else if (multipart_delegate_.get()) {
     multipart_delegate_->OnCompletedRequest();
     multipart_delegate_.reset(NULL);
   }
 
+  net::URLRequestStatus status = original_status;
+
+  // Rewrite the Content-Length mismatch as a success.
+  // See crbug.com/52847 for justification.
+  if (status.status() != net::URLRequestStatus::SUCCESS &&
+      status.error() == net::ERR_CONTENT_LENGTH_MISMATCH)
+    status.set_status(net::URLRequestStatus::SUCCESS);

[darin (slow to review), 2011/11/16 21:59:57]

should you also clear the error field here for completeness?

[cbentzel, 2011/11/16 22:19:28]

Done. The code below doesn't investigate error if status is SUCCESS, but that
may drift over time. This almost seems like it should be an invariant for
URLRequestStatus.

+
   // Prevent any further IPC to the browser now that we're complete, but
   // don't delete it to keep any downloaded temp files alive.
   DCHECK(!completed_bridge_.get());
   completed_bridge_.swap(bridge_);
 
   if (client_) {
     if (status.status() != net::URLRequestStatus::SUCCESS) {
       int error_code;
       if (status.status() == net::URLRequestStatus::HANDLED_EXTERNALLY) {
         // By marking this request as aborted we insure that we don't navigate
@@ skipping 109 matching lines @@
 
 void WebURLLoaderImpl::setDefersLoading(bool value) {
   context_->SetDefersLoading(value);
 }
 
 void WebURLLoaderImpl::UpdateRoutingId(int new_routing_id) {
   context_->UpdateRoutingId(new_routing_id);
 }
 
 }  // namespace webkit_glue