Issue 8496013: Suppress some Dr. Memory INVALID HEAP reports on UI tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8496013: Suppress some Dr. Memory INVALID HEAP reports on UI tests (Closed)

Created:
9 years, 1 month ago by Timur Iskhodzhanov

Modified:
9 years, 1 month ago

Reviewers:
Derek Bruening

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Suppress some Dr. Memory INVALID HEAP reports on UI tests TBR=bruening BUG=103365, 101717 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109018

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	tools/valgrind/drmemory/suppressions.txt	View		2 chunks	+17 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Derek Bruening

http://codereview.chromium.org/8496013/diff/1/tools/valgrind/drmemory/suppressions.txt File tools/valgrind/drmemory/suppressions.txt (right): http://codereview.chromium.org/8496013/diff/1/tools/valgrind/drmemory/suppressions.txt#newcode609 tools/valgrind/drmemory/suppressions.txt:609: ppapi_tests.dll!* how do you know this isn't a false ...

9 years, 1 month ago (2011-11-08 15:29:24 UTC) #2

Timur Iskhodzhanov

9 years, 1 month ago (2011-11-08 15:48:18 UTC) #3

http://codereview.chromium.org/8496013/diff/1/tools/valgrind/drmemory/suppres...
File tools/valgrind/drmemory/suppressions.txt (right):

http://codereview.chromium.org/8496013/diff/1/tools/valgrind/drmemory/suppres...
tools/valgrind/drmemory/suppressions.txt:609: ppapi_tests.dll!*
It's on r579 you've pushed.
FP or not these guys happen very often on ui_tests and make it hard to find
other stuff.
After all, I've added it to "investigate this" section.

Expand Messages | Collapse Messages