Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: frog/presubmit.py

Issue 8496009: Add a leg_only test suite, and make sure to run it in our presubmit script. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/presubmit.py
===================================================================
--- frog/presubmit.py (revision 1300)
+++ frog/presubmit.py (working copy)
@@ -83,30 +83,10 @@
if args[1:]:
test_cmd.extend(args[1:])
else:
- test_cmd.extend(['language', 'corelib', 'leg', 'isolate', 'peg'])
+ test_cmd.extend(['language', 'corelib', 'leg',
+ 'isolate', 'peg', 'leg_only'])
RunCommand(*test_cmd, verbose=True)
- leg_test_dir = os.path.join('leg', 'tests')
- for current_dir, directories, filenames in os.walk(leg_test_dir):
- for filename in filenames:
- if filename.endswith('.dart'):
- pattern = 'info: [leg] compilation succeeded'
- node_exit_code = 0
- vm_exit_code = 0
- if filename == 'empty.dart':
- pattern = 'info: [leg] compiler cancelled: Could not find main'
- node_exit_code = 1
- vm_exit_code = 255 # Sigh.
- filename = os.path.join(current_dir, filename)
- frog_bin = os.path.join('.', 'frogsh')
- RunCommand(frog_bin, '--enable_leg', '--verbose', '--throw_on_errors',
- filename, pattern=pattern, exit_code=node_exit_code)
- frog_bin = os.path.join('.', 'frog.py')
- RunCommand(frog_bin,
- '--vm_flags=--enable_type_checks --enable_asserts',
- '--', '--enable_leg', '--verbose', '--throw_on_errors',
- filename, pattern=pattern, exit_code=vm_exit_code)
-
if __name__ == '__main__':
try:
sys.exit(main(sys.argv))

Powered by Google App Engine
This is Rietveld 408576698