frog/tests/leg_only/leg_only.status - Issue 8496009: Add a leg_only test suite, and make sure to run it in our presubmit script.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: frog/tests/leg_only/leg_only.status

Issue 8496009: Add a leg_only test suite, and make sure to run it in our presubmit script. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 prefix leg	5 prefix leg_only

6	6

7 [ $component == dartc ]	7 [ $component == leg \|\| $component == frog \|\| $component == frogsh ]
	kasperl 2011/11/08 12:21:34 Are these really supposed to fail when running wit Are these really supposed to fail when running with frog/frogsh? Somehow that seems strange to me. ngeoffray 2011/11/08 12:28:11 That's because the test suite adds leg_only, so fr Show quoted text On 2011/11/08 12:21:34, kasperl wrote: > Are these really supposed to fail when running with frog/frogsh? Somehow that > seems strange to me. That's because the test suite adds leg_only, so frog and frogs will also fail. I don't want to make leg leg_only, as it will not help us find errors when we should bail out. I don't want to make frog and frogsh enable_leg by default, because this would affect frog developers. So having the status file this way was the best option for me.
8 *: Fail # Too many type errors in frog.	8 LocalsTest: Fail

	9 StatementsTest: Fail

	10 TypedLocalsTest: Fail

OLD	NEW

« no previous file with comments | « frog/presubmit.py ('k') | frog/tests/leg_only/src/12Test.dart » ('j') | no next file with comments »