Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 8496008: Revert 108752 - Support tracking of IPC messages as tasks in profiler (Closed)

Created:
9 years, 1 month ago by Jói
Modified:
9 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr., jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 108752 - Support tracking of IPC messages as tasks in profiler Also started to do more cleanup, including creating a base/profiler directory, and moving parts of the over-sized tracked_objects.* into that directory. r=rtenneti Review URL: http://codereview.chromium.org/8480014 TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -422 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 2 chunks +2 lines, -6 lines 0 comments Download
M base/location.h View 1 chunk +5 lines, -7 lines 0 comments Download
D base/profiler/scoped_profile.h View 1 chunk +0 lines, -47 lines 0 comments Download
D base/profiler/scoped_profile.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D base/profiler/tracked_time.h View 1 chunk +0 lines, -84 lines 0 comments Download
D base/profiler/tracked_time.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D base/profiler/tracked_time_unittest.cc View 1 chunk +0 lines, -111 lines 0 comments Download
M base/tracked_objects.h View 3 chunks +94 lines, -9 lines 0 comments Download
M base/tracked_objects.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M base/tracked_objects_unittest.cc View 1 chunk +97 lines, -0 lines 0 comments Download
M ipc/ipc_message_macros.h View 4 chunks +14 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jói
9 years, 1 month ago (2011-11-08 10:46:23 UTC) #1
Jói
9 years, 1 month ago (2011-11-08 11:11:40 UTC) #2
Reverted this as the almost-certain culprit behind memory bot failures
that started in this build:
http://build.chromium.org/p/chromium.memory/builders/ASAN%20Tests%20%282%29/b...

Will watch the tree and un-revert if it is not the cause.

Cheers,
Jói


On Tue, Nov 8, 2011 at 10:46 AM,  <joi@chromium.org> wrote:
> Reviewers: jar,
>
> Description:
> Revert 108752 - Support tracking of IPC messages as tasks in profiler
>
> Also started to do more cleanup, including creating
> a base/profiler directory, and moving parts of the
> over-sized tracked_objects.* into that directory.
>
> r=rtenneti
> Review URL: http://codereview.chromium.org/8480014
>
> TBR=jar@chromium.org
>
> Please review this at http://codereview.chromium.org/8496008/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/base.gyp
>  M     base/base.gypi
>  M     base/location.h
>  D     base/profiler/scoped_profile.h
>  D     base/profiler/scoped_profile.cc
>  D     base/profiler/tracked_time.h
>  D     base/profiler/tracked_time.cc
>  D     base/profiler/tracked_time_unittest.cc
>  M     base/tracked_objects.h
>  M     base/tracked_objects.cc
>  M     base/tracked_objects_unittest.cc
>  M     ipc/ipc_message_macros.h
>
>
>

Powered by Google App Engine
This is Rietveld 408576698