Issue 8496004: Linux: Don't call printing::GetColorModelForMode() when USE_CUPS is not defined.

Issue 8496004: Linux: Don't call printing::GetColorModelForMode() when USE_CUPS is not defined. (Closed)

Created:
9 years, 1 month ago by Lei Zhang

Modified:
9 years, 1 month ago

Reviewers:
kmadhusu

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: Don't call printing::GetColorModelForMode() when USE_CUPS is not defined. BUG=103183 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109091

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
M	chrome/browser/printing/print_dialog_gtk.cc	View	1	2 chunks	+2 lines, -0 lines	2 comments	Download
M	printing/print_settings.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	printing/print_settings.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

kmadhusu

http://codereview.chromium.org/8496004/diff/1/chrome/browser/printing/print_dialog_gtk.cc File chrome/browser/printing/print_dialog_gtk.cc (right): http://codereview.chromium.org/8496004/diff/1/chrome/browser/printing/print_dialog_gtk.cc#newcode218 chrome/browser/printing/print_dialog_gtk.cc:218: gtk_print_settings_set(gtk_settings_, kCUPSDuplex, cups_duplex_mode); If CUPS is disabled, we should ...

9 years, 1 month ago (2011-11-08 02:09:59 UTC) #2

Lei Zhang

9 years, 1 month ago (2011-11-08 02:22:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8496004/5001

9 years, 1 month ago (2011-11-08 19:29:38 UTC) #5

dhw

http://codereview.chromium.org/8496004/diff/5001/chrome/browser/printing/print_dialog_gtk.cc File chrome/browser/printing/print_dialog_gtk.cc (right): http://codereview.chromium.org/8496004/diff/5001/chrome/browser/printing/print_dialog_gtk.cc#newcode218 chrome/browser/printing/print_dialog_gtk.cc:218: #endif Needs to go after the close brace in ...

9 years, 1 month ago (2011-11-08 21:03:59 UTC) #7

Lei Zhang

9 years, 1 month ago (2011-11-08 21:12:46 UTC) #8

http://codereview.chromium.org/8496004/diff/5001/chrome/browser/printing/prin...
File chrome/browser/printing/print_dialog_gtk.cc (right):

http://codereview.chromium.org/8496004/diff/5001/chrome/browser/printing/prin...
chrome/browser/printing/print_dialog_gtk.cc:218: #endif
On 2011/11/08 21:03:59, David Wai wrote:
> Needs to go after the close brace in the following line.

Whoops. Will fix.

Expand Messages | Collapse Messages