chrome/browser/sync/util/sqlite_utils.cc - Issue 8496002: Sync: Improve handling of database load failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/util/sqlite_utils.cc

Issue 8496002: Sync: Improve handling of database load failures (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Many improvements and scope expansion Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/util/sqlite_utils.cc

diff --git a/chrome/browser/sync/util/sqlite_utils.cc b/chrome/browser/sync/util/sqlite_utils.cc

index 725fd8d9d9befd323149912b7cc5986d11bc7f89..f33e6213af40307ebddbf28bf45b0cf52aa23de5 100644

--- a/chrome/browser/sync/util/sqlite_utils.cc

+++ b/chrome/browser/sync/util/sqlite_utils.cc

@@ -33,9 +33,9 @@ class DebugSQLErrorHandler: public VanillaSQLErrorHandler {

public:

virtual int HandleError(int error, sqlite3* db) {

error_ = error;

- NOTREACHED() << "sqlite error " << error

- << " " << sqlite3_errmsg(db)

- << " db " << static_cast<void*>(db);

+ LOG(ERROR) << "sqlite error " << error

+ << " " << sqlite3_errmsg(db)

+ << " db " << static_cast<void*>(db);

return error;

}

};