Sync: Improve handling of database load failures

chrome/browser/sync/internal_api/sync_manager.cc

Index: chrome/browser/sync/internal_api/sync_manager.cc
diff --git a/chrome/browser/sync/internal_api/sync_manager.cc b/chrome/browser/sync/internal_api/sync_manager.cc
index 8359255a4899b0e8188ff6a4598b4ec29e13e90b..7f133edaf08f7f21b4a041f8fb7b7114719bcea1 100644
--- a/chrome/browser/sync/internal_api/sync_manager.cc
+++ b/chrome/browser/sync/internal_api/sync_manager.cc
@@ -802,7 +802,7 @@ bool SyncManager::SyncInternal::Init(
 
   bool signed_in = SignIn(credentials);
 
-  if (signed_in || setup_for_test_mode_) {

[lipalani1, 2011/11/14 21:34:24]

Did it have to be removed? Are the test cases passing?

[rlarocque, 2011/11/14 22:56:26]

Yes and yes.  

This setup_for_test_mode bool would force the SyncManager into thinking SignIn
succeeded when it actually failed due to directory initialization failure. 
That's a problem when I'm trying to test the directory intialization failure
handling code path.  

I tried making this change and sending it at the trybots because I was curious
as to which tests it would break.  I was pleasantly surprised to see that this
change did not appear to break anything.  

+  if (signed_in) {
     if (scheduler()) {
       scheduler()->Start(
           browser_sync::SyncScheduler::CONFIGURATION_MODE, base::Closure());
@@ -894,7 +894,6 @@ bool SyncManager::SyncInternal::OpenDirectory() {
   DCHECK(!initialized_) << "Should only happen once";
 
   bool share_opened = dir_manager()->Open(username_for_share(), this);
-  DCHECK(share_opened);
   if (!share_opened) {
     LOG(ERROR) << "Could not open share for:" << username_for_share();
     return false;
@@ -1291,7 +1290,7 @@ void SyncManager::SyncInternal::ShutdownOnSyncThread() {
   net::NetworkChangeNotifier::RemoveIPAddressObserver(this);
   observing_ip_address_changes_ = false;
 
-  if (dir_manager()) {
+  if (initialized_ && dir_manager()) {
     {
       // Cryptographer should only be accessed while holding a
       // transaction.