Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7510)

Unified Diff: chrome/browser/sync/syncable/directory_backing_store_unittest.cc

Issue 8496002: Sync: Improve handling of database load failures (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix memory access bugs Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/syncable/directory_backing_store.cc ('k') | chrome/browser/sync/util/sqlite_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/syncable/directory_backing_store_unittest.cc
diff --git a/chrome/browser/sync/syncable/directory_backing_store_unittest.cc b/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
index 88536cf249ab5ba6a214e16fa3c3164cd89539fd..461fac24483fce11b931c7bce2e62e29436d54cb 100644
--- a/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
+++ b/chrome/browser/sync/syncable/directory_backing_store_unittest.cc
@@ -2082,15 +2082,7 @@ TEST_F(DirectoryBackingStoreTest, Corruption) {
scoped_ptr<DirectoryBackingStore> dbs(
new DirectoryBackingStore(GetUsername(), GetDatabasePath()));
- // In release mode, we expect the sync database to nuke itself and start
- // over if it detects invalid/corrupted data.
-#if defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON)
- EXPECT_TRUE(dbs->BeginLoad());
-#elif defined(NDEBUG) && defined(DCHECK_ALWAYS_ON)
- EXPECT_DEATH(dbs->BeginLoad(), "stmt_");
-#else
- EXPECT_DEATH(dbs->BeginLoad(), "sqlite error");
-#endif
+ EXPECT_FALSE(dbs->BeginLoad());
}
}
« no previous file with comments | « chrome/browser/sync/syncable/directory_backing_store.cc ('k') | chrome/browser/sync/util/sqlite_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698