Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7079)

Unified Diff: chrome/browser/sync/glue/sync_backend_host.cc

Issue 8496002: Sync: Improve handling of database load failures (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix memory access bugs Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/internal_api/sync_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/sync_backend_host.cc
diff --git a/chrome/browser/sync/glue/sync_backend_host.cc b/chrome/browser/sync/glue/sync_backend_host.cc
index dd4ced4cdd3d11cf10d74e6a4f43e12418d46efa..c68682e00d73e549f7765f903aea6f782c074590 100644
--- a/chrome/browser/sync/glue/sync_backend_host.cc
+++ b/chrome/browser/sync/glue/sync_backend_host.cc
@@ -420,8 +420,11 @@ void SyncBackendHost::Core::OnInitializationComplete(
base::Bind(&Core::HandleInitializationCompletedOnFrontendLoop, this,
js_backend, success));
- // Initialization is complete, so we can schedule recurring SaveChanges.
- sync_loop_->PostTask(FROM_HERE, base::Bind(&Core::StartSavingChanges, this));
+ if (success) {
+ // Initialization is complete, so we can schedule recurring SaveChanges.
+ sync_loop_->PostTask(FROM_HERE,
+ base::Bind(&Core::StartSavingChanges, this));
+ }
}
void SyncBackendHost::Core::OnAuthError(const AuthError& auth_error) {
@@ -608,7 +611,7 @@ void SyncBackendHost::Core::DoInitialize(const DoInitializeOptions& options) {
host_->sync_notifier_factory_.CreateSyncNotifier(),
options.restored_key_for_bootstrapping,
options.setup_for_test_mode);
- DCHECK(success) << "Syncapi initialization failed!";
+ LOG_IF(ERROR, !success) << "Syncapi initialization failed!";
}
void SyncBackendHost::Core::DoCheckServerReachable() {
« no previous file with comments | « no previous file | chrome/browser/sync/internal_api/sync_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698