Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: chrome/browser/sync/internal_api/sync_manager.cc

Issue 8496002: Sync: Improve handling of database load failures (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/internal_api/sync_manager.cc
diff --git a/chrome/browser/sync/internal_api/sync_manager.cc b/chrome/browser/sync/internal_api/sync_manager.cc
index 9046a73aa9e4d6dfe1cd9ece7848495071532429..8d1cd4d7b7c60f24e466afcc6c0609a8df3a73f9 100644
--- a/chrome/browser/sync/internal_api/sync_manager.cc
+++ b/chrome/browser/sync/internal_api/sync_manager.cc
@@ -885,7 +885,6 @@ bool SyncManager::SyncInternal::OpenDirectory() {
DCHECK(!initialized_) << "Should only happen once";
bool share_opened = dir_manager()->Open(username_for_share(), this);
- DCHECK(share_opened);
if (!share_opened) {
LOG(ERROR) << "Could not open share for:" << username_for_share();
return false;
@@ -1282,7 +1281,7 @@ void SyncManager::SyncInternal::ShutdownOnSyncThread() {
net::NetworkChangeNotifier::RemoveIPAddressObserver(this);
observing_ip_address_changes_ = false;
- if (dir_manager()) {
+ if (initialized_ && dir_manager()) {
{
// Cryptographer should only be accessed while holding a
// transaction.

Powered by Google App Engine
This is Rietveld 408576698