Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8488)

Unified Diff: chrome/test/data/extensions/api_test/filesystem_handler/tab.html

Issue 8495044: Fix FileSystemExtensionApiTest.FileBrowserTest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_local_filesystem_apitest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/filesystem_handler/tab.html
diff --git a/chrome/test/data/extensions/api_test/filesystem_handler/tab.html b/chrome/test/data/extensions/api_test/filesystem_handler/tab.html
index ff934925cf50db636215e0939eb99122d96f194f..6ab73f8a8ce4bad6cefe97245fdc69b46d1a2d6f 100644
--- a/chrome/test/data/extensions/api_test/filesystem_handler/tab.html
+++ b/chrome/test/data/extensions/api_test/filesystem_handler/tab.html
@@ -77,7 +77,9 @@ function readEntryByUrl() {
errorCallback);
}
-chrome.test.runTests([function tab() {
+var reader;
zel 2011/11/09 21:04:50 i wouldn't do this one
+
+function onTabLoaded() {
var entries = chrome.extension.getBackgroundPage().getLastFileEntries();
if (!entries || entries.length != 1 || !entries[0]) {
chrome.extension.sendRequest(
@@ -87,7 +89,7 @@ chrome.test.runTests([function tab() {
return;
}
var entry = entries[0];
- var reader = new FileReader();
+ reader = new FileReader();
zel 2011/11/09 21:04:50 put var back
entryUrl = entry.toURL();
reader.onloadend = function(e) {
var content = document.getElementById('content');
@@ -99,6 +101,6 @@ chrome.test.runTests([function tab() {
entry.file(function(file) {
reader.readAsText(file);
});
-}]);
+}
</script>
-<html><body><div id="content"></div></body></html>
+<html><body onload="onTabLoaded();"><div id="content"></div></body></html>
« no previous file with comments | « chrome/browser/extensions/extension_local_filesystem_apitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698