Turn on -Wexit-time-destructors for ui and content.

ui/base/x/x11_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines utility functions for X11 (Linux only). This code has been
 // ported from XCB since we can't use XCB on Ubuntu while its 32-bit support
 // remains woefully incomplete.
 
 #include "ui/base/x/x11_util.h"
 
@@ skipping 198 matching lines @@
   render_supported_cached = true;
 
   return render_supported;
 }
 
 int GetDefaultScreen(Display* display) {
   return XDefaultScreen(display);
 }
 
 Cursor GetXCursor(int cursor_shape) {
-  static XCursorCache cache;
+  CR_DEFINE_STATIC_LOCAL(XCursorCache, cache, ());

[Mark Mentovai, 2011/11/09 17:44:44]

Break out. I won’t mention this again during this review.

[Nico, 2011/11/09 18:16:02]

(Un)done. I won't say "done" for the other instances where I (un)did this.

   return cache.GetCursor(cursor_shape);
 }
 
 XID GetX11RootWindow() {
   return DefaultRootWindow(GetXDisplay());
 }
 
 bool GetCurrentDesktop(int* desktop) {
   return GetIntProperty(GetX11RootWindow(), "_NET_CURRENT_DESKTOP", desktop);
 }
@@ skipping 663 matching lines @@
       << "request_code " << static_cast<int>(error_event.request_code) << ", "
       << "minor_code " << static_cast<int>(error_event.minor_code)
       << " (" << request_str << ")";
 }
 
 // ----------------------------------------------------------------------------
 // End of x11_util_internal.h
 
 
 }  // namespace ui