Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Side by Side Diff: build/common.gypi

Issue 8495043: Turn on -Wexit-time-destructors for ui and content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/content.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 # Enable a variable used elsewhere throughout the GYP files to determine 569 # Enable a variable used elsewhere throughout the GYP files to determine
570 # whether to compile in the sources for the GPU plugin / process. 570 # whether to compile in the sources for the GPU plugin / process.
571 'enable_gpu%': 1, 571 'enable_gpu%': 1,
572 572
573 # .gyp files or targets should set chromium_code to 1 if they build 573 # .gyp files or targets should set chromium_code to 1 if they build
574 # Chromium-specific code, as opposed to external code. This variable is 574 # Chromium-specific code, as opposed to external code. This variable is
575 # used to control such things as the set of warnings to enable, and 575 # used to control such things as the set of warnings to enable, and
576 # whether warnings are treated as errors. 576 # whether warnings are treated as errors.
577 'chromium_code%': 0, 577 'chromium_code%': 0,
578 578
579 # TODO(thakis): Make this a blacklist instead, http://crbug.com/101600
580 'enable_wexit_time_destructors%': 0,
581
579 # Set to 1 to compile with the built in pdf viewer. 582 # Set to 1 to compile with the built in pdf viewer.
580 'internal_pdf%': 0, 583 'internal_pdf%': 0,
581 584
582 # This allows to use libcros from the current system, ie. /usr/lib/ 585 # This allows to use libcros from the current system, ie. /usr/lib/
583 # The cros_api will be pulled in as a static library, and all headers 586 # The cros_api will be pulled in as a static library, and all headers
584 # from the system include dirs. 587 # from the system include dirs.
585 'system_libcros%': 0, 588 'system_libcros%': 0,
586 589
587 # NOTE: When these end up in the Mac bundle, we need to replace '-' for '_' 590 # NOTE: When these end up in the Mac bundle, we need to replace '-' for '_'
588 # so Cocoa is happy (http://crbug.com/20441). 591 # so Cocoa is happy (http://crbug.com/20441).
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
933 # std::partial_sort in Debug build which make them O(N^2) 936 # std::partial_sort in Debug build which make them O(N^2)
934 # instead of O(N*logN). This is particularly slow under memory 937 # instead of O(N*logN). This is particularly slow under memory
935 # tools like ThreadSanitizer so we want it to be disablable. 938 # tools like ThreadSanitizer so we want it to be disablable.
936 # See http://msdn.microsoft.com/en-us/library/aa985982(v=VS.80).aspx 939 # See http://msdn.microsoft.com/en-us/library/aa985982(v=VS.80).aspx
937 'win_debug_disable_iterator_debugging%': '0', 940 'win_debug_disable_iterator_debugging%': '0',
938 941
939 'release_extra_cflags%': '', 942 'release_extra_cflags%': '',
940 'debug_extra_cflags%': '', 943 'debug_extra_cflags%': '',
941 'release_valgrind_build%': 0, 944 'release_valgrind_build%': 0,
942 945
946 # TODO(thakis): Make this a blacklist instead, http://crbug.com/101600
947 'enable_wexit_time_destructors%': '<(enable_wexit_time_destructors)',
948
943 # Only used by Windows build for now. Can be used to build into a 949 # Only used by Windows build for now. Can be used to build into a
944 # differet output directory, e.g., a build_dir_prefix of VS2010_ would 950 # differet output directory, e.g., a build_dir_prefix of VS2010_ would
945 # output files in src/build/VS2010_{Debug,Release}. 951 # output files in src/build/VS2010_{Debug,Release}.
946 'build_dir_prefix%': '', 952 'build_dir_prefix%': '',
947 953
948 'conditions': [ 954 'conditions': [
949 ['OS=="win" and component=="shared_library"', { 955 ['OS=="win" and component=="shared_library"', {
950 # See http://msdn.microsoft.com/en-us/library/aa652367.aspx 956 # See http://msdn.microsoft.com/en-us/library/aa652367.aspx
951 'win_release_RuntimeLibrary%': '2', # 2 = /MT (nondebug DLL) 957 'win_release_RuntimeLibrary%': '2', # 2 = /MT (nondebug DLL)
952 'win_debug_RuntimeLibrary%': '3', # 3 = /MTd (debug DLL) 958 'win_debug_RuntimeLibrary%': '3', # 3 = /MTd (debug DLL)
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
1158 'ENABLE_REGISTER_PROTOCOL_HANDLER=1', 1164 'ENABLE_REGISTER_PROTOCOL_HANDLER=1',
1159 ], 1165 ],
1160 }], 1166 }],
1161 ['enable_web_intents==1', { 1167 ['enable_web_intents==1', {
1162 'defines': [ 1168 'defines': [
1163 'ENABLE_WEB_INTENTS=1', 1169 'ENABLE_WEB_INTENTS=1',
1164 ], 1170 ],
1165 }], 1171 }],
1166 ], # conditions for 'target_defaults' 1172 ], # conditions for 'target_defaults'
1167 'target_conditions': [ 1173 'target_conditions': [
1174 ['enable_wexit_time_destructors==1', {
1175 'conditions': [
1176 [ 'clang==1', {
1177 'cflags': [
1178 '-Wexit-time-destructors',
1179 ],
1180 'xcode_settings': {
1181 'WARNING_CFLAGS': [
1182 '-Wexit-time-destructors',
1183 ],
1184 },
1185 }],
1186 ],
1187 }],
1168 ['chromium_code==0', { 1188 ['chromium_code==0', {
1169 'conditions': [ 1189 'conditions': [
1170 [ 'os_posix==1 and OS!="mac"', { 1190 [ 'os_posix==1 and OS!="mac"', {
1171 # We don't want to get warnings from third-party code, 1191 # We don't want to get warnings from third-party code,
1172 # so remove any existing warning-enabling flags like -Wall. 1192 # so remove any existing warning-enabling flags like -Wall.
1173 'cflags!': [ 1193 'cflags!': [
1174 '-Wall', 1194 '-Wall',
1175 '-Wextra', 1195 '-Wextra',
1176 '-Werror', 1196 '-Werror',
1177 ], 1197 ],
(...skipping 1426 matching lines...) Expand 10 before | Expand all | Expand 10 after
2604 # settings in target dicts. SYMROOT is a special case, because many other 2624 # settings in target dicts. SYMROOT is a special case, because many other
2605 # Xcode variables depend on it, including variables such as 2625 # Xcode variables depend on it, including variables such as
2606 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 2626 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
2607 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 2627 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
2608 # files to appear (when present) in the UI as actual files and not red 2628 # files to appear (when present) in the UI as actual files and not red
2609 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 2629 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
2610 # and therefore SYMROOT, needs to be set at the project level. 2630 # and therefore SYMROOT, needs to be set at the project level.
2611 'SYMROOT': '<(DEPTH)/xcodebuild', 2631 'SYMROOT': '<(DEPTH)/xcodebuild',
2612 }, 2632 },
2613 } 2633 }
OLDNEW
« no previous file with comments | « no previous file | content/content.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698