Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 8495039: NewRunnable* conversion to base::Bind for service process utils. (Closed)

Created:
9 years, 1 month ago by Scott Byer
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

NewRunnable* conversion to base::Bind For chrome/common/service_process* BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109745

Patch Set 1 #

Patch Set 2 : Fix Windows and Linux #

Patch Set 3 : Could swear I build this on the Mac... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -33 lines) Patch
M chrome/common/service_process_util.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/service_process_util_posix.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_posix.cc View 1 6 chunks +12 lines, -10 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 2 10 chunks +11 lines, -10 lines 0 comments Download
M chrome/common/service_process_util_win.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/service/service_process.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Scott Byer
9 years, 1 month ago (2011-11-09 00:50:03 UTC) #1
willchan no longer on Chromium
Are there compilation errors here? Tryjobs seemed to fail.
9 years, 1 month ago (2011-11-09 19:54:32 UTC) #2
Scott Byer
On 2011/11/09 19:54:32, willchan wrote: > Are there compilation errors here? Tryjobs seemed to fail. ...
9 years, 1 month ago (2011-11-09 20:02:16 UTC) #3
Scott Byer
PTAL. I pulled the thread on both Windows and Linux and unraveled things a bit ...
9 years, 1 month ago (2011-11-10 01:02:13 UTC) #4
Scott Byer
Ping? On 2011/11/10 01:02:13, Scott Byer wrote: > PTAL. I pulled the thread on both ...
9 years, 1 month ago (2011-11-11 19:24:57 UTC) #5
willchan no longer on Chromium
lgtm
9 years, 1 month ago (2011-11-11 19:58:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/8495039/6002
9 years, 1 month ago (2011-11-11 20:00:53 UTC) #7
commit-bot: I haz the power
Try job failure for 8495039-6002 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years, 1 month ago (2011-11-11 21:18:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/8495039/6002
9 years, 1 month ago (2011-11-11 21:58:46 UTC) #9
commit-bot: I haz the power
9 years, 1 month ago (2011-11-12 00:44:25 UTC) #10
Change committed as 109745

Powered by Google App Engine
This is Rietveld 408576698