Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: build/temp_gyp/googleurl.gyp

Issue 8495036: Revert 109138 (broke linux shared build) - GURL: Build the unit tests on the components build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/temp_gyp/googleurl.gyp
===================================================================
--- build/temp_gyp/googleurl.gyp (revision 109143)
+++ build/temp_gyp/googleurl.gyp (working copy)
@@ -67,7 +67,6 @@
},
{
'target_name': 'googleurl_unittests',
- 'type': 'executable',
'dependencies': [
'googleurl',
'../../base/base.gyp:base_i18n',
@@ -95,6 +94,15 @@
}],
],
}],
+ # TODO(victorw): The unittest code uses inline functions that access
+ # global variables, it also uses internal functions that we may not want
+ # to export, so skip building unittests for component builds.
+ # The googleurl functions are tested by the static library build.
+ ['component=="shared_library"', {
+ 'type': 'none',
+ }, {
+ 'type': 'executable',
+ }],
],
},
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698