Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 8495025: Mark SearchEngineManagerWebUITest.testOpenSearchEngineManager as flaky. (Closed)

Created:
9 years, 1 month ago by rkc
Modified:
9 years, 1 month ago
Reviewers:
Sheridan Rawlins, zel
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Mark SearchEngineManagerWebUITest.testOpenSearchEngineManager as flaky. SearchEngineManagerWebUITest.testOpenSearchEngineManager fails when run on a ChromeOS VM for the first time, all subsequent runs pass. Marking it as flaky. See crosbug.com/22673 BUG=chromium-os:22673 TEST=Confirmed that the test doesn't cause a fail on ChromeOS VM's. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/ui/webui/options/search_engine_manager_browsertest.js View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rkc
Added reviewers.
9 years, 1 month ago (2011-11-09 10:33:51 UTC) #1
Sheridan Rawlins
lgtm Technically you're marking it disabled, but the code works for me.
9 years, 1 month ago (2011-11-09 19:09:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/8495025/1
9 years, 1 month ago (2011-11-17 06:36:24 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 07:45:23 UTC) #4
Change committed as 110468

Powered by Google App Engine
This is Rietveld 408576698