Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: remoting/host/host_status_observer.h

Issue 8495024: Access ChromotingHost::clients_ only on network thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: - Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/client_session_unittest.cc ('k') | remoting/host/plugin/host_script_object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/host_status_observer.h
diff --git a/remoting/host/host_status_observer.h b/remoting/host/host_status_observer.h
index 132dc9854ffea005039d44bfeac0bb5669b08158..ccd03a2205a9c208e0d140b5701cc55d3f4111f0 100644
--- a/remoting/host/host_status_observer.h
+++ b/remoting/host/host_status_observer.h
@@ -14,27 +14,28 @@ namespace protocol {
class ConnectionToClient;
}
+// Interface for host status observer. All methods are invoked on the
+// network thread.
class HostStatusObserver {
public:
HostStatusObserver() { }
virtual ~HostStatusObserver() { }
- // Called on the network thread when status of the XMPP changes.
+ // Called when status of the signalling channel changes.
virtual void OnSignallingConnected(SignalStrategy* signal_strategy,
const std::string& full_jid) = 0;
virtual void OnSignallingDisconnected() = 0;
- // Called on the network thread when an unauthorized user attempts
- // to connect to the host.
+ // Called when an unauthorized user attempts to connect to the host.
virtual void OnAccessDenied() = 0;
- // Called on the main thread when a client authenticates, or disconnects.
- // The observer must not tear-down ChromotingHost state on receipt of
- // this callback; it is purely informational.
+ // Called when a client authenticates, or disconnects. Observers
+ // must not tear-down ChromotingHost state on receipt of this
+ // callback; it is purely informational.
virtual void OnClientAuthenticated(const std::string& jid) = 0;
virtual void OnClientDisconnected(const std::string& jid) = 0;
- // Called on the main thread when the host shuts down.
+ // Called when the host shuts down.
virtual void OnShutdown() = 0;
};
« no previous file with comments | « remoting/host/client_session_unittest.cc ('k') | remoting/host/plugin/host_script_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698