Access ChromotingHost::clients_ only on network thread.

remoting/host/screen_recorder_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/screen_recorder.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/task.h"
 #include "remoting/base/base_mock_objects.h"
@@ skipping 69 matching lines @@
     connection_ = new MockConnectionToClient(
         session_, &host_stub_, &event_executor_);
     connection_->SetEventHandler(&handler_);
 
     record_ = new ScreenRecorder(
         &message_loop_, &message_loop_,
         base::MessageLoopProxy::current(),
         &capturer_, encoder_);
   }
 
+  virtual void TearDown() OVERRIDE {
+    record_ = NULL;
+    connection_ = NULL;
+    // Run message loop before destroying because protocol::Session is
+    // destroyed asynchronously.
+    message_loop_.RunAllPending();
+  }
+
  protected:
+  MessageLoop message_loop_;
   scoped_refptr<ScreenRecorder> record_;
 
   MockConnectionToClientEventHandler handler_;
   MockHostStub host_stub_;
   MockEventExecutor event_executor_;
   MockSession* session_;  // Owned by |connection_|.
   scoped_refptr<MockConnectionToClient> connection_;
 
   // The following mock objects are owned by ScreenRecorder.
   MockCapturer capturer_;
   MockEncoder* encoder_;
-  MessageLoop message_loop_;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(ScreenRecorderTest);
 };
 
 // This test mocks capturer, encoder and network layer to simulate one recording
 // cycle. When the first encoded packet is submitted to the network
 // ScreenRecorder is instructed to come to a complete stop. We expect the stop
 // sequence to be executed successfully.
 TEST_F(ScreenRecorderTest, StartAndStop) {
   SkRegion update_region(SkIRect::MakeXYWH(0, 0, 10, 10));
@@ skipping 39 matching lines @@
   record_->Start();
   message_loop_.Run();
 }
 
 TEST_F(ScreenRecorderTest, StopWithoutStart) {
   record_->Stop(base::Bind(&QuitMessageLoop, &message_loop_));
   message_loop_.Run();
 }
 
 }  // namespace remoting