Access ChromotingHost::clients_ only on network thread.

remoting/protocol/session.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_SESSION_H_
 #define REMOTING_PROTOCOL_SESSION_H_
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/threading/non_thread_safe.h"
 #include "remoting/protocol/buffered_socket_writer.h"
 #include "remoting/protocol/session_config.h"
 
 class Task;
 
 namespace net {
 class Socket;
 class StreamSocket;
 }  // namespace net
 
 namespace remoting {
 namespace protocol {
 
 // Generic interface for Chromotocol connection used by both client and host.
 // Provides access to the connection channels, but doesn't depend on the
 // protocol used for each channel.
+//
+// Because libjingle's sigslot class doesn't handle deletion properly
+// while it is being invoked all Session instances must be deleted
+// with clean stack, i.e. not from event handlers, when sigslot may be

[Wez, 2011/11/09 02:32:22]

nit: with _a_ clean stack.

[Sergey Ulanov, 2011/11/09 21:24:00]

Done.

+// present in the stack.
 class Session : public base::NonThreadSafe {
  public:
   enum State {
     // Created, but not connecting yet.
     INITIALIZING,
 
     // Sent or received session-initiate, but haven't sent or received
     // session-accept.
     CONNECTING,
 
@@ skipping 75 matching lines @@
   virtual const std::string& initiator_token() = 0;
   virtual void set_initiator_token(const std::string& initiator_token) = 0;
   virtual const std::string& receiver_token() = 0;
   virtual void set_receiver_token(const std::string& receiver_token) = 0;
 
   // A shared secret to use to mutually-authenticate the SSL channels.
   virtual void set_shared_secret(const std::string& secret) = 0;
   virtual const std::string& shared_secret() = 0;
 
   // Closes connection. Callbacks are guaranteed not to be called
-  // after this method returns. Must be called before the object is
-  // destroyed, unless the state is set to FAILED or CLOSED.
+  // after this method is called.

[Wez, 2011/11/09 02:32:22]

nit: after this method returns?

[Sergey Ulanov, 2011/11/09 21:24:00]

No - callback is not expected during this call. Previously it would call
StateChangeCallback(CLOSED) in response to this call. Not anymore.

[Wez, 2011/11/09 23:18:45]

OK, I think it's clearer to say "from the moment this method is called";
otherwise it's ambiguous whether it's only _after_ it has been called and
returned, or whether it's also guaranteed not to make callbacks mid call.

[Sergey Ulanov, 2011/11/10 21:06:14]

Reverted behavior of this method and this comment.

   virtual void Close() = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(Session);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_SESSION_H_