Access ChromotingHost::clients_ only on network thread.

remoting/host/host_status_observer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_STATUS_OBSERVER_H_
 #define REMOTING_HOST_STATUS_OBSERVER_H_
 
 #include <string>
 
 namespace remoting {
 class SignalStrategy;
 
 namespace protocol {
 class ConnectionToClient;
 }
 
+// Interface for host status observer. All methods are invoked on the
+// network thread.
 class HostStatusObserver {
  public:
   HostStatusObserver() { }
   virtual ~HostStatusObserver() { }
 
-  // Called on the network thread when status of the XMPP changes.
+  // Called when status of the XMPP changes.

[Wez, 2011/11/09 02:32:22]

nit: status of the XMPP signalling layer?

[Sergey Ulanov, 2011/11/09 21:24:00]

Done.

   virtual void OnSignallingConnected(SignalStrategy* signal_strategy,
                                      const std::string& full_jid) = 0;
   virtual void OnSignallingDisconnected() = 0;
 
-  // Called on the network thread when an unauthorized user attempts
+  // Called when an unauthorized user attempts
   // to connect to the host.

[Wez, 2011/11/09 02:32:22]

nit: line-wrap.

[Sergey Ulanov, 2011/11/09 21:24:00]

Done.

   virtual void OnAccessDenied() = 0;
 
-  // Called on the main thread when a client authenticates, or disconnects.
-  // The observer must not tear-down ChromotingHost state on receipt of
-  // this callback; it is purely informational.
+  // Called when a client authenticates, or disconnects.  The observer
+  // must not tear-down ChromotingHost state on receipt of this
+  // callback; it is purely informational.

[Wez, 2011/11/09 02:32:22]

nit: Incorrect plural/singular.

[Sergey Ulanov, 2011/11/09 21:24:00]

Changed s/the observer/observers/, but not sure if that's the problem.

[Wez, 2011/11/09 23:18:45]

Sorry, not a very helpful comment from me.  New text looks fine.

   virtual void OnClientAuthenticated(const std::string& jid) = 0;
   virtual void OnClientDisconnected(const std::string& jid) = 0;
 
-  // Called on the main thread when the host shuts down.
+  // Called when the host shuts down.
   virtual void OnShutdown() = 0;
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_STATUS_OBSERVER_H_