Access ChromotingHost::clients_ only on network thread.

remoting/client/chromoting_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/chromoting_client.h"
 
 #include "base/bind.h"
 #include "remoting/client/chromoting_view.h"
 #include "remoting/client/client_context.h"
 #include "remoting/client/input_handler.h"
@@ skipping 46 matching lines @@
 }
 
 void ChromotingClient::Stop(const base::Closure& shutdown_task) {
   if (!message_loop()->BelongsToCurrentThread()) {
     message_loop()->PostTask(
         FROM_HERE, base::Bind(&ChromotingClient::Stop,
                               base::Unretained(this), shutdown_task));
     return;
   }
 
+  // Drop all pending packets.
+  while(!received_packets_.empty()) {
+    received_packets_.front().done.Run();
+    received_packets_.pop_front();

[Wez, 2011/11/09 02:32:22]

This looks leaked from another CL?

[Sergey Ulanov, 2011/11/09 21:24:00]

Yeah, it should be in a separate CL. I thought my change triggered DCHECK due to
this issue, but it is actually not related to my change.

+  }
+
   connection_->Disconnect(base::Bind(&ChromotingClient::OnDisconnected,
                                      base::Unretained(this), shutdown_task));
 }
 
 void ChromotingClient::OnDisconnected(const base::Closure& shutdown_task) {
   view_->TearDown();
 
   shutdown_task.Run();
 }
 
@@ skipping 121 matching lines @@
   }
 
   // Initialize the decoder.
   rectangle_decoder_->Initialize(connection_->config());
 
   // Schedule the input handler to process the event queue.
   input_handler_->Initialize();
 }
 
 }  // namespace remoting