Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1437)

Unified Diff: content/browser/plugin_service.h

Issue 8493026: Revert r108760 / reland r108744, r108753 w/ fix (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename plugin list accessor to plugin_list() Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/plugin/chrome_content_plugin_client.cc ('k') | content/browser/plugin_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/plugin_service.h
diff --git a/content/browser/plugin_service.h b/content/browser/plugin_service.h
index 2b2c69f225f2812bdcc9a555ecc05acfe6158a6d..6be2c4f3623da48ed3d5fab10ca438be07473a8b 100644
--- a/content/browser/plugin_service.h
+++ b/content/browser/plugin_service.h
@@ -54,6 +54,7 @@ namespace webkit {
namespace npapi {
class PluginGroup;
class PluginList;
+struct PluginEntryPoints;
}
}
@@ -151,10 +152,6 @@ class CONTENT_EXPORT PluginService
bool GetPluginInfoByPath(const FilePath& plugin_path,
webkit::WebPluginInfo* info);
- // Marks the plugin list as dirty and will cause the plugins to be reloaded
- // on the next access through GetPlugins() or GetPluginGroups().
- void RefreshPluginList();
-
// Asynchronously loads plugins if necessary and then calls back to the
// provided function on the calling MessageLoop on completion.
void GetPlugins(const GetPluginsCallback& callback);
@@ -176,6 +173,22 @@ class CONTENT_EXPORT PluginService
}
content::PluginServiceFilter* filter() { return filter_; }
+
+ // The following functions are wrappers around webkit::npapi::PluginList.
+ // These must be used instead of those in order to ensure that we have a
+ // single global list in the component build and so that we don't
+ // accidentally load plugins in the wrong process or thread. Refer to
+ // PluginList for further documentation of these functions.
+ void RefreshPlugins();
+ void AddExtraPluginPath(const FilePath& path);
+ void RemoveExtraPluginPath(const FilePath& path);
+ void UnregisterInternalPlugin(const FilePath& path);
+ void RegisterInternalPlugin(const webkit::WebPluginInfo& info);
+ string16 GetPluginGroupName(const std::string& plugin_name);
+
+ // TODO(dpranke): This should be private.
+ webkit::npapi::PluginList* plugin_list();
+
private:
friend struct DefaultSingletonTraits<PluginService>;
« no previous file with comments | « chrome/plugin/chrome_content_plugin_client.cc ('k') | content/browser/plugin_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698