Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8493020: Move code in src/remoting to the new callbacks. (Closed)

Created:
9 years, 1 month ago by Sergey Ulanov
Modified:
9 years, 1 month ago
Reviewers:
awong
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move code in src/remoting to the new callbacks. BUG=None TEST=Remoting still works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109367

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix win and mac #

Total comments: 4

Patch Set 3 : - #

Patch Set 4 : - #

Patch Set 5 : - #

Patch Set 6 : fix mac #

Patch Set 7 : - #

Patch Set 8 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -357 lines) Patch
M remoting/base/base_mock_objects.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/codec_test.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M remoting/base/compound_buffer_unittest.cc View 4 chunks +34 lines, -42 lines 0 comments Download
M remoting/base/decoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/base/decoder_row_based.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/base/decoder_vp8.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/base/encoder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/base/encoder_row_based.h View 2 chunks +5 lines, -4 lines 0 comments Download
M remoting/base/encoder_row_based.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M remoting/base/encoder_vp8.h View 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/base/encoder_vp8.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/base/encoder_vp8_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M remoting/client/chromoting_client.h View 1 2 3 4 chunks +3 lines, -5 lines 0 comments Download
M remoting/client/chromoting_client.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M remoting/client/frame_consumer.h View 3 chunks +7 lines, -10 lines 0 comments Download
M remoting/client/input_handler.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_input_handler.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_view.h View 1 chunk +4 lines, -7 lines 0 comments Download
M remoting/client/plugin/pepper_view.cc View 3 chunks +9 lines, -14 lines 0 comments Download
M remoting/client/plugin/pepper_view_proxy.h View 1 chunk +4 lines, -7 lines 0 comments Download
M remoting/client/plugin/pepper_view_proxy.cc View 7 chunks +17 lines, -22 lines 0 comments Download
M remoting/client/rectangle_update_decoder.h View 1 2 3 4 chunks +5 lines, -11 lines 0 comments Download
M remoting/client/rectangle_update_decoder.cc View 1 2 3 4 10 chunks +29 lines, -66 lines 0 comments Download
M remoting/host/capturer.h View 3 chunks +5 lines, -3 lines 0 comments Download
M remoting/host/capturer_fake.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/capturer_fake.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M remoting/host/capturer_fake_ascii.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/capturer_fake_ascii.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/host/capturer_linux.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M remoting/host/capturer_mac.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/capturer_mac_unittest.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -4 lines 0 comments Download
M remoting/host/capturer_win.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M remoting/host/chromoting_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/chromoting_host.cc View 5 chunks +6 lines, -10 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 3 chunks +10 lines, -15 lines 0 comments Download
M remoting/host/continue_window_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/continue_window_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/continue_window_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/desktop_environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/disconnect_window_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/disconnect_window_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/disconnect_window_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_key_pair.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/host_mock_objects.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/json_host_config.cc View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/host/local_input_monitor_mac.mm View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M remoting/host/local_input_monitor_thread_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/plugin/host_script_object.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/screen_recorder.cc View 8 chunks +17 lines, -27 lines 0 comments Download
M remoting/host/screen_recorder_unittest.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M remoting/protocol/buffered_socket_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/connection_to_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/connection_to_host.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/protocol_test_client.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M remoting/protocol/util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/protocol/util.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sergey Ulanov
9 years, 1 month ago (2011-11-07 21:46:11 UTC) #1
Sergey Ulanov
http://codereview.chromium.org/8493020/diff/1/remoting/client/frame_consumer.h File remoting/client/frame_consumer.h (left): http://codereview.chromium.org/8493020/diff/1/remoting/client/frame_consumer.h#oldcode40 remoting/client/frame_consumer.h:40: base::TimeDelta timestamp, Problem with this method was that base::Bind() ...
9 years, 1 month ago (2011-11-07 21:49:38 UTC) #2
Sergey Ulanov
ping
9 years, 1 month ago (2011-11-09 21:33:53 UTC) #3
awong
thanks for doing all this! 2 comments. http://codereview.chromium.org/8493020/diff/1049/remoting/client/rectangle_update_decoder.cc File remoting/client/rectangle_update_decoder.cc (right): http://codereview.chromium.org/8493020/diff/1049/remoting/client/rectangle_update_decoder.cc#newcode32 remoting/client/rectangle_update_decoder.cc:32: void Run() ...
9 years, 1 month ago (2011-11-09 21:52:44 UTC) #4
Sergey Ulanov
http://codereview.chromium.org/8493020/diff/1049/remoting/client/rectangle_update_decoder.cc File remoting/client/rectangle_update_decoder.cc (right): http://codereview.chromium.org/8493020/diff/1049/remoting/client/rectangle_update_decoder.cc#newcode32 remoting/client/rectangle_update_decoder.cc:32: void Run() { On 2011/11/09 21:52:44, awong wrote: > ...
9 years, 1 month ago (2011-11-09 22:09:22 UTC) #5
awong
LGTM Thanks!
9 years, 1 month ago (2011-11-09 22:13:35 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-10 01:57:49 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698