Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: content/browser/plugin_service.cc

Issue 8493019: Refactor PluginService to take PluginList as a dependency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove TestPluginService Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/plugin_service.cc
diff --git a/content/browser/plugin_service.cc b/content/browser/plugin_service.cc
index 5e0e910656076fa2394cec4f57f871b1f52a079b..76e0102b181c42872218369e39ee2f0a63a9a9a3 100644
--- a/content/browser/plugin_service.cc
+++ b/content/browser/plugin_service.cc
@@ -113,9 +113,31 @@ PluginService* PluginService::GetInstance() {
}
PluginService::PluginService()
- : ui_locale_(
+ : plugin_list_(NULL),
+ ui_locale_(
content::GetContentClient()->browser()->GetApplicationLocale()),
filter_(NULL) {
+}
+
+PluginService::~PluginService() {
+#if defined(OS_WIN)
+ // Release the events since they're owned by RegKey, not WaitableEvent.
+ hkcu_watcher_.StopWatching();
+ hklm_watcher_.StopWatching();
+ if (hkcu_event_.get())
+ hkcu_event_->Release();
+ if (hklm_event_.get())
+ hklm_event_->Release();
+#endif
+ // Make sure no plugin channel requests have been leaked.
+ DCHECK(pending_plugin_clients_.empty());
+}
+
+void PluginService::Init(webkit::npapi::PluginList* a_plugin_list) {
+ DCHECK(!plugin_list_) << "PluginService already initialized";
+ DCHECK(a_plugin_list);
+ plugin_list_ = a_plugin_list;
+
plugin_list()->set_will_load_plugins_callback(
base::Bind(&WillLoadPluginsCallback));
@@ -140,20 +162,6 @@ PluginService::PluginService()
#endif
}
-PluginService::~PluginService() {
-#if defined(OS_WIN)
- // Release the events since they're owned by RegKey, not WaitableEvent.
- hkcu_watcher_.StopWatching();
- hklm_watcher_.StopWatching();
- if (hkcu_event_.get())
- hkcu_event_->Release();
- if (hklm_event_.get())
- hklm_event_->Release();
-#endif
- // Make sure no plugin channel requests have been leaked.
- DCHECK(pending_plugin_clients_.empty());
-}
-
void PluginService::StartWatchingPlugins() {
// Start watching for changes in the plugin list. This means watching
// for changes in the Windows registry keys and on both Windows and POSIX

Powered by Google App Engine
This is Rietveld 408576698