Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: chrome/browser/extensions/extension_permissions_api.h

Issue 8493017: Cleanup extension permissions module. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_permissions_api.h
diff --git a/chrome/browser/extensions/extension_permissions_api.h b/chrome/browser/extensions/extension_permissions_api.h
index 583302e11e003631ce45043bd69acb84dee554aa..5230222ad3395953852ea562369255ca12949f61 100644
--- a/chrome/browser/extensions/extension_permissions_api.h
+++ b/chrome/browser/extensions/extension_permissions_api.h
@@ -12,53 +12,11 @@
#include "chrome/browser/extensions/extension_function.h"
#include "chrome/browser/extensions/extension_install_ui.h"
#include "chrome/common/extensions/extension_permission_set.h"
-#include "chrome/common/chrome_notification_types.h"
-#include "content/public/browser/render_process_host.h"
class Extension;
class ExtensionPermissionSet;
class ExtensionService;
-class ExtensionPermissionsManager {
- public:
- explicit ExtensionPermissionsManager(ExtensionService* extension_service);
- ~ExtensionPermissionsManager();
-
- // Adds the set of |permissions| to the |extension|'s active permission set
- // and sends the relevant messages and notifications. This method assumes the
- // user has already been prompted, if necessary, for the extra permissions.
- void AddPermissions(const Extension* extension,
- const ExtensionPermissionSet* permissions);
-
- // Removes the set of |permissions| from the |extension|'s active permission
- // set and sends the relevant messages and notifications.
- void RemovePermissions(const Extension* extension,
- const ExtensionPermissionSet* permissions);
-
- private:
- enum EventType {
- ADDED,
- REMOVED,
- };
-
- // Dispatches specified event to the extension.
- void DispatchEvent(const std::string& extension_id,
- const char* event_name,
- const ExtensionPermissionSet* changed_permissions);
-
- // Issues the relevant events, messages and notifications when the
- // |extension|'s permissions have |changed| (|changed| is the delta).
- // Specifically, this sends the EXTENSION_PERMISSIONS_UPDATED notification,
- // the ExtensionMsg_UpdatePermissions IPC message, and fires the
- // onAdded/onRemoved events in the extension.
- void NotifyPermissionsUpdated(EventType event_type,
- const Extension* extension,
- const ExtensionPermissionSet* changed);
-
- ExtensionService* extension_service_;
-};
-
-
// chrome.permissions.contains
class ContainsPermissionsFunction : public SyncExtensionFunction {
virtual ~ContainsPermissionsFunction() {}
@@ -101,7 +59,6 @@ class RequestPermissionsFunction : public AsyncExtensionFunction,
private:
scoped_ptr<ExtensionInstallUI> install_ui_;
scoped_refptr<ExtensionPermissionSet> requested_permissions_;
- const Extension* extension_;
DECLARE_EXTENSION_FUNCTION_NAME("permissions.request")
};

Powered by Google App Engine
This is Rietveld 408576698