Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1471)

Unified Diff: chrome/browser/extensions/extension_permissions_api.h

Issue 8493017: Cleanup extension permissions module. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_permissions_api.h
diff --git a/chrome/browser/extensions/extension_permissions_api.h b/chrome/browser/extensions/extension_permissions_api.h
index 7644a6a7b824ce301616800de095a1d9d2df0253..e5cd67b0d966f719ed0720a4a79175c3721877e9 100644
--- a/chrome/browser/extensions/extension_permissions_api.h
+++ b/chrome/browser/extensions/extension_permissions_api.h
@@ -10,8 +10,6 @@
#include "chrome/browser/extensions/extension_function.h"
#include "chrome/browser/extensions/extension_install_ui.h"
#include "chrome/common/extensions/extension_permission_set.h"
-#include "chrome/common/chrome_notification_types.h"
-#include "content/browser/renderer_host/render_process_host.h"
namespace base {
class DictionaryValue;
@@ -21,10 +19,10 @@ class ExtensionPermissionSet;
class ExtensionService;
class Profile;
-class ExtensionPermissionsManager {
+class ExtensionPermissionsUpdater {
public:
- explicit ExtensionPermissionsManager(ExtensionService* extension_service);
- ~ExtensionPermissionsManager();
+ explicit ExtensionPermissionsUpdater(ExtensionService* extension_service);
+ ~ExtensionPermissionsUpdater();
// Adds the set of |permissions| to the |extension|'s active permission set
// and sends the relevant messages and notifications. This method assumes the
@@ -97,13 +95,12 @@ class RequestPermissionsFunction : public AsyncExtensionFunction,
virtual void InstallUIAbort(bool user_initiated) OVERRIDE;
protected:
- virtual ~RequestPermissionsFunction();
+ virtual ~RequestPermissionsFunction() {}
virtual bool RunImpl() OVERRIDE;
private:
scoped_ptr<ExtensionInstallUI> install_ui_;
scoped_refptr<ExtensionPermissionSet> requested_permissions_;
- const Extension* extension_;
DECLARE_EXTENSION_FUNCTION_NAME("permissions.request")
};

Powered by Google App Engine
This is Rietveld 408576698