content: Remove 16 exit time destructors and 15 static initializers.

content/browser/browsing_instance.h

Index: content/browser/browsing_instance.h
diff --git a/content/browser/browsing_instance.h b/content/browser/browsing_instance.h
index 5d7de84860bab82b56751ee23624d6aeaa5a38ed..71c4695886f59fcd0d4cf775fd5f197e199f33e9 100644
--- a/content/browser/browsing_instance.h
+++ b/content/browser/browsing_instance.h
@@ -7,6 +7,7 @@
 #pragma once
 
 #include "base/hash_tables.h"
+#include "base/lazy_instance.h"
 #include "base/memory/ref_counted.h"
 #include "content/common/content_export.h"
 
@@ -132,7 +133,10 @@ class CONTENT_EXPORT BrowsingInstance
   SiteInstanceMap site_instance_map_;
 
   // Global map of BrowserContext to SiteInstanceMap, for process-per-site.
-  static ContextSiteInstanceMap context_site_instance_map_;
+  static base::LazyInstance<

[Mark Mentovai, 2011/11/07 22:34:15]

private + static + in a .h file suggests that this can be made a non-member in
an anonymous namespace of the .cc file. It’s an implementation detail that
doesn’t need to be exposed here.

This occurs elsewhere in this change and I may not have marked each occurrence.

[Nico, 2011/11/07 23:29:21]

I tried that everywhere, but it wasn't trivially possible in all cases. Here,
the type ContextSiteInstanceMap was private to the class, and for some reason I
thought it was used in other places in the .h as well. In this case, I could
indeed move everything to the cc (done), but it wasn't always possible.

[Nico, 2011/11/07 23:37:41]

Ah, the problem was that the type depends on SiteInstanceMap, which is a private
typedef. Undid this.

+      ContextSiteInstanceMap,
+      base::LeakyLazyInstanceTraits<ContextSiteInstanceMap> >
+          context_site_instance_map_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowsingInstance);
 };