content: Remove 16 exit time destructors and 15 static initializers.

content/browser/net/url_request_mock_http_job.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A net::URLRequestJob class that pulls the content and http headers from disk.
 
 #ifndef CONTENT_BROWSER_NET_URL_REQUEST_MOCK_HTTP_JOB_H_
 #define CONTENT_BROWSER_NET_URL_REQUEST_MOCK_HTTP_JOB_H_
 #pragma once
 
@@ skipping 11 matching lines @@
   virtual bool GetMimeType(std::string* mime_type) const;
   virtual bool GetCharset(std::string* charset);
   virtual void GetResponseInfo(net::HttpResponseInfo* info);
   virtual bool IsRedirectResponse(GURL* location, int* http_status_code);
 
   static net::URLRequest::ProtocolFactory Factory;
 
   // Adds the testing URLs to the net::URLRequestFilter.
   static void AddUrlHandler(const FilePath& base_path);
 
-  // Given the path to a file relative to base_path_, construct a mock URL.
+  // Given the path to a file relative to BasePath(), construct a mock URL.
   static GURL GetMockUrl(const FilePath& path);
 
-  // Given the path to a file relative to base_path_,
+  // Given the path to a file relative to BasePath(),
   // construct a mock URL for view source.
   static GURL GetMockViewSourceUrl(const FilePath& path);
 
  protected:
   virtual ~URLRequestMockHTTPJob() { }
 
   static FilePath GetOnDiskPath(const FilePath& base_path,
                                 net::URLRequest* request,
                                 const std::string& scheme);
 
  private:
   void GetResponseInfoConst(net::HttpResponseInfo* info) const;
 
   // This is the file path leading to the root of the directory to use as the
   // root of the http server.
-  static FilePath base_path_;
+  static FilePath& BasePath();

[Mark Mentovai, 2011/11/07 22:34:15]

You’re making this return a non-const reference, and expecting a caller to
overwrite the value. Callers may not expect that. It’s worth a comment.

private + static, does this need to be here or can it move to an anonymous
namespace in the .cc file as an implementation detail?

[Nico, 2011/11/07 23:29:21]

Done.
I didn't do it because some comments referenced it. I updated the comments and
moved it over.

 };
 
 #endif  // CONTENT_BROWSER_NET_URL_REQUEST_MOCK_HTTP_JOB_H_