content: Remove 16 exit time destructors and 15 static initializers.

content/browser/debugger/devtools_http_protocol_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/debugger/devtools_http_protocol_handler.h"
 
 #include <utility>
 
 #include "base/compiler_specific.h"
 #include "base/json/json_writer.h"
+#include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/message_loop_proxy.h"
 #include "base/string_number_conversions.h"
 #include "base/stringprintf.h"
 #include "base/threading/thread.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "content/browser/debugger/devtools_client_host.h"
 #include "content/browser/debugger/devtools_manager.h"
 #include "content/browser/tab_contents/tab_contents.h"
@@ skipping 64 matching lines @@
   net::HttpServer* server_;
   int connection_id_;
 };
 
 static int next_id = 1;
 
 class TabContentsIDHelper : public TabContentsObserver {
  public:
 
   static int GetID(TabContents* tab) {
-    TabContentsToIdMap::iterator it = tabcontents_to_id_.find(tab);
-    if (it != tabcontents_to_id_.end())
+    TabContentsToIdMap::iterator it = tabcontents_to_id_.Get().find(tab);
+    if (it != tabcontents_to_id_.Get().end())
       return it->second;
     TabContentsIDHelper* wrapper = new TabContentsIDHelper(tab);
     return wrapper->id_;
   }
 
   static TabContents* GetTabContents(int id) {
-    IdToTabContentsMap::iterator it = id_to_tabcontents_.find(id);
-    if (it != id_to_tabcontents_.end())
+    IdToTabContentsMap::iterator it = id_to_tabcontents_.Get().find(id);
+    if (it != id_to_tabcontents_.Get().end())
       return it->second;
     return NULL;
   }
 
  private:
   explicit TabContentsIDHelper(TabContents* tab)
       : TabContentsObserver(tab),
         id_(next_id++) {
-    id_to_tabcontents_[id_] = tab;
-    tabcontents_to_id_[tab] = id_;
+    id_to_tabcontents_.Get()[id_] = tab;
+    tabcontents_to_id_.Get()[tab] = id_;
   }
 
   virtual ~TabContentsIDHelper() {}
 
   virtual void TabContentsDestroyed(TabContents* tab) {
-    id_to_tabcontents_.erase(id_);
-    tabcontents_to_id_.erase(tab);
+    id_to_tabcontents_.Get().erase(id_);
+    tabcontents_to_id_.Get().erase(tab);
     delete this;
   }
 
   int id_;
   typedef std::map<int, TabContents*> IdToTabContentsMap;
-  static IdToTabContentsMap id_to_tabcontents_;
+  static base::LazyInstance<IdToTabContentsMap,

[Mark Mentovai, 2011/11/07 22:34:15]

Note that I have no real concern with private + static + not in an .h file, as
in this case, when the class in question is restricted to an anonymous namespace
in a .cc file. You don’t get any further “hiding” advantage by taking the
variable out of the class, although I’d have no problem if you wanted to do
that, either.

+                            base::LeakyLazyInstanceTraits<IdToTabContentsMap> >
+      id_to_tabcontents_;
   typedef std::map<TabContents*, int> TabContentsToIdMap;
-  static TabContentsToIdMap tabcontents_to_id_;
+  static base::LazyInstance<TabContentsToIdMap,
+                            base::LeakyLazyInstanceTraits<TabContentsToIdMap> >
+      tabcontents_to_id_;
 };
 
-TabContentsIDHelper::IdToTabContentsMap TabContentsIDHelper::id_to_tabcontents_;
-TabContentsIDHelper::TabContentsToIdMap TabContentsIDHelper::tabcontents_to_id_;
+base::LazyInstance<
+    TabContentsIDHelper::IdToTabContentsMap,
+    base::LeakyLazyInstanceTraits<TabContentsIDHelper::IdToTabContentsMap> >
+        TabContentsIDHelper::id_to_tabcontents_(base::LINKER_INITIALIZED);
+base::LazyInstance<
+    TabContentsIDHelper::TabContentsToIdMap,
+    base::LeakyLazyInstanceTraits<TabContentsIDHelper::TabContentsToIdMap> >
+        TabContentsIDHelper::tabcontents_to_id_(base::LINKER_INITIALIZED);
 
 }  // namespace
 
 // static
 scoped_refptr<DevToolsHttpProtocolHandler> DevToolsHttpProtocolHandler::Start(
     const std::string& ip,
     int port,
     const std::string& frontend_url,
     Delegate* delegate) {
   scoped_refptr<DevToolsHttpProtocolHandler> http_handler =
@@ skipping 401 matching lines @@
 void DevToolsHttpProtocolHandler::AcceptWebSocket(
     int connection_id,
     const net::HttpServerRequestInfo& request) {
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       NewRunnableMethod(server_.get(),
                         &net::HttpServer::AcceptWebSocket,
                         connection_id,
                         request));
 }