Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 8493008: Tighten the code for MacroAssembler::ThrowUncatchable. (Closed)

Created:
9 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 1 month ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Tighten the code for MacroAssembler::ThrowUncatchable. Test at the bottom in the unwind loop. Eliminate the possibility of a useless move to the eax/rax/r0 register (currently impossible because this function has two call sites). Do not explicitly zero the context because we've already saved 0 as the context in the handler. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -105 lines) Patch
M src/arm/macro-assembler-arm.cc View 2 chunks +26 lines, -39 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +26 lines, -35 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +27 lines, -31 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 1 month ago (2011-11-07 12:52:38 UTC) #1
fschneider
9 years, 1 month ago (2011-11-08 10:55:07 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698