OLD | NEW |
| 1 2011-11-02 Ryosuke Niwa <rniwa@webkit.org> |
| 2 |
| 3 REGRESSION(r96870): WebKit generates background: transparent on blogger.
com |
| 4 https://bugs.webkit.org/show_bug.cgi?id=71203 |
| 5 |
| 6 Reviewed by Ojan Vafai. |
| 7 |
| 8 Remove the transparent background color from inline style declarations i
n the pasted content. |
| 9 Also fixed a bug in removeStyleFromRulesAndContext that it removes prope
rties in inline style |
| 10 declarations even if those properties were overridden. |
| 11 |
| 12 Tests: editing/deleting/merge-paragraphs-with-transparent-background.htm
l |
| 13 editing/deleting/paste-with-transparent-background-color.html |
| 14 |
| 15 * editing/EditingStyle.cpp: |
| 16 (WebCore::removePropertiesInStyle): |
| 17 (WebCore::EditingStyle::removeStyleFromRulesAndContext): |
| 18 (WebCore::EditingStyle::removePropertiesInElementDefaultStyle): |
| 19 |
| 20 2011-11-02 Andreas Kling <kling@webkit.org> |
| 21 |
| 22 CSSStyleRule: Devirtualize selectorText() |
| 23 https://bugs.webkit.org/show_bug.cgi?id=71364 |
| 24 |
| 25 Reviewed by Antti Koivisto. |
| 26 |
| 27 Have CSSStyleRule::selectorText() redirect to CSSPageRule::pageSelectorT
ext() |
| 28 if type() is PAGE_RULE. |
| 29 |
| 30 * css/CSSPageRule.cpp: |
| 31 (WebCore::CSSPageRule::pageSelectorText): |
| 32 * css/CSSPageRule.h: |
| 33 * css/CSSStyleRule.cpp: |
| 34 (WebCore::CSSStyleRule::selectorText): |
| 35 * css/CSSStyleRule.h: |
| 36 |
| 37 2011-11-02 Andreas Kling <kling@webkit.org> |
| 38 |
| 39 CSSRule: Devirtualize cssText() |
| 40 https://bugs.webkit.org/show_bug.cgi?id=71292 |
| 41 |
| 42 Reviewed by Antti Koivisto. |
| 43 |
| 44 Have CSSRule::cssText() redirect to the appropriate subclass based on ty
pe(). |
| 45 This is one of the last steps of devirtualizing CSSRule completely, whic
h will |
| 46 allow us to get rid of its vtable, and each instance's pointer thereto. |
| 47 |
| 48 * css/CSSCharsetRule.h: |
| 49 * css/CSSFontFaceRule.h: |
| 50 * css/CSSImportRule.h: |
| 51 * css/CSSMediaRule.h: |
| 52 * css/CSSRegionStyleRule.h: |
| 53 * css/CSSRule.cpp: |
| 54 (WebCore::CSSRule::cssText): |
| 55 * css/CSSRule.h: |
| 56 * css/CSSStyleRule.h: |
| 57 * css/WebKitCSSKeyframeRule.h: |
| 58 * css/WebKitCSSKeyframesRule.h: |
| 59 |
| 60 2011-11-02 Patrick Gansterer <paroga@webkit.org> |
| 61 |
| 62 Unreviewed build fix for !ENABLE(FILTERS) after r98989. |
| 63 |
| 64 * rendering/svg/SVGResourcesCache.cpp: |
| 65 (WebCore::SVGResourcesCache::clientLayoutChanged): |
| 66 |
| 67 2011-11-02 Alexander Pavlov <apavlov@chromium.org> |
| 68 |
| 69 Web Inspector: [REGRESSION] Clicking in a CSS property/value being edite
d commits the editor |
| 70 https://bugs.webkit.org/show_bug.cgi?id=71360 |
| 71 |
| 72 Reviewed by Pavel Feldman. |
| 73 |
| 74 Selecting a selected TreeElement should be an idempotent operation. |
| 75 |
| 76 * inspector/front-end/treeoutline.js: |
| 77 (TreeElement.prototype.select): |
| 78 |
| 79 2011-11-02 Ben Wells <benwells@chromium.org> |
| 80 |
| 81 Canvas filling paths or rects need to be invalidate larger rects for som
e compositing modes. |
| 82 https://bugs.webkit.org/show_bug.cgi?id=70379 |
| 83 |
| 84 Reviewed by James Robinson. |
| 85 |
| 86 Test: fast/canvas/canvas-composite-fill-repaint.html |
| 87 |
| 88 * html/canvas/CanvasRenderingContext2D.cpp: |
| 89 (WebCore::CanvasRenderingContext2D::fill): |
| 90 (WebCore::CanvasRenderingContext2D::fillRect): |
| 91 (WebCore::CanvasRenderingContext2D::drawImage): |
| 92 (WebCore::CanvasRenderingContext2D::didDrawEntireCanvas): |
| 93 * html/canvas/CanvasRenderingContext2D.h: |
| 94 |
| 95 2011-11-01 Levi Weintraub <leviw@chromium.org> |
| 96 |
| 97 Fix uses of LayoutUnit in Frame-, Scroll-, and RenderView |
| 98 https://bugs.webkit.org/show_bug.cgi?id=71321 |
| 99 |
| 100 Reviewed by Darin Adler. |
| 101 |
| 102 Updating the usage of LayoutUnits in the *View classes to mirror the pro
per use |
| 103 as derived in the subpixellayout branch. |
| 104 |
| 105 This entails scrolling only with integers (and rounding once we've made
the switch) |
| 106 and using integers for window coordinates, with LayoutUnits for content
coordinates. |
| 107 |
| 108 No new tests -- no change in behavior. |
| 109 |
| 110 * page/FrameView.cpp: |
| 111 (WebCore::FrameView::invalidateRect): |
| 112 (WebCore::FrameView::setFrameRect): |
| 113 (WebCore::FrameView::zoomAnimatorTransformChanged): |
| 114 (WebCore::FrameView::scrollContentsFastPath): |
| 115 (WebCore::FrameView::scrollContentsSlowPath): |
| 116 (WebCore::FrameView::scrollElementToRect): |
| 117 (WebCore::FrameView::setScrollPosition): |
| 118 (WebCore::FrameView::repaintContentRectangle): |
| 119 (WebCore::FrameView::scrollTo): |
| 120 (WebCore::FrameView::updateScrollCorner): |
| 121 * page/FrameView.h: |
| 122 (WebCore::FrameView::trackedRepaintRects): |
| 123 * platform/ScrollView.cpp: |
| 124 (WebCore::ScrollView::visibleContentRect): |
| 125 (WebCore::ScrollView::layoutWidth): |
| 126 (WebCore::ScrollView::layoutHeight): |
| 127 (WebCore::ScrollView::fixedLayoutSize): |
| 128 (WebCore::ScrollView::setFixedLayoutSize): |
| 129 (WebCore::ScrollView::contentsSize): |
| 130 (WebCore::ScrollView::setContentsSize): |
| 131 (WebCore::ScrollView::overhangAmount): |
| 132 (WebCore::ScrollView::updateScrollbars): |
| 133 (WebCore::ScrollView::rectToCopyOnScroll): |
| 134 (WebCore::ScrollView::scrollContents): |
| 135 (WebCore::ScrollView::windowToContents): |
| 136 (WebCore::ScrollView::screenToContents): |
| 137 (WebCore::ScrollView::scrollbarAtPoint): |
| 138 (WebCore::ScrollView::wheelEvent): |
| 139 * platform/ScrollView.h: |
| 140 (WebCore::ScrollView::visibleWidth): |
| 141 (WebCore::ScrollView::visibleHeight): |
| 142 (WebCore::ScrollView::contentsWidth): |
| 143 (WebCore::ScrollView::contentsHeight): |
| 144 (WebCore::ScrollView::adjustScrollPositionWithinRange): |
| 145 * rendering/RenderView.cpp: |
| 146 (WebCore::RenderView::paint): |
| 147 (WebCore::RenderView::shouldRepaint): |
| 148 (WebCore::RenderView::repaintViewRectangle): |
| 149 (WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): |
| 150 (WebCore::RenderView::computeRectForRepaint): |
| 151 (WebCore::RenderView::selectionBounds): |
| 152 (WebCore::RenderView::viewRect): |
| 153 (WebCore::RenderView::unscaledDocumentRect): |
| 154 (WebCore::RenderView::documentRect): |
| 155 * rendering/RenderView.h: |
| 156 (WebCore::RenderView::printRect): |
| 157 (WebCore::RenderView::setPrintRect): |
| 158 |
| 159 2011-11-01 Anna Cavender <annacc@chromium.org> |
| 160 |
| 161 Small fixes for WebVTTParser. |
| 162 https://bugs.webkit.org/show_bug.cgi?id=71334 |
| 163 |
| 164 Reviewed by Darin Adler. |
| 165 |
| 166 No new tests. This is needed to enable other tests, coming soon. |
| 167 |
| 168 * html/track/WebVTTParser.cpp: |
| 169 (WebCore::hasLongWebVTTIdentifier): changed to return true when header i
s |
| 170 exactly "WEBVTT" |
| 171 (WebCore::WebVTTParser::collectTimingsAndSettings): fix typos, position
should |
| 172 only progress once when checking the character after a timestamp. |
| 173 |
| 174 2011-11-01 Darin Adler <darin@apple.com> |
| 175 |
| 176 Change HTMLSelectElement::setSelectedIndex to use enums instead of bools |
| 177 https://bugs.webkit.org/show_bug.cgi?id=70184 |
| 178 |
| 179 Reviewed by Kent Tamura. |
| 180 |
| 181 Refactoring that does not require new tests. |
| 182 |
| 183 * bindings/objc/DOMHTML.mm: |
| 184 (-[DOMHTMLSelectElement _activateItemAtIndex:]): Replaced setSelectedInd
exByUser |
| 185 call with a call to the renamed optionSelectedByUser, also removed one a
rgument. |
| 186 (-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]):
Ditto. |
| 187 |
| 188 * html/HTMLOptionElement.cpp: |
| 189 (WebCore::HTMLOptionElement::setSelected): Replaced setSelectedIndex cal
l with a |
| 190 call to the new optionSelectionStateChanged function. |
| 191 (WebCore::HTMLOptionElement::insertedIntoTree): Ditto. |
| 192 |
| 193 * html/HTMLSelectElement.cpp: |
| 194 (WebCore::HTMLSelectElement::HTMLSelectElement): Updated since m_userDri
venChange |
| 195 was renamed to m_isProcessingUserDrivenChange. |
| 196 (WebCore::HTMLSelectElement::optionSelectedByUser): Removed deselect arg
ument, |
| 197 which was always true for all callers. Updated comment. |
| 198 (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Updated comment
. |
| 199 (WebCore::HTMLSelectElement::setOption): Call the new optionSelectionSta
teChanged |
| 200 function. The code used to explicitly ask the function it calls to desel
ect base |
| 201 on the value of m_multiple, but that is no longer needed because the sel
ectOption |
| 202 function itself takes care of that check. |
| 203 (WebCore::HTMLSelectElement::dispatchChangeEventForMenuList): Renamed th
is function. |
| 204 Also updated for name change to m_isProcessingUserDrivenChange. |
| 205 (WebCore::HTMLSelectElement::setSelectedIndex): Moved the formerly-inlin
ed function |
| 206 here from the header and changed it to call the renamed selectOption fun
ction. |
| 207 (WebCore::HTMLSelectElement::optionSelectionStateChanged): Added this fu
nction. |
| 208 It is used by callers that were previously using setSelectedIndex and pa
ssing |
| 209 "false" for the deselect argument. It's better now that setSelectedIndex
is now a |
| 210 pure DOM setter function without the multiple purposes it had before. Th
is function |
| 211 now has the logic that handles the special handling when deselecting an
option, |
| 212 which used to be at the top of the next function. |
| 213 (WebCore::HTMLSelectElement::selectOption): Renamed this from setSelecte
dIndex. |
| 214 Replaced boolean arguments with flags. Removed code to handle the specia
l case |
| 215 when we deselect an option; that's now handled in the optionSelectionSta
teChanged |
| 216 function. Added an assertion to replace a comment and updated for other
renaming. |
| 217 (WebCore::HTMLSelectElement::dispatchBlurEvent): Updated for name change
. |
| 218 (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Ditto. |
| 219 (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Changed to ca
ll the |
| 220 new selectOption function and also updated for other name changes. |
| 221 (WebCore::HTMLSelectElement::typeAheadFind): Ditto. |
| 222 (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto. |
| 223 |
| 224 * html/HTMLSelectElement.h: Changed the setSelectedIndex to be a pure se
tter |
| 225 function for the selectedIndex DOM property. Added a optionSelectedByUse
r function |
| 226 for the other use of setSelectedIndex, but removed the always true "dese
lect" |
| 227 argument from it. Added a optionSelectionStateChanged function for use i
n the |
| 228 HTMLOptionElement implementation. Renamed menuListOnChange to |
| 229 dispatchChangeEventForMenuList for clarity. Added a SelectOptionFlag and |
| 230 SelectOptionFlags type for the arguments to the selectOption function, f
ormerly |
| 231 implemented as an overload of setSelectedIndex (and called setSelectedIn
dexInternal |
| 232 before that). Renamed m_userDrivenChange to m_isProcessingUserDrivenChan
ge. |
| 233 |
| 234 * rendering/RenderMenuList.cpp: |
| 235 (WebCore::RenderMenuList::valueChanged): Replaced setSelectedIndexByUser |
| 236 call with a call to the renamed optionSelectedByUser, also removed one a
rgument. |
| 237 |
| 238 2011-11-01 Sam Weinig <sam@webkit.org> |
| 239 |
| 240 Implement __lookupGetter__/__lookupSetter__ in terms of getPropertyDescr
iptor |
| 241 https://bugs.webkit.org/show_bug.cgi?id=71336 |
| 242 |
| 243 Reviewed by Darin Adler. |
| 244 |
| 245 * bindings/js/JSDOMWindowCustom.cpp: |
| 246 * bindings/js/JSDOMWindowShell.cpp: |
| 247 * bindings/js/JSDOMWindowShell.h: |
| 248 * page/DOMWindow.idl: |
| 249 Remove overrides of lookupGetter/lookupSetter, which are no longer neede
d |
| 250 due to implementing getPropertyDescriptor. |
| 251 |
| 252 |
| 253 2011-11-01 Nat Duca <nduca@chromium.org> |
| 254 |
| 255 [chromium] Move resource-releasing logic into CCProxy and cleanup setNee
dsCommit |
| 256 https://bugs.webkit.org/show_bug.cgi?id=71269 |
| 257 |
| 258 Reviewed by James Robinson. |
| 259 |
| 260 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
| 261 (WebCore::CCLayerTreeHost::finishCommitOnImplThread): |
| 262 (WebCore::CCLayerTreeHost::setZoomAnimatorTransform): |
| 263 (WebCore::CCLayerTreeHost::setNeedsCommit): |
| 264 (WebCore::CCLayerTreeHost::setViewport): |
| 265 (WebCore::CCLayerTreeHost::setVisible): |
| 266 * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
| 267 * platform/graphics/chromium/cc/CCProxy.h: |
| 268 * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: |
| 269 (WebCore::CCSingleThreadProxy::doCommit): |
| 270 (WebCore::CCSingleThreadProxy::setNeedsRedraw): |
| 271 (WebCore::CCSingleThreadProxy::setVisible): |
| 272 (WebCore::CCSingleThreadProxy::recreateContextIfNeeded): |
| 273 (WebCore::CCSingleThreadProxy::doComposite): |
| 274 * platform/graphics/chromium/cc/CCSingleThreadProxy.h: |
| 275 (WebCore::CCSingleThreadProxy::setNeedsRedrawOnImplThread): |
| 276 (WebCore::CCSingleThreadProxy::setNeedsCommitOnImplThread): |
| 277 * platform/graphics/chromium/cc/CCThreadProxy.cpp: |
| 278 (WebCore::CCThreadProxy::setNeedsCommit): |
| 279 (WebCore::CCThreadProxy::setNeedsAnimateOnImplThread): |
| 280 (WebCore::CCThreadProxy::setVisible): |
| 281 * platform/graphics/chromium/cc/CCThreadProxy.h: |
| 282 |
| 283 2011-11-01 Anna Cavender <annacc@chromium.org> |
| 284 |
| 285 Makes [Reflect] work for constants. |
| 286 This is needed to avoid platform-specific define conflicts, specifically |
| 287 TextTrack::ERROR conflicts with a windows define. |
| 288 https://bugs.webkit.org/show_bug.cgi?id=70951 |
| 289 |
| 290 Reviewed by Darin Adler. |
| 291 |
| 292 Test: media/track/track-constants.html |
| 293 |
| 294 * bindings/scripts/CodeGenerator.pm: |
| 295 (GenerateCompileTimeCheckForEnumsIfNeeded): |
| 296 Check for [Reflect] and assign name accordingly. |
| 297 |
| 298 * bindings/scripts/test/CPP/WebDOMTestObj.h: Update test file. |
| 299 * bindings/scripts/test/JS/JSTestObj.cpp: Update test file. |
| 300 (WebCore::jsTestObjCONST_JAVASCRIPT): |
| 301 * bindings/scripts/test/JS/JSTestObj.h: Update test file. |
| 302 * bindings/scripts/test/ObjC/DOMTestObj.h: Update test file. |
| 303 * bindings/scripts/test/TestObj.idl: Update test file. |
| 304 * bindings/scripts/test/V8/V8TestObj.cpp: Update test file. |
| 305 |
| 306 * html/LoadableTextTrack.cpp: Use new DOM const name. |
| 307 (WebCore::LoadableTextTrack::cueLoadingStarted): |
| 308 (WebCore::LoadableTextTrack::cueLoadingCompleted): |
| 309 * html/TextTrack.cpp: Use new DOM const name. |
| 310 (WebCore::TextTrack::TextTrack): |
| 311 (WebCore::TextTrack::setMode): |
| 312 * html/TextTrack.h: Use new DOM const name. |
| 313 * html/TextTrack.idl: Use Reflect for ERROR, but leave other DOM const
names. |
| 314 |
| 315 2011-11-01 Levi Weintraub <leviw@chromium.org> |
| 316 |
| 317 Amend missing uses of LayoutUnit in RenderBlock |
| 318 https://bugs.webkit.org/show_bug.cgi?id=71254 |
| 319 |
| 320 Reviewed by Darin Adler. |
| 321 |
| 322 Switching relevant uses of integers in RenderBlock to LayoutUnits. |
| 323 |
| 324 No new tests -- no changes in behavior. |
| 325 |
| 326 * rendering/RenderBlock.cpp: |
| 327 (WebCore::RenderBlock::MarginInfo::MarginInfo): |
| 328 (WebCore::RenderBlock::layoutBlock): |
| 329 (WebCore::RenderBlock::adjustFloatingBlock): |
| 330 (WebCore::RenderBlock::clearFloatsIfNeeded): |
| 331 (WebCore::RenderBlock::layoutBlockChild): |
| 332 (WebCore::RenderBlock::paintColumnRules): |
| 333 (WebCore::RenderBlock::paintContents): |
| 334 (WebCore::clipOutPositionedObjects): |
| 335 (WebCore::RenderBlock::removeFloatingObject): |
| 336 (WebCore::RenderBlock::nextFloatLogicalBottomBelow): |
| 337 (WebCore::RenderBlock::getClearDelta): |
| 338 (WebCore::positionForPointRespectingEditingBoundaries): |
| 339 (WebCore::RenderBlock::calcColumnWidth): |
| 340 (WebCore::RenderBlock::layoutColumns): |
| 341 (WebCore::RenderBlock::adjustRectForColumns): |
| 342 (WebCore::RenderBlock::computeInlinePreferredLogicalWidths): |
| 343 (WebCore::RenderBlock::baselinePosition): |
| 344 (WebCore::getHeightForLineCount): |
| 345 (WebCore::RenderBlock::setPaginationStrut): |
| 346 (WebCore::RenderBlock::applyBeforeBreak): |
| 347 (WebCore::RenderBlock::applyAfterBreak): |
| 348 (WebCore::RenderBlock::adjustForUnsplittableChild): |
| 349 * rendering/RenderBlock.h: |
| 350 (WebCore::RenderBlock::availableLogicalWidthForLine): |
| 351 (WebCore::RenderBlock::paginationStrut): |
| 352 (WebCore::RenderBlock::availableLogicalWidthForContent): |
| 353 (WebCore::RenderBlock::FloatWithRect::FloatWithRect): |
| 354 (WebCore::RenderBlock::MarginInfo::setPositiveMargin): |
| 355 (WebCore::RenderBlock::MarginInfo::setNegativeMargin): |
| 356 (WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger): |
| 357 (WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger): |
| 358 (WebCore::RenderBlock::MarginInfo::setMargin): |
| 359 (WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAd
apter): |
| 360 (WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue): |
| 361 (WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue): |
| 362 (WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault)
: |
| 363 (WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault)
: |
| 364 (WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault): |
| 365 (WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault): |
| 366 |
| 367 2011-11-01 Luke Macpherson <macpherson@chromium.org> |
| 368 |
| 369 WIP: Add CSS property to control printing of backgrounds for individual
elements. |
| 370 https://bugs.webkit.org/show_bug.cgi?id=64583 |
| 371 |
| 372 Reviewed by Eric Seidel. |
| 373 |
| 374 Added test LayoutTests/fast/css/webkit-color-adjust.html, |
| 375 Updated tests under LayoutTests/fast/css/getComputedStyle |
| 376 Updated test under LayoutTests/svg/css |
| 377 |
| 378 * css/CSSComputedStyleDeclaration.cpp: |
| 379 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): |
| 380 * css/CSSParser.cpp: |
| 381 (WebCore::CSSParser::parseValue): |
| 382 * css/CSSPropertyNames.in: |
| 383 * css/CSSStyleSelector.cpp: |
| 384 (WebCore::CSSStyleSelector::styleForDocument): |
| 385 (WebCore::CSSStyleSelector::applyProperty): |
| 386 * rendering/RenderBoxModelObject.cpp: |
| 387 (WebCore::RenderBoxModelObject::paintFillLayerExtended): |
| 388 * rendering/style/RenderStyle.h: |
| 389 (WebCore::InheritedFlags::initialForceBackgroundsToWhite): |
| 390 |
| 391 2011-11-01 Dominic Cooney <dominicc@chromium.org> |
| 392 |
| 393 Remove initErrorEvent method |
| 394 https://bugs.webkit.org/show_bug.cgi?id=71338 |
| 395 |
| 396 Reviewed by Ojan Vafai. |
| 397 |
| 398 * dom/ErrorEvent.cpp: Crush. |
| 399 * dom/ErrorEvent.h: Kill. |
| 400 * dom/ErrorEvent.idl: Destroy. |
| 401 |
| 402 2011-11-01 Julien Chaffraix <jchaffraix@webkit.org> |
| 403 |
| 404 Pack RenderTableCell bits |
| 405 https://bugs.webkit.org/show_bug.cgi?id=71135 |
| 406 |
| 407 Reviewed by Darin Adler. |
| 408 |
| 409 Tested by RenderTableCellTest unit test. |
| 410 (unfortunately Chromium specific...) |
| 411 |
| 412 This saves another 8 bytes on RenderTableCell on x86-64. |
| 413 |
| 414 * rendering/RenderTableCell.cpp: |
| 415 (WebCore::RenderTableCell::RenderTableCell): |
| 416 * rendering/RenderTableCell.h: |
| 417 Changed the field order to use more strict packing. |
| 418 |
| 419 (WebCore::RenderTableCell::setCol): |
| 420 (WebCore::RenderTableCell::setRow): |
| 421 Added overflow checks to the 2 previous methods. We |
| 422 CRASH even in release to avoid potential badness |
| 423 (the limit is currently above 2 billions rows or columns |
| 424 which is high enough to prevent it being hit by accident) |
| 425 |
| 426 2011-11-01 Emil A Eklund <eae@chromium.org> |
| 427 |
| 428 Switch background/border image back to Int |
| 429 https://bugs.webkit.org/show_bug.cgi?id=71240 |
| 430 |
| 431 Reviewed by Darin Adler. |
| 432 |
| 433 Switch background- and border-image rendering back to int to align with |
| 434 device pixels. |
| 435 |
| 436 No new tests. |
| 437 |
| 438 * rendering/RenderBoxModelObject.cpp: |
| 439 (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): |
| 440 (WebCore::RenderBoxModelObject::calculateFillTileSize): |
| 441 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachm
ent): |
| 442 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip): |
| 443 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase): |
| 444 (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): |
| 445 (WebCore::RenderBoxModelObject::paintNinePieceImage): |
| 446 (WebCore::calculateAdjustedInnerBorder): |
| 447 * rendering/RenderBoxModelObject.h: |
| 448 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin): |
| 449 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin): |
| 450 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect): |
| 451 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect): |
| 452 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase): |
| 453 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase): |
| 454 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize): |
| 455 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize): |
| 456 |
| 457 2011-11-01 Mark Hahnenberg <mhahnenberg@apple.com> |
| 458 |
| 459 De-virtualize JSObject::defineSetter |
| 460 https://bugs.webkit.org/show_bug.cgi?id=71303 |
| 461 |
| 462 Reviewed by Darin Adler. |
| 463 |
| 464 No new tests. |
| 465 |
| 466 Added defineSetter to the MethodTable, changed all the virtual |
| 467 implementations of defineSetter to static ones, and replaced |
| 468 all call sites with corresponding lookups in the MethodTable. |
| 469 |
| 470 * bindings/js/JSDOMWindowCustom.cpp: |
| 471 (WebCore::JSDOMWindow::defineSetter): |
| 472 * bindings/js/JSDOMWindowShell.cpp: |
| 473 (WebCore::JSDOMWindowShell::defineSetter): |
| 474 * bindings/js/JSDOMWindowShell.h: |
| 475 * bindings/scripts/CodeGeneratorJS.pm: |
| 476 (GenerateHeader): |
| 477 |
| 478 2011-11-01 Emil A Eklund <eae@chromium.org> |
| 479 |
| 480 Switch PopupMenuClient to layout abstraction |
| 481 https://bugs.webkit.org/show_bug.cgi?id=71308 |
| 482 |
| 483 Reviewed by Darin Adler. |
| 484 |
| 485 Switch PopupMenuClient and rendering classes implementing it to layout |
| 486 type abstraction. |
| 487 |
| 488 No new tests. |
| 489 |
| 490 * platform/PopupMenuClient.h: |
| 491 * rendering/RenderListBox.cpp: |
| 492 (WebCore::RenderListBox::listIndexAtOffset): |
| 493 (WebCore::RenderListBox::panScroll): |
| 494 (WebCore::RenderListBox::scrollToward): |
| 495 (WebCore::RenderListBox::scrollSize): |
| 496 (WebCore::RenderListBox::scrollPosition): |
| 497 (WebCore::RenderListBox::setScrollOffset): |
| 498 (WebCore::RenderListBox::verticalScrollbarWidth): |
| 499 Revert scroll positions and scroll offsets to ints to align with device |
| 500 pixels. |
| 501 |
| 502 * rendering/RenderListBox.h: |
| 503 * rendering/RenderMenuList.cpp: |
| 504 (WebCore::RenderMenuList::showPopup): |
| 505 (WebCore::RenderMenuList::clientPaddingLeft): |
| 506 (WebCore::RenderMenuList::clientPaddingRight): |
| 507 * rendering/RenderMenuList.h: |
| 508 * rendering/RenderTextControl.cpp: |
| 509 (WebCore::RenderTextControl::hitInnerTextElement): |
| 510 * rendering/RenderTextControlSingleLine.cpp: |
| 511 (WebCore::RenderTextControlSingleLine::clientPaddingLeft): |
| 512 (WebCore::RenderTextControlSingleLine::clientPaddingRight): |
| 513 * rendering/RenderTextControlSingleLine.h: |
| 514 |
| 515 2011-11-01 Nate Chapin <japhet@chromium.org> |
| 516 |
| 517 [chromium] As of r98380, ThreadableLoaderClients are having their |
| 518 ResourceRequest::TargetType clobbered. They set their own |
| 519 type, but CachedResourceRequest (through which they now flow) |
| 520 sets a TargetType without bothering to see if one has already been set. |
| 521 https://bugs.webkit.org/show_bug.cgi?id=70972 |
| 522 |
| 523 Reviewed by Darin Fisher. |
| 524 |
| 525 No new tests, this is chromium-specific and only affects |
| 526 behavior seen in full builds of chromium. |
| 527 |
| 528 * loader/cache/CachedResourceRequest.cpp: |
| 529 (WebCore::CachedResourceRequest::load):Don't setTargetType() |
| 530 if the value is something other than the default already. |
| 531 * platform/network/chromium/ResourceRequest.h: Change default |
| 532 TargetType to TargetIsUnspecified. |
| 533 |
| 534 2011-11-01 Emil A Eklund <eae@chromium.org> |
| 535 |
| 536 Use IntPoint for screen coordinates in MouseEvent |
| 537 https://bugs.webkit.org/show_bug.cgi?id=71327 |
| 538 |
| 539 Reviewed by Darin Adler. |
| 540 |
| 541 Change mouse events to use int/IntPoint for screen/window coordinates an
d |
| 542 LayoutUnit/LayoutPoint for coordinates adjusted for zooming. |
| 543 |
| 544 No new tests. |
| 545 |
| 546 * dom/MouseRelatedEvent.cpp: |
| 547 (WebCore::MouseRelatedEvent::MouseRelatedEvent): |
| 548 (WebCore::MouseRelatedEvent::computeRelativePosition): |
| 549 * dom/MouseRelatedEvent.h: |
| 550 (WebCore::MouseRelatedEvent::screenLocation): |
| 551 Revert screenLocation and windowLocation back to int. |
| 552 |
| 553 * page/DragController.cpp: |
| 554 (WebCore::elementUnderMouse): |
| 555 Change elementUnderMouse to use a LayoutPoint for hit testing. |
| 556 |
| 557 * page/EventHandler.cpp: |
| 558 (WebCore::EventHandler::clear): |
| 559 (WebCore::EventHandler::currentMousePosition): |
| 560 (WebCore::documentPointForWindowPoint): |
| 561 (WebCore::EventHandler::fakeMouseMoveEventTimerFired): |
| 562 * page/EventHandler.h: |
| 563 Revert m_currentMousePosition to IntPoint as it represents a |
| 564 screen coordinate. |
| 565 |
| 566 * platform/PlatformMouseEvent.h: |
| 567 (WebCore::PlatformMouseEvent::PlatformMouseEvent): |
| 568 (WebCore::PlatformMouseEvent::pos): |
| 569 (WebCore::PlatformMouseEvent::x): |
| 570 (WebCore::PlatformMouseEvent::y): |
| 571 (WebCore::PlatformMouseEvent::globalX): |
| 572 (WebCore::PlatformMouseEvent::globalY): |
| 573 * platform/mac/PlatformMouseEventMac.mm: |
| 574 (WebCore::globalPoint): |
| 575 (WebCore::pointForEvent): |
| 576 (WebCore::globalPointForEvent): |
| 577 Revert PlatformMouseEvent to int/IntPoint as it represents a screen |
| 578 coordinate. |
| 579 |
| 580 2011-11-01 Tony Chang <tony@chromium.org> |
| 581 |
| 582 REGRESSION: -webkit-flex() should be an invalid value |
| 583 https://bugs.webkit.org/show_bug.cgi?id=71320 |
| 584 |
| 585 Reviewed by Ojan Vafai. |
| 586 |
| 587 This regressed in http://trac.webkit.org/changeset/98773 . |
| 588 |
| 589 No new tests, covered by css3/flexbox/flex-parsing.html. |
| 590 |
| 591 * css/CSSParser.cpp: |
| 592 (WebCore::CSSParser::parseFlex): |
| 593 |
| 594 2011-11-01 David Grogan <dgrogan@chromium.org> |
| 595 |
| 596 IndexedDB: get EventQueue from ScriptExecutionContext instead of Documen
t |
| 597 https://bugs.webkit.org/show_bug.cgi?id=71147 |
| 598 |
| 599 When IDB is used from a worker thread ScriptExecutionContext will |
| 600 be a WorkerContext, not a Document. This was the impetus behind |
| 601 moving EventQueue into ScriptExecutionContext in r98656. |
| 602 |
| 603 Reviewed by Nate Chapin. |
| 604 |
| 605 No new tests. No new functionality yet. |
| 606 |
| 607 * storage/IDBDatabase.cpp: |
| 608 (WebCore::IDBDatabase::close): |
| 609 (WebCore::IDBDatabase::enqueueEvent): |
| 610 * storage/IDBRequest.cpp: |
| 611 (WebCore::IDBRequest::abort): |
| 612 (WebCore::IDBRequest::enqueueEvent): |
| 613 * storage/IDBTransaction.cpp: |
| 614 (WebCore::IDBTransaction::enqueueEvent): |
| 615 |
| 616 2011-11-01 Andreas Kling <kling@webkit.org> |
| 617 |
| 618 CSS: Remove unused virtual parseString() in style and keyframe rules. |
| 619 https://bugs.webkit.org/show_bug.cgi?id=71300 |
| 620 |
| 621 Reviewed by Darin Adler. |
| 622 |
| 623 * css/CSSStyleRule.cpp: |
| 624 * css/CSSStyleRule.h: |
| 625 * css/WebKitCSSKeyframeRule.cpp: |
| 626 * css/WebKitCSSKeyframeRule.h: |
| 627 |
| 628 2011-11-01 Emil A Eklund <eae@chromium.org> |
| 629 |
| 630 Switch RenderObject to layout abstraction |
| 631 https://bugs.webkit.org/show_bug.cgi?id=71249 |
| 632 |
| 633 Switch RenderObject to LayoutRect/Size/Point abstraction. |
| 634 |
| 635 Reviewed by Darin Adler. |
| 636 |
| 637 No new tests. |
| 638 |
| 639 * rendering/RenderObject.cpp: |
| 640 (WebCore::RenderObject::drawLineForBoxSide): |
| 641 (WebCore::RenderObject::addPDFURLRect): |
| 642 (WebCore::RenderObject::absoluteBoundingBoxRect): |
| 643 (WebCore::RenderObject::absoluteFocusRingQuads): |
| 644 (WebCore::RenderObject::addAbsoluteRectForLayer): |
| 645 (WebCore::RenderObject::repaintAfterLayoutIfNeeded): |
| 646 (WebCore::RenderObject::computeRectForRepaint): |
| 647 (WebCore::RenderObject::viewRect): |
| 648 (WebCore::RenderObject::mapLocalToContainer): |
| 649 (WebCore::RenderObject::localCaretRect): |
| 650 (WebCore::RenderObject::addDashboardRegions): |
| 651 (WebCore::RenderObject::maximalOutlineSize): |
| 652 (WebCore::RenderObject::adjustRectForOutlineAndShadow): |
| 653 * rendering/RenderObject.h: |
| 654 (WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms): |
| 655 (WebCore::RenderObject::absoluteClippedOverflowRect): |
| 656 (WebCore::RenderObject::computeAbsoluteRepaintRect): |
| 657 (WebCore::RenderObject::absoluteOutlineBounds): |
| 658 (WebCore::RenderObject::outlineBoundsForRepaint): |
| 659 (WebCore::adjustForAbsoluteZoom): |
| 660 |
| 661 2011-11-01 Xiaomei Ji <xji@chromium.org> |
| 662 |
| 663 Refactor: change Scrollable::m_scrollOrigin from protected to private. |
| 664 https://bugs.webkit.org/show_bug.cgi?id=71236 |
| 665 |
| 666 Reviewed by Darin Adler. |
| 667 |
| 668 Only refactor, no new tests needed. |
| 669 |
| 670 * page/FrameView.cpp: |
| 671 (WebCore::FrameView::scrollXForFixedPosition): |
| 672 (WebCore::FrameView::scrollYForFixedPosition): |
| 673 * platform/ScrollView.cpp: |
| 674 (WebCore::ScrollView::maximumScrollPosition): |
| 675 (WebCore::ScrollView::minimumScrollPosition): |
| 676 (WebCore::ScrollView::setScrollOffset): |
| 677 (WebCore::ScrollView::scrollPosition): |
| 678 (WebCore::ScrollView::overhangAmount): |
| 679 (WebCore::ScrollView::updateScrollbars): |
| 680 (WebCore::ScrollView::wheelEvent): |
| 681 * platform/ScrollView.h: |
| 682 * platform/ScrollableArea.h: |
| 683 (WebCore::ScrollableArea::setScrollOrigin): |
| 684 (WebCore::ScrollableArea::setScrollOriginX): |
| 685 (WebCore::ScrollableArea::setScrollOriginY): |
| 686 * rendering/RenderLayer.cpp: |
| 687 (WebCore::RenderLayer::scrollTo): |
| 688 (WebCore::RenderLayer::scrollPosition): |
| 689 (WebCore::RenderLayer::minimumScrollPosition): |
| 690 (WebCore::RenderLayer::maximumScrollPosition): |
| 691 (WebCore::RenderLayer::computeScrollDimensions): |
| 692 * rendering/RenderLayer.h: |
| 693 (WebCore::RenderLayer::scrollXOffset): |
| 694 (WebCore::RenderLayer::scrollYOffset): |
| 695 |
| 696 2011-11-01 Dominic Cooney <dominicc@chromium.org> |
| 697 |
| 698 display: table-cell and box-sizing: border-box calculates content-box he
ight |
| 699 https://bugs.webkit.org/show_bug.cgi?id=69425 |
| 700 |
| 701 Reviewed by Dan Bernstein. |
| 702 |
| 703 Test: fast/box-sizing/table-cell.html |
| 704 |
| 705 * rendering/RenderTableSection.cpp: |
| 706 (WebCore::RenderTableSection::calcRowLogicalHeight): |
| 707 |
| 708 2011-11-01 Alok Priyadarshi <alokp@chromium.org> |
| 709 |
| 710 [chromium] Add testing for --enable-accelerated-drawing |
| 711 https://bugs.webkit.org/show_bug.cgi?id=70822 |
| 712 |
| 713 Reviewed by James Robinson. |
| 714 |
| 715 Test: platform/chromium/compositing/accelerated-drawing/alpha.html |
| 716 |
| 717 * WebCore.exp.in: |
| 718 * page/Settings.cpp: |
| 719 * page/Settings.h: |
| 720 (WebCore::Settings::setAcceleratedDrawingEnabled): |
| 721 * testing/Internals.cpp: |
| 722 (WebCore::Internals::setAcceleratedDrawingEnabled): |
| 723 * testing/Internals.h: |
| 724 * testing/Internals.idl: |
| 725 |
| 726 2011-11-01 Tim Horton <timothy_horton@apple.com> |
| 727 |
| 728 SVG Filter on a group doesn't invalidate when children are moved |
| 729 https://bugs.webkit.org/show_bug.cgi?id=70044 |
| 730 <rdar://problem/10281530> |
| 731 |
| 732 Reviewed by Nikolas Zimmermann. |
| 733 |
| 734 Call SVGResourcesCache::clientLayoutChanged whenever the element or its
children need layout. Previously, |
| 735 invalidation was only performed if the element itself needed layout; now
we also invalidate if any child |
| 736 needs layout and there is a filter applied, as the cached filter result
can depend on the layout of children. |
| 737 |
| 738 Test: svg/filters/invalidate-on-child-layout.svg |
| 739 |
| 740 * rendering/svg/RenderSVGContainer.cpp: |
| 741 (WebCore::RenderSVGContainer::layout): |
| 742 * rendering/svg/SVGResourcesCache.cpp: |
| 743 (WebCore::SVGResourcesCache::clientLayoutChanged): |
| 744 |
| 745 2011-11-01 Jer Noble <jer.noble@apple.com> |
| 746 |
| 747 Four media tests failing on Lion due to incorrect cached times. |
| 748 https://bugs.webkit.org/show_bug.cgi?id=69574 |
| 749 |
| 750 Reviewed by Eric Carlson. |
| 751 |
| 752 Do not invalidate the cached time when receiving a mediaPlayerRateChange
d notification |
| 753 while paused. AVFoundation in particular can return different results fo
r currentTime() |
| 754 when asked after being paused, breaking layout tests. |
| 755 |
| 756 * html/HTMLMediaElement.cpp: |
| 757 (WebCore::HTMLMediaElement::mediaPlayerRateChanged): |
| 758 |
| 759 2011-11-01 Gavin Peters <gavinp@chromium.org> |
| 760 |
| 761 properly end requests when a bad status code return happens |
| 762 https://bugs.webkit.org/show_bug.cgi?id=71122 |
| 763 |
| 764 Calling error without ending the request set up the CachedResourceReques
t so that it could |
| 765 actually send out two notifyFinished() events. This probably was the ro
ot cause of |
| 766 lots of crashing instability; I know from crbug.com/75604 that this bug
was causing lots |
| 767 of crashes in ScriptRunner/ScriptElement for instance. |
| 768 |
| 769 The fix is easy: just properly end the request instead of just calling e
rror, and we won't |
| 770 re-notify. |
| 771 |
| 772 Reviewed by Nate Chapin. |
| 773 |
| 774 No new tests, as the problem wasn't very amenable to layout tests. |
| 775 There is a chromium test going through code review at http://codereview.
chromium.org/8404001/ |
| 776 |
| 777 * loader/cache/CachedResourceRequest.cpp: |
| 778 (WebCore::CachedResourceRequest::didReceiveData): |
| 779 |
| 780 2011-11-01 Erik Arvidsson <arv@chromium.org> |
| 781 |
| 782 Remove LegacyDefaultOptionalArguments flag from CanvasRenderingContext2d |
| 783 https://bugs.webkit.org/show_bug.cgi?id=64628 |
| 784 |
| 785 Reviewed by Adam Barth. |
| 786 |
| 787 Covered by existing tests. |
| 788 |
| 789 * html/canvas/CanvasRenderingContext2D.idl: |
| 790 |
| 791 2011-11-01 Julien Chaffraix <jchaffraix@webkit.org> |
| 792 |
| 793 REGRESSION(98738): RenderTableSection::recalcCells does not properly shr
ink the RowStruct grid |
| 794 https://bugs.webkit.org/show_bug.cgi?id=71246 |
| 795 |
| 796 Reviewed by Darin Adler. |
| 797 |
| 798 Tests: fast/table/crash-empty-section-calcBorder.html |
| 799 fast/table/crash-empty-section-fixed-layout-calcArray.html |
| 800 |
| 801 The refactoring in r98738 changed the way we handle the size to avoid th
rowing off |
| 802 the memory. The new logic would end up never shrinking the grid's size (
prior to that |
| 803 we would grow to the appropriate size and throw the excess capacity with
shrinkToFit). |
| 804 Not shrinking would mean that we would potentially read RowStruct with t
he default values |
| 805 (for instance no |rowRenderer|). |
| 806 |
| 807 addCell will properly grow the grid as needed to accomodate the rows and
the protruding |
| 808 cells with a rowspan so we introduce a variable to keep track of the siz
e needed. At the |
| 809 end, we just shrink it to this size. |
| 810 |
| 811 * rendering/RenderTableSection.cpp: |
| 812 (WebCore::RenderTableSection::recalcCells): |
| 813 Introduce a variable to keep the grid size and shrink to that size to ma
tch the old code. |
| 814 |
| 815 2011-11-01 Andrey Kosyakov <caseq@chromium.org> |
| 816 |
| 817 [Chromium] Some media/video-*.html layout tests occasionally crash on WI
N GPU |
| 818 https://bugs.webkit.org/show_bug.cgi?id=71277 |
| 819 |
| 820 Reviewed by Simon Fraser. |
| 821 |
| 822 Disabled assert() in hasVisibleDescendant() until callers are fixed. |
| 823 |
| 824 * rendering/RenderLayer.h: |
| 825 (WebCore::RenderLayer::hasVisibleDescendant): |
| 826 |
| 827 2011-11-01 Mike Reed <reed@google.com> |
| 828 |
| 829 [skia] call readPixels on canvas instead of device (will be private on d
evice soon) and check for error |
| 830 https://bugs.webkit.org/show_bug.cgi?id=71284 |
| 831 |
| 832 Reviewed by Stephen White. |
| 833 |
| 834 No new tests. This is preparing for an API change to Skia. |
| 835 |
| 836 * platform/graphics/skia/ImageBufferSkia.cpp: |
| 837 (WebCore::getImageData): |
| 838 (WebCore::ImageBuffer::getUnmultipliedImageData): |
| 839 (WebCore::ImageBuffer::getPremultipliedImageData): |
| 840 |
| 841 2011-11-01 Andreas Kling <kling@webkit.org> |
| 842 |
| 843 CSSStyleSheet: Operate directly on the rule vector internally. |
| 844 |
| 845 Rubber-stamped by Antti Koivisto. |
| 846 |
| 847 There's no need to go through the public, range-checking item() method |
| 848 working on m_children. Also changed length() -> m_children.size(). |
| 849 |
| 850 * css/CSSStyleSheet.cpp: |
| 851 (WebCore::CSSStyleSheet::~CSSStyleSheet): |
| 852 (WebCore::CSSStyleSheet::insertRule): |
| 853 (WebCore::CSSStyleSheet::addRule): |
| 854 (WebCore::CSSStyleSheet::deleteRule): |
| 855 (WebCore::CSSStyleSheet::isLoading): |
| 856 (WebCore::CSSStyleSheet::addSubresourceStyleURLs): |
| 857 |
| 858 2011-11-01 Andreas Kling <kling@webkit.org> |
| 859 |
| 860 CSSRule: Devirtualize addSubresourceStyleURLs() |
| 861 https://bugs.webkit.org/show_bug.cgi?id=71285 |
| 862 |
| 863 Reviewed by Antti Koivisto. |
| 864 |
| 865 Move addSubresourceStyleURLs() into the rules that actually implement it
. |
| 866 Add type checks and casts at the (only) call site. |
| 867 |
| 868 * css/CSSFontFaceRule.h: |
| 869 * css/CSSImportRule.h: |
| 870 * css/CSSRule.h: |
| 871 * css/CSSStyleRule.h: |
| 872 * css/CSSStyleSheet.cpp: |
| 873 (WebCore::CSSStyleSheet::addSubresourceStyleURLs): |
| 874 |
| 875 2011-11-01 Chris Fleizach <cfleizach@apple.com> |
| 876 |
| 877 AX: some popup buttons not announced by VoiceOver |
| 878 https://bugs.webkit.org/show_bug.cgi?id=67743 |
| 879 |
| 880 Reviewed by Darin Adler. |
| 881 |
| 882 Test: platform/mac/accessibility/aria-popup-buttons-on-native-elements.h
tml |
| 883 |
| 884 * accessibility/AccessibilityRenderObject.cpp: |
| 885 (WebCore::AccessibilityRenderObject::stringValue): |
| 886 (WebCore::AccessibilityRenderObject::title): |
| 887 (WebCore::AccessibilityRenderObject::determineAccessibilityRole): |
| 888 |
| 889 2011-11-01 Alexander Pavlov <apavlov@chromium.org> |
| 890 |
| 891 Web Inspector: [Styles] Style-based CSS properties are editable and togg
leable |
| 892 https://bugs.webkit.org/show_bug.cgi?id=71275 |
| 893 |
| 894 Reviewed by Pavel Feldman. |
| 895 |
| 896 * inspector/front-end/StylesSidebarPane.js: |
| 897 (WebInspector.StylePropertiesSection.prototype.onpopulate): |
| 898 |
| 899 2011-11-01 Pavel Feldman <pfeldman@google.com> |
| 900 |
| 901 Web Inspector: do not switch panels on Cmd + -> while in console. |
| 902 https://bugs.webkit.org/show_bug.cgi?id=71281 |
| 903 |
| 904 Reviewed by Yury Semikhatsky. |
| 905 |
| 906 * inspector/front-end/InspectorView.js: |
| 907 (WebInspector.InspectorView.prototype._keyDown): |
| 908 |
| 909 2011-11-01 Zeno Albisser <zeno.albisser@nokia.com> |
| 910 |
| 911 [Qt] bad codegen, pointer diff in JSC::JSCallbackConstructor::JSCallback
Constructor |
| 912 https://bugs.webkit.org/show_bug.cgi?id=60951 |
| 913 |
| 914 Adjust symbols visibility for WebCore. |
| 915 |
| 916 Reviewed by Simon Hausmann. |
| 917 |
| 918 * WebCore.pro: |
| 919 |
| 920 2011-11-01 Pavel Feldman <pfeldman@google.com> |
| 921 |
| 922 Not reviewed: add InspectorView.js entry into WebKit.qrc |
| 923 |
| 924 * inspector/front-end/WebKit.qrc: |
| 925 |
| 926 2011-11-01 Pavel Feldman <pfeldman@google.com> |
| 927 |
| 928 |
| 929 Web Inspector: introduce PanelContainer class, start moving panel manage
ment from inspector.js to the new class. |
| 930 https://bugs.webkit.org/show_bug.cgi?id=71272 |
| 931 |
| 932 Reviewed by Yury Semikhatsky. |
| 933 |
| 934 * WebCore.gypi: |
| 935 * WebCore.vcproj/WebCore.vcproj: |
| 936 * inspector/compile-front-end.sh: |
| 937 * inspector/front-end/Drawer.js: |
| 938 (WebInspector.Drawer.prototype.show.animationFinished): |
| 939 (WebInspector.Drawer.prototype.show): |
| 940 (WebInspector.Drawer.prototype.hide): |
| 941 (WebInspector.Drawer.prototype._statusBarDragging): |
| 942 * inspector/front-end/ElementsPanel.js: |
| 943 (WebInspector.ElementsPanel.prototype.switchToAndFocus): |
| 944 (WebInspector.ElementsPanel.prototype.revealAndSelectNode): |
| 945 * inspector/front-end/ElementsTreeOutline.js: |
| 946 (WebInspector.ElementsTreeOutline.prototype.setVisible): |
| 947 * inspector/front-end/InspectorView.js: Added. |
| 948 (WebInspector.InspectorView): |
| 949 (WebInspector.InspectorView.prototype.addPanel): |
| 950 (WebInspector.InspectorView.prototype.currentPanel): |
| 951 (WebInspector.InspectorView.prototype._keyDown): |
| 952 (WebInspector.InspectorView.prototype._canGoBackInHistory): |
| 953 (WebInspector.InspectorView.prototype._goBackInHistory): |
| 954 (WebInspector.InspectorView.prototype._canGoForwardInHistory): |
| 955 (WebInspector.InspectorView.prototype._goForwardInHistory): |
| 956 (WebInspector.InspectorView.prototype._pushToHistory): |
| 957 * inspector/front-end/KeyboardShortcut.js: |
| 958 (WebInspector.KeyboardShortcut.eventHasCtrlOrMeta): |
| 959 * inspector/front-end/Panel.js: |
| 960 (WebInspector.Panel.prototype.show): |
| 961 * inspector/front-end/ScriptsPanel.js: |
| 962 (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked): |
| 963 * inspector/front-end/SearchController.js: |
| 964 (WebInspector.SearchController.prototype.updateSearchMatchesCount): |
| 965 (WebInspector.SearchController.prototype.updateCurrentMatchIndex): |
| 966 (WebInspector.SearchController.prototype.updateSearchLabel): |
| 967 (WebInspector.SearchController.prototype.handleShortcut): |
| 968 (WebInspector.SearchController.prototype._performSearch): |
| 969 * inspector/front-end/Toolbar.js: |
| 970 (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked): |
| 971 (WebInspector.Toolbar.createPanelToolbarItem): |
| 972 * inspector/front-end/WebKit.qrc: |
| 973 * inspector/front-end/externs.js: |
| 974 * inspector/front-end/inspector.html: |
| 975 * inspector/front-end/inspector.js: |
| 976 (WebInspector._createPanels): |
| 977 (WebInspector._panelSelected): |
| 978 (WebInspector.addPanel): |
| 979 (WebInspector.windowResize): |
| 980 (WebInspector.documentKeyDown): |
| 981 (WebInspector.documentCanCopy): |
| 982 (WebInspector.documentCopy): |
| 983 (WebInspector.showPanel): |
| 984 (WebInspector.startUserInitiatedDebugging): |
| 985 (WebInspector.inspect): |
| 986 (WebInspector._showAnchorLocationInPanel): |
| 987 (WebInspector._toolbarItemClicked): |
| 988 * inspector/front-end/treeoutline.js: |
| 989 (TreeElement.prototype.select): |
| 990 |
| 991 2011-11-01 Simon Hausmann <simon.hausmann@nokia.com> |
| 992 |
| 993 [WK2] Add WebGestureEvents to the Qt build and enable PlatformGestureEve
nt::TapType |
| 994 https://bugs.webkit.org/show_bug.cgi?id=71274 |
| 995 |
| 996 Reviewed by Kenneth Christiansen. |
| 997 |
| 998 * features.pri: Enable GESTURE_EVENTS. |
| 999 |
| 1000 2011-11-01 Sheriff Bot <webkit.review.bot@gmail.com> |
| 1001 |
| 1002 Unreviewed, rolling out r98847. |
| 1003 http://trac.webkit.org/changeset/98847 |
| 1004 https://bugs.webkit.org/show_bug.cgi?id=71268 |
| 1005 |
| 1006 "Debugger test failures on multiple platforms" (Requested by |
| 1007 yurys on #webkit). |
| 1008 |
| 1009 * inspector/front-end/DebuggerPresentationModel.js: |
| 1010 (WebInspector.DebuggerPresentationModel): |
| 1011 (WebInspector.DebuggerPresentationModel.prototype._addScript): |
| 1012 (WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes): |
| 1013 (WebInspector.DebuggerPresentationModel.prototype.setFormatSource): |
| 1014 (WebInspector.DebuggerPresentationModel.prototype._consoleCleared): |
| 1015 (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScrip
tWithURL): |
| 1016 (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScrip
t): |
| 1017 (WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCod
e): |
| 1018 (WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId
): |
| 1019 (WebInspector.DebuggerPresentationModel.prototype._debuggerReset): |
| 1020 (WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset): |
| 1021 * inspector/front-end/RawSourceCode.js: |
| 1022 (WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestCon
tent.didFormatContent): |
| 1023 (WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestCon
tent): |
| 1024 (WebInspector.RawSourceCode.prototype._createSourceMapping): |
| 1025 * inspector/front-end/Script.js: |
| 1026 (WebInspector.Script.prototype.editSource): |
| 1027 |
| 1028 2011-10-30 Filip Pizlo <fpizlo@apple.com> |
| 1029 |
| 1030 The GC should be parallel |
| 1031 https://bugs.webkit.org/show_bug.cgi?id=70995 |
| 1032 |
| 1033 Reviewed by Geoff Garen. |
| 1034 |
| 1035 Added parallel tracing to the GC. This required loosening some assertion
s, |
| 1036 since some code may now be called from outside the main thread. |
| 1037 |
| 1038 No new tests, since no behavior was changed. |
| 1039 |
| 1040 * platform/TreeShared.h: |
| 1041 (WebCore::TreeShared::parent): |
| 1042 |
| 1043 2011-10-31 Andy Estes <aestes@apple.com> |
| 1044 |
| 1045 Document pointer not null-checked in FrameView::isOnActivePage() |
| 1046 https://bugs.webkit.org/show_bug.cgi?id=71265 |
| 1047 <rdar://problem/10374427> |
| 1048 |
| 1049 Reviewed by Dan Bernstein. |
| 1050 |
| 1051 Return false in FrameView::isOnActivePage() if m_frame->document() is |
| 1052 null. Other calls to m_frame->document() in FrameView also have a null |
| 1053 check. The frame can have a null document if the FrameLoader is loading |
| 1054 the initial empty document. |
| 1055 |
| 1056 No test possible without triggering assertions in debug builds. This is |
| 1057 tracked by <http://webkit.org/b/71264>. |
| 1058 |
| 1059 * page/FrameView.cpp: |
| 1060 (WebCore::FrameView::isOnActivePage): |
| 1061 |
| 1062 2011-10-31 Jeremy Apthorp <jeremya@google.com> |
| 1063 |
| 1064 Fix a crash relating to anonymous block merging in |
| 1065 RenderFullScreen::unwrapRenderer. |
| 1066 https://bugs.webkit.org/show_bug.cgi?id=70705 |
| 1067 |
| 1068 Reviewed by Simon Fraser. |
| 1069 |
| 1070 Test: fullscreen/anonymous-block-merge-crash.html |
| 1071 |
| 1072 * rendering/RenderFullScreen.cpp: |
| 1073 (RenderFullScreen::unwrapRenderer): |
| 1074 |
| 1075 2011-10-31 Dave Michael <dmichael@chromium.org> |
| 1076 |
| 1077 V8MessageEvent::dataAccessorGetter does not return a reference to its ca
ller |
| 1078 https://bugs.webkit.org/show_bug.cgi?id=71229 |
| 1079 |
| 1080 Reviewed by Adam Barth. |
| 1081 |
| 1082 Test: fast/events/dispatch-message-string-data.html |
| 1083 |
| 1084 * bindings/v8/custom/V8MessageEventCustom.cpp: |
| 1085 (WebCore::V8MessageEvent::dataAccessorGetter): |
| 1086 |
| 1087 2011-10-31 Renata Hodovan <reni@webkit.org> |
| 1088 |
| 1089 [Qt] Build fix after r98853. |
| 1090 |
| 1091 Rubber-stamped by Andreas Kling. |
| 1092 |
| 1093 * xml/XSLImportRule.cpp: |
| 1094 * xml/XSLImportRule.h: |
| 1095 (WebCore::XSLImportRule::parentStyleSheet): |
| 1096 |
| 1097 2011-10-31 Mark Hahnenberg <mhahnenberg@apple.com> |
| 1098 |
| 1099 De-virtualize JSObject::defaultValue |
| 1100 https://bugs.webkit.org/show_bug.cgi?id=71146 |
| 1101 |
| 1102 Reviewed by Sam Weinig. |
| 1103 |
| 1104 No new tests. |
| 1105 |
| 1106 Added defaultValue to the MethodTable. Replaced all virtual versions of
|
| 1107 defaultValue with static versions. Replaced all call sites with lookups
in the |
| 1108 MethodTable. |
| 1109 |
| 1110 * WebCore.exp.in: |
| 1111 * bridge/objc/objc_runtime.h: |
| 1112 * bridge/objc/objc_runtime.mm: |
| 1113 (JSC::Bindings::ObjcFallbackObjectImp::defaultValue): |
| 1114 * bridge/runtime_object.cpp: |
| 1115 (JSC::Bindings::RuntimeObject::defaultValue): |
| 1116 * bridge/runtime_object.h: |
| 1117 |
| 1118 2011-10-31 Levi Weintraub <leviw@chromium.org> |
| 1119 |
| 1120 Switch RoundedRect back to integers |
| 1121 https://bugs.webkit.org/show_bug.cgi?id=71238 |
| 1122 |
| 1123 Reviewed by Darin Adler. |
| 1124 |
| 1125 Changing RoundedRect back to ints from LayoutUnits. As further testing h
as shown, this graphics- |
| 1126 focused class should maintain values aligned to pixel boundaries, and th
erefor kept as integers. |
| 1127 |
| 1128 No new tests -- no change in behavior. |
| 1129 |
| 1130 * platform/graphics/RoundedRect.cpp: |
| 1131 (WebCore::RoundedRect::Radii::scale): |
| 1132 (WebCore::RoundedRect::Radii::expand): |
| 1133 (WebCore::RoundedRect::inflateWithRadii): |
| 1134 (WebCore::RoundedRect::Radii::excludeLogicalEdges): |
| 1135 (WebCore::RoundedRect::RoundedRect): |
| 1136 * platform/graphics/RoundedRect.h: |
| 1137 (WebCore::RoundedRect::Radii::Radii): |
| 1138 (WebCore::RoundedRect::Radii::setTopLeft): |
| 1139 (WebCore::RoundedRect::Radii::setTopRight): |
| 1140 (WebCore::RoundedRect::Radii::setBottomLeft): |
| 1141 (WebCore::RoundedRect::Radii::setBottomRight): |
| 1142 (WebCore::RoundedRect::Radii::topLeft): |
| 1143 (WebCore::RoundedRect::Radii::topRight): |
| 1144 (WebCore::RoundedRect::Radii::bottomLeft): |
| 1145 (WebCore::RoundedRect::Radii::bottomRight): |
| 1146 (WebCore::RoundedRect::Radii::expand): |
| 1147 (WebCore::RoundedRect::Radii::shrink): |
| 1148 (WebCore::RoundedRect::rect): |
| 1149 (WebCore::RoundedRect::setRect): |
| 1150 (WebCore::RoundedRect::move): |
| 1151 (WebCore::RoundedRect::inflate): |
| 1152 (WebCore::RoundedRect::expandRadii): |
| 1153 (WebCore::RoundedRect::shrinkRadii): |
| 1154 * rendering/svg/SVGRenderSupport.h: Adding missing LayoutTypes.h include |
| 1155 |
| 1156 2011-10-31 Peter Kasting <pkasting@google.com> |
| 1157 |
| 1158 https://bugs.webkit.org/show_bug.cgi?id=70666 |
| 1159 BitmapImage::dataChanged() needs to clear all incomplete frames. |
| 1160 |
| 1161 Reviewed by James Robinson. |
| 1162 |
| 1163 No tests, as I don't know of a way to send an image to the renderer in |
| 1164 small pieces (with script run between pieces no less). |
| 1165 |
| 1166 * platform/graphics/BitmapImage.cpp: |
| 1167 (WebCore::BitmapImage::dataChanged): |
| 1168 |
| 1169 2011-10-31 Levi Weintraub <leviw@chromium.org> |
| 1170 |
| 1171 Amend missing uses of LayoutUnits in RenderApplet, Button, and Deprecate
dFlexibleBox |
| 1172 https://bugs.webkit.org/show_bug.cgi?id=71243 |
| 1173 |
| 1174 Reviewed by Eric Seidel. |
| 1175 |
| 1176 Replacing remaining integer uses with LayoutUnits in the aforementioned
classes. |
| 1177 |
| 1178 No new tests -- no change in behavior. |
| 1179 |
| 1180 * rendering/RenderApplet.cpp: |
| 1181 (WebCore::RenderApplet::intrinsicSize): |
| 1182 (WebCore::RenderApplet::createWidgetIfNecessary): |
| 1183 * rendering/RenderApplet.h: |
| 1184 * rendering/RenderButton.cpp: |
| 1185 (WebCore::RenderButton::controlClipRect): |
| 1186 * rendering/RenderButton.h: |
| 1187 * rendering/RenderDeprecatedFlexibleBox.cpp: |
| 1188 (WebCore::marginWidthForChild): |
| 1189 (WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths): |
| 1190 (WebCore::RenderDeprecatedFlexibleBox::layoutBlock): |
| 1191 (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): |
| 1192 (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp): |
| 1193 * rendering/RenderDeprecatedFlexibleBox.h: |
| 1194 |
| 1195 2011-10-31 Tommy Widenflycht <tommyw@google.com> |
| 1196 |
| 1197 [Chromium] Media Stream API: add the Chromium WebKit interfaces |
| 1198 https://bugs.webkit.org/show_bug.cgi?id=58550 |
| 1199 |
| 1200 Changes the PeerHandler platform interface so that embedders can more ea
sily use it. |
| 1201 |
| 1202 Reviewed by Darin Fisher. |
| 1203 |
| 1204 * GNUmakefile.am: |
| 1205 * GNUmakefile.list.am: |
| 1206 * WebCore.gyp/WebCore.gyp: |
| 1207 * WebCore.gypi: |
| 1208 * mediastream/PeerConnection.cpp: |
| 1209 (WebCore::PeerConnection::PeerConnection): |
| 1210 (WebCore::PeerConnection::didCompleteICEProcessing): |
| 1211 (WebCore::PeerConnection::didGenerateSDP): |
| 1212 (WebCore::PeerConnection::didReceiveDataStreamMessage): |
| 1213 (WebCore::PeerConnection::didAddRemoteStream): |
| 1214 (WebCore::PeerConnection::didRemoveRemoteStream): |
| 1215 * mediastream/PeerConnection.h: |
| 1216 * platform/mediastream/PeerConnectionHandlerClient.h: Copied from Source
/WebCore/platform/mediastream/PeerHandler.cpp. |
| 1217 (WebCore::PeerConnectionHandlerClient::~PeerConnectionHandlerClient): |
| 1218 * platform/mediastream/chromium/PeerConnectionHandler.h: Copied from Sou
rce/WebCore/platform/mediastream/PeerHandler.h. |
| 1219 * platform/mediastream/gstreamer/PeerConnectionHandler.cpp: Copied from
Source/WebCore/platform/mediastream/PeerHandler.cpp. |
| 1220 (WebCore::PeerConnectionHandler::create): |
| 1221 (WebCore::PeerConnectionHandler::PeerConnectionHandler): |
| 1222 (WebCore::PeerConnectionHandler::~PeerConnectionHandler): |
| 1223 (WebCore::PeerConnectionHandler::produceInitialOffer): |
| 1224 (WebCore::PeerConnectionHandler::handleInitialOffer): |
| 1225 (WebCore::PeerConnectionHandler::processSDP): |
| 1226 (WebCore::PeerConnectionHandler::processPendingStreams): |
| 1227 (WebCore::PeerConnectionHandler::sendDataStreamMessage): |
| 1228 (WebCore::PeerConnectionHandler::stop): |
| 1229 * platform/mediastream/gstreamer/PeerConnectionHandler.h: Renamed from S
ource/WebCore/platform/mediastream/PeerHandler.h. |
| 1230 |
| 1231 Tests for the Media Stream API will be provided by the bug 56587, pendin
g enough landed code. |
| 1232 |
| 1233 2011-10-31 Adam Roben <aroben@apple.com> |
| 1234 |
| 1235 Fix linker warnings on Windows |
| 1236 |
| 1237 * WebCore.vcproj/WebCore.vcproj: Exclude SpellingCorrectionCommand.cpp a
nd |
| 1238 JSRequestAnimationFrameCallback.cpp from all configurations. They are al
ready getting |
| 1239 compiled via *AllInOne.cpp files. |
| 1240 |
| 1241 2011-10-31 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> |
| 1242 |
| 1243 [GStreamer] Don't use GOwnPtr for ref-counted objects |
| 1244 https://bugs.webkit.org/show_bug.cgi?id=71042 |
| 1245 |
| 1246 Reviewed by Martin Robinson. |
| 1247 |
| 1248 * CMakeListsEfl.txt: |
| 1249 * GNUmakefile.list.am: |
| 1250 * WebCore.gypi: |
| 1251 * WebCore.pro: |
| 1252 * platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Removed. |
| 1253 * platform/graphics/gstreamer/GOwnPtrGStreamer.h: Removed. |
| 1254 * platform/graphics/gstreamer/GStreamerGWorld.cpp: |
| 1255 (WebCore::GStreamerGWorld::enterFullscreen): |
| 1256 (WebCore::GStreamerGWorld::exitFullscreen): |
| 1257 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: |
| 1258 (WebCore::MediaPlayerPrivateGStreamer::updateAudioSink): |
| 1259 (WebCore::MediaPlayerPrivateGStreamer::sourceChanged): |
| 1260 |
| 1261 2011-10-28 Nat Duca <nduca@chromium.org> |
| 1262 |
| 1263 [chromium] Connect CCThreadProxy to FrameRateController and SchedulerSta
teMachine via CCScheduler |
| 1264 https://bugs.webkit.org/show_bug.cgi?id=71100 |
| 1265 |
| 1266 Reviewed by James Robinson. |
| 1267 |
| 1268 * platform/graphics/chromium/cc/CCDelayBasedTimeSource.h: |
| 1269 (WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime): |
| 1270 * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
| 1271 (WebCore::CCLayerTreeHostClient::didCommitAndDrawFrame): |
| 1272 (WebCore::CCLayerTreeHost::didCommitAndDrawFrame): |
| 1273 * platform/graphics/chromium/cc/CCScheduler.cpp: |
| 1274 (WebCore::CCSchedulerFrameRateControllerClientAdapter::create): |
| 1275 (WebCore::CCSchedulerFrameRateControllerClientAdapter::~CCSchedulerFrame
RateControllerClientAdapter): |
| 1276 (WebCore::CCSchedulerFrameRateControllerClientAdapter::beginFrame): |
| 1277 (WebCore::CCSchedulerFrameRateControllerClientAdapter::CCSchedulerFrameR
ateControllerClientAdapter): |
| 1278 (WebCore::CCScheduler::CCScheduler): |
| 1279 (WebCore::CCScheduler::~CCScheduler): |
| 1280 (WebCore::CCScheduler::setNeedsAnimate): |
| 1281 (WebCore::CCScheduler::setNeedsCommit): |
| 1282 (WebCore::CCScheduler::setNeedsRedraw): |
| 1283 (WebCore::CCScheduler::beginFrameComplete): |
| 1284 (WebCore::CCScheduler::didSwapBuffersComplete): |
| 1285 (WebCore::CCScheduler::didSwapBuffersAbort): |
| 1286 (WebCore::CCScheduler::onBeginFrame): |
| 1287 (WebCore::CCScheduler::processScheduledActions): |
| 1288 * platform/graphics/chromium/cc/CCScheduler.h: |
| 1289 (WebCore::CCScheduler::create): |
| 1290 (WebCore::CCScheduler::commitPending): |
| 1291 (WebCore::CCScheduler::redrawPending): |
| 1292 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: |
| 1293 (WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine): |
| 1294 (WebCore::CCSchedulerStateMachine::nextAction): |
| 1295 (WebCore::CCSchedulerStateMachine::updateState): |
| 1296 (WebCore::CCSchedulerStateMachine::beginUpdateMoreResourcesComplete): |
| 1297 * platform/graphics/chromium/cc/CCSchedulerStateMachine.h: |
| 1298 (WebCore::CCSchedulerStateMachine::redrawPending): |
| 1299 * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: |
| 1300 (WebCore::CCSingleThreadProxy::CCSingleThreadProxy): |
| 1301 (WebCore::CCSingleThreadProxy::doCommit): |
| 1302 (WebCore::CCSingleThreadProxy::doComposite): |
| 1303 * platform/graphics/chromium/cc/CCSingleThreadProxy.h: |
| 1304 * platform/graphics/chromium/cc/CCTextureUpdater.cpp: |
| 1305 (WebCore::CCTextureUpdater::hasMoreUpdates): |
| 1306 * platform/graphics/chromium/cc/CCTextureUpdater.h: |
| 1307 * platform/graphics/chromium/cc/CCThreadProxy.cpp: |
| 1308 (WebCore::CCThreadProxy::CCThreadProxy): |
| 1309 (WebCore::CCThreadProxy::compositeAndReadback): |
| 1310 (WebCore::CCThreadProxy::requestReadbackOnImplThread): |
| 1311 (WebCore::CCThreadProxy::setNeedsAnimateOnImplThread): |
| 1312 (WebCore::CCThreadProxy::setNeedsCommitOnImplThread): |
| 1313 (WebCore::CCThreadProxy::setNeedsRedrawOnImplThread): |
| 1314 (WebCore::CCThreadProxy::finishAllRenderingOnImplThread): |
| 1315 (WebCore::CCThreadProxy::scheduledActionBeginFrame): |
| 1316 (WebCore::CCThreadProxy::beginFrameAndCommit): |
| 1317 (WebCore::CCThreadProxy::beginFrameCompleteOnImplThread): |
| 1318 (WebCore::CCThreadProxy::hasMoreResourceUpdates): |
| 1319 (WebCore::CCThreadProxy::scheduledActionUpdateMoreResources): |
| 1320 (WebCore::CCThreadProxy::scheduledActionCommit): |
| 1321 (WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread): |
| 1322 (WebCore::CCThreadProxy::didCommitAndDrawFrame): |
| 1323 (WebCore::CCThreadProxy::initializeImplOnImplThread): |
| 1324 (WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread): |
| 1325 (WebCore::CCThreadProxy::scheduledActionDrawAndSwap): |
| 1326 * platform/graphics/chromium/cc/CCThreadProxy.h: |
| 1327 |
| 1328 2011-10-31 Nate Chapin <japhet@chromium.org> |
| 1329 |
| 1330 Rename the remaining uses of Cue in WebCore/loader/ |
| 1331 to TextTrack. |
| 1332 https://bugs.webkit.org/show_bug.cgi?id=71231 |
| 1333 |
| 1334 Reviewed by Eric Carlson. |
| 1335 |
| 1336 No new tests, strictly a renaming. |
| 1337 |
| 1338 * loader/TextTrackLoader.cpp: |
| 1339 * loader/cache/CachedResource.cpp: |
| 1340 * loader/cache/CachedResource.h: |
| 1341 * loader/cache/CachedResourceLoader.cpp: |
| 1342 * loader/cache/CachedResourceLoader.h: |
| 1343 * loader/cache/CachedResourceRequest.cpp: |
| 1344 * loader/cache/CachedTextTrack.cpp: |
| 1345 * platform/network/chromium/ResourceRequest.h: |
| 1346 |
| 1347 2011-10-27 Adam Klein <adamk@chromium.org> |
| 1348 |
| 1349 [MutationObservers] Support characterDataOldValue for characterData muta
tions |
| 1350 https://bugs.webkit.org/show_bug.cgi?id=70862 |
| 1351 |
| 1352 Reviewed by Ojan Vafai. |
| 1353 |
| 1354 * dom/CharacterData.cpp: |
| 1355 (WebCore::hasOldValue): |
| 1356 (WebCore::isOldValueRequested): |
| 1357 (WebCore::CharacterData::dispatchModifiedEvent): |
| 1358 * dom/MutationRecord.cpp: |
| 1359 (WebCore::MutationRecord::createCharacterData): |
| 1360 * dom/MutationRecord.h: |
| 1361 |
| 1362 2011-10-31 Sam Weinig <sam@webkit.org> |
| 1363 |
| 1364 Remove need for virtual JSObject::unwrappedObject |
| 1365 https://bugs.webkit.org/show_bug.cgi?id=71034 |
| 1366 |
| 1367 Reviewed by Geoffrey Garen. |
| 1368 |
| 1369 Move the member containing the global object from the JSDOMWindowShell |
| 1370 down to the JSGlobalThis class, and update JSDOMWindowShell to go throug
h |
| 1371 an inline helper (which just casts) to get the window. |
| 1372 |
| 1373 * bindings/js/JSDOMWindowShell.cpp: |
| 1374 (WebCore::JSDOMWindowShell::setWindow): |
| 1375 (WebCore::JSDOMWindowShell::className): |
| 1376 (WebCore::JSDOMWindowShell::getOwnPropertySlot): |
| 1377 (WebCore::JSDOMWindowShell::getOwnPropertyDescriptor): |
| 1378 (WebCore::JSDOMWindowShell::put): |
| 1379 (WebCore::JSDOMWindowShell::putWithAttributes): |
| 1380 (WebCore::JSDOMWindowShell::defineOwnProperty): |
| 1381 (WebCore::JSDOMWindowShell::deleteProperty): |
| 1382 (WebCore::JSDOMWindowShell::getPropertyNames): |
| 1383 (WebCore::JSDOMWindowShell::getOwnPropertyNames): |
| 1384 (WebCore::JSDOMWindowShell::defineGetter): |
| 1385 (WebCore::JSDOMWindowShell::defineSetter): |
| 1386 (WebCore::JSDOMWindowShell::lookupGetter): |
| 1387 (WebCore::JSDOMWindowShell::lookupSetter): |
| 1388 (WebCore::JSDOMWindowShell::impl): |
| 1389 * bindings/js/JSDOMWindowShell.h: |
| 1390 (WebCore::JSDOMWindowShell::window): |
| 1391 (WebCore::JSDOMWindowShell::setWindow): |
| 1392 (WebCore::JSDOMWindowShell::createStructure): |
| 1393 |
| 1394 2011-10-29 Ryosuke Niwa <rniwa@webkit.org> |
| 1395 |
| 1396 WebKit nests pre on copy and paste when the pre is the root editable ele
ment |
| 1397 https://bugs.webkit.org/show_bug.cgi?id=70800 |
| 1398 |
| 1399 Reviewed by Darin Adler. |
| 1400 |
| 1401 Fixed the bug by removing nested block elements in removeRedundantStyles
AndKeepStyleSpanInline. |
| 1402 |
| 1403 Tests: editing/pasteboard/contenteditable-pre-2.html |
| 1404 editing/pasteboard/contenteditable-pre.html |
| 1405 |
| 1406 * editing/ApplyStyleCommand.cpp: |
| 1407 * editing/ReplaceSelectionCommand.cpp: |
| 1408 (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpan
Inline): Remove block |
| 1409 elements if it's identical to its parent and there are no contents betwe
en the two. Also remove |
| 1410 contenteditable attribute from an element if the parent is already richl
y editable. |
| 1411 (WebCore::ReplaceSelectionCommand::doApply): Remove redundant styles aft
er removing the placeholder |
| 1412 br so that the above check doesn't get affected by the placeholder. |
| 1413 * editing/htmlediting.cpp: |
| 1414 (WebCore::areIdenticalElements): Moved from ApplyStyleCommand. |
| 1415 (WebCore::isNonTableCellHTMLBlockElement): Moved from markup.cpp. |
| 1416 * editing/htmlediting.h: |
| 1417 * editing/markup.cpp: |
| 1418 |
| 1419 2011-10-31 Vineet Chaudhary <vineet.chaudhary@motorola.com> |
| 1420 |
| 1421 text/plain form encoding ignored and incorrectly specified in request he
ader. |
| 1422 https://bugs.webkit.org/show_bug.cgi?id=20795 |
| 1423 |
| 1424 Reviewed by Darin Adler. |
| 1425 |
| 1426 This patch fixes the behaviour of forms where enctype is set to |
| 1427 text/plain, encoding is also text/plain. |
| 1428 |
| 1429 Tests: fast/forms/form-get-textplain.html |
| 1430 http/tests/misc/form-post-textplain.html |
| 1431 |
| 1432 * loader/FormSubmission.cpp: |
| 1433 (WebCore::FormSubmission::create): |
| 1434 * platform/network/FormData.cpp: |
| 1435 (WebCore::FormData::create): |
| 1436 (WebCore::FormData::appendKeyValuePairItems): |
| 1437 * platform/network/FormData.h: |
| 1438 (WebCore::FormData::parseEncodingType): |
| 1439 * platform/network/FormDataBuilder.cpp: |
| 1440 (WebCore::FormDataBuilder::addKeyValuePairAsFormData): Modified encoding
scheme for text/plain. |
| 1441 * platform/network/FormDataBuilder.h: |
| 1442 |
| 1443 2011-10-31 John Gregg <johnnyg@google.com> |
| 1444 |
| 1445 RenderImage.cpp calls SVGImage even if it's not defined |
| 1446 https://bugs.webkit.org/show_bug.cgi?id=71247 |
| 1447 |
| 1448 This fixes a compile error when ENABLE_SVG=0. |
| 1449 |
| 1450 * rendering/RenderImage.cpp: |
| 1451 (WebCore::RenderImage::embeddedContentBox): |
| 1452 |
| 1453 2011-10-31 Pavel Podivilov <podivilov@chromium.org> |
| 1454 |
| 1455 Update XMLHttpRequest.send idl declaration to match implementation. |
| 1456 https://bugs.webkit.org/show_bug.cgi?id=71121 |
| 1457 |
| 1458 Reviewed by Adam Barth. |
| 1459 |
| 1460 * xml/XMLHttpRequest.idl: |
| 1461 |
| 1462 2011-10-31 Anders Carlsson <andersca@apple.com> |
| 1463 |
| 1464 More work on making plug-ins work better with transforms |
| 1465 https://bugs.webkit.org/show_bug.cgi?id=71241 |
| 1466 |
| 1467 Reviewed by Darin Adler. |
| 1468 |
| 1469 Export symbols used by WebKit2. |
| 1470 |
| 1471 * WebCore.exp.in: |
| 1472 |
| 1473 2011-10-31 Mark Hahnenberg <mhahnenberg@apple.com> |
| 1474 |
| 1475 De-virtualize JSObject::defineGetter |
| 1476 https://bugs.webkit.org/show_bug.cgi?id=71134 |
| 1477 |
| 1478 Reviewed by Darin Adler. |
| 1479 |
| 1480 No new tests. |
| 1481 |
| 1482 Added defineGetter to the MethodTable. Replaced all virtual versions of
defineGetter |
| 1483 with static versions. Replaced all call sites with lookups in the Metho
dTable. |
| 1484 |
| 1485 * bindings/js/JSDOMWindowCustom.cpp: |
| 1486 (WebCore::JSDOMWindow::defineGetter): |
| 1487 * bindings/js/JSDOMWindowShell.cpp: |
| 1488 (WebCore::JSDOMWindowShell::defineGetter): |
| 1489 * bindings/js/JSDOMWindowShell.h: |
| 1490 * bindings/js/JSLocationCustom.cpp: |
| 1491 (WebCore::JSLocation::defineGetter): |
| 1492 (WebCore::JSLocationPrototype::defineGetter): |
| 1493 * bindings/scripts/CodeGeneratorJS.pm: |
| 1494 (GenerateHeader): |
| 1495 |
| 1496 2011-10-31 Arko Saha <arko@motorola.com> |
| 1497 |
| 1498 Microdata: Support for itemid attribute. |
| 1499 https://bugs.webkit.org/show_bug.cgi?id=71007 |
| 1500 |
| 1501 Reviewed by Ryosuke Niwa. |
| 1502 |
| 1503 itemid attribute: To give a global identifier for the Microdata items. |
| 1504 The itemid attribute, if specified, must have a value that is a valid UR
L potentially |
| 1505 surrounded by spaces. |
| 1506 Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microd
ata.html#attr-itemid |
| 1507 |
| 1508 Tests: fast/dom/MicroData/itemid-attribute-test.html |
| 1509 fast/dom/MicroData/itemid-must-see-resolved-url.html |
| 1510 |
| 1511 * html/HTMLElement.idl: |
| 1512 |
| 1513 2011-10-31 Yury Semikhatsky <yurys@chromium.org> |
| 1514 |
| 1515 window.onerror doesn't work with inline (attribute) scripts |
| 1516 https://bugs.webkit.org/show_bug.cgi?id=70991 |
| 1517 |
| 1518 Uncaught syntax errors in inline event handlers are now reported to |
| 1519 window.onerror handler. |
| 1520 |
| 1521 Reviewed by Geoffrey Garen. |
| 1522 |
| 1523 Tests: fast/events/window-onerror-exception-in-attr.html |
| 1524 fast/events/window-onerror-syntax-error-in-attr.html |
| 1525 |
| 1526 * bindings/js/JSLazyEventListener.cpp: |
| 1527 (WebCore::JSLazyEventListener::initializeJSFunction): report exception a
s usual |
| 1528 if it happens during event handler compilation. |
| 1529 |
| 1530 2011-10-31 Emil A Eklund <eae@chromium.org> |
| 1531 |
| 1532 Overridden LayoutRect method still uses IntRects |
| 1533 https://bugs.webkit.org/show_bug.cgi?id=71166 |
| 1534 |
| 1535 Reviewed by Eric Seidel. |
| 1536 |
| 1537 Change all virtual controlClipRect, windowResizerRect, windowClipRect, |
| 1538 visibleContentRect, scrollCornerRect, outlineBoundsForRepaint and |
| 1539 localCaretRect functions to have the same signature. |
| 1540 |
| 1541 * page/FrameView.cpp: |
| 1542 (WebCore::FrameView::windowClipRect): |
| 1543 (WebCore::FrameView::windowClipRectForLayer): |
| 1544 (WebCore::FrameView::windowResizerRect): |
| 1545 * page/FrameView.h: |
| 1546 * platform/ScrollView.cpp: |
| 1547 (WebCore::ScrollView::wheelEvent): |
| 1548 * platform/ScrollView.h: |
| 1549 * platform/ScrollableArea.h: |
| 1550 * rendering/RenderButton.h: |
| 1551 * rendering/RenderLayer.cpp: |
| 1552 (WebCore::RenderLayer::visibleContentRect): |
| 1553 * rendering/RenderLayer.h: |
| 1554 * rendering/RenderObject.cpp: |
| 1555 (WebCore::RenderObject::localCaretRect): |
| 1556 * rendering/RenderObject.h: |
| 1557 (WebCore::RenderObject::outlineBoundsForRepaint): |
| 1558 * rendering/RenderText.cpp: |
| 1559 (WebCore::RenderText::localCaretRect): |
| 1560 (WebCore::RenderText::linesBoundingBox): |
| 1561 * rendering/RenderText.h: |
| 1562 * rendering/svg/RenderSVGInlineText.cpp: |
| 1563 (WebCore::RenderSVGInlineText::localCaretRect): |
| 1564 * rendering/svg/RenderSVGInlineText.h: |
| 1565 |
| 1566 2011-10-31 Dmitry Lomov <dslomov@google.com> |
| 1567 |
| 1568 https://bugs.webkit.org/show_bug.cgi?id=70658 |
| 1569 [JSC] Implement MessagePort transfer in JSC bindings implementation of w
ebkitPostMessage. |
| 1570 Transfer of MessagePorts implemented. |
| 1571 |
| 1572 Reviewed by David Levin. |
| 1573 |
| 1574 * bindings/js/SerializedScriptValue.cpp: |
| 1575 (WebCore::CloneSerializer::serialize): |
| 1576 (WebCore::CloneSerializer::CloneSerializer): |
| 1577 (WebCore::CloneSerializer::dumpIfTerminal): |
| 1578 (WebCore::CloneDeserializer::deserialize): |
| 1579 (WebCore::CloneDeserializer::CloneDeserializer): |
| 1580 (WebCore::CloneDeserializer::readTerminal): |
| 1581 (WebCore::SerializedScriptValue::create): |
| 1582 (WebCore::SerializedScriptValue::deserialize): |
| 1583 |
| 1584 2011-10-31 Andreas Kling <kling@webkit.org> |
| 1585 |
| 1586 CSSRule: Devirtualize insertedIntoParent() |
| 1587 https://bugs.webkit.org/show_bug.cgi?id=71223 |
| 1588 |
| 1589 Reviewed by Antti Koivisto. |
| 1590 |
| 1591 Moved insertedIntoParent() down into CSSImportRule and renamed it to |
| 1592 requestStyleSheet(). CSSImportRule is the only user of this function. |
| 1593 |
| 1594 * css/CSSImportRule.cpp: |
| 1595 (WebCore::CSSImportRule::requestStyleSheet): |
| 1596 * css/CSSImportRule.h: |
| 1597 * css/CSSRule.h: |
| 1598 * css/CSSStyleSheet.cpp: |
| 1599 (WebCore::CSSStyleSheet::append): |
| 1600 (WebCore::CSSStyleSheet::insertRule): |
| 1601 |
| 1602 2011-10-31 Anna Cavender <annacc@chromium.org> |
| 1603 |
| 1604 Implement load notification and events for <track>. |
| 1605 https://bugs.webkit.org/show_bug.cgi?id=71054 |
| 1606 |
| 1607 Reviewed by Eric Carlson. |
| 1608 |
| 1609 Tests: media/track/track-load-error-readyState.html |
| 1610 media/track/track-load-from-element-readyState.html |
| 1611 media/track/track-load-from-src-readyState.html |
| 1612 |
| 1613 * html/HTMLMediaElement.cpp: |
| 1614 (WebCore::HTMLMediaElement::trackWasAdded): |
| 1615 (WebCore::HTMLMediaElement::trackWillBeRemoved): |
| 1616 (WebCore::HTMLMediaElement::trackSourceChanged): |
| 1617 * html/HTMLMediaElement.h: |
| 1618 * html/HTMLTrackElement.cpp: |
| 1619 (WebCore::HTMLTrackElement::insertedIntoTree): |
| 1620 (WebCore::HTMLTrackElement::willRemove): |
| 1621 (WebCore::HTMLTrackElement::parseMappedAttribute): |
| 1622 (WebCore::HTMLTrackElement::attributeChanged): |
| 1623 * html/HTMLTrackElement.h: |
| 1624 * html/LoadableTextTrack.cpp: |
| 1625 (WebCore::LoadableTextTrack::cueLoadingCompleted): |
| 1626 |
| 1627 2011-10-31 Andreas Kling <kling@webkit.org> |
| 1628 |
| 1629 CSSRule: Devirtualize type() and isFooRule() |
| 1630 https://bugs.webkit.org/show_bug.cgi?id=71221 |
| 1631 |
| 1632 Reviewed by Antti Koivisto. |
| 1633 |
| 1634 Store the rule type in a CSSRule member (packed with the parent-is-rule
flag) |
| 1635 and let the isFooRule() functions return type() == FOO_TYPE. |
| 1636 |
| 1637 CSSPageRule will no longer return true for isStyleRule(), tweaked call s
ites |
| 1638 accordingly. |
| 1639 |
| 1640 * css/CSSCharsetRule.cpp: |
| 1641 (WebCore::CSSCharsetRule::CSSCharsetRule): |
| 1642 * css/CSSCharsetRule.h: |
| 1643 * css/CSSFontFaceRule.cpp: |
| 1644 (WebCore::CSSFontFaceRule::CSSFontFaceRule): |
| 1645 * css/CSSFontFaceRule.h: |
| 1646 * css/CSSImportRule.cpp: |
| 1647 (WebCore::CSSImportRule::CSSImportRule): |
| 1648 * css/CSSImportRule.h: |
| 1649 * css/CSSMediaRule.cpp: |
| 1650 (WebCore::CSSMediaRule::CSSMediaRule): |
| 1651 * css/CSSMediaRule.h: |
| 1652 * css/CSSPageRule.cpp: |
| 1653 (WebCore::CSSPageRule::CSSPageRule): |
| 1654 * css/CSSPageRule.h: |
| 1655 * css/CSSRegionStyleRule.cpp: |
| 1656 (WebCore::CSSRegionStyleRule::CSSRegionStyleRule): |
| 1657 * css/CSSRegionStyleRule.h: |
| 1658 * css/CSSRule.h: |
| 1659 (WebCore::CSSRule::type): |
| 1660 (WebCore::CSSRule::isCharsetRule): |
| 1661 (WebCore::CSSRule::isFontFaceRule): |
| 1662 (WebCore::CSSRule::isKeyframeRule): |
| 1663 (WebCore::CSSRule::isKeyframesRule): |
| 1664 (WebCore::CSSRule::isMediaRule): |
| 1665 (WebCore::CSSRule::isPageRule): |
| 1666 (WebCore::CSSRule::isStyleRule): |
| 1667 (WebCore::CSSRule::isRegionStyleRule): |
| 1668 (WebCore::CSSRule::isImportRule): |
| 1669 (WebCore::CSSRule::CSSRule): |
| 1670 * css/CSSStyleRule.cpp: |
| 1671 (WebCore::CSSStyleRule::CSSStyleRule): |
| 1672 * css/CSSStyleRule.h: |
| 1673 * css/CSSStyleSelector.cpp: |
| 1674 (WebCore::RuleSet::addPageRule): |
| 1675 (WebCore::RuleSet::addRulesFromSheet): |
| 1676 (WebCore::RuleSet::addStyleRule): |
| 1677 * css/CSSUnknownRule.h: |
| 1678 (WebCore::CSSUnknownRule::CSSUnknownRule): |
| 1679 * css/WebKitCSSKeyframeRule.cpp: |
| 1680 (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule): |
| 1681 * css/WebKitCSSKeyframeRule.h: |
| 1682 * css/WebKitCSSKeyframesRule.cpp: |
| 1683 (WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule): |
| 1684 * css/WebKitCSSKeyframesRule.h: |
| 1685 * inspector/InspectorCSSAgent.cpp: |
| 1686 (WebCore::InspectorCSSAgent::asCSSStyleRule): |
| 1687 |
| 1688 2011-10-31 Pavel Feldman <pfeldman@google.com> |
| 1689 |
| 1690 Not reviewed: reorder inspector js files to fix remote mode. |
| 1691 |
| 1692 * inspector/front-end/inspector.html: |
| 1693 |
| 1694 2011-10-28 Alexander Pavlov <apavlov@chromium.org> |
| 1695 |
| 1696 Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract h
istory management |
| 1697 https://bugs.webkit.org/show_bug.cgi?id=70936 |
| 1698 |
| 1699 Reviewed by Pavel Feldman. |
| 1700 |
| 1701 * inspector/front-end/ConsoleView.js: |
| 1702 (WebInspector.ConsoleView): |
| 1703 * inspector/front-end/DatabaseQueryView.js: |
| 1704 (WebInspector.DatabaseQueryView): |
| 1705 (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): |
| 1706 * inspector/front-end/StylesSidebarPane.js: |
| 1707 (WebInspector.StylesSidebarPane.prototype._attributesModified): |
| 1708 (WebInspector.StylePropertyTreeElement.prototype.selectElement): |
| 1709 (WebInspector.StylePropertyTreeElement.prototype.selectElement.context): |
| 1710 (WebInspector.StylePropertyTreeElement.prototype.selectElement.event): |
| 1711 (WebInspector.StylePropertyTreeElement.prototype): |
| 1712 (WebInspector.StylePropertyTreeElement.prototype.context.event): |
| 1713 (): |
| 1714 * inspector/front-end/TextPrompt.js: |
| 1715 (WebInspector.TextPrompt): |
| 1716 (WebInspector.TextPrompt.prototype.get proxyElement): |
| 1717 (WebInspector.TextPrompt.prototype.attach): |
| 1718 (WebInspector.TextPrompt.prototype.attachAndStartEditing): |
| 1719 (WebInspector.TextPrompt.prototype._attachInternal): |
| 1720 (WebInspector.TextPrompt.prototype.detach): |
| 1721 (WebInspector.TextPrompt.prototype.get text): |
| 1722 (WebInspector.TextPrompt.prototype.set text): |
| 1723 (WebInspector.TextPrompt.prototype._removeFromElement): |
| 1724 (WebInspector.TextPrompt.prototype._startEditing): |
| 1725 (WebInspector.TextPrompt.prototype._stopEditing): |
| 1726 (WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside): |
| 1727 (WebInspector.TextPrompt.prototype._selectStart): |
| 1728 (WebInspector.TextPrompt.prototype.defaultKeyHandler): |
| 1729 (WebInspector.TextPrompt.prototype._onKeyDown): |
| 1730 (WebInspector.TextPrompt.prototype.clearAutoComplete): |
| 1731 (WebInspector.TextPrompt.prototype.complete): |
| 1732 (WebInspector.TextPrompt.prototype._completionsReady): |
| 1733 (WebInspector.TextPrompt.prototype.isCaretInsidePrompt): |
| 1734 (WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt): |
| 1735 (WebInspector.TextPrompt.prototype.isCaretOnFirstLine): |
| 1736 (WebInspector.TextPrompt.prototype.isCaretOnLastLine): |
| 1737 (WebInspector.TextPrompt.prototype.moveCaretToEndOfPrompt): |
| 1738 (WebInspector.TextPrompt.prototype.upKeyPressed): |
| 1739 (WebInspector.TextPrompt.prototype.downKeyPressed): |
| 1740 (WebInspector.TextPrompt.prototype.tabKeyPressed): |
| 1741 (WebInspector.TextPromptConfig): |
| 1742 (WebInspector.TextPromptWithHistory): |
| 1743 (WebInspector.TextPromptWithHistory.prototype.get historyData): |
| 1744 (WebInspector.TextPromptWithHistory.prototype.setHistoryData): |
| 1745 (WebInspector.TextPromptWithHistory.prototype.pushHistoryItem): |
| 1746 (WebInspector.TextPromptWithHistory.prototype._pushCurrentText): |
| 1747 (WebInspector.TextPromptWithHistory.prototype._previous): |
| 1748 (WebInspector.TextPromptWithHistory.prototype._next): |
| 1749 (WebInspector.TextPromptWithHistory.prototype._currentHistoryItem): |
| 1750 (WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler): |
| 1751 |
| 1752 2011-10-31 Pavel Feldman <pfeldman@google.com> |
| 1753 |
| 1754 Web Inspector: move localization support into UIUtil.js, reduce externs. |
| 1755 https://bugs.webkit.org/show_bug.cgi?id=71220 |
| 1756 |
| 1757 Reviewed by Yury Semikhatsky. |
| 1758 |
| 1759 * inspector/compile-front-end.sh: |
| 1760 * inspector/front-end/AdvancedSearchController.js: |
| 1761 (WebInspector.SearchView.prototype.focus): |
| 1762 * inspector/front-end/ConsoleView.js: |
| 1763 (WebInspector.ConsoleView.prototype.afterShow): |
| 1764 * inspector/front-end/Drawer.js: |
| 1765 * inspector/front-end/GoToLineDialog.js: |
| 1766 (WebInspector.GoToLineDialog.prototype._hide): |
| 1767 * inspector/front-end/HelpScreen.js: |
| 1768 (WebInspector.HelpScreen.prototype.show): |
| 1769 (WebInspector.HelpScreen.prototype.hide): |
| 1770 (WebInspector.HelpScreen.prototype._onBlur): |
| 1771 * inspector/front-end/InspectorFrontendHostStub.js: |
| 1772 * inspector/front-end/KeyboardShortcut.js: |
| 1773 (WebInspector.KeyboardShortcut._keyName): |
| 1774 * inspector/front-end/Panel.js: |
| 1775 (WebInspector.Panel.prototype.wasShown): |
| 1776 * inspector/front-end/SearchController.js: |
| 1777 (WebInspector.SearchController.prototype._onSearchFieldManualFocus): |
| 1778 (WebInspector.SearchController.prototype._onKeyDown): |
| 1779 * inspector/front-end/Settings.js: |
| 1780 * inspector/front-end/SourceFrame.js: |
| 1781 (WebInspector.SourceFrame): |
| 1782 * inspector/front-end/Toolbar.js: |
| 1783 (WebInspector.Toolbar.prototype._toolbarDragStart): |
| 1784 * inspector/front-end/UIUtils.js: |
| 1785 (WebInspector.startEditing.cleanUpAfterEditing): |
| 1786 (WebInspector.startEditing.var): |
| 1787 (WebInspector.startEditing): |
| 1788 (WebInspector.UIString): |
| 1789 (WebInspector.useLowerCaseMenuTitles): |
| 1790 (WebInspector.platform): |
| 1791 (WebInspector.isMac): |
| 1792 (WebInspector.platformFlavor): |
| 1793 (WebInspector.port): |
| 1794 (WebInspector.installPortStyles): |
| 1795 (WebInspector._windowFocused): |
| 1796 (WebInspector._windowBlurred): |
| 1797 (WebInspector.previousFocusElement): |
| 1798 (WebInspector.currentFocusElement): |
| 1799 (WebInspector._focusChanged): |
| 1800 (WebInspector.setCurrentFocusElement): |
| 1801 * inspector/front-end/externs.js: |
| 1802 (Event.prototype.initWebKitWheelEvent): |
| 1803 (window.getComputedStyle): |
| 1804 (InspectorBackend.runAfterPendingDispatches): |
| 1805 * inspector/front-end/inspector.js: |
| 1806 (WebInspector.documentKeyDown): |
| 1807 (WebInspector.addMainEventListeners): |
| 1808 |
| 1809 2011-10-31 Andreas Kling <kling@webkit.org> |
| 1810 |
| 1811 Kill StyleBase. |
| 1812 https://bugs.webkit.org/show_bug.cgi?id=71218 |
| 1813 |
| 1814 Reviewed by Antti Koivisto. |
| 1815 |
| 1816 Remove the StyleBase class and make all subclasses stand alone. CSSRule
and StyleSheet |
| 1817 now inherit from RefCounted<T> instead, and XSLImportRule doesn't even n
eed that, |
| 1818 so StyleBase is replaced by nothing. |
| 1819 |
| 1820 * css/StyleBase.cpp: |
| 1821 * css/StyleBase.h: |
| 1822 |
| 1823 Removed. |
| 1824 |
| 1825 * css/CSSRule.cpp: |
| 1826 * css/CSSRule.h: |
| 1827 (WebCore::CSSRule::~CSSRule): |
| 1828 (WebCore::CSSRule::useStrictParsing): |
| 1829 (WebCore::CSSRule::setParentStyleSheet): |
| 1830 (WebCore::CSSRule::setParentRule): |
| 1831 (WebCore::CSSRule::parentStyleSheet): |
| 1832 (WebCore::CSSRule::parentRule): |
| 1833 (WebCore::CSSRule::baseURL): |
| 1834 (WebCore::CSSRule::CSSRule): |
| 1835 |
| 1836 CSSRule now inherits directly from RefCounted, and has either a CSSR
ule or a |
| 1837 CSSStyleSheet as its parent. Made these getters/setters inline since
they are |
| 1838 trivial now. |
| 1839 |
| 1840 * CMakeLists.txt: |
| 1841 * GNUmakefile.list.am: |
| 1842 * WebCore.gypi: |
| 1843 * WebCore.pro: |
| 1844 * WebCore.vcproj/WebCore.vcproj: |
| 1845 * WebCore.xcodeproj/project.pbxproj: |
| 1846 |
| 1847 Purge StyleBase.* from the build systems. |
| 1848 |
| 1849 * bindings/js/JSDOMBinding.h: |
| 1850 (WebCore::root): |
| 1851 |
| 1852 New root() functions for CSSRule and StyleSheet. |
| 1853 |
| 1854 * bindings/js/JSNodeCustom.h: |
| 1855 |
| 1856 Remove StyleBase.h include. |
| 1857 |
| 1858 * css/CSSStyleSheet.h: |
| 1859 (WebCore::CSSStyleSheet::parentStyleSheet): |
| 1860 |
| 1861 Added CSS-specific parentStyleSheet() so we don't have to cast it to
a |
| 1862 CSSStyleSheet* at the call sites. |
| 1863 |
| 1864 * css/StyleSheet.cpp: |
| 1865 (WebCore::StyleSheet::StyleSheet): |
| 1866 (WebCore::StyleSheet::parentStyleSheet): |
| 1867 (WebCore::StyleSheet::baseURL): |
| 1868 * css/StyleSheet.h: |
| 1869 (WebCore::StyleSheet::parentRule): |
| 1870 (WebCore::StyleSheet::setParentRule): |
| 1871 (WebCore::StyleSheet::isCSSStyleSheet): |
| 1872 (WebCore::StyleSheet::isXSLStyleSheet): |
| 1873 |
| 1874 StyleSheet now inherits directly from RefCounted and always has a pa
rent CSSRule |
| 1875 though it can be null. parentStyleSheet() returns that rule's parent
style sheet. |
| 1876 Moved the relevant guts from StyleBase down here. |
| 1877 |
| 1878 * loader/cache/CachedStyleSheetClient.h: |
| 1879 |
| 1880 Remove unnecessary WTF_MAKE_FAST_ALLOCATED, we get it from CachedRes
ourceClient. |
| 1881 |
| 1882 * xml/XSLImportRule.cpp: |
| 1883 (WebCore::XSLImportRule::XSLImportRule): |
| 1884 (WebCore::XSLImportRule::~XSLImportRule): |
| 1885 (WebCore::XSLImportRule::parentStyleSheet): |
| 1886 (WebCore::XSLImportRule::setXSLStyleSheet): |
| 1887 (WebCore::XSLImportRule::loadSheet): |
| 1888 * xml/XSLImportRule.h: |
| 1889 (WebCore::XSLImportRule::create): |
| 1890 (WebCore::XSLImportRule::setParentStyleSheet): |
| 1891 |
| 1892 Remove inheritance from StyleBase, and have create() return a PassOw
nPtr instead. |
| 1893 This is fine, since XSLStyleSheet is the only object that ever manag
es these rules. |
| 1894 |
| 1895 * svg/SVGFontFaceElement.cpp: |
| 1896 (WebCore::SVGFontFaceElement::insertedIntoDocument): |
| 1897 * css/CSSStyleSheet.cpp: |
| 1898 (WebCore::CSSStyleSheet::~CSSStyleSheet): |
| 1899 (WebCore::CSSStyleSheet::ownerRule): |
| 1900 (WebCore::CSSStyleSheet::deleteRule): |
| 1901 (WebCore::CSSStyleSheet::checkLoaded): |
| 1902 (WebCore::CSSStyleSheet::document): |
| 1903 (WebCore::CSSStyleSheet::styleSheetChanged): |
| 1904 * css/CSSImportRule.cpp: |
| 1905 (WebCore::CSSImportRule::~CSSImportRule): |
| 1906 (WebCore::CSSImportRule::setCSSStyleSheet): |
| 1907 (WebCore::CSSImportRule::insertedIntoParent): |
| 1908 * css/CSSMediaRule.cpp: |
| 1909 (WebCore::CSSMediaRule::CSSMediaRule): |
| 1910 (WebCore::CSSMediaRule::~CSSMediaRule): |
| 1911 (WebCore::CSSMediaRule::append): |
| 1912 (WebCore::CSSMediaRule::insertRule): |
| 1913 (WebCore::CSSMediaRule::deleteRule): |
| 1914 * css/CSSRegionStyleRule.cpp: |
| 1915 (WebCore::CSSRegionStyleRule::CSSRegionStyleRule): |
| 1916 (WebCore::CSSRegionStyleRule::~CSSRegionStyleRule): |
| 1917 * css/CSSRuleList.cpp: |
| 1918 (WebCore::CSSRuleList::deleteRule): |
| 1919 * css/CSSStyleDeclaration.h: |
| 1920 * css/WebKitCSSKeyframesRule.cpp: |
| 1921 (WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule): |
| 1922 (WebCore::WebKitCSSKeyframesRule::setName): |
| 1923 (WebCore::WebKitCSSKeyframesRule::append): |
| 1924 * dom/ProcessingInstruction.cpp: |
| 1925 (WebCore::ProcessingInstruction::parseStyleSheet): |
| 1926 * inspector/InspectorCSSAgent.cpp: |
| 1927 (WebCore::InspectorCSSAgent::parentStyleSheet): |
| 1928 * xml/XSLStyleSheet.h: |
| 1929 * xml/XSLStyleSheetLibxslt.cpp: |
| 1930 (WebCore::XSLStyleSheet::XSLStyleSheet): |
| 1931 (WebCore::XSLStyleSheet::~XSLStyleSheet): |
| 1932 (WebCore::XSLStyleSheet::checkLoaded): |
| 1933 (WebCore::XSLStyleSheet::loadChildSheet): |
| 1934 * xml/XSLStyleSheetQt.cpp: |
| 1935 (WebCore::XSLStyleSheet::~XSLStyleSheet): |
| 1936 |
| 1937 Use the new, more explicit, parenting functions of StyleSheet. |
| 1938 |
| 1939 2011-10-31 Nikolas Zimmermann <nzimmermann@rim.com> |
| 1940 |
| 1941 CSS 2.1 failure: background-intrinsic-* |
| 1942 https://bugs.webkit.org/show_bug.cgi?id=47156 |
| 1943 |
| 1944 SVGs do not work as tiled background images |
| 1945 https://bugs.webkit.org/show_bug.cgi?id=16281 |
| 1946 |
| 1947 Apply preserveAspectRatio and synthesize viewboxes in <img> |
| 1948 https://bugs.webkit.org/show_bug.cgi?id=34521 |
| 1949 |
| 1950 SVG background doesn't resize properly when dimensions are changed |
| 1951 https://bugs.webkit.org/show_bug.cgi?id=42944 |
| 1952 |
| 1953 Images with percent height inside a floated div should use intrinsic hei
ght. |
| 1954 https://bugs.webkit.org/show_bug.cgi?id=45439 |
| 1955 |
| 1956 SVG image in HTML changes size as the window is resized |
| 1957 https://bugs.webkit.org/show_bug.cgi?id=52045 |
| 1958 |
| 1959 Reviewed by Antti Koivisto. |
| 1960 |
| 1961 Implement intrinsic sizing support for SVGImage (svg embedded through <h
tml:img>/<svg:image>/background-image/border-image/...). |
| 1962 This is demanded by CSS 2.1, and covered by new layout tests in LayoutTe
sts/css2.1 and several new custom testcases. |
| 1963 |
| 1964 Tests: css2.1/20110323/background-intrinsic-001.htm |
| 1965 css2.1/20110323/background-intrinsic-002.htm |
| 1966 css2.1/20110323/background-intrinsic-003.htm |
| 1967 css2.1/20110323/background-intrinsic-004.htm |
| 1968 css2.1/20110323/background-intrinsic-005.htm |
| 1969 css2.1/20110323/background-intrinsic-006.htm |
| 1970 css2.1/20110323/background-intrinsic-007.htm |
| 1971 css2.1/20110323/background-intrinsic-008.htm |
| 1972 css2.1/20110323/background-intrinsic-009.htm |
| 1973 svg/as-background-image/background-image-preserveaspectRatio-supp
ort.html (adapted from testcase from bug 34521) |
| 1974 svg/as-background-image/background-image-tiled.html (reduction fr
om bug 16281) |
| 1975 svg/as-background-image/same-image-two-instances-background-image
.html |
| 1976 svg/as-image/img-preserveAspectRatio-support-1.html (reduction fr
om bug 34521) |
| 1977 svg/as-image/same-image-two-instances.html |
| 1978 svg/as-image/svg-as-relative-image-with-explicit-size.html |
| 1979 svg/as-image/svg-image-change-content-size.xhtml (reduction from
bug 42944) |
| 1980 svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html |
| 1981 svg/zoom/page/zoom-svg-as-image.html |
| 1982 svg/zoom/page/zoom-svg-as-relative-image.html |
| 1983 |
| 1984 * css/CSSImageGeneratorValue.cpp: |
| 1985 (WebCore::CSSImageGeneratorValue::addClient): Pass default zoom factor. |
| 1986 (WebCore::CSSImageGeneratorValue::getImage): Ditto. |
| 1987 * loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache. |
| 1988 (WebCore::CachedImage::lookupImageForSize): Use recently introduced Imag
eBySizeCache, to lookup an image for a certain size. |
| 1989 (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently int
roduced ImageBySizeCache, to dynamically create copies of m_image if needed. |
| 1990 (WebCore::CachedImage::imageForRenderer): Lookup image by renderer, whic
h first looks up a size for a renderer, then uses lookupImageForSize(). |
| 1991 (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass
on container size handling to ImageBySizeCache. |
| 1992 (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size,
respecting per-renderer overrides, for a certain renderer. |
| 1993 (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary R
enderObject parameter. |
| 1994 * loader/cache/CachedImage.h: |
| 1995 * page/ChromeClient.h: |
| 1996 (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whethe
r a RenderSVGRoot is embedded through a SVGImage. Returns false, by default. |
| 1997 * platform/graphics/Image.h: |
| 1998 (WebCore::Image::setImageObserver): Add helper. |
| 1999 * rendering/ImageBySizeCache.cpp: Cleanup code. |
| 2000 (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is va
lid. |
| 2001 (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() t
o be called w/o prio addClient() usage. |
| 2002 (WebCore::ImageBySizeCache::getImage): Add zoom parameter. |
| 2003 (WebCore::ImageBySizeCache::getRequestedSizeAndZoom): Add way to get req
uested size from cache, instead of actual cached sizes. |
| 2004 (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just ret
urn 0, instead of asserting. |
| 2005 (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retri
eves an image for a renderer, by lookup up its size and using imageForSize(). |
| 2006 * rendering/ImageBySizeCache.h: Cleaup code, introduce struct that repla
ces the std::pair<IntSize, int>. |
| 2007 (WebCore::SizeZoomAndCount::SizeZoomAndCount): |
| 2008 * rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size n
egotiation for images. |
| 2009 (WebCore::resolveWidthForRatio): New inline helper function used by calc
ulateImageIntrinsicDimensions. |
| 2010 (WebCore::resolveHeightForRatio): Ditto. |
| 2011 (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto. |
| 2012 (WebCore::resolveAgainstIntrinsicRatio): Ditto. |
| 2013 (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New
helper function, containing the main algorithm, which is a pure transcription of
the spec. |
| 2014 (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculat
eImageIntrinsicDimensions() helper to figure out the intrinsic size. |
| 2015 (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propa
gate calculateFillTileSize() result to the image resource, via setContainerSizeF
orRenderer(). |
| 2016 (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateI
mageIntrinsicDimensions() helper to figure out the intrinsic size. |
| 2017 * rendering/RenderBoxModelObject.h: Clarify some variable names, added c
alculateImageIntrinsicDimensions(). |
| 2018 * rendering/RenderImage.cpp: |
| 2019 (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0
, 0). |
| 2020 (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from ima
geDimensionsChanged(). |
| 2021 (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeI
fNeeded(). |
| 2022 (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced:
:computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size
must be correct. |
| 2023 (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implem
entation for non-SVGImages. |
| 2024 (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true,
just like RenderPart, if embeddedContentBox is not null. |
| 2025 (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* r
enderer of the embedded SVG, if possible. |
| 2026 * rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / com
puteReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height(). |
| 2027 * rendering/RenderImageResource.cpp: |
| 2028 (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around
new "float containerZoomFactor" parameter. |
| 2029 * rendering/RenderImageResourceStyleImage.cpp: |
| 2030 (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is
now calling image() earlier than before. We now have to handle the case that th
e image is pending. |
| 2031 (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): P
ass zoom factor. |
| 2032 * rendering/RenderImageResourceStyleImage.h: |
| 2033 * rendering/RenderListMarker.cpp: |
| 2034 (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effecti
ve zoom to setContainerSizeForRenderer(). |
| 2035 * rendering/RenderReplaced.cpp: |
| 2036 (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized thi
s code, as RenderImage is using it as well now. Marginal changes needed. |
| 2037 (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto. |
| 2038 (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto. |
| 2039 * rendering/style/StyleCachedImage.cpp: |
| 2040 (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_
renderer to CachedImage, it's no longer needed. |
| 2041 (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float con
tainerZoomFactor" parameter. |
| 2042 * rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" pa
rameter to setContainerSizeForRenderer. |
| 2043 * rendering/style/StyleGeneratedImage.h: |
| 2044 (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto. |
| 2045 * rendering/style/StyleImage.h: Ditto. |
| 2046 * rendering/style/StylePendingImage.h: |
| 2047 (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto. |
| 2048 * rendering/svg/RenderSVGImage.cpp: |
| 2049 (WebCore::RenderSVGImage::layout): Always supply a container size when e
mbedding SVGs in <svg:image>. |
| 2050 * rendering/svg/RenderSVGRoot.cpp: Move "override container size" from S
VGSVGElement into RenderSVGRoot, where it belongs. |
| 2051 (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper meth
od to determine whether we're loaded through SVGImage. |
| 2052 (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a vali
d container size, it has precendence (only supplied via external SVGImages). |
| 2053 (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto. |
| 2054 (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need t
o track/override the viewport size anymore, all done in coputeReplacedLogical* n
ow. |
| 2055 (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always ma
tches the previously computed m_viewportSize. |
| 2056 (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto. |
| 2057 * rendering/svg/RenderSVGRoot.h: Move "override container size" from SVG
SVGElement into RenderSVGRoot, where it belongs. |
| 2058 (WebCore::RenderSVGRoot::containerSize): |
| 2059 (WebCore::RenderSVGRoot::setContainerSize): |
| 2060 * svg/SVGLength.cpp: |
| 2061 (WebCore::SVGLength::determineViewport): Resolve lengths against overrid
e container size in documents embedded through SVGImage. |
| 2062 * svg/SVGSVGElement.cpp: Remove "override container size" handling from
SVGSVGElement. |
| 2063 (WebCore::SVGSVGElement::SVGSVGElement): Ditto. |
| 2064 (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBo
x, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition. |
| 2065 * svg/SVGSVGElement.h: |
| 2066 * svg/graphics/SVGImage.cpp: |
| 2067 (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, us
ed to identify whether RenderSVGRoot is embedded through SVGImage. |
| 2068 (WebCore::SVGImage::createWithDataAndSize): Add new helper function. |
| 2069 (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFac
tor. |
| 2070 (WebCore::SVGImage::setContainerSize): Assert that container size is not
empty. We should never receive an empty container size. |
| 2071 (WebCore::SVGImage::usesContainerSize): Adapt to override container size
changes, it now lives in RenderSVGRoot instead of SVGSVGElement. |
| 2072 (WebCore::SVGImage::size): New algorithm to figure out the size of an em
bedded SVG, as demanded by the CSS/SVG specs. |
| 2073 (WebCore::SVGImage::embeddedContentBox): Add helper which returns the Re
nderSVGRoot of the document. |
| 2074 (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic rat
io calculation. |
| 2075 (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScr
ollbars(false), as SVG images now always synthesize a viewBox, and thus never re
ceive scrollbars. |
| 2076 * svg/graphics/SVGImage.h: |
| 2077 |
| 2078 2011-10-31 Yury Semikhatsky <yurys@chromium.org> |
| 2079 |
| 2080 Unreviewed. Add ResourcePreviewView.js to the list of inspector front-en
d |
| 2081 files on Qt. |
| 2082 |
| 2083 * inspector/front-end/WebKit.qrc: |
| 2084 |
| 2085 2011-10-31 Pavel Feldman <pfeldman@google.com> |
| 2086 |
| 2087 Web Inspector: do not map scripts generated with document.write to the d
ocument resources. |
| 2088 https://bugs.webkit.org/show_bug.cgi?id=71114 |
| 2089 |
| 2090 Reviewed by Yury Semikhatsky. |
| 2091 |
| 2092 Test: inspector/debugger/bind-script-to-resource.html |
| 2093 |
| 2094 * inspector/front-end/DebuggerPresentationModel.js: |
| 2095 (WebInspector.DebuggerPresentationModel): |
| 2096 (WebInspector.DebuggerPresentationModel.prototype._addScript): |
| 2097 (WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSource
Code): |
| 2098 (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScrip
tWithURL): |
| 2099 (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScrip
t): |
| 2100 (WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCod
e): |
| 2101 (WebInspector.DebuggerPresentationModel.prototype._debuggerReset): |
| 2102 * inspector/front-end/RawSourceCode.js: |
| 2103 (WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestCon
tent.didFormatContent): |
| 2104 (WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestCon
tent): |
| 2105 (WebInspector.RawSourceCode.prototype._createSourceMapping): |
| 2106 * inspector/front-end/Script.js: |
| 2107 |
| 2108 2011-10-31 Antti Koivisto <antti@apple.com> |
| 2109 |
| 2110 https://bugs.webkit.org/show_bug.cgi?id=71012 |
| 2111 Use StringHasher to generate the matched declaration cache hash |
| 2112 |
| 2113 Reviewed by Sam Weinig. |
| 2114 |
| 2115 Make sure the MatchedStyleDeclarations are fully zero-initialized as we
calculate a hash over a raw memory array of these. |
| 2116 |
| 2117 * css/CSSStyleSelector.cpp: |
| 2118 (WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclara
tion): |
| 2119 (WebCore::CSSStyleSelector::addMatchedDeclaration): |
| 2120 * css/CSSStyleSelector.h: |
| 2121 |
| 2122 2011-10-31 Carlos Garcia Campos <cgarcia@igalia.com> |
| 2123 |
| 2124 Unreviewed. Fix make distcheck build. |
| 2125 |
| 2126 * GNUmakefile.am: Add InFilesCompiler.pm to SCRIPTS_BINDINGS and |
| 2127 EXTRA_DIST. Also remove duplicated entries in EXTRA_DIST. |
| 2128 |
| 2129 2011-10-31 Pavel Feldman <pfeldman@chromium.org> |
| 2130 |
| 2131 Web Inspector: factor out ResourceUtils, clean up externs. |
| 2132 https://bugs.webkit.org/show_bug.cgi?id=71192 |
| 2133 |
| 2134 Reviewed by Yury Semikhatsky. |
| 2135 |
| 2136 * WebCore.gypi: |
| 2137 * WebCore.vcproj/WebCore.vcproj: |
| 2138 * inspector/compile-front-end.sh: |
| 2139 * inspector/front-end/ConsoleMessage.js: |
| 2140 (WebInspector.ConsoleMessageImpl.prototype._linkifyLocation): |
| 2141 * inspector/front-end/DebuggerPresentationModel.js: |
| 2142 * inspector/front-end/ProfilesPanel.js: |
| 2143 * inspector/front-end/Resource.js: |
| 2144 (WebInspector.Resource.displayName): |
| 2145 * inspector/front-end/ResourceTreeModel.js: |
| 2146 (WebInspector.ResourceTreeModel.prototype._createResource): |
| 2147 * inspector/front-end/ResourceUtils.js: Added. |
| 2148 (WebInspector.resourceForURL): |
| 2149 (WebInspector.forAllResources): |
| 2150 (WebInspector.displayNameForURL): |
| 2151 (WebInspector.linkifyStringAsFragmentWithCustomLinkifier): |
| 2152 (WebInspector.registerLinkifierPlugin): |
| 2153 (WebInspector.linkifyStringAsFragment): |
| 2154 (WebInspector.linkifyURLAsNode): |
| 2155 (WebInspector.linkifyURL): |
| 2156 (WebInspector.formatLinkText): |
| 2157 (WebInspector.linkifyResourceAsNode): |
| 2158 (WebInspector.resourceURLForRelatedNode.callback): |
| 2159 (WebInspector.resourceURLForRelatedNode): |
| 2160 (WebInspector.populateHrefContextMenu): |
| 2161 (WebInspector.completeURL): |
| 2162 * inspector/front-end/StylesSidebarPane.js: |
| 2163 (WebInspector.StylePropertyTreeElement.prototype.selectElement): |
| 2164 * inspector/front-end/WebKit.qrc: |
| 2165 * inspector/front-end/externs.js: |
| 2166 * inspector/front-end/inspector.html: |
| 2167 * inspector/front-end/inspector.js: |
| 2168 (WebInspector.networkResourceById): |
| 2169 * inspector/front-end/utilities.js: |
| 2170 (setupPrototypeUtilities.Element.prototype.selectionLeftOffset): |
| 2171 |
| 2172 2011-10-28 Alexander Pavlov <apavlov@chromium.org> |
| 2173 |
| 2174 Web Inspector: Using keyboard to increment/decrement units is inconsiste
nt |
| 2175 https://bugs.webkit.org/show_bug.cgi?id=71119 |
| 2176 |
| 2177 Reviewed by Pavel Feldman. |
| 2178 |
| 2179 This change makes the behavior consistent with that described at http://
trac.webkit.org/wiki/WebInspector |
| 2180 |
| 2181 * inspector/front-end/StylesSidebarPane.js: |
| 2182 (WebInspector.StylesSidebarPane.alteredFloatNumber): |
| 2183 (WebInspector.StylesSidebarPane.prototype._attributesModified): |
| 2184 |
| 2185 2011-10-29 Martin Robinson <mrobinson@igalia.com> |
| 2186 |
| 2187 [GTK] Switch to a backing store approach for painting WebKitWebView |
| 2188 https://bugs.webkit.org/show_bug.cgi?id=70213 |
| 2189 |
| 2190 Reviewed by Gustavo Noronha Silva. |
| 2191 |
| 2192 No new tests. The changes to WebCore should not change |
| 2193 behavior. The changes in WebKit are covered by existing |
| 2194 tests. |
| 2195 |
| 2196 * platform/cairo/WidgetBackingStore.h: |
| 2197 (WebCore::WidgetBackingStore::size): Added this getter for the size. |
| 2198 * platform/cairo/WidgetBackingStoreCairo.cpp: |
| 2199 (WebCore::WidgetBackingStore::WidgetBackingStore): Initialize size. |
| 2200 * platform/graphics/cairo/CairoUtilities.cpp: |
| 2201 (WebCore::copyRectFromCairoSurfaceToContext): Added this new helper. |
| 2202 (WebCore::copyRectFromOneSurfaceToAnother): Use the new helper. |
| 2203 * platform/graphics/cairo/CairoUtilities.h: |
| 2204 * platform/gtk/GtkWidgetBackingStoreX11.cpp: |
| 2205 (WebCore::WidgetBackingStore::WidgetBackingStore): Initialize the size. |
| 2206 |
| 2207 2011-10-30 Sheriff Bot <webkit.review.bot@gmail.com> |
| 2208 |
| 2209 Unreviewed, rolling out r98803. |
| 2210 http://trac.webkit.org/changeset/98803 |
| 2211 https://bugs.webkit.org/show_bug.cgi?id=71186 |
| 2212 |
| 2213 Causing test and assertion failures on some platforms |
| 2214 (Requested by anttik on #webkit). |
| 2215 |
| 2216 * css/CSSStyleSelector.cpp: |
| 2217 (WebCore::CSSStyleSelector::applyMatchedDeclarations): |
| 2218 |
| 2219 2011-10-29 Mark Rowe <mrowe@apple.com> |
| 2220 |
| 2221 Build fix. |
| 2222 |
| 2223 * platform/graphics/mac/WebLayer.mm: |
| 2224 (drawLayerContents): |
| 2225 |
| 2226 2011-10-29 Mark Rowe <mrowe@apple.com> |
| 2227 |
| 2228 Build fix. |
| 2229 |
| 2230 * editing/Editor.cpp: |
| 2231 (WebCore::Editor::markMisspellingsAfterTypingToWord): |
| 2232 |
| 2233 2011-10-29 Daniel Cheng <dcheng@chromium.org> |
| 2234 |
| 2235 Rename DataTransferItems to DataTransferItemList |
| 2236 https://bugs.webkit.org/show_bug.cgi?id=71151 |
| 2237 |
| 2238 Per feedback that Items and Item are hard to distinguish between, the HT
ML5 spec renamed |
| 2239 DataTransferItems to DataTransferItemList: |
| 2240 http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the
-datatransferitemlist-interface |
| 2241 |
| 2242 Reviewed by Tony Chang. |
| 2243 |
| 2244 * CMakeLists.txt: |
| 2245 * CodeGenerators.pri: |
| 2246 * DerivedSources.cpp: |
| 2247 * DerivedSources.make: |
| 2248 * GNUmakefile.list.am: |
| 2249 * WebCore.gypi: |
| 2250 * WebCore.pro: |
| 2251 * WebCore.vcproj/WebCore.vcproj: |
| 2252 * WebCore.xcodeproj/project.pbxproj: |
| 2253 * dom/Clipboard.h: |
| 2254 * dom/Clipboard.idl: |
| 2255 * dom/DataTransferItemList.cpp: Renamed from Source/WebCore/dom/DataTran
sferItems.cpp. |
| 2256 (WebCore::DataTransferItemList::DataTransferItemList): |
| 2257 (WebCore::DataTransferItemList::length): |
| 2258 (WebCore::DataTransferItemList::item): |
| 2259 (WebCore::DataTransferItemList::deleteItem): |
| 2260 (WebCore::DataTransferItemList::clear): |
| 2261 (WebCore::DataTransferItemList::add): |
| 2262 * dom/DataTransferItemList.h: Renamed from Source/WebCore/dom/DataTransf
erItems.h. |
| 2263 (WebCore::DataTransferItemList::~DataTransferItemList): |
| 2264 * dom/DataTransferItemList.idl: Renamed from Source/WebCore/dom/DataTran
sferItems.idl. |
| 2265 * platform/chromium/ClipboardChromium.cpp: |
| 2266 (WebCore::ClipboardChromium::items): |
| 2267 * platform/chromium/ClipboardChromium.h: |
| 2268 * platform/chromium/DataTransferItemListChromium.cpp: Renamed from Sourc
e/WebCore/platform/chromium/DataTransferItemsChromium.cpp. |
| 2269 (WebCore::DataTransferItemListChromium::create): |
| 2270 (WebCore::DataTransferItemListChromium::DataTransferItemListChromium): |
| 2271 (WebCore::DataTransferItemListChromium::addPasteboardItem): |
| 2272 * platform/chromium/DataTransferItemListChromium.h: Renamed from Source/
WebCore/platform/chromium/DataTransferItemsChromium.h. |
| 2273 * platform/qt/ClipboardQt.cpp: |
| 2274 (WebCore::ClipboardQt::items): |
| 2275 * platform/qt/ClipboardQt.h: |
| 2276 * platform/qt/DataTransferItemListQt.cpp: Renamed from Source/WebCore/pl
atform/qt/DataTransferItemsQt.cpp. |
| 2277 (WebCore::DataTransferItemListQt::create): |
| 2278 (WebCore::DataTransferItemListQt::DataTransferItemListQt): |
| 2279 (WebCore::DataTransferItemListQt::addPasteboardItem): |
| 2280 * platform/qt/DataTransferItemListQt.h: Renamed from Source/WebCore/plat
form/qt/DataTransferItemsQt.h. |
| 2281 |
| 2282 2011-10-03 Robert Hogan <robert@webkit.org> |
| 2283 |
| 2284 CSS 2.1 failure: block-non-replaced-width-008.htm |
| 2285 https://bugs.webkit.org/show_bug.cgi?id=69278 |
| 2286 |
| 2287 Reviewed by Simon Fraser. |
| 2288 |
| 2289 * rendering/RenderBox.cpp: |
| 2290 (WebCore::RenderBox::computeLogicalWidthUsing): |
| 2291 Include the margins in the calculation of logical width even when the
containing block's |
| 2292 width is zero. This is required by section '10.3.3 Block-level, non-re
placed elements in |
| 2293 normal flow' in the CSS 2.1 spec. Tested by block-non-replaced-width-0
08.htm in the CSS |
| 2294 test suite. |
| 2295 |
| 2296 2011-10-29 Anna Cavender <annacc@chromium.org> |
| 2297 |
| 2298 Make sure TextTracks are destructed if HTMLMediaElement goes away. |
| 2299 https://bugs.webkit.org/show_bug.cgi?id=71148 |
| 2300 |
| 2301 Reviewed by Eric Carlson. |
| 2302 |
| 2303 Test: media/track/track-text-track-destructor-crash.html |
| 2304 |
| 2305 * html/HTMLMediaElement.cpp: |
| 2306 (WebCore::HTMLMediaElement::~HTMLMediaElement): |
| 2307 Destroy the client (this) on TextTracks. |
| 2308 (WebCore::HTMLMediaElement::loadTextTracks): |
| 2309 Move TextTrack creation to loadNextTextTrack. |
| 2310 (WebCore::HTMLMediaElement::loadNextTextTrack): |
| 2311 Keep track of new TextTrack in a list. |
| 2312 (WebCore::HTMLMediaElement::addTrack): |
| 2313 Keep track of new TextTrack in a list. |
| 2314 * html/HTMLMediaElement.h: |
| 2315 Add m_textTracks and loadNextTextTrack(). |
| 2316 |
| 2317 2011-10-29 Jochen Eisinger <jochen@chromium.org> |
| 2318 |
| 2319 Implement IDBFactory.deleteDatabase |
| 2320 https://bugs.webkit.org/show_bug.cgi?id=62622 |
| 2321 |
| 2322 Reviewed by Tony Chang. |
| 2323 |
| 2324 Tests: storage/indexeddb/factory-deletedatabase-interactions.html |
| 2325 storage/indexeddb/factory-deletedatabase.html |
| 2326 |
| 2327 * storage/IDBBackingStore.h: |
| 2328 * storage/IDBDatabaseBackendImpl.cpp: |
| 2329 (WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create): |
| 2330 (WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::callbacks): |
| 2331 (WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::PendingDeleteCall): |
| 2332 (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): |
| 2333 (WebCore::IDBDatabaseBackendImpl::openInternal): |
| 2334 (WebCore::IDBDatabaseBackendImpl::processPendingCalls): |
| 2335 (WebCore::IDBDatabaseBackendImpl::openConnection): |
| 2336 (WebCore::IDBDatabaseBackendImpl::deleteDatabase): |
| 2337 * storage/IDBDatabaseBackendImpl.h: |
| 2338 * storage/IDBFactory.cpp: |
| 2339 (WebCore::IDBFactory::deleteDatabase): |
| 2340 * storage/IDBFactory.h: |
| 2341 * storage/IDBFactory.idl: |
| 2342 * storage/IDBFactoryBackendImpl.cpp: |
| 2343 (WebCore::IDBFactoryBackendImpl::deleteDatabase): |
| 2344 * storage/IDBFactoryBackendImpl.h: |
| 2345 * storage/IDBFactoryBackendInterface.h: |
| 2346 * storage/IDBLevelDBBackingStore.cpp: |
| 2347 (WebCore::deleteRange): |
| 2348 (WebCore::IDBLevelDBBackingStore::deleteDatabase): |
| 2349 * storage/IDBLevelDBBackingStore.h: |
| 2350 * storage/IDBRequest.cpp: |
| 2351 (WebCore::IDBRequest::dispatchEvent): |
| 2352 |
| 2353 2011-10-28 Robert Hogan <robert@webkit.org> |
| 2354 |
| 2355 CSS 2.1 failure: dynamic-top-change-001 to 004 fail |
| 2356 https://bugs.webkit.org/show_bug.cgi?id=68149 |
| 2357 |
| 2358 Reviewed by David Hyatt. |
| 2359 |
| 2360 In these tests a child inherits its top value from its parent and the pa
rent's top value |
| 2361 is later updated by an onload event. The updated value is expected to ca
scade to the child. |
| 2362 |
| 2363 The tests were failing because updating the value did not cascade immedi
ately to the child inheriting it, though |
| 2364 it could be forced eventually with a full recalculation of the RenderSty
le by changing the zoom factor |
| 2365 or opening the inspector. |
| 2366 |
| 2367 The fix is to let the parent RenderStyle know that a child inherits a pr
operty explicitly and |
| 2368 recalculate children's style if the parent ever changes. This only happe
ns if the property is inherited |
| 2369 explicitly, it does not apply to cases where the property is inherited b
y default. |
| 2370 |
| 2371 * css/CSSStyleSelector.cpp: |
| 2372 (WebCore::CSSStyleSelector::applyProperty): |
| 2373 * dom/Node.cpp: |
| 2374 (WebCore::Node::diff): |
| 2375 * rendering/style/RenderStyle.cpp: |
| 2376 (WebCore::RenderStyle::RenderStyle): |
| 2377 * rendering/style/RenderStyle.h: |
| 2378 (WebCore::InheritedFlags::setHasExplicitlyInheritedProperties): |
| 2379 (WebCore::InheritedFlags::hasExplicitlyInheritedProperties): |
| 2380 |
| 2381 2011-10-29 Antti Koivisto <antti@apple.com> |
| 2382 |
| 2383 Tighten font change conditions in matched declaration cache |
| 2384 https://bugs.webkit.org/show_bug.cgi?id=71026 |
| 2385 |
| 2386 Reviewed by Darin Adler. |
| 2387 |
| 2388 We currently test if font description has changed to see if all properti
es need to be applied. However |
| 2389 only a few size related metrics can actually affect other properties. We
can just test those, making |
| 2390 the cache somewhat more effective while also making the equality test fa
ster. |
| 2391 |
| 2392 * css/CSSStyleSelector.cpp: |
| 2393 (WebCore::fontDifferenceAffectsNonInherited): |
| 2394 (WebCore::CSSStyleSelector::applyMatchedDeclarations): |
| 2395 |
| 2396 Test for text computedSize, xHeight and orientation only. Other text
properties don't affect computed |
| 2397 values of non-text CSS properties. |
| 2398 |
| 2399 2011-10-29 Adam Barth <abarth@webkit.org> |
| 2400 |
| 2401 DOMURL should keep its own state rather than storing it on ScriptExecuti
onContext |
| 2402 https://bugs.webkit.org/show_bug.cgi?id=71169 |
| 2403 |
| 2404 Reviewed by Eric Seidel. |
| 2405 |
| 2406 This patch untwists this code. I think this code was originally |
| 2407 twisted because these APIs moved onto DOMURL after they were first |
| 2408 implemented. |
| 2409 |
| 2410 * dom/ScriptExecutionContext.cpp: |
| 2411 (WebCore::ScriptExecutionContext::~ScriptExecutionContext): |
| 2412 * dom/ScriptExecutionContext.h: |
| 2413 * fileapi/FileWriter.h: |
| 2414 * html/DOMURL.cpp: |
| 2415 (WebCore::DOMURL::contextDestroyed): |
| 2416 (WebCore::DOMURL::createObjectURL): |
| 2417 (WebCore::DOMURL::revokeObjectURL): |
| 2418 * html/DOMURL.h: |
| 2419 |
| 2420 2011-10-29 Sheriff Bot <webkit.review.bot@gmail.com> |
| 2421 |
| 2422 Unreviewed, rolling out r98795. |
| 2423 http://trac.webkit.org/changeset/98795 |
| 2424 https://bugs.webkit.org/show_bug.cgi?id=71171 |
| 2425 |
| 2426 Causes worker tests to crash (Requested by abarth on #webkit). |
| 2427 |
| 2428 * dom/ActiveDOMObject.cpp: |
| 2429 (WebCore::ContextDestructionObserver::contextDestroyed): |
| 2430 * dom/MessagePort.cpp: |
| 2431 (WebCore::MessagePort::MessagePort): |
| 2432 (WebCore::MessagePort::contextDestroyed): |
| 2433 * dom/MessagePort.h: |
| 2434 * dom/ScriptExecutionContext.cpp: |
| 2435 (WebCore::ScriptExecutionContext::~ScriptExecutionContext): |
| 2436 (WebCore::ScriptExecutionContext::closeMessagePorts): |
| 2437 |
| 2438 2011-10-28 Ryosuke Niwa <rniwa@webkit.org> |
| 2439 |
| 2440 Potential crash in ReplaceNodeWithSpanCommand |
| 2441 https://bugs.webkit.org/show_bug.cgi?id=71145 |
| 2442 |
| 2443 Reviewed by Ojan Vafai. |
| 2444 |
| 2445 Fix a potential crash without tests because we don't have a reduction. |
| 2446 |
| 2447 * editing/ReplaceNodeWithSpanCommand.cpp: |
| 2448 (WebCore::swapInNodePreservingAttributesAndChildren): |
| 2449 |
| 2450 2011-10-28 Adam Barth <abarth@webkit.org> |
| 2451 |
| 2452 MessagePort should be a ContextDestructionObserver |
| 2453 https://bugs.webkit.org/show_bug.cgi?id=71167 |
| 2454 |
| 2455 Reviewed by Eric Seidel. |
| 2456 |
| 2457 I couldn't quite get rid of all the uses of the |
| 2458 ScriptExecutionContext::m_messagePorts in this patch. I hope to get |
| 2459 rid of them in the future as the "extra data" design for |
| 2460 ScriptExecutionContext emerges. |
| 2461 |
| 2462 * dom/ActiveDOMObject.cpp: |
| 2463 (WebCore::ContextDestructionObserver::contextDestroyed): |
| 2464 * dom/MessagePort.cpp: |
| 2465 (WebCore::MessagePort::MessagePort): |
| 2466 (WebCore::MessagePort::contextDestroyed): |
| 2467 * dom/MessagePort.h: |
| 2468 * dom/ScriptExecutionContext.cpp: |
| 2469 (WebCore::ScriptExecutionContext::~ScriptExecutionContext): |
| 2470 (WebCore::ScriptExecutionContext::closeMessagePorts): |
| 2471 |
| 2472 2011-10-28 Ryosuke Niwa <rniwa@webkit.org> |
| 2473 |
| 2474 The copy and paste result in nested scrollbars on http://dojotoolkit.org
/widgets |
| 2475 https://bugs.webkit.org/show_bug.cgi?id=70799 |
| 2476 |
| 2477 Reviewed by Enrica Casucci. |
| 2478 |
| 2479 The bug was caused by WebKit's treating a fully selected root with backg
round property as a special common ancestor. |
| 2480 A variant of this bug was caused by treating any element with text-decor
ation property as a presentational element. |
| 2481 |
| 2482 Fixed the above two bugs by not serializing the said nodes. The effectiv
e background color was already serialized |
| 2483 by wrappingStyleForSerialization, there was nothing to be done besides s
top including it in highestAncestorToWrapMarkup. |
| 2484 |
| 2485 For text-decoration property, added the logic to compute the effective v
alue in EditingStyle::init. Also treat it |
| 2486 as a non-inheritable editing property so that the rest of EditingStyle j
ust works. |
| 2487 |
| 2488 Test: editing/pasteboard/avoid-copying-body-with-background.html |
| 2489 |
| 2490 * editing/EditingStyle.cpp: Added CSSPropertyTextDecoration to the list
of editing properties. |
| 2491 (WebCore::copyEditingProperties): |
| 2492 (WebCore::EditingStyle::init): Compute the effective text decoration whe
n propertiesToInclude is |
| 2493 EditingPropertiesInEffect. |
| 2494 (WebCore::EditingStyle::prepareToApplyAt): |
| 2495 (WebCore::EditingStyle::mergeInlineStyleOfElement): |
| 2496 (WebCore::EditingStyle::wrappingStyleForSerialization): |
| 2497 (WebCore::EditingStyle::removeStyleFromRulesAndContext): |
| 2498 * editing/EditingStyle.h: Renamed EditingInheritablePropertiesAndBackgro
undColorInEffect to |
| 2499 EditingPropertiesInEffect. |
| 2500 * editing/markup.cpp: |
| 2501 (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): Removed an a
ssertion that's no longer valid. |
| 2502 (WebCore::isElementPresentational): Don't consider an element with text-
decoration as a presentational element. |
| 2503 (WebCore::highestAncestorToWrapMarkup): Don't consider fully selected ro
ot as a special common ancestor ever. |
| 2504 Background color is computed property when we compute the wrapping style
. |
| 2505 (WebCore::createMarkup): |
| 2506 |
| 2507 2011-10-28 Adam Barth <abarth@webkit.org> |
| 2508 |
| 2509 Rename ExceptionCodeDescription.in to DOMExceptions.in |
| 2510 https://bugs.webkit.org/show_bug.cgi?id=71157 |
| 2511 |
| 2512 Reviewed by Eric Seidel. |
| 2513 |
| 2514 This file is now used for more than just the descriptions of the excepti
ons. |
| 2515 |
| 2516 * CMakeLists.txt: |
| 2517 * CodeGenerators.pri: |
| 2518 * DerivedSources.make: |
| 2519 * GNUmakefile.am: |
| 2520 * WebCore.gyp/WebCore.gyp: |
| 2521 * WebCore.gyp/scripts/action_makenames.py: |
| 2522 * dom/DOMExceptions.in: Copied from Source/WebCore/dom/ExceptionCodeDesc
ription.in. |
| 2523 * dom/ExceptionCodeDescription.in: Removed. |
| 2524 * dom/make_dom_exceptions.pl: Copied from Source/WebCore/dom/make_except
ion_code_description.pl. |
| 2525 * dom/make_exception_code_description.pl: Removed. |
| 2526 |
| 2527 2011-10-28 Chris Rogers <crogers@google.com> |
| 2528 |
| 2529 SincResampler must be able to resample progressively |
| 2530 https://bugs.webkit.org/show_bug.cgi?id=71131 |
| 2531 |
| 2532 Reviewed by Kenneth Russell. |
| 2533 |
| 2534 No new tests. There is not yet an implementation using progressive resa
mpling to test. |
| 2535 |
| 2536 * platform/audio/SincResampler.cpp: |
| 2537 (WebCore::SincResampler::SincResampler): |
| 2538 (WebCore::SincResampler::consumeSource): |
| 2539 (WebCore::SincResampler::process): |
| 2540 * platform/audio/SincResampler.h: |
| 2541 |
| 2542 2011-10-28 Adam Klein <adamk@chromium.org> |
| 2543 |
| 2544 [MutationObservers] Support attributeOldValue for attribute mutations |
| 2545 https://bugs.webkit.org/show_bug.cgi?id=70861 |
| 2546 |
| 2547 Reviewed by Ryosuke Niwa. |
| 2548 |
| 2549 Respect 'attributeOldValue' when passed to WebKitMutationObserver.observ
e(). |
| 2550 |
| 2551 If multiple observers have different attributeOldValue settings in |
| 2552 their registrations, two different MutationRecords are created (one is |
| 2553 a wrapper around the other). |
| 2554 |
| 2555 If a single observer has multiple registrations that apply to a single |
| 2556 mutation, and those registrations have different values for |
| 2557 attributeOldValue, the observer is passed the oldValue. |
| 2558 |
| 2559 * dom/Element.cpp: |
| 2560 (WebCore::hasOldValue): |
| 2561 (WebCore::enqueueAttributesMutationRecord): |
| 2562 (WebCore::Element::setAttribute): |
| 2563 * dom/MutationRecord.cpp: |
| 2564 (WebCore::MutationRecord::createAttributes): |
| 2565 (WebCore::MutationRecord::createWithNullOldValue): |
| 2566 * dom/MutationRecord.h: |
| 2567 (WebCore::MutationRecord::oldValue): |
| 2568 |
| 2569 2011-10-28 Adam Barth <abarth@webkit.org> |
| 2570 |
| 2571 Delete ExceptionCode.cpp, which is empty |
| 2572 https://bugs.webkit.org/show_bug.cgi?id=71159 |
| 2573 |
| 2574 Reviewed by Eric Seidel. |
| 2575 |
| 2576 This file has been stripped down to nothing and can be removed. |
| 2577 |
| 2578 * CMakeLists.txt: |
| 2579 * GNUmakefile.list.am: |
| 2580 * WebCore.gypi: |
| 2581 * WebCore.pro: |
| 2582 * WebCore.vcproj/WebCore.vcproj: |
| 2583 * WebCore.xcodeproj/project.pbxproj: |
| 2584 * dom/DOMAllInOne.cpp: |
| 2585 * dom/ExceptionCode.cpp: Removed. |
| 2586 |
| 2587 2011-10-28 Sheriff Bot <webkit.review.bot@gmail.com> |
| 2588 |
| 2589 Unreviewed, rolling out r98776. |
| 2590 http://trac.webkit.org/changeset/98776 |
| 2591 https://bugs.webkit.org/show_bug.cgi?id=71164 |
| 2592 |
| 2593 caused lots of test crashes (Requested by smfr on #webkit). |
| 2594 |
| 2595 * rendering/RenderLayer.cpp: |
| 2596 (WebCore::RenderLayer::updateVisibilityStatus): |
| 2597 (WebCore::RenderLayer::dirtyZOrderLists): |
| 2598 * rendering/RenderLayer.h: |
| 2599 * rendering/RenderLayerCompositor.cpp: |
| 2600 (WebCore::RenderLayerCompositor::enableCompositingMode): |
| 2601 |
| 2602 2011-10-28 John Sullivan <sullivan@apple.com> |
| 2603 |
| 2604 Improvement to the fix for: |
| 2605 https://bugs.webkit.org/show_bug.cgi?id=71142 |
| 2606 Whether backspace goes Back should be configurable |
| 2607 |
| 2608 Reviewed by Dan Bernstein. |
| 2609 |
| 2610 * page/EventHandler.cpp: |
| 2611 (WebCore::EventHandler::defaultBackspaceEventHandler): |
| 2612 Do the frame->settings() check after the !page check, since |
| 2613 a null page means null settings. |
| 2614 |
| 2615 2011-10-28 Adam Barth <abarth@webkit.org> |
| 2616 |
| 2617 Make DOMURL a ContextDestructionObserver |
| 2618 https://bugs.webkit.org/show_bug.cgi?id=71162 |
| 2619 |
| 2620 Reviewed by Eric Seidel. |
| 2621 |
| 2622 This removes a bunch of hand-rolled ifdefed code. |
| 2623 |
| 2624 * dom/ActiveDOMObject.h: |
| 2625 - One-argument constructors should be explicit. |
| 2626 * dom/ScriptExecutionContext.cpp: |
| 2627 (WebCore::ScriptExecutionContext::~ScriptExecutionContext): |
| 2628 * dom/ScriptExecutionContext.h: |
| 2629 * html/DOMURL.cpp: |
| 2630 (WebCore::DOMURL::DOMURL): |
| 2631 (WebCore::DOMURL::~DOMURL): |
| 2632 * html/DOMURL.h: |
| 2633 |
| 2634 2011-10-28 Adam Barth <abarth@webkit.org> |
| 2635 |
| 2636 Factor ContextDestructionObserver out of ActiveDOMObject |
| 2637 https://bugs.webkit.org/show_bug.cgi?id=71153 |
| 2638 |
| 2639 Reviewed by Sam Weinig. |
| 2640 |
| 2641 This patch paves the way to make more objects observe the destruction |
| 2642 of ScriptExecutioContext without needing to add ifdefs to |
| 2643 ScriptExecutionContext.h/cpp. (As an example, see DOMURL.) |
| 2644 |
| 2645 * dom/ActiveDOMObject.cpp: |
| 2646 (WebCore::ContextDestructionObserver::ContextDestructionObserver): |
| 2647 (WebCore::ContextDestructionObserver::~ContextDestructionObserver): |
| 2648 (WebCore::ContextDestructionObserver::contextDestroyed): |
| 2649 (WebCore::ActiveDOMObject::ActiveDOMObject): |
| 2650 (WebCore::ActiveDOMObject::~ActiveDOMObject): |
| 2651 * dom/ActiveDOMObject.h: |
| 2652 (WebCore::ContextDestructionObserver::scriptExecutionContext): |
| 2653 * dom/ScriptExecutionContext.cpp: |
| 2654 (WebCore::ScriptExecutionContext::~ScriptExecutionContext): |
| 2655 (WebCore::ScriptExecutionContext::didCreateActiveDOMObject): |
| 2656 (WebCore::ScriptExecutionContext::willDestroyActiveDOMObject): |
| 2657 (WebCore::didCreateDestructionObserver): |
| 2658 (WebCore::willDestroyDestructionObserver): |
| 2659 * dom/ScriptExecutionContext.h: |
| 2660 |
| 2661 2011-10-28 Tim Horton <timothy_horton@apple.com> |
| 2662 |
| 2663 One more unreviewed build fix due to r98775. |
| 2664 |
| 2665 No new tests. |
| 2666 |
| 2667 * WebCore.vcproj/WebCore.vcproj: |
| 2668 |
| 2669 2011-10-28 James Robinson <jamesr@chromium.org> |
| 2670 |
| 2671 [chromium] Track wheel event handler registration and pass to input filt
er |
| 2672 https://bugs.webkit.org/show_bug.cgi?id=71078 |
| 2673 |
| 2674 Reviewed by Kenneth Russell. |
| 2675 |
| 2676 This propagates mouse wheel registration notifications to the compositor
input filter. If there are any handlers |
| 2677 registered, which includes JS handlers and scrollable areas other than t
he main view, the input filter will pass |
| 2678 mouse wheel events to the widget. Otherwise when threaded compositing is
enabled the input filter translates |
| 2679 wheel events into root layer scrolling. |
| 2680 |
| 2681 Only changes behavior with an off-by-default flag enabled, so no tests. |
| 2682 |
| 2683 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
| 2684 (WebCore::CCLayerTreeHost::CCLayerTreeHost): |
| 2685 (WebCore::CCLayerTreeHost::finishCommitOnImplThread): |
| 2686 (WebCore::CCLayerTreeHost::setHaveWheelEventHandlers): |
| 2687 * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
| 2688 * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: |
| 2689 (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): |
| 2690 (WebCore::CCLayerTreeHostImpl::haveWheelEventHandlers): |
| 2691 * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: |
| 2692 (WebCore::CCLayerTreeHostImpl::setHaveWheelEventHandlers): |
| 2693 * platform/graphics/chromium/cc/CCScrollController.h: |
| 2694 |
| 2695 2011-10-28 Tim Horton <timothy_horton@apple.com> |
| 2696 |
| 2697 Unreviewed build fix due to r98775. |
| 2698 |
| 2699 No new tests. |
| 2700 |
| 2701 * CMakeLists.txt: |
| 2702 * GNUmakefile.list.am: |
| 2703 * WebCore.gypi: |
| 2704 * WebCore.pro: |
| 2705 |
| 2706 2011-10-28 Simon Fraser <simon.fraser@apple.com> |
| 2707 |
| 2708 If visibility changes while an accelerated animation is running, element
jumps around |
| 2709 https://bugs.webkit.org/show_bug.cgi?id=29984 |
| 2710 |
| 2711 Reviewed by Chris Marrin. |
| 2712 |
| 2713 Compositing now affects whether RenderLayers for visibility:hidden eleme
nts |
| 2714 are included in z-order lists. So we have to dirty those lists when we e
nter |
| 2715 compopsiting mode. |
| 2716 |
| 2717 Test: compositing/visibility/animation-visibility.html |
| 2718 |
| 2719 * rendering/RenderLayer.cpp: |
| 2720 (WebCore::RenderLayer::updateVisibilityStatus): Removed trailing whitesp
ace. |
| 2721 (WebCore::RenderLayer::dirtyZOrderLists): Call dirtyZOrderListsInternal(
), which doesn't have |
| 2722 to ping the compositor. |
| 2723 (WebCore::RenderLayer::dirtyZOrderListsInternal): |
| 2724 (WebCore::RenderLayer::dirtyZOrderListsIncludingDescendants): Recursivel
y dirty z-order |
| 2725 lists. |
| 2726 * rendering/RenderLayer.h: |
| 2727 * rendering/RenderLayerCompositor.cpp: |
| 2728 (WebCore::RenderLayerCompositor::enableCompositingMode): When going into
compositing mode, |
| 2729 dirty all z-order lists. |
| 2730 |
| 2731 2011-10-28 Tim Horton <timothy_horton@apple.com> |
| 2732 |
| 2733 Implement CSS3 Images cross-fade() image function |
| 2734 https://bugs.webkit.org/show_bug.cgi?id=52162 |
| 2735 <rdar://problem/10209254> |
| 2736 |
| 2737 Reviewed by Simon Fraser. |
| 2738 |
| 2739 Parse -webkit-cross-fade according to the CSS3 Images Values specificati
on. |
| 2740 |
| 2741 Also, adjust other CSS parsing functions to support nested functions, by
using a specific CSS value list |
| 2742 instead of the global one. This allows - for example - cross-fade to pas
s each of its arguments back into |
| 2743 parseFillImage and to successfully parse image functions in this fashion
. |
| 2744 |
| 2745 Test: fast/css/getComputedStyle/computed-style-cross-fade.html |
| 2746 |
| 2747 * WebCore.xcodeproj/project.pbxproj: |
| 2748 * css/CSSCrossfadeValue.cpp: Added. |
| 2749 (WebCore::CSSCrossfadeValue::~CSSCrossfadeValue): |
| 2750 (WebCore::CSSCrossfadeValue::cssText): |
| 2751 (WebCore::CSSCrossfadeValue::fixedSize): |
| 2752 (WebCore::CSSCrossfadeValue::image): |
| 2753 * css/CSSCrossfadeValue.h: Added. |
| 2754 (WebCore::CSSCrossfadeValue::create): |
| 2755 (WebCore::CSSCrossfadeValue::isFixedSize): |
| 2756 (WebCore::CSSCrossfadeValue::setFromImage): |
| 2757 (WebCore::CSSCrossfadeValue::setToImage): |
| 2758 (WebCore::CSSCrossfadeValue::setPercentage): |
| 2759 (WebCore::CSSCrossfadeValue::CSSCrossfadeValue): |
| 2760 * css/CSSParser.cpp: |
| 2761 (WebCore::CSSParser::parseValue): |
| 2762 (WebCore::CSSParser::parseContent): |
| 2763 (WebCore::CSSParser::parseFillImage): |
| 2764 (WebCore::CSSParser::parseFillProperty): |
| 2765 (WebCore::CSSParser::parseBorderImage): |
| 2766 (WebCore::CSSParser::parseDeprecatedGradient): |
| 2767 (WebCore::CSSParser::parseLinearGradient): |
| 2768 (WebCore::CSSParser::parseRadialGradient): |
| 2769 (WebCore::CSSParser::isGeneratedImageValue): |
| 2770 (WebCore::CSSParser::parseGeneratedImage): |
| 2771 (WebCore::CSSParser::parseCrossfade): |
| 2772 (WebCore::CSSParser::parseCanvas): |
| 2773 * css/CSSParser.h: |
| 2774 |
| 2775 2011-10-28 Dan Bernstein <mitz@apple.com> |
| 2776 |
| 2777 Attempted build fix after r98765. |
| 2778 |
| 2779 * platform/graphics/mac/SimpleFontDataMac.mm: |
| 2780 (WebCore::SimpleFontData::platformWidthForGlyph): |
| 2781 |
| 2782 2011-10-28 Chris Marrin <cmarrin@apple.com> |
| 2783 |
| 2784 CSS grammar doesn't support functions with no parameters |
| 2785 https://bugs.webkit.org/show_bug.cgi?id=69110 |
| 2786 |
| 2787 Reviewed by Dean Jackson. |
| 2788 |
| 2789 Add rule to grammar to accept functions with 0 args and return |
| 2790 this case with a CSSParserValueList with 0 values. Also fixed |
| 2791 filter creation function to properly handle filters with 0 |
| 2792 arguments. |
| 2793 |
| 2794 * css/CSSGrammar.y: |
| 2795 * css/CSSStyleSelector.cpp: |
| 2796 (WebCore::CSSStyleSelector::createFilterOperations): |
| 2797 |
| 2798 2011-10-28 Sheriff Bot <webkit.review.bot@gmail.com> |
| 2799 |
| 2800 Unreviewed, rolling out r98757. |
| 2801 http://trac.webkit.org/changeset/98757 |
| 2802 https://bugs.webkit.org/show_bug.cgi?id=71150 |
| 2803 |
| 2804 crashes webkit_unit_tests on chromium windows (Requested by |
| 2805 johnny_g on #webkit). |
| 2806 |
| 2807 * platform/graphics/chromium/LayerRendererChromium.cpp: |
| 2808 (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces): |
| 2809 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
| 2810 (WebCore::CCLayerTreeHost::paintLayerContents): |
| 2811 (WebCore::CCLayerTreeHost::updateCompositorResources): |
| 2812 * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: |
| 2813 (WebCore::calculateDrawTransformsAndVisibilityInternal): |
| 2814 |
| 2815 2011-10-28 Adam Barth <abarth@webkit.org> |
| 2816 |
| 2817 Rubber-stamped by Eric Seidel. |
| 2818 |
| 2819 Fix namespace indent in ScriptExecutionContext.h. |
| 2820 |
| 2821 * dom/ScriptExecutionContext.h: |
| 2822 (WebCore::ScriptExecutionContext::isDocument): |
| 2823 (WebCore::ScriptExecutionContext::isWorkerContext): |
| 2824 (WebCore::ScriptExecutionContext::setHasOpenDatabases): |
| 2825 (WebCore::ScriptExecutionContext::hasOpenDatabases): |
| 2826 (WebCore::ScriptExecutionContext::url): |
| 2827 (WebCore::ScriptExecutionContext::completeURL): |
| 2828 (WebCore::ScriptExecutionContext::securityOrigin): |
| 2829 (WebCore::ScriptExecutionContext::contentSecurityPolicy): |
| 2830 (WebCore::ScriptExecutionContext::activeDOMObjects): |
| 2831 (WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCall
backs): |
| 2832 (WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallb
acks): |
| 2833 (WebCore::ScriptExecutionContext::messagePorts): |
| 2834 (WebCore::ScriptExecutionContext::domUrls): |
| 2835 (WebCore::ScriptExecutionContext::ref): |
| 2836 (WebCore::ScriptExecutionContext::deref): |
| 2837 (WebCore::ScriptExecutionContext::Task::Task): |
| 2838 (WebCore::ScriptExecutionContext::Task::isCleanupTask): |
| 2839 |
| 2840 2011-10-28 John Sullivan <sullivan@apple.com> |
| 2841 |
| 2842 WebCore part of: |
| 2843 https://bugs.webkit.org/show_bug.cgi?id=71142 |
| 2844 Whether backspace goes Back should be configurable |
| 2845 |
| 2846 Reviewed by Sam Weinig. |
| 2847 |
| 2848 * page/EventHandler.cpp: |
| 2849 (WebCore::EventHandler::defaultBackspaceEventHandler): |
| 2850 Bail out if backspace navigation is not enabled. |
| 2851 |
| 2852 * page/Settings.cpp: |
| 2853 (WebCore::Settings::Settings): |
| 2854 Initialize m_backspaceKeyNavigationEnabled to true to match current beha
vior. |
| 2855 |
| 2856 * page/Settings.h: |
| 2857 Declared m_backspaceKeyNavigationEnabled. |
| 2858 (WebCore::Settings::setBackspaceKeyNavigationEnabled): |
| 2859 New function, simple setter. |
| 2860 (WebCore::Settings::backspaceKeyNavigationEnabled): |
| 2861 New function, simple getter. |
| 2862 |
| 2863 2011-10-28 Emil A Eklund <eae@chromium.org> |
| 2864 |
| 2865 Overridden clippedOverflowRectForRepaint() still uses IntRects |
| 2866 https://bugs.webkit.org/show_bug.cgi?id=71046 |
| 2867 |
| 2868 Reviewed by Simon Fraser. |
| 2869 |
| 2870 Change all virtual clippedOverflowRectForRepaint functions to use the |
| 2871 same signature. |
| 2872 |
| 2873 No new tests. |
| 2874 |
| 2875 * rendering/RenderObject.cpp: |
| 2876 (WebCore::RenderObject::rectWithOutlineForRepaint): |
| 2877 (WebCore::RenderObject::clippedOverflowRectForRepaint): |
| 2878 * rendering/RenderObject.h: |
| 2879 * rendering/RenderReplaced.cpp: |
| 2880 (WebCore::RenderReplaced::clippedOverflowRectForRepaint): |
| 2881 * rendering/RenderReplaced.h: |
| 2882 * rendering/RenderTableCell.cpp: |
| 2883 (WebCore::RenderTableCell::clippedOverflowRectForRepaint): |
| 2884 * rendering/RenderTableCell.h: |
| 2885 * rendering/RenderTableCol.cpp: |
| 2886 (WebCore::RenderTableCol::clippedOverflowRectForRepaint): |
| 2887 * rendering/RenderTableCol.h: |
| 2888 * rendering/RenderTableRow.cpp: |
| 2889 (WebCore::RenderTableRow::clippedOverflowRectForRepaint): |
| 2890 * rendering/RenderTableRow.h: |
| 2891 * rendering/RenderText.cpp: |
| 2892 (WebCore::RenderText::clippedOverflowRectForRepaint): |
| 2893 * rendering/RenderText.h: |
| 2894 |
| 2895 2011-10-28 Adam Klein <adamk@chromium.org> |
| 2896 |
| 2897 Remove unused parsers for 'exception' and 'alias' IDL keywords |
| 2898 https://bugs.webkit.org/show_bug.cgi?id=71140 |
| 2899 |
| 2900 Reviewed by Adam Barth. |
| 2901 |
| 2902 * bindings/scripts/IDLParser.pm: |
| 2903 (ParseInterface): |
| 2904 (DetermineParseMode): |
| 2905 (ProcessSection): |
| 2906 * bindings/scripts/IDLStructure.pm: |
| 2907 |
| 2908 2011-10-28 Dan Bernstein <mitz@apple.com> |
| 2909 |
| 2910 <rdar://problem/10288006> Emoji characters are too close to each other i
n small font size |
| 2911 |
| 2912 Reviewed by Sam Weinig. |
| 2913 |
| 2914 * platform/graphics/mac/SimpleFontDataMac.mm: |
| 2915 (WebCore::SimpleFontData::platformWidthForGlyph): If the font is a color
bitmap font, use |
| 2916 -[NSFont advancementForGlyph:] instead of wkGetGlyphTransformedAdvances(
). |
| 2917 |
| 2918 2011-10-28 Adam Barth <abarth@webkit.org> |
| 2919 |
| 2920 Remove unused default constructor |
| 2921 https://bugs.webkit.org/show_bug.cgi?id=71136 |
| 2922 |
| 2923 Reviewed by Eric Seidel. |
| 2924 |
| 2925 No one is calling this constructor anymore now that we've fixed the |
| 2926 callers. |
| 2927 |
| 2928 * dom/make_exception_code_description.pl: |
| 2929 (generateHeader): |
| 2930 |
| 2931 2011-10-28 Ken Buchanan <kenrb@chromium.org> |
| 2932 |
| 2933 Crash when splitting inline flows with generated floats |
| 2934 https://bugs.webkit.org/show_bug.cgi?id=70458 |
| 2935 |
| 2936 Reviewed by David Hyatt. |
| 2937 |
| 2938 When lineBoxes on a RenderBlock are being deleted, we now check the floa
ting object list to |
| 2939 ensure references to them are being cleared. |
| 2940 |
| 2941 * rendering/RenderBlock.cpp: |
| 2942 (WebCore::RenderBlock::deleteLineBoxTree): Remove references to lineBox
when deleting them |
| 2943 |
| 2944 2011-10-28 Simon Fraser <simon.fraser@apple.com> |
| 2945 |
| 2946 Remove Leopard-only code from GraphicsLayerCA |
| 2947 https://bugs.webkit.org/show_bug.cgi?id=71141 |
| 2948 |
| 2949 Reviewed by Chris Marrin. |
| 2950 |
| 2951 Remove !HAVE_MODERN_QUARTZCORE code, which was only |
| 2952 used on Leopard. updateContentsTransform() became a no-op, |
| 2953 so could be removed. |
| 2954 |
| 2955 * platform/graphics/ca/GraphicsLayerCA.cpp: |
| 2956 (WebCore::getValueFunctionNameForTransformOperation): |
| 2957 (WebCore::GraphicsLayerCA::GraphicsLayerCA): |
| 2958 (WebCore::GraphicsLayerCA::addAnimation): |
| 2959 (WebCore::GraphicsLayerCA::updateGeometry): |
| 2960 (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints): |
| 2961 (WebCore::GraphicsLayerCA::setTransformAnimationKeyframes): |
| 2962 (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): |
| 2963 (WebCore::GraphicsLayerCA::defaultContentsOrientation): |
| 2964 (WebCore::GraphicsLayerCA::updateOpacityOnLayer): |
| 2965 * platform/graphics/ca/GraphicsLayerCA.h: |
| 2966 |
| 2967 2011-10-28 Adrienne Walker <enne@google.com> |
| 2968 |
| 2969 [chromium] Implicitly skip render surfaces that won't be drawn |
| 2970 https://bugs.webkit.org/show_bug.cgi?id=71038 |
| 2971 |
| 2972 Rather than having redundant checks in three places for how to walk |
| 2973 through a render surface list, instead don't add render surfaces that |
| 2974 don't need to get rendered to the render surface list. |
| 2975 |
| 2976 Reviewed by James Robinson. |
| 2977 |
| 2978 Covered by existing layout tests. |
| 2979 |
| 2980 * platform/graphics/chromium/LayerRendererChromium.cpp: |
| 2981 (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces): |
| 2982 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
| 2983 (WebCore::CCLayerTreeHost::paintLayerContents): |
| 2984 (WebCore::CCLayerTreeHost::updateCompositorResources): |
| 2985 * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: |
| 2986 (WebCore::calculateDrawTransformsAndVisibilityInternal): |
| 2987 |
| 2988 2011-10-28 Adam Barth <abarth@webkit.org> |
| 2989 |
| 2990 Autogenerate Exception-downcast code in bindings |
| 2991 https://bugs.webkit.org/show_bug.cgi?id=71108 |
| 2992 |
| 2993 Reviewed by Eric Seidel. |
| 2994 |
| 2995 This patch uses the same generated code style as we're using for Events |
| 2996 to generate the downcasts for the Exception types in the bindings. |
| 2997 This cause me to refactor more code from make_event_factory.pl into |
| 2998 InFilesCompiler.pm. |
| 2999 |
| 3000 After this patch, some of these files and scripts are misnamed. I'll |
| 3001 rename them in a followup patch. |
| 3002 |
| 3003 * DerivedSources.make: |
| 3004 * GNUmakefile.am: |
| 3005 * GNUmakefile.list.am: |
| 3006 * WebCore.gyp/WebCore.gyp: |
| 3007 * WebCore.gypi: |
| 3008 * WebCore.vcproj/WebCore.vcproj: |
| 3009 * WebCore.xcodeproj/project.pbxproj: |
| 3010 * bindings/js/JSDOMBinding.cpp: |
| 3011 (WebCore::setDOMException): |
| 3012 * bindings/objc/ExceptionHandlers.mm: |
| 3013 (WebCore::raiseDOMException): |
| 3014 * bindings/scripts/InFilesCompiler.pm: |
| 3015 (initializeFromCommandLine): |
| 3016 (compile): |
| 3017 (interfaceForItem): |
| 3018 (toMacroStyle): |
| 3019 (generateInterfacesHeader): |
| 3020 (generateHeadersHeader): |
| 3021 * bindings/v8/V8Proxy.cpp: |
| 3022 (WebCore::V8Proxy::setDOMException): |
| 3023 * dom/ExceptionCodeDescription.in: |
| 3024 * dom/make_event_factory.pl: |
| 3025 (generateCode): |
| 3026 (generateImplementation): |
| 3027 * dom/make_exception_code_description.pl: |
| 3028 (defaultItemFactory): |
| 3029 (generateCode): |
| 3030 |
| 3031 2011-10-28 Simon Fraser <simon.fraser@apple.com> |
| 3032 |
| 3033 Fix builds which have ACCELERATED_COMPOSITING disabled. |
| 3034 |
| 3035 * rendering/RenderLayer.cpp: |
| 3036 (WebCore::RenderLayer::updateZOrderLists): |
| 3037 |
| 3038 2011-10-28 Erik Arvidsson <arv@chromium.org> |
| 3039 |
| 3040 Remove LegacyDefaultOptionalArguments flag from inspector IDLs |
| 3041 https://bugs.webkit.org/show_bug.cgi?id=65748 |
| 3042 |
| 3043 Reviewed by Adam Barth. |
| 3044 |
| 3045 Covered by existing tests. |
| 3046 |
| 3047 * inspector/InjectedScriptHost.idl: |
| 3048 * inspector/InspectorFrontendHost.idl: |
| 3049 * inspector/JavaScriptCallFrame.idl: |
| 3050 |
| 3051 2011-10-28 Joshua Bell <jsbell@chromium.org> |
| 3052 |
| 3053 IndexedDB: Database metadata changes should be tied to transaction |
| 3054 https://bugs.webkit.org/show_bug.cgi?id=70974 |
| 3055 |
| 3056 Reviewed by Tony Chang. |
| 3057 |
| 3058 Database metadata (that is, the version string) was rolled back |
| 3059 on abort by an abort task. If the abort task didn't run e.g. |
| 3060 due to a crash, the metadata would not be reverted. All of the |
| 3061 other store/index/data changes were written into the transaction |
| 3062 itself, so the metadata now is too. Refactored the metadata |
| 3063 get/create/update methods for clarity as well. |
| 3064 |
| 3065 Note that the new tests don't actually verify that the code handles |
| 3066 this case; that will need to be done with persistence tests |
| 3067 that span multiple runs of the browser and induce crashes. |
| 3068 The new tests do verify that these changes don't cause regressions |
| 3069 not caught by other tests. |
| 3070 |
| 3071 Tests: storage/indexeddb/open-during-transaction.html |
| 3072 storage/indexeddb/version-change-abort.html |
| 3073 |
| 3074 * storage/IDBBackingStore.h: |
| 3075 * storage/IDBDatabaseBackendImpl.cpp: |
| 3076 (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): |
| 3077 (WebCore::IDBDatabaseBackendImpl::setVersionInternal): |
| 3078 * storage/IDBLevelDBBackingStore.cpp: |
| 3079 (WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData): |
| 3080 (WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData): |
| 3081 (WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData): |
| 3082 * storage/IDBLevelDBBackingStore.h: |
| 3083 |
| 3084 2011-10-28 Luke Macpherson <macpherson@chromium.org> |
| 3085 |
| 3086 Use enum instead of bool to represent -webkit-column-span property. |
| 3087 https://bugs.webkit.org/show_bug.cgi?id=70867 |
| 3088 |
| 3089 Reviewed by Darin Adler. |
| 3090 |
| 3091 Covered by existing tests. |
| 3092 |
| 3093 * css/CSSPrimitiveValueMappings.h: |
| 3094 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): |
| 3095 (WebCore::CSSPrimitiveValue::operator ColumnSpan): |
| 3096 * css/CSSStyleSelector.cpp: |
| 3097 (WebCore::CSSStyleSelector::applyProperty): |
| 3098 * rendering/RenderBlock.cpp: |
| 3099 (WebCore::RenderBlock::createAnonymousColumnSpanBlock): |
| 3100 * rendering/RenderObject.cpp: |
| 3101 (WebCore::RenderObject::propagateStyleToAnonymousChildren): |
| 3102 * rendering/style/RenderStyle.h: |
| 3103 (WebCore::InheritedFlags::columnSpan): |
| 3104 (WebCore::InheritedFlags::setColumnSpan): |
| 3105 (WebCore::InheritedFlags::initialColumnSpan): |
| 3106 * rendering/style/RenderStyleConstants.h: |
| 3107 * rendering/style/StyleMultiColData.h: |
| 3108 |
| 3109 2011-10-28 Mark Hahnenberg <mhahnenberg@apple.com> |
| 3110 |
| 3111 De-virtualize isGlobalObject, isVariableObject, isActivationObject, and
isErrorInstance in JSObject |
| 3112 https://bugs.webkit.org/show_bug.cgi?id=70968 |
| 3113 |
| 3114 Reviewed by Geoffrey Garen. |
| 3115 |
| 3116 No new tests. |
| 3117 |
| 3118 * bindings/js/JSDOMGlobalObject.h: Changed JSType provided to TypeInfo i
n createStructure since this |
| 3119 class inherits from JSGlobalObject. |
| 3120 (WebCore::JSDOMGlobalObject::createStructure): |
| 3121 * bindings/js/JSDOMWindowBase.h: Ditto |
| 3122 (WebCore::JSDOMWindowBase::createStructure): |
| 3123 * bindings/js/JSWorkerContextBase.h: Ditto |
| 3124 (WebCore::JSWorkerContextBase::createStructure): |
| 3125 * bindings/scripts/CodeGeneratorJS.pm: Added extra check to make sure su
bclasses of JSGlobalObject, |
| 3126 namely JSDOMWindow and JSWorkerContext, get their special JSType in thei
r createStructure function. |
| 3127 (GenerateHeader): |
| 3128 |
| 3129 2011-10-28 Sheriff Bot <webkit.review.bot@gmail.com> |
| 3130 |
| 3131 Unreviewed, rolling out r98736. |
| 3132 http://trac.webkit.org/changeset/98736 |
| 3133 https://bugs.webkit.org/show_bug.cgi?id=71125 |
| 3134 |
| 3135 This patch broke perf/array-binary-search.html test (Requested |
| 3136 by annacc on #webkit). |
| 3137 |
| 3138 * html/HTMLMediaElement.cpp: |
| 3139 (WebCore::HTMLMediaElement::loadTextTracks): |
| 3140 (WebCore::HTMLMediaElement::addTrack): |
| 3141 * html/HTMLMediaElement.h: |
| 3142 * html/HTMLTrackElement.cpp: |
| 3143 (WebCore::HTMLTrackElement::insertedIntoTree): |
| 3144 (WebCore::HTMLTrackElement::willRemove): |
| 3145 * html/HTMLTrackElement.h: |
| 3146 * html/LoadableTextTrack.cpp: |
| 3147 (WebCore::LoadableTextTrack::cueLoadingCompleted): |
| 3148 |
| 3149 2011-10-28 Julien Chaffraix <jchaffraix@webkit.org> |
| 3150 |
| 3151 RenderTableSection::recalcCells should not free its grid |
| 3152 https://bugs.webkit.org/show_bug.cgi?id=71056 |
| 3153 |
| 3154 Reviewed by Darin Adler. |
| 3155 |
| 3156 Refactoring only, no change in behavior. |
| 3157 |
| 3158 r98614 had the bad side effect of clearing the row vector (m_grid) on |
| 3159 the RenderTableSection when doing a recalcCells. This change removes the |
| 3160 unneeded free and inline the |row| field into the RowStruct as it made |
| 3161 no sense to have it as a pointer. |
| 3162 |
| 3163 * rendering/RenderTableSection.cpp: |
| 3164 (WebCore::setRowLogicalHeightToRowStyleLogicalHeightIfNotRelative): |
| 3165 (WebCore::RenderTableSection::addChild): |
| 3166 (WebCore::RenderTableSection::setCellLogicalWidths): |
| 3167 (WebCore::RenderTableSection::calcRowLogicalHeight): |
| 3168 (WebCore::RenderTableSection::firstLineBoxBaseline): |
| 3169 (WebCore::RenderTableSection::appendColumn): |
| 3170 (WebCore::RenderTableSection::splitColumn): |
| 3171 Mechanical changes now that |row| is a member of RowStruct. |
| 3172 |
| 3173 (WebCore::RenderTableSection::~RenderTableSection): Clear our row vector
. |
| 3174 |
| 3175 (WebCore::RenderTableSection::ensureRows): |
| 3176 (WebCore::RenderTableSection::recalcCells): |
| 3177 Those 2 functions were refactored to use fillRowsWithDefaultStartingAtPo
sition. |
| 3178 |
| 3179 (WebCore::RenderTableSection::fillRowsWithDefaultStartingAtPosition): |
| 3180 Factored the code to fill the RowStruct structure with default values. |
| 3181 |
| 3182 * rendering/RenderTableSection.h: |
| 3183 (WebCore::RenderTableSection::cellAt): |
| 3184 (WebCore::RenderTableSection::primaryCellAt): |
| 3185 More mechanical change after the |row| field change. |
| 3186 |
| 3187 2011-10-28 Anna Cavender <annacc@chromium.org> |
| 3188 |
| 3189 Implement load notification and events for <track>. |
| 3190 https://bugs.webkit.org/show_bug.cgi?id=71054 |
| 3191 |
| 3192 Reviewed by Eric Carlson. |
| 3193 |
| 3194 Tests: media/track/track-load-error-readyState.html |
| 3195 media/track/track-load-from-element-readyState.html |
| 3196 media/track/track-load-from-src-readyState.html |
| 3197 |
| 3198 * html/HTMLMediaElement.cpp: |
| 3199 (WebCore::HTMLMediaElement::loadTextTracks): |
| 3200 (WebCore::HTMLMediaElement::loadNextTextTrack): |
| 3201 (WebCore::HTMLMediaElement::trackWasAdded): |
| 3202 (WebCore::HTMLMediaElement::trackWillBeRemoved): |
| 3203 (WebCore::HTMLMediaElement::trackSourceChanged): |
| 3204 * html/HTMLMediaElement.h: |
| 3205 * html/HTMLTrackElement.cpp: |
| 3206 (WebCore::HTMLTrackElement::insertedIntoTree): |
| 3207 (WebCore::HTMLTrackElement::willRemove): |
| 3208 (WebCore::HTMLTrackElement::parseMappedAttribute): |
| 3209 (WebCore::HTMLTrackElement::attributeChanged): |
| 3210 * html/HTMLTrackElement.h: |
| 3211 * html/LoadableTextTrack.cpp: |
| 3212 (WebCore::LoadableTextTrack::cueLoadingCompleted): |
| 3213 |
| 3214 2011-10-28 Simon Fraser <simon.fraser@apple.com> |
| 3215 |
| 3216 The HTML5 video element in Safari does not respect "visibility:hidden" C
SS property |
| 3217 https://bugs.webkit.org/show_bug.cgi?id=38829 |
| 3218 |
| 3219 Reviewed by James Robinson. |
| 3220 |
| 3221 Make compositing and CSS visibility play nicely together. |
| 3222 |
| 3223 The main issue was that an old optimization (see bug 4377) caused |
| 3224 visibility:hidden layers to not appear in the z-order lists, but those |
| 3225 layers could still become composited, but would remain detached. In addi
tion, |
| 3226 composited layers which were visibility:hidden would become visible some
times. |
| 3227 |
| 3228 With this fix, the z-order lists always contain all layers when the page |
| 3229 is in compositing mode. GraphicsLayer is changed to ensure that visibili
ty:hidden |
| 3230 layers show no content, and visible descendants of hidden layers work co
rrectly. |
| 3231 |
| 3232 Tests: compositing/visibility/visibility-composited-transforms.html |
| 3233 compositing/visibility/visibility-composited.html |
| 3234 compositing/visibility/visibility-image-layers-dynamic.html |
| 3235 compositing/visibility/visibility-image-layers.html |
| 3236 |
| 3237 * platform/graphics/GraphicsLayer.cpp: |
| 3238 (WebCore::GraphicsLayer::GraphicsLayer): Init m_contentsVisible to true. |
| 3239 (WebCore::GraphicsLayer::dumpProperties): Dump m_contentsVisible if not
true. |
| 3240 * platform/graphics/GraphicsLayer.h: |
| 3241 (WebCore::GraphicsLayer::contentsAreVisible): Getter for m_contentsVisib
le. |
| 3242 (WebCore::GraphicsLayer::setContentsVisible): Setter for m_contentsVisib
le. |
| 3243 * platform/graphics/ca/GraphicsLayerCA.cpp: |
| 3244 (WebCore::GraphicsLayerCA::setContentsVisible): Override setContentsVisi
ble. |
| 3245 (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Handle Co
ntentsVisibilityChanged |
| 3246 flag |
| 3247 (WebCore::GraphicsLayerCA::updateSublayerList): Only parent the m_conten
tsLayer if the layer |
| 3248 has visible contents. |
| 3249 (WebCore::GraphicsLayerCA::updateContentsVisibility): For bits painted i
nto the layer itself, |
| 3250 we hide it by clearing the backing store. |
| 3251 * platform/graphics/ca/GraphicsLayerCA.h: Removed obsolete comment on th
e DrawsContentChanged flag, |
| 3252 added ContentsVisibilityChanged flag. |
| 3253 * rendering/RenderLayer.cpp: |
| 3254 (WebCore::RenderLayer::updateZOrderLists): If we're in compositing mode,
include all layers |
| 3255 in the z-order lists. |
| 3256 (WebCore::RenderLayer::collectLayers): New param to specify whether we n
eed to collect all layers. |
| 3257 * rendering/RenderLayer.h: |
| 3258 (WebCore::RenderLayer::hasVisibleDescendant): Add comment about the need
for an assertion in hasVisibleContent() |
| 3259 , and assertion in hasVisibleDescendant(). |
| 3260 * rendering/RenderLayerBacking.cpp: |
| 3261 (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call setCont
entsVisible() on the GraphicsLayer. |
| 3262 (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): We can
use simple container layers in cases |
| 3263 where visibility:hidden causes layer content to not be drawn. |
| 3264 (WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants): Rena
med from hasNonCompositingDescendants() |
| 3265 because it now also looks at visibility to decide when things are visibl
e. |
| 3266 * rendering/RenderLayerBacking.h: hasNonCompositingDescendants() renamed
to hasVisibleNonCompositingDescendants(). |
| 3267 |
| 3268 2011-10-22 Philippe Normand <pnormand@igalia.com> |
| 3269 |
| 3270 [GTK] Build fixes for glib 2.31 (current master) |
| 3271 https://bugs.webkit.org/show_bug.cgi?id=70679 |
| 3272 |
| 3273 Reviewed by Martin Robinson. |
| 3274 |
| 3275 g_cond_new and g_mutex_new have been replaced by _init |
| 3276 functions. Same for _free, replaced by _clear. |
| 3277 |
| 3278 * platform/graphics/gstreamer/VideoSinkGStreamer.cpp: |
| 3279 (webkit_video_sink_init): |
| 3280 (webkit_video_sink_dispose): |
| 3281 |
| 3282 2011-10-28 Jochen Eisinger <jochen@chromium.org> |
| 3283 |
| 3284 Rename a number of methods mentioning JavaScript to just Script instead |
| 3285 https://bugs.webkit.org/show_bug.cgi?id=71105 |
| 3286 |
| 3287 Reviewed by Adam Barth. |
| 3288 |
| 3289 * WebCore.exp.in: |
| 3290 * bindings/ScriptControllerBase.cpp: |
| 3291 (WebCore::ScriptController::canExecuteScripts): |
| 3292 * bindings/v8/V8Proxy.cpp: |
| 3293 (WebCore::V8Proxy::handleOutOfMemory): |
| 3294 * loader/FrameLoaderClient.h: |
| 3295 (WebCore::FrameLoaderClient::allowScript): |
| 3296 * loader/cache/CachedResourceLoader.cpp: |
| 3297 (WebCore::CachedResourceLoader::canRequest): |
| 3298 * page/Settings.cpp: |
| 3299 (WebCore::Settings::Settings): |
| 3300 (WebCore::Settings::setScriptEnabled): |
| 3301 * page/Settings.h: |
| 3302 (WebCore::Settings::isScriptEnabled): |
| 3303 * svg/graphics/SVGImage.cpp: |
| 3304 (WebCore::SVGImage::dataChanged): |
| 3305 |
| 3306 2011-10-28 Pavel Feldman <pfeldman@google.com> |
| 3307 |
| 3308 Reset line numbers for scripts generated with document.write. |
| 3309 https://bugs.webkit.org/show_bug.cgi?id=71099 |
| 3310 |
| 3311 Reviewed by Yury Semikhatsky. |
| 3312 |
| 3313 Test: http/tests/inspector-enabled/document-write.html |
| 3314 |
| 3315 * dom/Document.h: |
| 3316 (WebCore::Document::isInDocumentWrite): |
| 3317 * dom/ScriptElement.cpp: |
| 3318 (WebCore::ScriptElement::prepareScript): |
| 3319 |
| 3320 2011-10-28 Adam Roben <aroben@apple.com> |
| 3321 |
| 3322 Mac build fix after r98711 |
| 3323 |
| 3324 * WebCore.xcodeproj/project.pbxproj: Mark ExceptionCodeDescription.h pri
vate so WebKit can |
| 3325 find it. |
| 3326 |
| 3327 2011-10-28 Antti Koivisto <antti@apple.com> |
| 3328 |
| 3329 [Chromium] css3/font-feature-settings-rendering.html has incorrect image
result after r98542 |
| 3330 https://bugs.webkit.org/show_bug.cgi?id=71019 |
| 3331 |
| 3332 Reviewed by Andreas Kling. |
| 3333 |
| 3334 These properties need to be marked inherited too. |
| 3335 |
| 3336 Note that the new test case doesn't fail even without the patch. If I un
derstand correctly |
| 3337 the image test in the title is pretty much the only way to see this. How
ever the |
| 3338 new test improves code coverage and protects against future regressions. |
| 3339 |
| 3340 Test: fast/css/inherited-properties-rare-text.html |
| 3341 |
| 3342 * css/CSSProperty.cpp: |
| 3343 (WebCore::CSSProperty::isInheritedProperty): |
| 3344 |
| 3345 2011-10-28 Adam Barth <abarth@webkit.org> |
| 3346 |
| 3347 Remove getExceptionCodeDescription() |
| 3348 https://bugs.webkit.org/show_bug.cgi?id=71103 |
| 3349 |
| 3350 Reviewed by Eric Seidel. |
| 3351 |
| 3352 This function serves no purpose. |
| 3353 |
| 3354 * bindings/js/JSDOMBinding.cpp: |
| 3355 (WebCore::setDOMException): |
| 3356 * bindings/objc/ExceptionHandlers.mm: |
| 3357 (WebCore::raiseDOMException): |
| 3358 * bindings/scripts/CodeGeneratorGObject.pm: |
| 3359 (): |
| 3360 * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: |
| 3361 (webkit_dom_test_obj_method_that_requires_all_args_and_throws): |
| 3362 (webkit_dom_test_obj_method_with_exception): |
| 3363 (webkit_dom_test_obj_with_script_state_void_exception): |
| 3364 (webkit_dom_test_obj_with_script_state_obj_exception): |
| 3365 (webkit_dom_test_obj_get_attr_with_getter_exception): |
| 3366 (webkit_dom_test_obj_set_attr_with_getter_exception): |
| 3367 (webkit_dom_test_obj_set_attr_with_setter_exception): |
| 3368 (webkit_dom_test_obj_set_string_attr_with_getter_exception): |
| 3369 (webkit_dom_test_obj_set_string_attr_with_setter_exception): |
| 3370 * bindings/v8/V8Proxy.cpp: |
| 3371 (WebCore::V8Proxy::setDOMException): |
| 3372 * dom/ExceptionCode.cpp: |
| 3373 * dom/ExceptionCode.h: |
| 3374 |
| 3375 2011-10-19 Alexander Pavlov <apavlov@chromium.org> |
| 3376 |
| 3377 Web Inspector: CSS background-image applied inline shows a warning, but
still works. |
| 3378 https://bugs.webkit.org/show_bug.cgi?id=70325 |
| 3379 |
| 3380 Reviewed by Antti Koivisto. |
| 3381 |
| 3382 This change eliminates the "non-parsed property" warning displayed next
to any |
| 3383 "background-image" property of an element's inline style. |
| 3384 |
| 3385 * css/CSSParser.cpp: |
| 3386 (WebCore::CSSParser::parseDeclaration): |
| 3387 * css/CSSParser.h: |
| 3388 * inspector/InspectorStyleSheet.cpp: |
| 3389 (WebCore::InspectorStyle::setPropertyText): |
| 3390 (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges): |
| 3391 |
| 3392 2011-10-28 Adam Barth <abarth@webkit.org> |
| 3393 |
| 3394 Attempt to fixenate Qt. |
| 3395 |
| 3396 * CodeGenerators.pri: |
| 3397 * dom/make_event_factory.pl: |
| 3398 (toMacroStyle): |
| 3399 |
| 3400 2011-10-28 Adam Barth <abarth@webkit.org> |
| 3401 |
| 3402 ExceptionCode.cpp shouldn't need to know about every feature that throws
exceptions |
| 3403 https://bugs.webkit.org/show_bug.cgi?id=70890 |
| 3404 |
| 3405 Reviewed by Eric Seidel. |
| 3406 |
| 3407 Generate the feature-specific parts of ExceptionCode.cpp from a ".in" |
| 3408 file. This is an incremental step towards inlining |
| 3409 getExceptionCodeDescription into its callers and replacing the switch |
| 3410 statements at those locations with autogenerated code. |
| 3411 |
| 3412 * CMakeLists.txt: |
| 3413 * CodeGenerators.pri: |
| 3414 * DerivedSources.make: |
| 3415 * GNUmakefile.am: |
| 3416 * GNUmakefile.list.am: |
| 3417 * WebCore.gyp/WebCore.gyp: |
| 3418 * WebCore.gyp/scripts/action_makenames.py: |
| 3419 * WebCore.gypi: |
| 3420 * WebCore.vcproj/WebCore.vcproj: |
| 3421 * WebCore.xcodeproj/project.pbxproj: |
| 3422 * bindings/js/JSDOMBinding.cpp: |
| 3423 (WebCore::setDOMException): |
| 3424 * bindings/v8/V8Proxy.cpp: |
| 3425 (WebCore::V8Proxy::setDOMException): |
| 3426 * dom/DOMCoreException.cpp: |
| 3427 (WebCore::DOMCoreException::initializeDescription): |
| 3428 * dom/ExceptionCode.cpp: |
| 3429 (WebCore::getExceptionCodeDescription): |
| 3430 * dom/ExceptionCode.h: |
| 3431 * dom/ExceptionCodeDescription.in: Added. |
| 3432 * dom/make_exception_code_description.pl: Added. |
| 3433 (defaultItemFactory): |
| 3434 (generateCode): |
| 3435 (generateHeader): |
| 3436 (generateImplementation): |
| 3437 |
| 3438 2011-10-28 Yury Semikhatsky <yurys@chromium.org> |
| 3439 |
| 3440 Web Inspector: CallStackSidebarPane should remove discarded Placards fro
m RawSourceCode listeners list |
| 3441 https://bugs.webkit.org/show_bug.cgi?id=70996 |
| 3442 |
| 3443 Reviewed by Pavel Feldman. |
| 3444 |
| 3445 Test: inspector/debugger/callstack-placards-discarded.html |
| 3446 |
| 3447 * inspector/front-end/CallStackSidebarPane.js: |
| 3448 (WebInspector.CallStackSidebarPane.prototype.update): |
| 3449 * inspector/front-end/DebuggerPresentationModel.js: |
| 3450 (WebInspector.DebuggerPresentationModel.prototype.createPlacard): |
| 3451 (WebInspector.DebuggerPresentationModel.CallFramePlacard): |
| 3452 (WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.disca
rd): |
| 3453 (WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._upda
te): |
| 3454 * inspector/front-end/Placard.js: |
| 3455 (WebInspector.Placard.prototype.toggleSelected): |
| 3456 (WebInspector.Placard.prototype.discard): |
| 3457 |
| 3458 2011-10-28 Jochen Eisinger <jochen@chromium.org> |
| 3459 |
| 3460 Add allowScriptFromSource callback to FrameLoaderClient |
| 3461 https://bugs.webkit.org/show_bug.cgi?id=71013 |
| 3462 |
| 3463 Reviewed by Darin Fisher. |
| 3464 |
| 3465 Test: platform/chromium/permissionclient/script-permissions.html |
| 3466 |
| 3467 * loader/FrameLoaderClient.h: |
| 3468 (WebCore::FrameLoaderClient::allowScriptFromSource): |
| 3469 * loader/cache/CachedResourceLoader.cpp: |
| 3470 (WebCore::CachedResourceLoader::canRequest): |
| 3471 |
| 3472 2011-10-27 Adam Barth <abarth@webkit.org> |
| 3473 |
| 3474 Refactor make_event_factory.pl to use InFilesCompiler.pm |
| 3475 https://bugs.webkit.org/show_bug.cgi?id=71094 |
| 3476 |
| 3477 Reviewed by Eric Seidel. |
| 3478 |
| 3479 This refactoring helps share code with |
| 3480 make_exception_code_descriptions.pl, which is coming in a future patch. |
| 3481 I have a dream of refactoring make_names.pl to use this module as well. |
| 3482 |
| 3483 * CodeGenerators.pri: |
| 3484 * DerivedSources.make: |
| 3485 * GNUmakefile.am: |
| 3486 * WebCore.gyp/scripts/action_makenames.py: |
| 3487 * bindings/scripts/InFilesCompiler.pm: Added. |
| 3488 (itemHandler): |
| 3489 (parameterHandler): |
| 3490 (new): |
| 3491 (compile): |
| 3492 (license): |
| 3493 * dom/make_event_factory.pl: |
| 3494 (defaultItemFactory): |
| 3495 (interfaceForEvent): |
| 3496 (generateCode): |
| 3497 (printFactoryFile): |
| 3498 (printMacroFile): |
| 3499 (printHeadersFile): |
| 3500 |
| 3501 2011-10-26 Nat Duca <nduca@chromium.org> |
| 3502 |
| 3503 [chromium] Implement frame rate control portions of CCScheduler |
| 3504 https://bugs.webkit.org/show_bug.cgi?id=70713 |
| 3505 |
| 3506 Reviewed by James Robinson. |
| 3507 |
| 3508 * WebCore.gypi: |
| 3509 * platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp: Added. |
| 3510 (WebCore::CCDelayBasedTimeSource::setActive): |
| 3511 (WebCore::CCDelayBasedTimeSource::postTickTask): |
| 3512 (WebCore::CCDelayBasedTimeSource::onTick): |
| 3513 * platform/graphics/chromium/cc/CCDelayBasedTimeSource.h: Added. |
| 3514 (WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource): |
| 3515 (WebCore::CCDelayBasedTimeSource::~CCDelayBasedTimeSource): |
| 3516 (WebCore::CCDelayBasedTimeSource::setClient): |
| 3517 (WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime): |
| 3518 * platform/graphics/chromium/cc/CCFrameRateController.cpp: Added. |
| 3519 (WebCore::CCFrameRateControllerTimeSourceAdapter::create): |
| 3520 (WebCore::CCFrameRateControllerTimeSourceAdapter::~CCFrameRateController
TimeSourceAdapter): |
| 3521 (WebCore::CCFrameRateControllerTimeSourceAdapter::onTimerTick): |
| 3522 (WebCore::CCFrameRateControllerTimeSourceAdapter::CCFrameRateControllerT
imeSourceAdapter): |
| 3523 (WebCore::CCFrameRateController::CCFrameRateController): |
| 3524 (WebCore::CCFrameRateController::~CCFrameRateController): |
| 3525 (WebCore::CCFrameRateController::onTimerTick): |
| 3526 (WebCore::CCFrameRateController::didBeginFrame): |
| 3527 (WebCore::CCFrameRateController::didFinishFrame): |
| 3528 (WebCore::CCFrameRateController::didAbortAllPendingFrames): |
| 3529 * platform/graphics/chromium/cc/CCFrameRateController.h: Added. |
| 3530 (WebCore::CCFrameRateControllerClient::~CCFrameRateControllerClient): |
| 3531 (WebCore::CCFrameRateController::setClient): |
| 3532 (WebCore::CCFrameRateController::setActive): |
| 3533 * platform/graphics/chromium/cc/CCTimeSource.h: Added. |
| 3534 (WebCore::CCTimeSourceClient::~CCTimeSourceClient): |
| 3535 (WebCore::CCTimeSource::~CCTimeSource): |
| 3536 |
| 3537 2011-10-27 Kentaro Hara <haraken@chromium.org> |
| 3538 |
| 3539 Deprecate [V8ConstructorSetsActiveDOMWrapper] IDL |
| 3540 https://bugs.webkit.org/show_bug.cgi?id=71088 |
| 3541 |
| 3542 Reviewed by Adam Barth. |
| 3543 |
| 3544 I introduced [V8ConstructorSetsActiveDOMWrapper] IDL in bug 66536, |
| 3545 but I found that it has the same meaning as [ActiveDOMObject] IDL. |
| 3546 This patch removes [V8ConstructorSetsActiveDOMWrapper] IDL. |
| 3547 |
| 3548 No change in behavior. |
| 3549 |
| 3550 Tests: fast/dom/global-constructors.html |
| 3551 fast/eventsource/eventsource-constructor.html |
| 3552 fast/eventsource/eventsource-attribute-listeners.html |
| 3553 fast/files/blob-slice-test.html |
| 3554 fast/files/file-reader-abort.html |
| 3555 ui_tests:WorkerTest.FLAKY_SharedWorkerFastConstructor |
| 3556 ui_tests:WorkerTest.FLAKY_SharedWorkerFastName |
| 3557 ui_tests:WorkerTest.FLAKY_WorkerConstructor |
| 3558 ui_tests:WorkerTest.FLAKY_WorkerEventListener |
| 3559 |
| 3560 * bindings/scripts/CodeGeneratorV8.pm: Replaced "V8ConstructorSetsActive
DOMWrapper" with "ActiveDOMObject". |
| 3561 (GenerateConstructorCallback): |
| 3562 * bindings/scripts/test/TestInterface.idl: Ditto. |
| 3563 * bindings/scripts/test/JS/JSTestInterface.cpp: Updated a test result. |
| 3564 (WebCore::isObservable): |
| 3565 (WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots): |
| 3566 (WebCore::JSTestInterfaceOwner::finalize): |
| 3567 * bindings/scripts/test/JS/JSTestInterface.h: Ditto. |
| 3568 (WebCore::wrapperOwner): |
| 3569 (WebCore::wrapperContext): |
| 3570 * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto. |
| 3571 * bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Ditto. |
| 3572 * bindings/scripts/test/JS/JSTestObj.cpp: Ditto. |
| 3573 * bindings/scripts/test/JS/JSTestObj.h: Ditto. |
| 3574 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Dit
to. |
| 3575 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Ditto
. |
| 3576 * bindings/scripts/test/V8/V8TestInterface.cpp: Ditto. |
| 3577 (WebCore::V8TestInterface::toActiveDOMObject): |
| 3578 (WebCore::V8TestInterface::wrapSlow): |
| 3579 * bindings/scripts/test/V8/V8TestInterface.h: Ditto. |
| 3580 (WebCore::V8TestInterface::existingWrapper): |
| 3581 * fileapi/FileReader.idl: Removed [V8ConstructorSetsActiveDOMWrapper] ID
L. |
| 3582 * mediastream/PeerConnection.idl: Ditto. |
| 3583 * page/EventSource.idl: Ditto. |
| 3584 * workers/SharedWorker.idl: Ditto. |
| 3585 * workers/Worker.idl: Ditto. |
| 3586 |
| 3587 2011-10-28 Yuta Kitamura <yutak@chromium.org> |
| 3588 |
| 3589 Race condition in SocketStreamHandleCFNet when PAC script is used |
| 3590 https://bugs.webkit.org/show_bug.cgi?id=70894 |
| 3591 |
| 3592 Reviewed by Alexey Proskuryakov. |
| 3593 |
| 3594 Pass callback functions that call ref() or deref() as retain/release mem
ber |
| 3595 of CFStreamClientContext. |
| 3596 |
| 3597 No new tests, as it is not possible to write a test with PAC script enab
led. |
| 3598 |
| 3599 * platform/network/cf/SocketStreamHandle.h: |
| 3600 * platform/network/cf/SocketStreamHandleCFNet.cpp: |
| 3601 (WebCore::SocketStreamHandle::scheduleStreams): |
| 3602 (WebCore::SocketStreamHandle::retainSocketStreamHandle): |
| 3603 (WebCore::SocketStreamHandle::releaseSocketStreamHandle): |
| 3604 (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): |
| 3605 This callback may be called after platformClose() is already called. We
should |
| 3606 not create new streams in this case. |
| 3607 (WebCore::SocketStreamHandle::executePACFileURL): |
| 3608 (WebCore::SocketStreamHandle::readStreamCallback): |
| 3609 This manual ref/deref can be safely removed as m_readStream holds the re
ference. |
| 3610 (WebCore::SocketStreamHandle::writeStreamCallback): |
| 3611 Ditto. |
| 3612 |
| 3613 2011-10-27 Arthur Hsu <arthurhsu@chromium.org> |
| 3614 |
| 3615 Reland patch ensure font load before calling Skia during printing |
| 3616 https://bugs.webkit.org/show_bug.cgi?id=70390 |
| 3617 |
| 3618 Reviewed by James Robinson. |
| 3619 |
| 3620 * platform/graphics/chromium/FontChromiumWin.cpp: |
| 3621 (WebCore::Font::drawGlyphs): |
| 3622 * platform/graphics/skia/SkiaFontWin.cpp: |
| 3623 (WebCore::paintSkiaText): |
| 3624 |
| 3625 2011-10-27 Adam Barth <abarth@webkit.org> |
| 3626 |
| 3627 Attempt to fix the Qt build. |
| 3628 |
| 3629 * WebCore.pro: |
| 3630 |
| 3631 2011-10-27 Ryosuke Niwa <rniwa@webkit.org> |
| 3632 |
| 3633 binding test rebaseline after r98679. |
| 3634 |
| 3635 * bindings/scripts/test/JS/JSTestInterface.cpp: |
| 3636 (WebCore::JSTestInterfaceConstructor::constructJSTestInterface): |
| 3637 * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: |
| 3638 (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod): |
| 3639 * bindings/scripts/test/JS/JSTestObj.cpp: |
| 3640 (WebCore::setJSTestObjStringAttr): |
| 3641 (WebCore::setJSTestObjStringAttrWithGetterException): |
| 3642 (WebCore::setJSTestObjStringAttrWithSetterException): |
| 3643 (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): |
| 3644 (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): |
| 3645 (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): |
| 3646 (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs): |
| 3647 (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows): |
| 3648 (WebCore::jsTestObjPrototypeFunctionSerializedValue): |
| 3649 (WebCore::jsTestObjPrototypeFunctionIdbKey): |
| 3650 (WebCore::jsTestObjPrototypeFunctionOptionsObject): |
| 3651 (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): |
| 3652 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): |
| 3653 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): |
| 3654 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): |
| 3655 (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): |
| 3656 (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): |
| 3657 (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalA
rg): |
| 3658 (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOption
alArgs): |
| 3659 (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackA
rg): |
| 3660 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): |
| 3661 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): |
| 3662 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): |
| 3663 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): |
| 3664 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod6): |
| 3665 (WebCore::jsTestObjPrototypeFunctionOverloadedMethod7): |
| 3666 (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional): |
| 3667 |
| 3668 2011-10-27 Adam Barth <abarth@webkit.org> |
| 3669 |
| 3670 Move type-specific exception descriptions into the implementation files
for each type |
| 3671 https://bugs.webkit.org/show_bug.cgi?id=71081 |
| 3672 |
| 3673 Reviewed by Eric Seidel. |
| 3674 |
| 3675 There's no reason to centralize this information. It belongs with each |
| 3676 exception type. This patch is in preparation for autogenerating the cen
tral file. |
| 3677 |
| 3678 * WebCore.xcodeproj/project.pbxproj: |
| 3679 * dom/DOMCoreException.cpp: Added. |
| 3680 (WebCore::DOMCoreException::initializeDescription): |
| 3681 * dom/DOMCoreException.h: |
| 3682 * dom/EventException.cpp: Copied from Source/WebCore/xml/XMLHttpRequestE
xception.h. |
| 3683 (WebCore::EventException::initializeDescription): |
| 3684 * dom/EventException.h: |
| 3685 * dom/ExceptionBase.h: |
| 3686 (WebCore::ExceptionBase::code): |
| 3687 (WebCore::ExceptionBase::name): |
| 3688 (WebCore::ExceptionBase::message): |
| 3689 (WebCore::ExceptionBase::description): |
| 3690 * dom/ExceptionCode.cpp: |
| 3691 (WebCore::getExceptionCodeDescription): |
| 3692 * dom/RangeException.cpp: Copied from Source/WebCore/xml/XPathException.
h. |
| 3693 (WebCore::RangeException::initializeDescription): |
| 3694 * dom/RangeException.h: |
| 3695 * fileapi/FileException.cpp: Added. |
| 3696 (WebCore::FileException::initializeDescription): |
| 3697 * fileapi/FileException.h: |
| 3698 * fileapi/OperationNotAllowedException.cpp: Copied from Source/WebCore/x
ml/XMLHttpRequestException.h. |
| 3699 (WebCore::OperationNotAllowedException::initializeDescription): |
| 3700 * fileapi/OperationNotAllowedException.h: |
| 3701 * storage/IDBDatabaseException.cpp: Added. |
| 3702 (WebCore::IDBDatabaseException::initializeDescription): |
| 3703 * storage/IDBDatabaseException.h: |
| 3704 * storage/SQLException.cpp: Added. |
| 3705 (WebCore::SQLException::initializeDescription): |
| 3706 * storage/SQLException.h: |
| 3707 * svg/SVGException.cpp: Copied from Source/WebCore/dom/EventException.h. |
| 3708 (WebCore::SVGException::initializeDescription): |
| 3709 * svg/SVGException.h: |
| 3710 * xml/XMLHttpRequestException.cpp: Copied from Source/WebCore/xml/XMLHtt
pRequestException.h. |
| 3711 (WebCore::XMLHttpRequestException::initializeDescription): |
| 3712 * xml/XMLHttpRequestException.h: |
| 3713 * xml/XPathException.cpp: Copied from Source/WebCore/xml/XPathException.
h. |
| 3714 (WebCore::XPathException::initializeDescription): |
| 3715 * xml/XPathException.h: |
| 3716 |
| 3717 2011-10-27 Kentaro Hara <haraken@chromium.org> |
| 3718 |
| 3719 Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL |
| 3720 https://bugs.webkit.org/show_bug.cgi?id=70215 |
| 3721 |
| 3722 Reviewed by Adam Barth. |
| 3723 |
| 3724 This patch implements [Optional=CallWithNullValue] IDL for JSC. |
| 3725 While a parameter specified as [Optional=CallWithDefaultValue] is |
| 3726 handled as a string "undefined", a parameter specified as |
| 3727 [Optional=CallWithNullValue] is handled as a null string. |
| 3728 (Note: not a string "null", but a null string). |
| 3729 |
| 3730 c.f. [Optional=CallWithNullValue] is implemented in V8 in bug 67458. |
| 3731 |
| 3732 Tests: fast/dom/global-constructors.html |
| 3733 transforms/svg-vs-css.xhtml |
| 3734 transforms/cssmatrix-2d-interface.xhtml |
| 3735 transforms/cssmatrix-3d-interface.xhtml |
| 3736 |
| 3737 * GNUmakefile.list.am: Removed JSWebKitCSSMatrixCustom.cpp. |
| 3738 * UseJSC.cmake: Ditto. |
| 3739 * WebCore.gypi: Ditto. |
| 3740 * WebCore.pro: Ditto. |
| 3741 * WebCore.xcodeproj/project.pbxproj: Ditto. |
| 3742 * bindings/js/JSBindingsAllInOne.cpp: Ditto. |
| 3743 * bindings/js/JSDOMBinding.h: MAYBE_MISSING_PARAMETER(exec, index, polic
y) returns the index-th parameter, if the parameter exists. It returns an undefi
ned value, if the index-th parameter is missing and the policy is MissingIsUndef
ined. It returns an empty value, otherwise (i.e. if the index-th parameter is mi
ssing and the policy is MissingIsEmpty). |
| 3744 * bindings/js/JSWebKitCSSMatrixCustom.cpp: Removed. |
| 3745 * bindings/scripts/CodeGeneratorJS.pm: |
| 3746 (GenerateParametersCheck): Supported [Optional=CallWithNullValue]. |
| 3747 (GenerateConstructorDefinition): Supported [Optional=CallWithNullValue]. |
| 3748 * css/WebKitCSSMatrix.idl: Removed [JSCustomConstructor]. |
| 3749 |
| 3750 2011-10-27 Julien Chaffraix <jchaffraix@webkit.org> |
| 3751 |
| 3752 RenderTableCell m_row and m_column should not be signed values |
| 3753 https://bugs.webkit.org/show_bug.cgi?id=70369 |
| 3754 |
| 3755 Reviewed by Darin Adler. |
| 3756 |
| 3757 No new tests, refactoring only. |
| 3758 |
| 3759 The gist of the change is to update row / column handling in the table's |
| 3760 rendering code to use unsigned values. Not all the code is switched over |
| 3761 to unsigned but this is a good start. |
| 3762 |
| 3763 Using unsigned makes a lot more sense that allowing some negative indexe
s |
| 3764 to creep in the algorithms. Also it enables us to "free" the unused sign
ed |
| 3765 bit on the 2 RenderTableCell fields that can be used to pack 2 bits in a |
| 3766 follow-up patch. |
| 3767 |
| 3768 * accessibility/AccessibilityTable.cpp: |
| 3769 (WebCore::AccessibilityTable::cellForColumnAndRow): |
| 3770 Removed 2 casts to int as the left side now computes to an unsigned too. |
| 3771 Added some ASSERT to make sure we don't get negative values (colSpan / r
owSpan |
| 3772 are always >= 1 by definition but better to be safe). |
| 3773 |
| 3774 * accessibility/AccessibilityTableColumn.cpp: |
| 3775 (WebCore::AccessibilityTableColumn::headerObjectForSection): |
| 3776 * accessibility/AccessibilityTableColumn.h: |
| 3777 Switched m_columnIndex to unsigned to remove any signed / unsigned compa
risons. |
| 3778 |
| 3779 * rendering/RenderTable.cpp: |
| 3780 (WebCore::RenderTable::splitColumn): |
| 3781 (WebCore::RenderTable::calcBorderEnd): |
| 3782 (WebCore::RenderTable::cellAbove): |
| 3783 (WebCore::RenderTable::cellBelow): |
| 3784 (WebCore::RenderTable::cellBefore): |
| 3785 (WebCore::RenderTable::cellAfter): |
| 3786 Mostly mechanical changes to avoid signed / unsigned comparisons or cast
s. |
| 3787 |
| 3788 * rendering/RenderTable.h: |
| 3789 (WebCore::RenderTable::numEffCols): |
| 3790 (WebCore::RenderTable::colToEffCol): |
| 3791 Updated a couple of functions to use an unsigned. |
| 3792 |
| 3793 * rendering/RenderTableCell.cpp: |
| 3794 (WebCore::RenderTableCell::RenderTableCell): |
| 3795 * rendering/RenderTableCell.h: |
| 3796 (WebCore::RenderTableCell::col): |
| 3797 (WebCore::RenderTableCell::setCol): |
| 3798 (WebCore::RenderTableCell::row): |
| 3799 (WebCore::RenderTableCell::setRow): |
| 3800 Updated after switching the fields to unsigned. Also added 2 constants |
| 3801 to cover the not-initialized-yet value for row and column indexes. |
| 3802 Note: we don't enforce that you can't reach those indexes but neither |
| 3803 did the previous code! |
| 3804 |
| 3805 * rendering/RenderTableSection.cpp: |
| 3806 (WebCore::RenderTableSection::RenderTableSection): |
| 3807 (WebCore::RenderTableSection::addChild): |
| 3808 (WebCore::RenderTableSection::ensureRows): |
| 3809 (WebCore::RenderTableSection::setCellLogicalWidths): |
| 3810 (WebCore::RenderTableSection::calcRowLogicalHeight): |
| 3811 (WebCore::RenderTableSection::layoutRows): |
| 3812 (WebCore::RenderTableSection::calcOuterBorderStart): |
| 3813 (WebCore::RenderTableSection::calcOuterBorderEnd): |
| 3814 (WebCore::RenderTableSection::recalcCells): |
| 3815 (WebCore::RenderTableSection::clearGrid): |
| 3816 (WebCore::RenderTableSection::numColumns): |
| 3817 (WebCore::RenderTableSection::appendColumn): |
| 3818 (WebCore::RenderTableSection::splitColumn): |
| 3819 Lots of mechanical: signed -> unsigned changes. However we had |
| 3820 to change the logic a bit as it assumed that m_cRow started at |
| 3821 -1 and increased from there. The new meaning of m_cRow is the |
| 3822 number of rows seen and m_cRow - 1 is where to insert your new |
| 3823 cells. |
| 3824 |
| 3825 (WebCore::RenderTableSection::addCell): |
| 3826 Checked the callers and all increase m_cRow before calling the function. |
| 3827 Added an ASSERT to catch up wrong usage in the future. |
| 3828 |
| 3829 * rendering/RenderTableSection.h: |
| 3830 (WebCore::RenderTableSection::numRows): Switched to unsigned. |
| 3831 |
| 3832 2011-10-27 Dan Bernstein <mitz@apple.com> |
| 3833 |
| 3834 Assertion failure (m_text) in RenderText::RenderText() at icanhascheezbu
rger.com |
| 3835 https://bugs.webkit.org/show_bug.cgi?id=71085 |
| 3836 |
| 3837 Reviewed by Jon Honeycutt. |
| 3838 |
| 3839 Test: fast/css-generated-content/attr-missing.html |
| 3840 |
| 3841 * css/CSSStyleSelector.cpp: |
| 3842 (WebCore::CSSStyleSelector::applyProperty): If the element does not have
the attribute specified |
| 3843 in the attr() function in the content property, set the content to the e
mpty string, per |
| 3844 <http://www.w3.org/TR/CSS21/generate.html#content>. |
| 3845 |
| 3846 2011-10-27 Helder Correia <helder.correia@palm.com> |
| 3847 |
| 3848 [Qt] Failure to build when QT_NO_CURSOR defined |
| 3849 https://bugs.webkit.org/show_bug.cgi?id=71060 |
| 3850 |
| 3851 Reviewed by Noam Rosenthal. |
| 3852 |
| 3853 PlatformVideoWindowQt needs to wrap some code around #ifndef |
| 3854 QT_NO_CURSOR in order to build QtWebKit when QT_NO_CURSOR is defined. |
| 3855 |
| 3856 Build fix, no new tests. |
| 3857 |
| 3858 * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: |
| 3859 (FullScreenVideoWindow::FullScreenVideoWindow): |
| 3860 (FullScreenVideoWindow::closeEvent): |
| 3861 (FullScreenVideoWindow::hideCursor): |
| 3862 (FullScreenVideoWindow::showCursor): |
| 3863 |
| 3864 2011-10-27 Shawn Singh <shawnsingh@chromium.org> |
| 3865 |
| 3866 [chromium] Track when CCLayerImpl properties have changed. |
| 3867 https://bugs.webkit.org/show_bug.cgi?id=70442 |
| 3868 |
| 3869 Reviewed by James Robinson. |
| 3870 |
| 3871 To determine a good scissor rect, we must determine what |
| 3872 will change on the screen on the next redraw. This patch |
| 3873 tracks the necessary information on CCLayerImpl and marks |
| 3874 a flag indicating whether this layer will "damage" the screen. |
| 3875 The other portion of "change", the updateRect, was already |
| 3876 landed in https://bugs.webkit.org/show_bug.cgi?id=69441. |
| 3877 |
| 3878 New unit test added to CCLayerImplTest to test this patch. |
| 3879 |
| 3880 * platform/graphics/chromium/cc/CCLayerImpl.cpp: |
| 3881 (WebCore::CCLayerImpl::CCLayerImpl): |
| 3882 (WebCore::CCLayerImpl::scrollBy): |
| 3883 (WebCore::CCLayerImpl::noteLayerPropertyChangedForSubtree): |
| 3884 (WebCore::CCLayerImpl::noteLayerPropertyChangedForDescendants): |
| 3885 (WebCore::CCLayerImpl::setBounds): |
| 3886 (WebCore::CCLayerImpl::setMaskLayer): |
| 3887 (WebCore::CCLayerImpl::setReplicaLayer): |
| 3888 (WebCore::CCLayerImpl::setDrawsContent): |
| 3889 (WebCore::CCLayerImpl::setAnchorPoint): |
| 3890 (WebCore::CCLayerImpl::setAnchorPointZ): |
| 3891 (WebCore::CCLayerImpl::setMasksToBounds): |
| 3892 (WebCore::CCLayerImpl::setOpaque): |
| 3893 (WebCore::CCLayerImpl::setOpacity): |
| 3894 (WebCore::CCLayerImpl::setPosition): |
| 3895 (WebCore::CCLayerImpl::setPreserves3D): |
| 3896 (WebCore::CCLayerImpl::setSublayerTransform): |
| 3897 (WebCore::CCLayerImpl::setTransform): |
| 3898 (WebCore::CCLayerImpl::setDebugBorderColor): |
| 3899 (WebCore::CCLayerImpl::setDebugBorderWidth): |
| 3900 (WebCore::CCLayerImpl::setContentBounds): |
| 3901 (WebCore::CCLayerImpl::setScrollPosition): |
| 3902 (WebCore::CCLayerImpl::setScrollDelta): |
| 3903 (WebCore::CCLayerImpl::setDoubleSided): |
| 3904 * platform/graphics/chromium/cc/CCLayerImpl.h: |
| 3905 (WebCore::CCLayerImpl::layerPropertyChanged): |
| 3906 (WebCore::CCLayerImpl::resetLayerPropertyChanged): |
| 3907 |
| 3908 2011-10-27 Anders Carlsson <andersca@apple.com> |
| 3909 |
| 3910 Add a Plugin::geometryDidChange that will work with transforms |
| 3911 https://bugs.webkit.org/show_bug.cgi?id=71072 |
| 3912 |
| 3913 Reviewed by Simon Fraser. |
| 3914 |
| 3915 Export symbols needed by WebKit2. |
| 3916 |
| 3917 * WebCore.exp.in: |
| 3918 |
| 3919 2011-10-27 Adam Barth <abarth@webkit.org> |
| 3920 |
| 3921 Exception subtypes have incorrect namespace indentation |
| 3922 https://bugs.webkit.org/show_bug.cgi?id=71075 |
| 3923 |
| 3924 Reviewed by Eric Seidel. |
| 3925 |
| 3926 This patch is in preparation for editing these headers. We decided to |
| 3927 not indent namespaces in headers and update the headers as we edited |
| 3928 them. |
| 3929 |
| 3930 * dom/DOMCoreException.h: |
| 3931 (WebCore::DOMCoreException::create): |
| 3932 (WebCore::DOMCoreException::DOMCoreException): |
| 3933 * dom/EventException.h: |
| 3934 (WebCore::EventException::create): |
| 3935 (WebCore::EventException::EventException): |
| 3936 * dom/RangeException.h: |
| 3937 (WebCore::RangeException::create): |
| 3938 (WebCore::RangeException::RangeException): |
| 3939 * xml/XMLHttpRequestException.h: |
| 3940 (WebCore::XMLHttpRequestException::create): |
| 3941 (WebCore::XMLHttpRequestException::XMLHttpRequestException): |
| 3942 * xml/XPathException.h: |
| 3943 (WebCore::XPathException::create): |
| 3944 (WebCore::XPathException::XPathException): |
| 3945 |
| 3946 2011-10-27 Kenneth Russell <kbr@google.com> |
| 3947 |
| 3948 Implement new restrictions on uniform and attribute location lengths |
| 3949 https://bugs.webkit.org/show_bug.cgi?id=70981 |
| 3950 |
| 3951 Reviewed by Chris Marrin. |
| 3952 |
| 3953 Tests: fast/canvas/webgl/attrib-location-length-limits.html |
| 3954 fast/canvas/webgl/uniform-location-length-limits.html |
| 3955 |
| 3956 * html/canvas/WebGLRenderingContext.cpp: |
| 3957 (WebCore::WebGLRenderingContext::bindAttribLocation): |
| 3958 (WebCore::WebGLRenderingContext::getAttribLocation): |
| 3959 (WebCore::WebGLRenderingContext::getUniformLocation): |
| 3960 (WebCore::WebGLRenderingContext::validateLocationLength): |
| 3961 * html/canvas/WebGLRenderingContext.h: |
| 3962 |
| 3963 2011-10-27 Rafael Weinstein <rafaelw@chromium.org> |
| 3964 |
| 3965 [MutationObservers] Implement subtree observation of transiently disconn
ected nodes |
| 3966 https://bugs.webkit.org/show_bug.cgi?id=70788 |
| 3967 |
| 3968 Reviewed by Ryosuke Niwa. |
| 3969 |
| 3970 This patch adds support for observing all descendant nodes reachable fro
m a subtree |
| 3971 observation until delivery of mutations -- even if they become detached.
We do this by |
| 3972 introducing a "transient registration" which can exist for a short time
along side |
| 3973 normal registrations on Node. Transient registrations have a reference t
o the node |
| 3974 which "owns" the subtree observation registration (the "registrationNode
"). Transient |
| 3975 registrations are cleared immediately before mutations are delivered to
an observer, |
| 3976 or when the observer re-observes at the registrationNode, in-effect rese
tting the |
| 3977 observation. |
| 3978 |
| 3979 New tests added to fast/mutation/observe-subtree.html. |
| 3980 |
| 3981 * dom/CharacterData.cpp: |
| 3982 (WebCore::CharacterData::dispatchModifiedEvent): |
| 3983 * dom/ChildListMutationScope.cpp: |
| 3984 (WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::Chil
dListMutationAccumulator): |
| 3985 (WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqu
eueMutationRecord): |
| 3986 (WebCore::MutationAccumulationRouter::MutationAccumulationRouter::increm
entScopingLevel): |
| 3987 * dom/ContainerNode.cpp: |
| 3988 (WebCore::dispatchChildRemovalEvents): |
| 3989 * dom/Element.cpp: |
| 3990 (WebCore::enqueueAttributesMutationRecord): |
| 3991 * dom/Node.cpp: |
| 3992 (WebCore::addMatchingObservers): |
| 3993 (WebCore::Node::getRegisteredMutationObserversOfType): |
| 3994 (WebCore::Node::registerMutationObserver): |
| 3995 (WebCore::Node::unregisterMutationObserver): |
| 3996 (WebCore::Node::notifySubtreeObserversOfDisconnection): |
| 3997 * dom/Node.h: |
| 3998 * dom/NodeRareData.h: |
| 3999 (WebCore::MutationObserverEntry::MutationObserverEntry): |
| 4000 (WebCore::MutationObserverEntry::operator==): |
| 4001 * dom/WebKitMutationObserver.cpp: |
| 4002 (WebCore::WebKitMutationObserver::observe): |
| 4003 (WebCore::unregisterTransientEntries): |
| 4004 (WebCore::WebKitMutationObserver::disconnect): |
| 4005 (WebCore::WebKitMutationObserver::observedNodeDestructed): |
| 4006 (WebCore::WebKitMutationObserver::observedSubtreeWillDisconnect): |
| 4007 (WebCore::WebKitMutationObserver::clearTransientEntries): |
| 4008 (WebCore::WebKitMutationObserver::deliver): |
| 4009 * dom/WebKitMutationObserver.h: |
| 4010 |
| 4011 2011-10-27 Pratik Solanki <psolanki@apple.com> |
| 4012 |
| 4013 Ask CG to not parse image metadata |
| 4014 https://bugs.webkit.org/show_bug.cgi?id=71029 |
| 4015 |
| 4016 Reviewed by Simon Fraser. |
| 4017 |
| 4018 We don't need CG to parse the image metadata since WebCore never uses it
. Passing this |
| 4019 option shaves off time spent under CGImageSourceCopyPropertiesAtIndex. U
nder Instruments I |
| 4020 saw the time drop from ~75ms to ~25ms when loading http://boston.com/big
picture and the |
| 4021 first link on that page. |
| 4022 |
| 4023 No new tests because no change in functionality. |
| 4024 |
| 4025 * platform/graphics/ImageSource.h: |
| 4026 * platform/graphics/cg/ImageSourceCG.cpp: |
| 4027 (WebCore::imageSourceOptions): |
| 4028 (WebCore::ImageSource::isSizeAvailable): |
| 4029 (WebCore::ImageSource::frameSizeAtIndex): |
| 4030 (WebCore::ImageSource::getHotSpot): |
| 4031 (WebCore::ImageSource::repetitionCount): |
| 4032 (WebCore::ImageSource::createFrameAtIndex): |
| 4033 (WebCore::ImageSource::frameDurationAtIndex): |
| 4034 |
| 4035 2011-10-27 David Grogan <dgrogan@chromium.org> |
| 4036 |
| 4037 Move eventqueue from Document to ScriptExecutionContext so that it can b
e accessed from workers |
| 4038 https://bugs.webkit.org/show_bug.cgi?id=57789 |
| 4039 |
| 4040 Extract interface from EventQueue and create two new subclasses: |
| 4041 DocumentEventQueue and WorkerEventQueue. DocumentEventQueue is the |
| 4042 old EventQueue implementation that uses DOMTimer(0) to post async |
| 4043 events. WorkerEventQueue posts events to its thread's message loop. |
| 4044 |
| 4045 Reviewed by David Levin. |
| 4046 |
| 4047 No new tests - IndexedDB will use this but isn't ready yet. I don't |
| 4048 know of any other API available in workers that I can test this with. |
| 4049 |
| 4050 * GNUmakefile.list.am: |
| 4051 * WebCore.gypi: |
| 4052 * WebCore.pro: |
| 4053 * WebCore.xcodeproj/project.pbxproj: |
| 4054 * dom/DOMAllInOne.cpp: |
| 4055 * dom/Document.cpp: |
| 4056 (WebCore::Document::Document): |
| 4057 * dom/Document.h: |
| 4058 (WebCore::Document::eventQueue): |
| 4059 * dom/DocumentEventQueue.cpp: Renamed from Source/WebCore/dom/EventQueue
.cpp. |
| 4060 (WebCore::shouldDispatchScrollEventSynchronously): |
| 4061 (WebCore::DocumentEventQueueTimer::DocumentEventQueueTimer): |
| 4062 (WebCore::DocumentEventQueueTimer::fired): |
| 4063 (WebCore::DocumentEventQueue::create): |
| 4064 (WebCore::DocumentEventQueue::DocumentEventQueue): |
| 4065 (WebCore::DocumentEventQueue::~DocumentEventQueue): |
| 4066 (WebCore::DocumentEventQueue::enqueueEvent): |
| 4067 (WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent): |
| 4068 (WebCore::DocumentEventQueue::cancelEvent): |
| 4069 (WebCore::DocumentEventQueue::close): |
| 4070 (WebCore::DocumentEventQueue::pendingEventTimerFired): |
| 4071 (WebCore::DocumentEventQueue::dispatchEvent): |
| 4072 * dom/DocumentEventQueue.h: Copied from Source/WebCore/dom/EventQueue.h. |
| 4073 * dom/EventQueue.h: |
| 4074 * dom/ScriptExecutionContext.h: |
| 4075 * page/EventHandler.cpp: Change EventQueue to DocumentEventQueue. |
| 4076 (WebCore::EventHandler::sendScrollEvent): Change EventQueue to DocumentE
ventQueue. |
| 4077 * rendering/RenderLayer.cpp: |
| 4078 (WebCore::RenderLayer::scrollTo): Change EventQueue to DocumentEventQueu
e. |
| 4079 * rendering/RenderListBox.cpp: |
| 4080 (WebCore::RenderListBox::scrollTo): Change EventQueue to DocumentEventQu
eue. |
| 4081 * storage/IDBDatabase.cpp: |
| 4082 * storage/IDBRequest.cpp: |
| 4083 * storage/IDBTransaction.cpp: |
| 4084 * workers/WorkerContext.cpp: |
| 4085 (WebCore::WorkerContext::eventQueue): |
| 4086 * workers/WorkerContext.h: |
| 4087 * workers/WorkerEventQueue.cpp: Added. |
| 4088 (WebCore::WorkerEventQueue::create): |
| 4089 (WebCore::WorkerEventQueue::WorkerEventQueue): |
| 4090 (WebCore::WorkerEventQueue::~WorkerEventQueue): |
| 4091 (WebCore::WorkerEventQueue::EventDispatcherTask::create): |
| 4092 (WebCore::WorkerEventQueue::EventDispatcherTask::dispatchEvent): |
| 4093 (WebCore::WorkerEventQueue::EventDispatcherTask::performTask): |
| 4094 (WebCore::WorkerEventQueue::EventDispatcherTask::cancel): |
| 4095 (WebCore::WorkerEventQueue::EventDispatcherTask::EventDispatcherTask): |
| 4096 (WebCore::WorkerEventQueue::removeEvent): |
| 4097 (WebCore::WorkerEventQueue::enqueueEvent): |
| 4098 (WebCore::WorkerEventQueue::cancelEvent): |
| 4099 (WebCore::WorkerEventQueue::close): |
| 4100 * workers/WorkerEventQueue.h: Copied from Source/WebCore/dom/EventQueue.
h. |
| 4101 |
| 4102 2011-10-27 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> |
| 4103 |
| 4104 [GStreamer] Prevent memory leak when fullscreening a video |
| 4105 https://bugs.webkit.org/show_bug.cgi?id=71043 |
| 4106 |
| 4107 Reviewed by Gustavo Noronha Silva. |
| 4108 |
| 4109 * platform/graphics/gstreamer/GStreamerGWorld.cpp: |
| 4110 (WebCore::GStreamerGWorld::GStreamerGWorld): |
| 4111 (WebCore::GStreamerGWorld::enterFullscreen): |
| 4112 (WebCore::GStreamerGWorld::exitFullscreen): |
| 4113 * platform/graphics/gstreamer/GStreamerGWorld.h: |
| 4114 |
| 4115 2011-10-27 Joseph Pecoraro <pecoraro@apple.com> |
| 4116 |
| 4117 Reviewed by David Kilzer. |
| 4118 |
| 4119 Make FeatureDefines Identical Across OS X Projects |
| 4120 https://bugs.webkit.org/show_bug.cgi?id=71051 |
| 4121 |
| 4122 * Configurations/FeatureDefines.xcconfig: |
| 4123 |
| 4124 2011-10-27 Joseph Pecoraro <pecoraro@apple.com> |
| 4125 |
| 4126 Correctly Guard Exported REQUEST_ANIMATION_FRAME Symbols |
| 4127 https://bugs.webkit.org/show_bug.cgi?id=71047 |
| 4128 |
| 4129 Reviewed by David Kilzer. |
| 4130 |
| 4131 * WebCore.exp.in: |
| 4132 |
| 4133 2011-10-27 Sheriff Bot <webkit.review.bot@gmail.com> |
| 4134 |
| 4135 Unreviewed, rolling out r98626. |
| 4136 http://trac.webkit.org/changeset/98626 |
| 4137 https://bugs.webkit.org/show_bug.cgi?id=71066 |
| 4138 |
| 4139 Does not compile on cr-win (Requested by jamesr_ on #webkit). |
| 4140 |
| 4141 * platform/graphics/chromium/FontChromiumWin.cpp: |
| 4142 (WebCore::Font::drawGlyphs): |
| 4143 * platform/graphics/skia/SkiaFontWin.cpp: |
| 4144 (WebCore::paintSkiaText): |
| 4145 |
| 4146 2011-10-27 Tony Chang <tony@chromium.org> |
| 4147 |
| 4148 Fix a compiler warning caught by gcc 4.6.1. Need to return something. |
| 4149 |
| 4150 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: |
| 4151 (WebCore::CCSchedulerStateMachine::nextAction): |
| 4152 |
| 4153 2011-10-27 Vsevolod Vlasov <vsevik@chromium.org> |
| 4154 |
| 4155 Web Inspector: Advanced search style fixes. |
| 4156 https://bugs.webkit.org/show_bug.cgi?id=71036 |
| 4157 |
| 4158 Reviewed by Pavel Feldman. |
| 4159 |
| 4160 * inspector/front-end/AdvancedSearchController.js: |
| 4161 (WebInspector.SearchView): |
| 4162 * inspector/front-end/Images/statusbarButtonGlyphs.png: |
| 4163 * inspector/front-end/inspector.css: |
| 4164 (.search-view .search-panel): |
| 4165 (.search-view .search-panel input[type="search"].search-config-search): |
| 4166 (.search-view .search-panel input[type="checkbox"].search-config-checkbo
x): |
| 4167 (body:not(.platform-mac) .search-view .search-panel input[type="checkbox
"].search-config-checkbox): |
| 4168 (body.platform-mac .search-view .search-panel input[type="checkbox"].sea
rch-config-checkbox): |
| 4169 (#drawer-status-bar .search-status-bar-progress): |
| 4170 (body:not(.platform-mac) #drawer-status-bar .search-status-bar-progress)
: |
| 4171 (body.platform-mac #drawer-status-bar .search-status-bar-progress): |
| 4172 |
| 4173 2011-10-27 David Hyatt <hyatt@apple.com> |
| 4174 |
| 4175 https://bugs.webkit.org/show_bug.cgi?id=71061 |
| 4176 |
| 4177 [CSS Line Grid] Add support for parsing the line-grid property. |
| 4178 |
| 4179 New tests in fast/line-grid. |
| 4180 |
| 4181 Reviewed by Dan Bernstein. |
| 4182 |
| 4183 * css/CSSComputedStyleDeclaration.cpp: |
| 4184 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): |
| 4185 * css/CSSParser.cpp: |
| 4186 (WebCore::CSSParser::parseValue): |
| 4187 * css/CSSProperty.cpp: |
| 4188 (WebCore::CSSProperty::isInheritedProperty): |
| 4189 * css/CSSPropertyNames.in: |
| 4190 * css/CSSStyleSelector.cpp: |
| 4191 (WebCore::CSSStyleSelector::applyProperty): |
| 4192 * rendering/style/RenderStyle.h: |
| 4193 (WebCore::InheritedFlags::lineGrid): |
| 4194 (WebCore::InheritedFlags::setLineGrid): |
| 4195 (WebCore::InheritedFlags::initialLineGrid): |
| 4196 * rendering/style/StyleRareInheritedData.cpp: |
| 4197 (WebCore::StyleRareInheritedData::StyleRareInheritedData): |
| 4198 (WebCore::StyleRareInheritedData::operator==): |
| 4199 * rendering/style/StyleRareInheritedData.h: |
| 4200 |
| 4201 2011-10-27 Fady Samuel <fsamuel@chromium.org> |
| 4202 |
| 4203 iframes seem to occasionally doubly scale or scale incorrectly when page
ScaleFactor != 1.0 |
| 4204 https://bugs.webkit.org/show_bug.cgi?id=70552 |
| 4205 |
| 4206 Reviewed by Simon Fraser. |
| 4207 |
| 4208 Test: fast/frames/iframe-double-scale-contents.html |
| 4209 |
| 4210 The iframe's document style was using the page's scale factor, rather th
an the frame's (1.0). |
| 4211 If the page scale factor was set after layout was complete, then this wo
uld have no impact because the iframe's document style and layout is not recompu
ted, |
| 4212 but if the page scale factor is set prior to creating and laying out the
iframe, the iframe's content would be doubly scaled. |
| 4213 |
| 4214 * css/CSSStyleSelector.cpp: |
| 4215 (WebCore::CSSStyleSelector::styleForDocument): |
| 4216 |
| 4217 2011-10-27 Nat Duca <nduca@chromium.org> |
| 4218 |
| 4219 Unreviewed, fix CCSchedulerStateMachine build errors. |
| 4220 |
| 4221 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: |
| 4222 * platform/graphics/chromium/cc/CCSchedulerStateMachine.h: |
| 4223 |
| 4224 2011-10-27 Tony Chang <tony@chromium.org> |
| 4225 |
| 4226 fix sizing of auto sized flexbox |
| 4227 https://bugs.webkit.org/show_bug.cgi?id=70839 |
| 4228 |
| 4229 Reviewed by David Hyatt. |
| 4230 |
| 4231 Correctly set the height of the flexbox when we have a column flow |
| 4232 and the height is auto. |
| 4233 |
| 4234 Tests: css3/flexbox/columns-auto-size.html |
| 4235 css3/flexbox/flex-flow-margins-auto-size.html |
| 4236 |
| 4237 * rendering/RenderFlexibleBox.cpp: |
| 4238 (WebCore::RenderFlexibleBox::layoutBlock): Always computeLogicalHeight()
after we're done placing children. |
| 4239 (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): Set
the height as we place children. |
| 4240 |
| 4241 2011-10-25 Vangelis Kokkevis <vangelis@chromium.org> |
| 4242 |
| 4243 Add support for creating compositing layers for fixed position elements. |
| 4244 https://bugs.webkit.org/show_bug.cgi?id=69796 |
| 4245 |
| 4246 position:fixed elements will get a compositing layer if: |
| 4247 1. Settings:acceleratedCompositingForFixedPositionEnabled() returns true
, |
| 4248 2. The element has its own stacking context (e.g. has a z-index), and |
| 4249 3. The element's container is the RenderView (e.g. not a descendant of a
transformed element) |
| 4250 |
| 4251 Reviewed by Simon Fraser. |
| 4252 |
| 4253 |
| 4254 Test: compositing/geometry/fixed-position-composited-switch.html |
| 4255 |
| 4256 * page/Settings.cpp: |
| 4257 (WebCore::Settings::Settings): |
| 4258 * page/Settings.h: |
| 4259 (WebCore::Settings::setAcceleratedCompositingForFixedPositionEnabled): |
| 4260 (WebCore::Settings::acceleratedCompositingForFixedPositionEnabled): |
| 4261 * rendering/RenderLayerCompositor.cpp: |
| 4262 (WebCore::RenderLayerCompositor::RenderLayerCompositor): |
| 4263 (WebCore::RenderLayerCompositor::updateCompositingLayers): |
| 4264 (WebCore::RenderLayerCompositor::requiresCompositingLayer): |
| 4265 (WebCore::RenderLayerCompositor::requiresCompositingForPosition): |
| 4266 * rendering/RenderLayerCompositor.h: |
| 4267 * testing/Internals.cpp: |
| 4268 (WebCore::Internals::setEnableCompositingForFixedPosition): |
| 4269 * testing/Internals.h: |
| 4270 * testing/Internals.idl: |
| 4271 |
| 4272 2011-10-27 Arthur Hsu <arthurhsu@chromium.org> |
| 4273 |
| 4274 https://bugs.webkit.org/show_bug.cgi?id=70390 |
| 4275 Ensure font load for Skia backend during printing. |
| 4276 |
| 4277 Reviewed by James Robinson. |
| 4278 |
| 4279 * platform/graphics/chromium/FontChromiumWin.cpp: |
| 4280 (WebCore::Font::drawGlyphs): |
| 4281 * platform/graphics/skia/SkiaFontWin.cpp: |
| 4282 (WebCore::paintSkiaText): |
| 4283 |
| 4284 2011-10-27 Michael Saboff <msaboff@apple.com> |
| 4285 |
| 4286 Investigate storing strings in 8-bit buffers when possible |
| 4287 https://bugs.webkit.org/show_bug.cgi?id=66161 |
| 4288 |
| 4289 Changes to support 8 bit StringImpl changes. |
| 4290 |
| 4291 Reviewed by Geoffrey Garen. |
| 4292 |
| 4293 No new tests, refactored StringImpl for 8 bit strings. |
| 4294 |
| 4295 * platform/text/cf/StringImplCF.cpp: |
| 4296 (WTF::StringImpl::createCFString): |
| 4297 |
| 4298 2011-10-27 Nat Duca <nduca@chromium.org> |
| 4299 |
| 4300 [chromium] Encapsulate state machine parts of scheduling in CCSchedulerS
tateMachine |
| 4301 https://bugs.webkit.org/show_bug.cgi?id=70714 |
| 4302 |
| 4303 Reland of ill-fated r98612. |
| 4304 |
| 4305 Reviewed by James Robinson. |
| 4306 |
| 4307 * WebCore.gypi: |
| 4308 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added. |
| 4309 (WebCore::CCSchedulerStateMachine::nextAction): |
| 4310 (WebCore::CCSchedulerStateMachine::updateState): |
| 4311 * platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added. |
| 4312 (WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine): |
| 4313 (WebCore::CCSchedulerStateMachine::operator=): |
| 4314 (WebCore::CCSchedulerStateMachine::commitPending): |
| 4315 (WebCore::CCSchedulerStateMachine::setNeedsRedraw): |
| 4316 (WebCore::CCSchedulerStateMachine::setNeedsCommit): |
| 4317 (WebCore::CCSchedulerStateMachine::beginFrameComplete): |
| 4318 (WebCore::CCSchedulerStateMachine::updateResourcesComplete): |
| 4319 |
| 4320 2011-10-27 Pavel Podivilov <podivilov@chromium.org> |
| 4321 |
| 4322 Get rid of optional parameters in the middle in IDLs. |
| 4323 https://bugs.webkit.org/show_bug.cgi?id=70816 |
| 4324 |
| 4325 Reviewed by Adam Barth. |
| 4326 |
| 4327 Optional parameters in the middle are prohibited by WebIDL spec. |
| 4328 |
| 4329 * bindings/js/JSCanvasRenderingContext2DCustom.cpp: |
| 4330 * bindings/scripts/CodeGeneratorJS.pm: |
| 4331 (GenerateHeader): |
| 4332 (GenerateImplementation): |
| 4333 * bindings/scripts/CodeGeneratorV8.pm: |
| 4334 (GenerateHeader): |
| 4335 (GenerateArgumentsCountCheck): |
| 4336 (GenerateImplementation): |
| 4337 * bindings/scripts/test/JS/JSTestObj.cpp: |
| 4338 (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOption
alArgs): |
| 4339 * bindings/scripts/test/TestObj.idl: |
| 4340 * bindings/scripts/test/V8/V8TestObj.cpp: |
| 4341 (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCal
lback): |
| 4342 * html/canvas/CanvasRenderingContext2D.idl: |
| 4343 * page/DOMWindow.idl: |
| 4344 |
| 4345 2011-10-27 Antti Koivisto <antti@apple.com> |
| 4346 |
| 4347 REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.htm
l |
| 4348 https://bugs.webkit.org/show_bug.cgi?id=71032 |
| 4349 |
| 4350 Reviewed by Dave Hyatt. |
| 4351 |
| 4352 If we apply an explicitly inherited property, we need to apply any furth
er |
| 4353 non-inherited properties as the property might get overridden again. |
| 4354 |
| 4355 * css/CSSStyleSelector.cpp: |
| 4356 (WebCore::CSSStyleSelector::styleForKeyframe): |
| 4357 (WebCore::CSSStyleSelector::styleForPage): |
| 4358 (WebCore::CSSStyleSelector::applyDeclaration): |
| 4359 (WebCore::CSSStyleSelector::applyDeclarations): |
| 4360 * css/CSSStyleSelector.h: |
| 4361 |
| 4362 2011-10-27 Julien Chaffraix <jchaffraix@webkit.org> |
| 4363 |
| 4364 Remove RenderTableSection::m_gridRows |
| 4365 https://bugs.webkit.org/show_bug.cgi?id=70570 |
| 4366 |
| 4367 Reviewed by Darin Adler. |
| 4368 |
| 4369 No new test, refactoring only. |
| 4370 |
| 4371 Just nuke the old field that was duplicating |
| 4372 m_grid.size(). |
| 4373 |
| 4374 * rendering/RenderTableSection.h: |
| 4375 (WebCore::RenderTableSection::numRows): |
| 4376 * rendering/RenderTableSection.cpp: |
| 4377 (WebCore::RenderTableSection::RenderTableSection): |
| 4378 (WebCore::RenderTableSection::ensureRows): |
| 4379 (WebCore::RenderTableSection::setCellLogicalWidths): |
| 4380 (WebCore::RenderTableSection::calcRowLogicalHeight): |
| 4381 (WebCore::RenderTableSection::layoutRows): |
| 4382 (WebCore::RenderTableSection::calcOuterBorderBefore): |
| 4383 (WebCore::RenderTableSection::calcOuterBorderAfter): |
| 4384 (WebCore::RenderTableSection::calcOuterBorderStart): |
| 4385 (WebCore::RenderTableSection::calcOuterBorderEnd): |
| 4386 (WebCore::RenderTableSection::firstLineBoxBaseline): |
| 4387 (WebCore::RenderTableSection::paint): |
| 4388 (WebCore::RenderTableSection::paintObject): |
| 4389 (WebCore::RenderTableSection::clearGrid): |
| 4390 (WebCore::RenderTableSection::numColumns): |
| 4391 (WebCore::RenderTableSection::appendColumn): |
| 4392 (WebCore::RenderTableSection::splitColumn): |
| 4393 s/m_gridRows/m_grid.size()/. |
| 4394 Also updated the code as m_grid.size() is unsigned. |
| 4395 |
| 4396 (WebCore::RenderTableSection::recalcCells): |
| 4397 The old code would keep the grid's memory but we have to clear it to pro
perly |
| 4398 count the elements. To avoid lots of small reallocations, we reallocate
the |
| 4399 buffer at the old capacity upfront. |
| 4400 |
| 4401 2011-10-27 Nat Duca <nduca@chromium.org> |
| 4402 |
| 4403 Unreviewed, rolling out r98612. |
| 4404 http://trac.webkit.org/changeset/98612 |
| 4405 https://bugs.webkit.org/show_bug.cgi?id=70714 |
| 4406 |
| 4407 Broke build |
| 4408 |
| 4409 * WebCore.gypi: |
| 4410 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Removed. |
| 4411 * platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Removed. |
| 4412 |
| 4413 2011-10-24 Nat Duca <nduca@chromium.org> |
| 4414 |
| 4415 [chromium] Encapsulate state machine parts of scheduling in CCSchedulerS
tateMachine |
| 4416 https://bugs.webkit.org/show_bug.cgi?id=70714 |
| 4417 |
| 4418 Reviewed by James Robinson. |
| 4419 |
| 4420 * WebCore.gypi: |
| 4421 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added. |
| 4422 (WebCore::CCSchedulerStateMachine::nextAction): |
| 4423 (WebCore::CCSchedulerStateMachine::updateState): |
| 4424 * platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added. |
| 4425 (WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine): |
| 4426 (WebCore::CCSchedulerStateMachine::operator=): |
| 4427 (WebCore::CCSchedulerStateMachine::commitPending): |
| 4428 (WebCore::CCSchedulerStateMachine::setNeedsRedraw): |
| 4429 (WebCore::CCSchedulerStateMachine::setNeedsCommit): |
| 4430 (WebCore::CCSchedulerStateMachine::beginFrameComplete): |
| 4431 (WebCore::CCSchedulerStateMachine::updateResourcesComplete): |
| 4432 |
| 4433 2011-10-27 Dan Bernstein <mitz@apple.com> |
| 4434 |
| 4435 <rdar://problem/10262205> Allow column progression to be independent of
writing mode |
| 4436 https://bugs.webkit.org/show_bug.cgi?id=71028 |
| 4437 |
| 4438 Reviewed by Darin Adler. |
| 4439 |
| 4440 Tests: fast/multicol/block-axis-horizontal-bt.html |
| 4441 fast/multicol/block-axis-horizontal-tb.html |
| 4442 fast/multicol/block-axis-vertical-lr.html |
| 4443 fast/multicol/block-axis-vertical-rl.html |
| 4444 fast/multicol/flipped-blocks-hit-test.html |
| 4445 |
| 4446 Allow “columns” to be stacked along the block axis rather than the inlin
e axis. This can facilitate |
| 4447 paginated interfaces. A column-axis property is added in order to enable
this mode. |
| 4448 |
| 4449 * css/CSSComputedStyleDeclaration.cpp: |
| 4450 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle the
column-axis property. |
| 4451 * css/CSSParser.cpp: |
| 4452 (WebCore::CSSParser::parseValue): Ditto. |
| 4453 * css/CSSPrimitiveValueMappings.h: |
| 4454 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Map ColumnAxis values t
o identifiers. |
| 4455 (WebCore::CSSPrimitiveValue::operator ColumnAxis): Map identifiers to Co
lumnAxis values. |
| 4456 * css/CSSProperty.cpp: |
| 4457 (WebCore::CSSProperty::isInheritedProperty): Updated to return false for
the column-axis property. |
| 4458 * css/CSSPropertyNames.in: Added -webkit-column-axis. |
| 4459 * css/CSSStyleSelector.cpp: |
| 4460 (WebCore::CSSStyleSelector::applyProperty): Handle column-axis. |
| 4461 * rendering/ColumnInfo.h: |
| 4462 (WebCore::ColumnInfo::ColumnInfo): Added m_progressionAxis to the initia
lization list. |
| 4463 (WebCore::ColumnInfo::progressionAxis): Added this getter. |
| 4464 (WebCore::ColumnInfo::setProgressionAxis): Added this setter. |
| 4465 * rendering/RenderBlock.cpp: |
| 4466 (WebCore::RenderBlock::addOverflowFromChildren): Simplified, and thus al
so made this function work |
| 4467 with block-axis column progression. |
| 4468 (WebCore::RenderBlock::paintColumnRules): Added code to paint rules betw
een columns with block-axis |
| 4469 progression. |
| 4470 (WebCore::RenderBlock::paintColumnContents): Adjusted the painting offse
t for the block-axis |
| 4471 column progression case. |
| 4472 (WebCore::RenderBlock::nodeAtPoint): Fixed hit-testing in flipped-blocks
writing modes. This is |
| 4473 covered by flipped-blocks-hit-test.html. |
| 4474 (WebCore::RenderBlock::hitTestColumns): Adjusted the offset for the bloc
k-axis column progression |
| 4475 case. |
| 4476 (WebCore::RenderBlock::calcColumnWidth): Set the column width to the con
tent logical width in |
| 4477 the block-axis column progression case. The column-width and column-coun
t properties are ignored. |
| 4478 (WebCore::RenderBlock::setDesiredColumnCountAndWidth): Set the column pr
ogression axis based on |
| 4479 the style. |
| 4480 (WebCore::RenderBlock::columnCount): Broke up an assertion into two. |
| 4481 (WebCore::RenderBlock::columnRectAt): Updated for block-axis column prog
ression. |
| 4482 (WebCore::RenderBlock::adjustPointToColumnContents): Ditto. |
| 4483 (WebCore::RenderBlock::adjustRectForColumns): Ditto. |
| 4484 (WebCore::RenderBlock::adjustForColumns): Ditto. |
| 4485 * rendering/RenderLayer.cpp: |
| 4486 (WebCore::RenderLayer::paintChildLayerIntoColumns): Adjusted the offser
for the block-axis column |
| 4487 progression case. |
| 4488 (WebCore::RenderLayer::hitTestChildLayerColumns): Ditto. |
| 4489 * rendering/style/RenderStyle.h: |
| 4490 (WebCore::InheritedFlags::columnAxis): Added this getter. |
| 4491 (WebCore::InheritedFlags::hasInlineColumnAxis): Added. Checks the column
axis against the writing |
| 4492 mode. |
| 4493 (WebCore::InheritedFlags::specifiesColumns): Changed to return true if t
he specified column axis |
| 4494 is the block axis. |
| 4495 (WebCore::InheritedFlags::setColumnAxis): Added this setter. |
| 4496 (WebCore::InheritedFlags::initialColumnAxis): Added. Returns AutoColumnA
xis. |
| 4497 * rendering/style/RenderStyleConstants.h: Added a ColumnAxis enum. |
| 4498 * rendering/style/StyleMultiColData.cpp: |
| 4499 (WebCore::StyleMultiColData::StyleMultiColData): Added m_axis to the ini
tialization list. |
| 4500 (WebCore::StyleMultiColData::operator==): Compare m_axis. |
| 4501 * rendering/style/StyleMultiColData.h: Added m_axis member variable. |
| 4502 |
| 4503 2011-10-27 Mihnea Ovidenie <mihnea@adobe.com> |
| 4504 |
| 4505 [CSSRegions]Flag regions with custom styling |
| 4506 https://bugs.webkit.org/show_bug.cgi?id=70733 |
| 4507 |
| 4508 Reviewed by David Hyatt. |
| 4509 |
| 4510 Region elements that have custom region styling are now marked according
ly. |
| 4511 |
| 4512 Test: fast/regions/render-region-custom-style-mark.html |
| 4513 |
| 4514 * css/CSSStyleSelector.cpp: |
| 4515 (WebCore::CSSStyleSelector::checkRegionStyle): |
| 4516 * css/CSSStyleSelector.h: |
| 4517 * rendering/RenderRegion.cpp: |
| 4518 (WebCore::RenderRegion::RenderRegion): |
| 4519 (WebCore::RenderRegion::styleDidChange): |
| 4520 * rendering/RenderRegion.h: |
| 4521 (WebCore::RenderRegion::hasCustomRegionStyle): |
| 4522 (WebCore::RenderRegion::setHasCustomRegionStyle): |
| 4523 * rendering/RenderTreeAsText.cpp: |
| 4524 (WebCore::writeRenderFlowThreads): |
| 4525 |
| 4526 2011-10-27 Sheriff Bot <webkit.review.bot@gmail.com> |
| 4527 |
| 4528 Unreviewed, rolling out r98556. |
| 4529 http://trac.webkit.org/changeset/98556 |
| 4530 https://bugs.webkit.org/show_bug.cgi?id=71031 |
| 4531 |
| 4532 The test added by the patch doesn't pass on Snow Leopard |
| 4533 (Requested by rniwa on #webkit). |
| 4534 |
| 4535 * editing/TextCheckingHelper.cpp: |
| 4536 (WebCore::checkTextOfParagraph): |
| 4537 * testing/Internals.cpp: |
| 4538 * testing/Internals.h: |
| 4539 * testing/Internals.idl: |
| 4540 |
| 4541 2011-10-27 Mike Reed <reed@google.com> |
| 4542 |
| 4543 [skia] replace offscreen technique with native support for antialiased c
lipping |
| 4544 https://bugs.webkit.org/show_bug.cgi?id=70748 |
| 4545 |
| 4546 Reviewed by Stephen White. |
| 4547 |
| 4548 ~100 layout tests need to be rebaselined, as the native aa-clipping diff
ers sometimes in the low |
| 4549 bits of the result. Other than that, the results should be the same, exc
ept that now the drawing |
| 4550 can go directly to the canvas, rather than being direct offscreen and th
en have that result |
| 4551 "clipped" during the restore. This has the effect of allowing LCD text t
o be drawing inside a |
| 4552 antialiased clip area. |
| 4553 |
| 4554 * platform/graphics/skia/PlatformContextSkia.cpp: |
| 4555 (WebCore::PlatformContextSkia::State::State): |
| 4556 (WebCore::PlatformContextSkia::State::cloneInheritedProperties): |
| 4557 (WebCore::PlatformContextSkia::clipPathAntiAliased): |
| 4558 (WebCore::PlatformContextSkia::restore): |
| 4559 * platform/graphics/skia/PlatformContextSkia.h: |
| 4560 |
| 4561 2011-10-27 Tony Chang <tony@chromium.org> |
| 4562 |
| 4563 use main/cross instead of logical width/height when talking about flow d
irection |
| 4564 https://bugs.webkit.org/show_bug.cgi?id=70977 |
| 4565 |
| 4566 Reviewed by Ojan Vafai. |
| 4567 |
| 4568 Flexbox code uses logical in function names to refer to the flow |
| 4569 direction. This is confusing because writing mode also uses logical, |
| 4570 but this is a diffent usage. To avoid confusion, be explicit about |
| 4571 main vs cross axis. Extent is used instead of width/height. |
| 4572 |
| 4573 No new tests, just a refactoring. |
| 4574 |
| 4575 * rendering/RenderFlexibleBox.cpp: |
| 4576 (WebCore::RenderFlexibleBox::mainAxisLengthForChild): |
| 4577 (WebCore::RenderFlexibleBox::crossAxisLength): |
| 4578 (WebCore::RenderFlexibleBox::setCrossExtent): |
| 4579 (WebCore::RenderFlexibleBox::crossExtentForChild): |
| 4580 (WebCore::RenderFlexibleBox::mainExtentForChild): |
| 4581 (WebCore::RenderFlexibleBox::crossAxisExtent): |
| 4582 (WebCore::RenderFlexibleBox::mainAxisExtent): |
| 4583 (WebCore::RenderFlexibleBox::crossAxisContentExtent): |
| 4584 (WebCore::RenderFlexibleBox::mainAxisContentExtent): |
| 4585 (WebCore::RenderFlexibleBox::crossAxisBorderAndPaddingExtent): |
| 4586 (WebCore::RenderFlexibleBox::crossAxisMarginExtentForChild): |
| 4587 (WebCore::RenderFlexibleBox::flowAwareLocationForChild): |
| 4588 (WebCore::RenderFlexibleBox::setFlowAwareLocationForChild): |
| 4589 (WebCore::RenderFlexibleBox::mainAxisBorderAndPaddingExtentForChild): |
| 4590 (WebCore::RenderFlexibleBox::mainAxisScrollbarExtentForChild): |
| 4591 (WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForFlexItem): |
| 4592 (WebCore::RenderFlexibleBox::layoutInlineDirection): |
| 4593 (WebCore::RenderFlexibleBox::positiveFlexForChild): Since flex only |
| 4594 matters in the main axis, there's no reason to deambiguate it here. |
| 4595 (WebCore::RenderFlexibleBox::negativeFlexForChild): Ditto. |
| 4596 (WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Alignment
is always |
| 4597 in the cross axis direction, so don't include that in the method nam
e. |
| 4598 (WebCore::RenderFlexibleBox::marginBoxAscent): |
| 4599 (WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): |
| 4600 (WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirect
ion): |
| 4601 (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): |
| 4602 (WebCore::RenderFlexibleBox::adjustAlignmentForChild): Alignment is alw
ays |
| 4603 in the cross axis direction, so don't include that in the method nam
e. |
| 4604 (WebCore::RenderFlexibleBox::alignChildrenBlockDirection): |
| 4605 * rendering/RenderFlexibleBox.h: |
| 4606 |
| 4607 2011-10-27 Mark Hahnenberg <mhahnenberg@apple.com> |
| 4608 |
| 4609 De-virtualize JSCell::toThisObject |
| 4610 https://bugs.webkit.org/show_bug.cgi?id=70958 |
| 4611 |
| 4612 Reviewed by Geoffrey Garen. |
| 4613 |
| 4614 No new tests. |
| 4615 |
| 4616 Converted all instances of toThisObject to static functions, |
| 4617 added toThisObject to the MethodTable, and replaced all call sites |
| 4618 with a corresponding lookup in the MethodTable. |
| 4619 |
| 4620 * bindings/js/JSDOMWindowBase.cpp: |
| 4621 (WebCore::JSDOMWindowBase::toThisObject): |
| 4622 * bindings/js/JSDOMWindowBase.h: |
| 4623 * bindings/js/JSErrorHandler.cpp: |
| 4624 (WebCore::JSErrorHandler::handleEvent): |
| 4625 * bridge/NP_jsobject.cpp: |
| 4626 (_NPN_Invoke): |
| 4627 * bridge/qt/qt_runtime.cpp: |
| 4628 (JSC::Bindings::QtRuntimeConnectionMethod::call): |
| 4629 |
| 4630 2011-10-27 Adam Roben <aroben@apple.com> |
| 4631 |
| 4632 Windows build fix after r98512 |
| 4633 |
| 4634 * html/HTMLMediaElement.cpp: Moved a Web Audio-related #include inside a
n appropriate ENABLE |
| 4635 guard. |
| 4636 |
| 4637 2011-10-27 Adam Roben <aroben@apple.com> |
| 4638 |
| 4639 Regenerate WebCore's Localizable.strings file |
| 4640 |
| 4641 All I did was run update-webkit-localizable-strings. A few localizer com
ments changed, and |
| 4642 some strings (which must have been hand-added) got moved to a different
part of the file. |
| 4643 |
| 4644 * English.lproj/Localizable.strings: |
| 4645 |
| 4646 2011-10-27 Daniel Cheng <dcheng@chromium.org> |
| 4647 |
| 4648 Clean up MicroDataItemValue to use const String& instead of String |
| 4649 https://bugs.webkit.org/show_bug.cgi?id=70978 |
| 4650 |
| 4651 Reviewed by Tony Chang. |
| 4652 |
| 4653 * html/MicroDataItemValue.cpp: |
| 4654 (WebCore::MicroDataItemValue::MicroDataItemValue): |
| 4655 * html/MicroDataItemValue.h: |
| 4656 |
| 4657 2011-10-27 Antti Koivisto <antti@apple.com> |
| 4658 |
| 4659 Use StringHasher to generate the matched declaration cache hash |
| 4660 https://bugs.webkit.org/show_bug.cgi?id=71012 |
| 4661 |
| 4662 Reviewed by Kenneth Rohde Christiansen and Andreas Kling. |
| 4663 |
| 4664 It is faster and better than the current custom function. |
| 4665 |
| 4666 * css/CSSStyleSelector.cpp: |
| 4667 (WebCore::CSSStyleSelector::computeDeclarationHash): |
| 4668 |
| 4669 2011-10-27 Kentaro Hara <haraken@chromium.org> |
| 4670 |
| 4671 Refactor OptionsObject.cpp |
| 4672 https://bugs.webkit.org/show_bug.cgi?id=70572 |
| 4673 |
| 4674 Reviewed by Adam Barth. |
| 4675 |
| 4676 For example, OptionsObject::getKeyBool() is an alias of |
| 4677 OptionsObject::getKeyValue(const String& key, bool& value). |
| 4678 We should remove OptionsObject::getKeyXXXX() (XXXX is some specific type
) |
| 4679 and unify them into OptionsObject::get(const String& key, XXXX& value). |
| 4680 c.f. Corresponding JSC methods are unified into |
| 4681 JSDictionary::convertValue(JSC::ExecState*, JSC::JSValue, XXXX&). |
| 4682 |
| 4683 The result of git diff is weird, but this patch is making just the follo
wing changes: |
| 4684 - Replaced getKeyBool(), getKeyInt32(), getKeyDouble() and getKeyString(
) with get(). |
| 4685 - Renamed getKeyStringWithUndefinedOrNullCheck() to getWithUndefinedOrNu
llCheck(). |
| 4686 - Removed getKeyDOMStringList() and getKeyKeyRange(), since these are no
t used. |
| 4687 - Move definitions of get() from .h to .cpp. |
| 4688 |
| 4689 No new tests. No change in behavior. |
| 4690 |
| 4691 * bindings/v8/OptionsObject.cpp: |
| 4692 (WebCore::OptionsObject::get): Renamed from getKeyValue(). |
| 4693 (WebCore::OptionsObject::getKey): No change to this method. git diff see
ms to misunderstand as if it is modified. |
| 4694 (WebCore::OptionsObject::getKeyDOMStringList): Removed, since no one is
using it. |
| 4695 (WebCore::OptionsObject::getKeyKeyRange): Ditto. |
| 4696 (WebCore::OptionsObject::getWithUndefinedOrNullCheck): No change to this
method. git diff seems to misunderstand as if it is modified. |
| 4697 * bindings/v8/OptionsObject.h: Moved definitions of get() to OptionsObje
ct.cpp |
| 4698 * bindings/v8/custom/V8EventConstructors.cpp: |
| 4699 * bindings/v8/custom/V8WebKitMutationObserverCustom.cpp: |
| 4700 (WebCore::V8WebKitMutationObserver::observeCallback): Replaced getKeyXXX
X() to get(); |
| 4701 * storage/IDBDatabase.cpp: |
| 4702 (WebCore::IDBDatabase::createObjectStore): Ditto. |
| 4703 * storage/IDBObjectStore.cpp: |
| 4704 (WebCore::IDBObjectStore::createIndex): Ditto. |
| 4705 |
| 4706 2011-10-27 Andreas Kling <kling@webkit.org> |
| 4707 |
| 4708 StyleSheet.parentStyleSheet does not work. |
| 4709 https://bugs.webkit.org/show_bug.cgi?id=70956 |
| 4710 |
| 4711 Reviewed by Antti Koivisto. |
| 4712 |
| 4713 Since StyleSheet is only ever parented by a CSSRule, we need |
| 4714 to go through that rule when resolving the StyleSheet's parent. |
| 4715 |
| 4716 Test: fast/css/stylesheet-parentStyleSheet.html |
| 4717 |
| 4718 * css/StyleSheet.cpp: |
| 4719 (WebCore::StyleSheet::parentStyleSheet): |
| 4720 |
| 4721 2011-10-27 Antoine Labour <piman@chromium.org> |
| 4722 |
| 4723 Disable blending when drawing opaque layers |
| 4724 https://bugs.webkit.org/show_bug.cgi?id=70085 |
| 4725 |
| 4726 Reviewed by James Robinson. |
| 4727 |
| 4728 Covered by compositing/ tests, as well as a new unit test: |
| 4729 CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers |
| 4730 |
| 4731 * platform/graphics/chromium/LayerChromium.cpp: |
| 4732 (WebCore::LayerChromium::LayerChromium): |
| 4733 (WebCore::LayerChromium::pushPropertiesTo): |
| 4734 * platform/graphics/chromium/LayerRendererChromium.cpp: |
| 4735 (WebCore::LayerRendererChromium::drawLayer): |
| 4736 * platform/graphics/chromium/cc/CCLayerImpl.cpp: |
| 4737 (WebCore::CCLayerImpl::CCLayerImpl): |
| 4738 * platform/graphics/chromium/cc/CCLayerImpl.h: |
| 4739 (WebCore::CCLayerImpl::setOpaque): |
| 4740 (WebCore::CCLayerImpl::opaque): |
| 4741 |
| 4742 2011-10-27 Joshua Bell <jsbell@chromium.org> |
| 4743 |
| 4744 IndexedDB: Passing empty array to IDBDatabase.transaction should raise e
xception |
| 4745 https://bugs.webkit.org/show_bug.cgi?id=70251 |
| 4746 |
| 4747 Reviewed by Adam Barth. |
| 4748 |
| 4749 IDBDatabase.transaction() supported being called with an empty array to |
| 4750 lock all object stores. Support for this was rejected from inclusion in |
| 4751 the IDB spec due to performance concerns. This patch removes that |
| 4752 functionality. |
| 4753 |
| 4754 A special case in the spec (passing a string instead of an array) worked |
| 4755 in WebKit accidentally, by resolving the string to an empty array. This |
| 4756 needed explicit support. Support for DOMString[] is added to the binding |
| 4757 code generators (reliant on DOMStringList) to ensure JS arrays are not |
| 4758 coerced to DOMStrings. This matches the proposed IDL. |
| 4759 |
| 4760 * bindings/scripts/CodeGeneratorV8.pm: |
| 4761 (GenerateParametersCheckExpression): |
| 4762 (GetNativeType): |
| 4763 (JSValueToNative): |
| 4764 (IsArrayType): |
| 4765 * bindings/scripts/IDLStructure.pm: |
| 4766 * storage/IDBDatabase.cpp: |
| 4767 (WebCore::IDBDatabase::transaction): |
| 4768 * storage/IDBDatabase.h: |
| 4769 (WebCore::IDBDatabase::transaction): |
| 4770 * storage/IDBDatabase.idl: |
| 4771 * storage/IDBTransactionBackendImpl.cpp: |
| 4772 (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): |
| 4773 (WebCore::IDBTransactionBackendImpl::objectStore): |
| 4774 |
| 4775 2011-10-27 Ken Buchanan <kenrb@chromium.org> |
| 4776 |
| 4777 Crash due to nested first-letter selectors |
| 4778 https://bugs.webkit.org/show_bug.cgi?id=70457 |
| 4779 |
| 4780 Now only the lowest-level first-letter pseudostyle will be applied to |
| 4781 a given piece of text. Previously the last renderer to have layout |
| 4782 done would have its pseudostyle applied, no matter where it was in the |
| 4783 tree. |
| 4784 |
| 4785 Reviewed by David Hyatt. |
| 4786 |
| 4787 * renderer/RenderBlock.cpp: |
| 4788 (WebCore::RenderBlock::updateFirstLetter): Use the pseudostyle from |
| 4789 the lowest level node to have one |
| 4790 |
| 4791 2011-10-27 Andras Becsi <andras.becsi@nokia.com> |
| 4792 |
| 4793 Fix the build if NO_LISTBOX_RENDERING is enabled |
| 4794 https://bugs.webkit.org/show_bug.cgi?id=71009 |
| 4795 |
| 4796 Reviewed by Kenneth Rohde Christiansen. |
| 4797 |
| 4798 If NO_LISTBOX_RENDERING is enabled RenderMenuList::listBoxSelectItem use
s the |
| 4799 HTMLSelectElement::listBoxSelectItem function which was accidentally rem
oved in r97533. |
| 4800 Reintroduce HTMLSelectElement::listBoxSelectItem with a NO_LISTBOX_RENDE
RING guard to unbreak this setup. |
| 4801 |
| 4802 This is covered by: |
| 4803 Source/WebCore/manual-tests/no-listbox-rendering.html |
| 4804 |
| 4805 * html/HTMLSelectElement.cpp: |
| 4806 (WebCore::HTMLSelectElement::listBoxSelectItem): Reintroduce. |
| 4807 * html/HTMLSelectElement.h: |
| 4808 |
| 4809 2011-10-27 Shinya Kawanaka <shinyak@google.com> |
| 4810 |
| 4811 Implement legacy text check emulation in unified text check interface. |
| 4812 https://bugs.webkit.org/show_bug.cgi?id=70299 |
| 4813 |
| 4814 Reviewed by Hajime Morita. |
| 4815 |
| 4816 When UNIFIED_TEXT_CHECKING is off, WebCore::checkTextOfParagraph() emula
tes |
| 4817 TextCheckerClient::checkTextOfParagraph() using checkSpellingOfString an
d checkGrammarOfString. |
| 4818 |
| 4819 This emulation can be used by setting the flag on. |
| 4820 This can be done by WebCore::Internals::setUnifiedTextCheckingEnabled. |
| 4821 |
| 4822 Test: editing/spelling/spelling-unified-emulation.html |
| 4823 |
| 4824 * editing/TextCheckingHelper.cpp: |
| 4825 (WebCore::findBadGrammars): Added. |
| 4826 (WebCore::findMisspellings): Added. |
| 4827 (WebCore::checkTextOfParagraph): |
| 4828 Emulates TextCheckerClients::checkTextOfParagraph if UNIFIED_TEXT_CHEC
KING is off. |
| 4829 * testing/Internals.cpp: |
| 4830 (WebCore::Internals::setUnifiedTextCheckingEnabled): flag setter. |
| 4831 (WebCore::Internals::unifiedTextCheckingEnabled): flag getter. |
| 4832 * testing/Internals.h: |
| 4833 * testing/Internals.idl: |
| 4834 |
| 4835 2011-10-27 Philippe Normand <pnormand@igalia.com> |
| 4836 |
| 4837 Unreviewed, remove those un-needed files committed by error in |
| 4838 r98554. |
| 4839 |
| 4840 * platform/audio/gstreamer/#AudioFileReaderGStreamer.h#: Removed. |
| 4841 * platform/audio/gstreamer/.#AudioFileReaderGStreamer.h: Removed. |
| 4842 |
| 4843 2011-10-27 Philippe Normand <pnormand@igalia.com> and Zan Dobersek <zandobers
ek@gmail.com> |
| 4844 |
| 4845 [GStreamer] WebAudio AudioFileReader implementation |
| 4846 https://bugs.webkit.org/show_bug.cgi?id=69834 |
| 4847 |
| 4848 Reviewed by Martin Robinson. |
| 4849 |
| 4850 Basic FileReader implementation, supporting one or 2 audio |
| 4851 channels. An empty AudioDestination is also provided, its complete |
| 4852 implementation is handled in bug 69835. |
| 4853 |
| 4854 * GNUmakefile.am: |
| 4855 * GNUmakefile.list.am: |
| 4856 * platform/audio/gstreamer/AudioDestinationGStreamer.cpp: Added. |
| 4857 (WebCore::AudioDestination::create): |
| 4858 (WebCore::AudioDestination::hardwareSampleRate): |
| 4859 (WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer): |
| 4860 (WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer): |
| 4861 (WebCore::AudioDestinationGStreamer::start): |
| 4862 (WebCore::AudioDestinationGStreamer::stop): |
| 4863 * platform/audio/gstreamer/AudioDestinationGStreamer.h: Added. |
| 4864 (WebCore::AudioDestinationGStreamer::isPlaying): |
| 4865 (WebCore::AudioDestinationGStreamer::sampleRate): |
| 4866 (WebCore::AudioDestinationGStreamer::sourceProvider): |
| 4867 * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp: Added. |
| 4868 (WebCore::getGStreamerAudioCaps): |
| 4869 (WebCore::getFloatFromByteReader): |
| 4870 (WebCore::copyGstreamerBuffersToAudioChannel): |
| 4871 (WebCore::onAppsinkNewBufferCallback): |
| 4872 (WebCore::messageCallback): |
| 4873 (WebCore::onGStreamerDeinterleavePadAddedCallback): |
| 4874 (WebCore::onGStreamerDeinterleaveReadyCallback): |
| 4875 (WebCore::onGStreamerDecodebinPadAddedCallback): |
| 4876 (WebCore::AudioFileReader::AudioFileReader): |
| 4877 (WebCore::AudioFileReader::~AudioFileReader): |
| 4878 (WebCore::AudioFileReader::handleBuffer): |
| 4879 (WebCore::AudioFileReader::handleMessage): |
| 4880 (WebCore::AudioFileReader::handleNewDeinterleavePad): |
| 4881 (WebCore::AudioFileReader::deinterleavePadsConfigured): |
| 4882 (WebCore::AudioFileReader::plugDeinterleave): |
| 4883 (WebCore::AudioFileReader::createBus): |
| 4884 (WebCore::createBusFromAudioFile): |
| 4885 (WebCore::createBusFromInMemoryAudioFile): |
| 4886 * platform/audio/gtk/AudioBusGtk.cpp: Added. |
| 4887 (WebCore::AudioBus::loadPlatformResource): |
| 4888 |
| 4889 2011-10-27 Philippe Normand <pnormand@igalia.com> |
| 4890 |
| 4891 Unreviewed, rebaseline of the bindings tests after r98501 which |
| 4892 removed getOwnPropertySlotVirtual. |
| 4893 |
| 4894 * bindings/scripts/test/JS/JSTestInterface.cpp: |
| 4895 * bindings/scripts/test/JS/JSTestInterface.h: |
| 4896 * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: |
| 4897 * bindings/scripts/test/JS/JSTestMediaQueryListListener.h: |
| 4898 * bindings/scripts/test/JS/JSTestObj.cpp: |
| 4899 * bindings/scripts/test/JS/JSTestObj.h: |
| 4900 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: |
| 4901 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: |
| 4902 |
| 4903 2011-10-27 Ilya Tikhonovsky <loislo@chromium.org> |
| 4904 |
| 4905 WebInspector: View throughs the exception when a child view are removed
by removeChildren call. |
| 4906 https://bugs.webkit.org/show_bug.cgi?id=71002 |
| 4907 |
| 4908 Another followup fix after r98225. |
| 4909 |
| 4910 Reviewed by Pavel Feldman. |
| 4911 |
| 4912 * inspector/front-end/DatabaseTableView.js: |
| 4913 (WebInspector.DatabaseTableView.prototype._queryFinished): |
| 4914 (WebInspector.DatabaseTableView.prototype._queryError): |
| 4915 |
| 4916 2011-10-27 Vsevolod Vlasov <vsevik@chromium.org> |
| 4917 |
| 4918 Web Inspector: Execution line in selected call frame should keep showing
after toggling format source. |
| 4919 https://bugs.webkit.org/show_bug.cgi?id=70906 |
| 4920 |
| 4921 Reviewed by Yury Semikhatsky. |
| 4922 |
| 4923 Test: inspector/debugger/selected-call-frame-after-formatting-source.htm
l |
| 4924 |
| 4925 * inspector/front-end/DebuggerPresentationModel.js: |
| 4926 (WebInspector.DebuggerPresentationModel.prototype.setFormatSource): |
| 4927 |
| 4928 2011-10-27 Steve Block <steveblock@google.com> |
| 4929 |
| 4930 Numerous debug build fixes |
| 4931 |
| 4932 Unreviewed build fix. |
| 4933 |
| 4934 No new tests, buuld fix only. |
| 4935 |
| 4936 * loader/icon/IconDatabase.cpp: urlForLogging() is used by both LOG() an
d LOG_ERROR() |
| 4937 * storage/AbstractDatabase.h: databaseDebugName() is used by both LOG()
and LOG_ERROR() |
| 4938 * storage/DatabaseTask.cpp: m_complete is only available when !LOG_DISAB
LED |
| 4939 |
| 4940 2011-10-27 Vsevolod Vlasov <vsevik@chromium.org> |
| 4941 |
| 4942 Web Inspector: Refactor ScriptsPanel so that ConsoleView does not depend
on it. |
| 4943 https://bugs.webkit.org/show_bug.cgi?id=70899 |
| 4944 |
| 4945 Moved methods used in console view to DebuggerPresentationModel. |
| 4946 Changed debuggerPaused handler logic so that selectedCallFrame is never
null when debugger is paused. |
| 4947 |
| 4948 Reviewed by Pavel Feldman. |
| 4949 |
| 4950 * inspector/front-end/ConsoleView.js: |
| 4951 * inspector/front-end/DebuggerPresentationModel.js: |
| 4952 (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused): |
| 4953 (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame)
: |
| 4954 (WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCall
Frame): |
| 4955 (WebInspector.DebuggerPresentationModel.prototype.getSelectedCallFrameVa
riables.propertiesCollected): |
| 4956 (WebInspector.DebuggerPresentationModel.prototype.getSelectedCallFrameVa
riables): |
| 4957 (WebInspector.DebuggerPresentationModel.prototype._dispatchExecutionLine
Changed): |
| 4958 (WebInspector.DebuggerPresentationModel.prototype.get executionLineLocat
ion): |
| 4959 * inspector/front-end/ScriptsPanel.js: |
| 4960 (WebInspector.ScriptsPanel.prototype._consoleCommandEvaluatedInSelectedC
allFrame): |
| 4961 (WebInspector.ScriptsPanel.prototype._executionLineChanged): |
| 4962 (WebInspector.ScriptsPanel.prototype._updateExecutionLine): |
| 4963 (WebInspector.ScriptsPanel.prototype._callFrameSelected): |
| 4964 (WebInspector.ScriptsPanel.prototype._updateCallFrame): |
| 4965 |
| 4966 2011-10-27 Vsevolod Vlasov <vsevik@chromium.org> |
| 4967 |
| 4968 Web Inspector: Add support for advanced search in content scripts. |
| 4969 https://bugs.webkit.org/show_bug.cgi?id=70923 |
| 4970 |
| 4971 Reviewed by Yury Semikhatsky. |
| 4972 |
| 4973 * English.lproj/localizedStrings.js: |
| 4974 * inspector/front-end/ScriptsSearchScope.js: |
| 4975 * inspector/front-end/SettingsScreen.js: |
| 4976 (WebInspector.SettingsScreen): |
| 4977 |
| 4978 2011-10-27 Ilya Tikhonovsky <loislo@chromium.org> |
| 4979 |
| 4980 Unreviewed one line fix for DOMStorageItemsView. |
| 4981 It have to use this.detachChildViews instead of this.element.removeChild
ren after r98225. |
| 4982 |
| 4983 * inspector/front-end/DOMStorageItemsView.js: |
| 4984 (WebInspector.DOMStorageItemsView.prototype.update): |
| 4985 |
| 4986 2011-10-27 Antti Koivisto <antti@apple.com> |
| 4987 |
| 4988 Matched declaration cache |
| 4989 https://bugs.webkit.org/show_bug.cgi?id=70931 |
| 4990 |
| 4991 Reviewed by Darin Adler. |
| 4992 |
| 4993 Sets of style declarations are applied repeatedly for different elements
when calculating the document style. |
| 4994 The same set of applied declarations results in the same non-inherited s
tyle, independent of the element and |
| 4995 its context. We can use this to build a cache to speed up style applying
and to share more style data for |
| 4996 reduced memory usage. |
| 4997 |
| 4998 The patch reduces RenderStyle memory use ~40% and total memory use by ~7
% over HTML5 spec load. |
| 4999 It is also ~10% progression in PerformanceTests/Parser/html5-full-render
.html. |
| 5000 |
| 5001 * css/CSSProperty.cpp: |
| 5002 (WebCore::CSSProperty::isInheritedProperty): |
| 5003 * css/CSSProperty.h: |
| 5004 (WebCore::CSSProperty::CSSProperty): |
| 5005 (WebCore::CSSProperty::isInherited): |
| 5006 |
| 5007 We need to know which properties are inherited, something we didn't
have available so far. |
| 5008 |
| 5009 * css/CSSStyleSelector.cpp: |
| 5010 (WebCore::CSSStyleSelector::matchAllRules): |
| 5011 |
| 5012 A set of declarations is only cacheable if it contains no element sp
ecific style. This way we |
| 5013 don't need to worry about cache invalidation. The whole style select
or is reconstructed if the |
| 5014 stylesheets change, invalidating the cache too. |
| 5015 |
| 5016 (WebCore::CSSStyleSelector::styleForElement): |
| 5017 |
| 5018 Trigger image loads bit earlier so cached style will have them too. |
| 5019 |
| 5020 (WebCore::CSSStyleSelector::applyDeclaration): |
| 5021 (WebCore::CSSStyleSelector::applyDeclarations): |
| 5022 |
| 5023 Allow skipping over non-inherited properties. |
| 5024 |
| 5025 (WebCore::CSSStyleSelector::computeDeclarationHash): |
| 5026 |
| 5027 Hash function for declartion cache lookups. |
| 5028 |
| 5029 (WebCore::operator==): |
| 5030 (WebCore::operator!=): |
| 5031 (WebCore::CSSStyleSelector::findFromMatchedDeclarationCache): |
| 5032 |
| 5033 Lookup from cache. |
| 5034 |
| 5035 (WebCore::CSSStyleSelector::addToMatchedDeclarationCache): |
| 5036 |
| 5037 Add to cache. |
| 5038 |
| 5039 (WebCore::CSSStyleSelector::applyMatchedDeclarations): |
| 5040 |
| 5041 If cached style is found, copy the non-inherited properties from the
cache and apply the inherited properties (if any) only. |
| 5042 |
| 5043 Font and zoom changes force full applying as they can affect values
of other properties (this can be relaxed later). |
| 5044 |
| 5045 * css/CSSStyleSelector.h: |
| 5046 (WebCore::CSSStyleSelector::MatchResult::MatchResult): |
| 5047 |
| 5048 Cacheability bit. |
| 5049 |
| 5050 * rendering/style/RenderStyle.cpp: |
| 5051 (WebCore::RenderStyle::copyNonInheritedFrom): |
| 5052 * rendering/style/RenderStyle.h: |
| 5053 * rendering/style/SVGRenderStyle.cpp: |
| 5054 (WebCore::SVGRenderStyle::copyNonInheritedFrom): |
| 5055 * rendering/style/SVGRenderStyle.h: |
| 5056 |
| 5057 Functions for assembling RenderStyle from non-inherited parts of the
cached style. |
| 5058 |
| 5059 2011-10-27 Andrey Kosyakov <caseq@chromium.org> |
| 5060 |
| 5061 Web Inspector: [Extensions API] add ignoreCache flag to options of inspe
ctedWindow.reload() |
| 5062 https://bugs.webkit.org/show_bug.cgi?id=70926 |
| 5063 |
| 5064 Reviewed by Pavel Feldman. |
| 5065 |
| 5066 Test: http/tests/inspector/extensions-ignore-cache.html |
| 5067 |
| 5068 * inspector/front-end/ExtensionServer.js: |
| 5069 (WebInspector.ExtensionServer.prototype._onReload): |
| 5070 * inspector/front-end/externs.js: |
| 5071 (): |
| 5072 |
| 5073 2011-10-26 Steve Falkenburg <sfalken@apple.com> |
| 5074 |
| 5075 ResourceError doesn't support custom domains on Windows |
| 5076 https://bugs.webkit.org/show_bug.cgi?id=70983 |
| 5077 <rdar://problem/10352145> |
| 5078 |
| 5079 Reviewed by Oliver Hunt. |
| 5080 |
| 5081 * platform/network/cf/ResourceErrorCF.cpp: |
| 5082 (WebCore::ResourceError::platformLazyInit): Add fallback case for unknow
n error types. |
| 5083 |
| 5084 2011-10-26 Dan Bernstein <mitz@apple.com> |
| 5085 |
| 5086 Fix a slider thumb rendering regression in Chromium on OS X in r98520. |
| 5087 |
| 5088 Reviewed by Anders Carlsson. |
| 5089 |
| 5090 * rendering/RenderThemeMac.mm: |
| 5091 (WebCore::RenderThemeMac::paintSliderThumb): Reverted the changes to the
Chromium code path. |
| 5092 |
| 5093 2011-10-26 Julien Chaffraix <jchaffraix@webkit.org> |
| 5094 |
| 5095 Unreviewed, rolling out r98486. |
| 5096 http://trac.webkit.org/changeset/98486 |
| 5097 https://bugs.webkit.org/show_bug.cgi?id=70748 |
| 5098 |
| 5099 Broke Chromium's test_expectation.txt |
| 5100 |
| 5101 * platform/graphics/skia/PlatformContextSkia.cpp: |
| 5102 (WebCore::PlatformContextSkia::State::State): |
| 5103 (WebCore::PlatformContextSkia::State::cloneInheritedProperties): |
| 5104 (WebCore::PlatformContextSkia::clipPathAntiAliased): |
| 5105 (WebCore::PlatformContextSkia::restore): |
| 5106 (WebCore::PlatformContextSkia::applyAntiAliasedClipPaths): |
| 5107 * platform/graphics/skia/PlatformContextSkia.h: |
| 5108 |
| 5109 2011-10-26 Dan Bernstein <mitz@apple.com> |
| 5110 |
| 5111 <rdar://problem/10350775> REGRESSION (r97032): Slider thumb is not drawn |
| 5112 https://bugs.webkit.org/show_bug.cgi?id=70891 |
| 5113 |
| 5114 Reviewed by Anders Carlsson. |
| 5115 |
| 5116 * platform/mac/ThemeMac.mm: |
| 5117 (WebCore::ThemeMac::ensuredView): Set the WebCoreFlippedView’s size, bec
ause NSSliderCell |
| 5118 always shrinks the slider thumb to fit in the control view’s bounds. |
| 5119 * rendering/RenderThemeMac.mm: |
| 5120 (WebCore::RenderThemeMac::paintSliderThumb): Removed workaround code no
longer needed after |
| 5121 r97032. |
| 5122 |
| 5123 2011-10-26 Chris Rogers <crogers@google.com> |
| 5124 |
| 5125 Add AudioSourceProviderClient and setFormat() method so we can know audi
o stream format |
| 5126 https://bugs.webkit.org/show_bug.cgi?id=70155 |
| 5127 |
| 5128 Reviewed by Eric Carlson. |
| 5129 |
| 5130 No new tests. There isn't yet an implementation to test. |
| 5131 |
| 5132 * html/HTMLMediaElement.cpp: |
| 5133 (WebCore::HTMLMediaElement::createMediaPlayer): |
| 5134 (WebCore::HTMLMediaElement::setAudioSourceNode): |
| 5135 Let MediaPlayer know about the MediaElementAudioSourceNode so it can cal
lback with audio stream format information. |
| 5136 * platform/audio/AudioSourceProvider.h: |
| 5137 (WebCore::AudioSourceProvider::setClient): |
| 5138 Add abstract setClient() method so a client may know about stream format
information when it becomes available. |
| 5139 * platform/audio/AudioSourceProviderClient.h: Copied from Source/WebCore
/webaudio/MediaElementAudioSourceNode.h. |
| 5140 (WebCore::AudioSourceProviderClient::~AudioSourceProviderClient): |
| 5141 Add abstract class AudioSourceProviderClient which implements setFormat(
) to receive audio stream format information. |
| 5142 * webaudio/MediaElementAudioSourceNode.cpp: |
| 5143 (WebCore::MediaElementAudioSourceNode::setFormat): |
| 5144 Concrete implementation of setFormat() so MediaElementAudioSourceNode ca
n create necessary audio converters. |
| 5145 * webaudio/MediaElementAudioSourceNode.h: |
| 5146 Make MediaElementAudioSourceNode implement AudioSourceProviderClient so
it can get audio stream format information |
| 5147 when its setFormat() method is called. |
| 5148 |
| 5149 2011-10-26 Julien Chaffraix <jchaffraix@webkit.org> |
| 5150 |
| 5151 Unreviewed, rolling out r98483. |
| 5152 http://trac.webkit.org/changeset/98483 |
| 5153 https://bugs.webkit.org/show_bug.cgi?id=47156 |
| 5154 |
| 5155 Change is causing some crashes and ASSERTs. |
| 5156 |
| 5157 * loader/cache/CachedImage.cpp: |
| 5158 (WebCore::CachedImage::lookupImageForSize): |
| 5159 (WebCore::CachedImage::lookupImageForRenderer): |
| 5160 (WebCore::CachedImage::lookupOrCreateImageForRenderer): |
| 5161 (WebCore::CachedImage::setContainerSizeForRenderer): |
| 5162 (WebCore::CachedImage::imageSizeForRenderer): |
| 5163 (WebCore::CachedImage::computeIntrinsicDimensions): |
| 5164 (WebCore::CachedImage::createImage): |
| 5165 * loader/cache/CachedImage.h: |
| 5166 * page/ChromeClient.h: |
| 5167 * rendering/ImageBySizeCache.cpp: |
| 5168 (WebCore::ImageBySizeCache::addClient): |
| 5169 (WebCore::ImageBySizeCache::removeClient): |
| 5170 (WebCore::ImageBySizeCache::imageForSize): |
| 5171 (WebCore::ImageBySizeCache::sizeForClient): |
| 5172 * rendering/ImageBySizeCache.h: |
| 5173 * rendering/RenderBoxModelObject.cpp: |
| 5174 (WebCore::RenderBoxModelObject::calculateFillTileSize): |
| 5175 (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): |
| 5176 (WebCore::RenderBoxModelObject::paintNinePieceImage): |
| 5177 * rendering/RenderBoxModelObject.h: |
| 5178 * rendering/RenderImage.cpp: |
| 5179 (WebCore::RenderImage::RenderImage): |
| 5180 (WebCore::RenderImage::imageDimensionsChanged): |
| 5181 (WebCore::RenderImage::isLogicalWidthSpecified): |
| 5182 (WebCore::RenderImage::isLogicalHeightSpecified): |
| 5183 (WebCore::RenderImage::computeReplacedLogicalWidth): |
| 5184 (WebCore::RenderImage::computeReplacedLogicalHeight): |
| 5185 (WebCore::RenderImage::calcAspectRatioLogicalWidth): |
| 5186 (WebCore::RenderImage::calcAspectRatioLogicalHeight): |
| 5187 * rendering/RenderImage.h: |
| 5188 * rendering/RenderImageResource.cpp: |
| 5189 (WebCore::RenderImageResource::setContainerSizeForRenderer): |
| 5190 * rendering/RenderImageResourceStyleImage.cpp: |
| 5191 * rendering/RenderImageResourceStyleImage.h: |
| 5192 (WebCore::RenderImageResourceStyleImage::image): |
| 5193 (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): |
| 5194 * rendering/RenderListMarker.cpp: |
| 5195 (WebCore::RenderListMarker::computePreferredLogicalWidths): |
| 5196 * rendering/RenderReplaced.cpp: |
| 5197 (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): |
| 5198 (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): |
| 5199 (WebCore::RenderReplaced::computeReplacedLogicalWidth): |
| 5200 * rendering/style/StyleCachedImage.cpp: |
| 5201 (WebCore::StyleCachedImage::computeIntrinsicDimensions): |
| 5202 (WebCore::StyleCachedImage::setContainerSizeForRenderer): |
| 5203 (WebCore::StyleCachedImage::addClient): |
| 5204 (WebCore::StyleCachedImage::removeClient): |
| 5205 * rendering/style/StyleCachedImage.h: |
| 5206 * rendering/style/StyleGeneratedImage.h: |
| 5207 (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): |
| 5208 * rendering/style/StyleImage.h: |
| 5209 * rendering/style/StylePendingImage.h: |
| 5210 (WebCore::StylePendingImage::setContainerSizeForRenderer): |
| 5211 * rendering/svg/RenderSVGImage.cpp: |
| 5212 (WebCore::RenderSVGImage::layout): |
| 5213 * rendering/svg/RenderSVGRoot.cpp: |
| 5214 (WebCore::RenderSVGRoot::computeIntrinsicWidth): |
| 5215 (WebCore::RenderSVGRoot::computeIntrinsicHeight): |
| 5216 (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): |
| 5217 (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): |
| 5218 (WebCore::RenderSVGRoot::layout): |
| 5219 (WebCore::RenderSVGRoot::paint): |
| 5220 (WebCore::RenderSVGRoot::calcViewport): |
| 5221 (WebCore::RenderSVGRoot::computeRectForRepaint): |
| 5222 * rendering/svg/RenderSVGRoot.h: |
| 5223 * svg/SVGLength.cpp: |
| 5224 (WebCore::SVGLength::determineViewport): |
| 5225 * svg/SVGSVGElement.cpp: |
| 5226 (WebCore::SVGSVGElement::SVGSVGElement): |
| 5227 (WebCore::SVGSVGElement::relativeWidthValue): |
| 5228 (WebCore::SVGSVGElement::relativeHeightValue): |
| 5229 (WebCore::SVGSVGElement::currentViewBoxRect): |
| 5230 * svg/SVGSVGElement.h: |
| 5231 (WebCore::SVGSVGElement::setContainerSize): |
| 5232 (WebCore::SVGSVGElement::containerSize): |
| 5233 (WebCore::SVGSVGElement::hasSetContainerSize): |
| 5234 * svg/graphics/SVGImage.cpp: |
| 5235 (WebCore::SVGImage::setContainerSize): |
| 5236 (WebCore::SVGImage::usesContainerSize): |
| 5237 (WebCore::SVGImage::size): |
| 5238 (WebCore::SVGImage::hasRelativeWidth): |
| 5239 (WebCore::SVGImage::hasRelativeHeight): |
| 5240 (WebCore::SVGImage::draw): |
| 5241 (WebCore::SVGImage::computeIntrinsicDimensions): |
| 5242 (WebCore::SVGImage::dataChanged): |
| 5243 * svg/graphics/SVGImage.h: |
| 5244 |
| 5245 2011-10-26 Eric Carlson <eric.carlson@apple.com> |
| 5246 |
| 5247 Constructors for all TextTrack interfaces should be available on DOMWind
ow |
| 5248 https://bugs.webkit.org/show_bug.cgi?id=70734 |
| 5249 |
| 5250 Reviewed by Sam Weinig. |
| 5251 |
| 5252 window-properties-expected.txt and global-constructors-expected.txt upda
ted for this change. |
| 5253 |
| 5254 * page/DOMWindow.idl: Add HTMLTrackElement, TextTrack, and TextTrackCueL
ist. |
| 5255 |
| 5256 2011-10-25 Andy Estes <aestes@apple.com> |
| 5257 |
| 5258 REGRESSION (r93108): Shadow DOM media controls created for plug-in backe
d media elements. |
| 5259 https://bugs.webkit.org/show_bug.cgi?id=70872 |
| 5260 |
| 5261 Reviewed by Eric Carlson. |
| 5262 |
| 5263 r93108 added a call to HTMLMediaElement::configureMediaControls() in |
| 5264 HTMLMediaElement::prepareForLoad(), which creates shadow DOM media |
| 5265 controls and is only appropriate to call when media elements are not |
| 5266 backed by plug-in proxies. |
| 5267 |
| 5268 Resolve this by refactoring configureMediaControls() to do the right |
| 5269 thing for the plug-in proxy case by calling MediaPlayer::setControls(). |
| 5270 |
| 5271 * html/HTMLMediaElement.cpp: |
| 5272 (WebCore::HTMLMediaElement::attributeChanged): Call |
| 5273 configureMediaControls() directly and remove the preprocessor |
| 5274 conditional. |
| 5275 (WebCore::HTMLMediaElement::configureMediaControls): Call |
| 5276 MediaPlayer::setControls() if PLUGIN_PROXY_FOR_VIDEO is enabled. |
| 5277 |
| 5278 2011-10-26 Jon Lee <jonlee@apple.com> |
| 5279 |
| 5280 selectedIndex gets set from -1 to 0 when modifying options |
| 5281 https://bugs.webkit.org/show_bug.cgi?id=70547 |
| 5282 <rdar://problem/8388856> |
| 5283 |
| 5284 Reviewed by Darin Adler. |
| 5285 |
| 5286 Changing the text causes a recalculation of the list items, which in the
menu list case |
| 5287 forces the first element to be selected. We check the value of the selec
ted option prior, |
| 5288 and restore it if it differs. |
| 5289 |
| 5290 Test: fast/dom/HTMLSelectElement/selected-index-preserved-when-option-te
xt-changes.html |
| 5291 |
| 5292 * html/HTMLOptionElement.cpp: |
| 5293 (WebCore::HTMLOptionElement::setText): |
| 5294 * html/HTMLSelectElement.h: promote usesMenuList() from private to publi
c for use by HTMLOptionElement |
| 5295 |
| 5296 2011-10-25 Alexey Proskuryakov <ap@apple.com> |
| 5297 |
| 5298 Embedded PDFs should be known to DocumentLoader |
| 5299 https://bugs.webkit.org/show_bug.cgi?id=70864 |
| 5300 |
| 5301 Reviewed by Darin Adler. |
| 5302 |
| 5303 * WebCore.exp.in: Added exports. |
| 5304 |
| 5305 2011-10-26 Mark Hahnenberg <mhahnenberg@apple.com> |
| 5306 |
| 5307 Remove getOwnPropertySlotVirtual |
| 5308 https://bugs.webkit.org/show_bug.cgi?id=70741 |
| 5309 |
| 5310 Reviewed by Geoffrey Garen. |
| 5311 |
| 5312 No new tests. |
| 5313 |
| 5314 Removed all declarations and definitions of getOwnPropertySlotVirtual. |
| 5315 Also replaced all call sites to getOwnPropertyVirtualVirtual with a |
| 5316 corresponding lookup in the MethodTable. |
| 5317 |
| 5318 * WebCore.exp.in: |
| 5319 * bindings/js/JSDOMWindowCustom.cpp: |
| 5320 (WebCore::DialogHandler::returnValue): |
| 5321 * bindings/js/JSDOMWindowShell.cpp: |
| 5322 (WebCore::JSDOMWindowShell::getOwnPropertySlot): |
| 5323 * bindings/js/JSDOMWindowShell.h: |
| 5324 * bindings/js/SerializedScriptValue.cpp: |
| 5325 (WebCore::CloneSerializer::getSparseIndex): |
| 5326 (WebCore::CloneSerializer::getProperty): |
| 5327 * bindings/scripts/CodeGeneratorJS.pm: |
| 5328 (GenerateHeader): |
| 5329 (GenerateImplementation): |
| 5330 (GenerateConstructorDeclaration): |
| 5331 (GenerateConstructorDefinition): |
| 5332 * bridge/objc/objc_runtime.h: |
| 5333 * bridge/objc/objc_runtime.mm: |
| 5334 * bridge/qt/qt_runtime.cpp: |
| 5335 * bridge/qt/qt_runtime.h: |
| 5336 * bridge/runtime_array.cpp: |
| 5337 * bridge/runtime_array.h: |
| 5338 * bridge/runtime_method.cpp: |
| 5339 * bridge/runtime_method.h: |
| 5340 * bridge/runtime_object.cpp: |
| 5341 * bridge/runtime_object.h: |
| 5342 |
| 5343 2011-10-26 Alejandro G. Castro <alex@igalia.com> |
| 5344 |
| 5345 [GTK] Fix distcheck compilation |
| 5346 https://bugs.webkit.org/show_bug.cgi?id=70921 |
| 5347 |
| 5348 Add EventTargetFactory.in to the dist files, required after |
| 5349 r98388. |
| 5350 |
| 5351 Reviewed by Martin Robinson. |
| 5352 |
| 5353 * GNUmakefile.am: |
| 5354 |
| 5355 2011-10-26 Michael Saboff <msaboff@apple.com> |
| 5356 |
| 5357 Increase StringImpl Flag Bits for 8 bit Strings |
| 5358 https://bugs.webkit.org/show_bug.cgi?id=70937 |
| 5359 |
| 5360 Increased the number of bits used for flags in StringImpl |
| 5361 from 6 to 8 bits. This frees up 2 flag bits that will be |
| 5362 used for 8-bit string support. Updated hash methods accordingly. |
| 5363 Changed hash value masking from the low bits to the high |
| 5364 bits. |
| 5365 |
| 5366 Reviewed by Darin Adler. |
| 5367 |
| 5368 * bindings/scripts/CodeGeneratorJS.pm: |
| 5369 (GenerateHashValue): |
| 5370 |
| 5371 2011-10-26 Dimitri Glazkov <dglazkov@chromium.org> |
| 5372 |
| 5373 REGRESSION (r94887): Scrolling the HTML spec is more jerky now than it w
as (regression) |
| 5374 https://bugs.webkit.org/show_bug.cgi?id=70857 |
| 5375 |
| 5376 Revert r94887, because it regressed performance. |
| 5377 |
| 5378 Rubber-stamped by Antti Koivisto. |
| 5379 |
| 5380 * css/CSSStyleSelector.cpp: |
| 5381 (WebCore::CSSStyleSelector::canShareStyleWithElement): |
| 5382 (WebCore::parentStylePreventsSharing): |
| 5383 * css/SelectorChecker.cpp: |
| 5384 (WebCore::SelectorChecker::checkSelector): |
| 5385 * dom/Element.cpp: |
| 5386 (WebCore::Element::recalcStyle): |
| 5387 (WebCore::checkForSiblingStyleChanges): |
| 5388 * rendering/style/RenderStyle.cpp: |
| 5389 (WebCore::RenderStyle::RenderStyle): |
| 5390 * rendering/style/RenderStyle.h: |
| 5391 (WebCore::InheritedFlags::childrenAffectedByDirectAdjacentRules): |
| 5392 (WebCore::InheritedFlags::setChildrenAffectedByDirectAdjacentRules): |
| 5393 |
| 5394 2011-10-26 Alexander Pavlov <apavlov@chromium.org> |
| 5395 |
| 5396 Web Inspector: Need workaround for the red crossed circle in the status
bar not bringing up the console when clicked |
| 5397 https://bugs.webkit.org/show_bug.cgi?id=70928 |
| 5398 |
| 5399 Reviewed by Pavel Feldman. |
| 5400 |
| 5401 * inspector/front-end/inspector.css: |
| 5402 (#error-count-img): |
| 5403 (#error-count + #warning-count-img): |
| 5404 (#warning-count-img): |
| 5405 * inspector/front-end/inspector.js: |
| 5406 (WebInspector._updateErrorAndWarningCounts): |
| 5407 |
| 5408 2011-10-26 Mike Reed <reed@google.com> |
| 5409 |
| 5410 [skia] replace offscreen technique with native support for antialiased c
lipping |
| 5411 https://bugs.webkit.org/show_bug.cgi?id=70748 |
| 5412 |
| 5413 Reviewed by Stephen White. |
| 5414 |
| 5415 ~100 layout tests need to be rebaselined, as the native aa-clipping diff
ers sometimes in the low |
| 5416 bits of the result. Other than that, the results should be the same, exc
ept that now the drawing |
| 5417 can go directly to the canvas, rather than being direct offscreen and th
en have that result |
| 5418 "clipped" during the restore. This has the effect of allowing LCD text t
o be drawing inside a |
| 5419 antialiased clip area. |
| 5420 |
| 5421 * platform/graphics/skia/PlatformContextSkia.cpp: |
| 5422 (WebCore::PlatformContextSkia::State::State): |
| 5423 (WebCore::PlatformContextSkia::State::cloneInheritedProperties): |
| 5424 (WebCore::PlatformContextSkia::clipPathAntiAliased): |
| 5425 (WebCore::PlatformContextSkia::restore): |
| 5426 |
| 5427 2011-10-26 Nikolas Zimmermann <nzimmermann@rim.com> |
| 5428 |
| 5429 CSS 2.1 failure: background-intrinsic-* |
| 5430 https://bugs.webkit.org/show_bug.cgi?id=47156 |
| 5431 |
| 5432 SVGs do not work as tiled background images |
| 5433 https://bugs.webkit.org/show_bug.cgi?id=16281 |
| 5434 |
| 5435 Apply preserveAspectRatio and synthesize viewboxes in <img> |
| 5436 https://bugs.webkit.org/show_bug.cgi?id=34521 |
| 5437 |
| 5438 SVG background doesn't resize properly when dimensions are changed |
| 5439 https://bugs.webkit.org/show_bug.cgi?id=42944 |
| 5440 |
| 5441 Images with percent height inside a floated div should use intrinsic hei
ght. |
| 5442 https://bugs.webkit.org/show_bug.cgi?id=45439 |
| 5443 |
| 5444 SVG image in HTML changes size as the window is resized |
| 5445 https://bugs.webkit.org/show_bug.cgi?id=52045 |
| 5446 |
| 5447 Reviewed by Antti Koivisto. |
| 5448 |
| 5449 Implement intrinsic sizing support for SVGImage (svg embedded through <h
tml:img>/<svg:image>/background-image/border-image/...). |
| 5450 This is demanded by CSS 2.1, and covered by new layout tests in LayoutTe
sts/css2.1 and several new custom testcases. |
| 5451 |
| 5452 Tests: css2.1/20110323/background-intrinsic-001.htm |
| 5453 css2.1/20110323/background-intrinsic-002.htm |
| 5454 css2.1/20110323/background-intrinsic-003.htm |
| 5455 css2.1/20110323/background-intrinsic-004.htm |
| 5456 css2.1/20110323/background-intrinsic-005.htm |
| 5457 css2.1/20110323/background-intrinsic-006.htm |
| 5458 css2.1/20110323/background-intrinsic-007.htm |
| 5459 css2.1/20110323/background-intrinsic-008.htm |
| 5460 css2.1/20110323/background-intrinsic-009.htm |
| 5461 svg/as-background-image/background-image-preserveaspectRatio-supp
ort.html (adapted from testcase from bug 34521) |
| 5462 svg/as-background-image/background-image-tiled.html (reduction fr
om bug 16281) |
| 5463 svg/as-background-image/same-image-two-instances-background-image
.html |
| 5464 svg/as-image/img-preserveAspectRatio-support-1.html (reduction fr
om bug 34521) |
| 5465 svg/as-image/same-image-two-instances.html |
| 5466 svg/as-image/svg-as-relative-image-with-explicit-size.html |
| 5467 svg/as-image/svg-image-change-content-size.xhtml (reduction from
bug 42944) |
| 5468 svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html |
| 5469 |
| 5470 * loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache. |
| 5471 (WebCore::CachedImage::lookupImageForSize): Use recently introduced Imag
eBySizeCache, to lookup an image for a certain size. |
| 5472 (WebCore::CachedImage::lookupImageForRenderer): Lookup image by renderer
, which first looks up a size for a renderer, then uses lookupImageForSize(). |
| 5473 (WebCore::createSVGImage): Refactored from createImage(), contains the S
VGImage creation part only. |
| 5474 (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently int
roduced ImageBySizeCache, to dynamically create copies of m_image if needed. |
| 5475 (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass
on container size handling to ImageBySizeCache. |
| 5476 (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size,
respecting per-renderer overrides, for a certain renderer. |
| 5477 (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary R
enderObject parameter. |
| 5478 (WebCore::CachedImage::addClientForRenderer): Special variant of addClie
nt(), overriding the existing in CachedResource. |
| 5479 (WebCore::CachedImage::removeClientForRenderer): Special variant of remo
veClient(), that also clears the image in the ImageBySizeCache. |
| 5480 (WebCore::CachedImage::createImage): Refactor SVGImage creation into cre
ateSVGImage() free function, to be useable from lookupOrCreateImageForRenderer()
. |
| 5481 * loader/cache/CachedImage.h: Expose removeClientForRenderer(). |
| 5482 * page/ChromeClient.h: |
| 5483 (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whethe
r a RenderSVGRoot is embedded through a SVGImage. Returns false, by default. |
| 5484 * rendering/ImageBySizeCache.cpp: |
| 5485 (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is va
lid. |
| 5486 (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() t
o be called w/o prio addClient() usage. |
| 5487 (WebCore::ImageBySizeCache::setClient): New helper function, that combin
es the usage of addClient/removeClient, for the use in CachedImage. |
| 5488 (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just ret
urn 0, instead of asserting. |
| 5489 (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retri
eves an image for a renderer, by lookup up its size and using imageForSize(). |
| 5490 * rendering/ImageBySizeCache.h: Expose setClient() & imageForRenderer(). |
| 5491 * rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size n
egotiation for images. |
| 5492 (WebCore::resolveWidthForRatio): New inline helper function used bz calc
ulateImageIntrinsicDimensions. |
| 5493 (WebCore::resolveHeightForRatio): Ditto. |
| 5494 (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto. |
| 5495 (WebCore::resolveAgainstIntrinsicRatio): Ditto. |
| 5496 (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New
helper function, containing the main algorithm, which is a pure transcription of
the spec. |
| 5497 (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculat
eImageIntrinsicDimensions() helper to figure out the intrinsic size. |
| 5498 (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propa
gate calculateFillTileSize() result to the image resource, via setContainerSizeF
orRenderer(). |
| 5499 (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateI
mageIntrinsicDimensions() helper to figure out the intrinsic size. |
| 5500 * rendering/RenderBoxModelObject.h: Clarify some variable names, added c
alculateImageIntrinsicDimensions(). |
| 5501 * rendering/RenderImage.cpp: |
| 5502 (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0
, 0). |
| 5503 (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from ima
geDimensionsChanged(). |
| 5504 (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeI
fNeeded(). |
| 5505 (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced:
:computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size
must be correct. |
| 5506 (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implem
entation for non-SVGImages. |
| 5507 (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true,
just like RenderPart, if embeddedContentBox is not null. |
| 5508 (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* r
enderer of the embedded SVG, if possible. |
| 5509 * rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / com
puteReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height(). |
| 5510 * rendering/RenderImageResource.cpp: |
| 5511 (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around
new "float containerZoomFactor" parameter. |
| 5512 * rendering/RenderImageResourceStyleImage.cpp: |
| 5513 (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is
now calling image() earlier than before. We now have to handle the case that th
e image is pending. |
| 5514 (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): P
ass zoom factor. |
| 5515 * rendering/RenderImageResourceStyleImage.h: |
| 5516 * rendering/RenderListMarker.cpp: |
| 5517 (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effecti
ve zoom to setContainerSizeForRenderer(). |
| 5518 * rendering/RenderReplaced.cpp: |
| 5519 (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized thi
s code, as RenderImage is using it as well now. Marginal changes needed. |
| 5520 (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto. |
| 5521 (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto. |
| 5522 * rendering/style/StyleCachedImage.cpp: |
| 5523 (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_
renderer to CachedImage, it's no longer needed. |
| 5524 (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float con
tainerZoomFactor" parameter. |
| 5525 (WebCore::StyleCachedImage::addClient): Forward to new addClientForRende
rer(). |
| 5526 (WebCore::StyleCachedImage::removeClient): Call new removeClientForRende
rer() instead of removeClient(), so the ImageBySizeCache is also updated. |
| 5527 * rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" pa
rameter to setContainerSizeForRenderer. |
| 5528 * rendering/style/StyleGeneratedImage.h: |
| 5529 (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto. |
| 5530 * rendering/style/StyleImage.h: Ditto. |
| 5531 * rendering/style/StylePendingImage.h: |
| 5532 (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto. |
| 5533 * rendering/svg/RenderSVGImage.cpp: |
| 5534 (WebCore::RenderSVGImage::layout): Always supply a container size when e
mbedding SVGs in <svg:image>. |
| 5535 * rendering/svg/RenderSVGRoot.cpp: Move "override container size" from S
VGSVGElement into RenderSVGRoot, where it belongs. |
| 5536 (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper meth
od to determine whether we're loaded through SVGImage. |
| 5537 (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a vali
d container size, it has precendence (only supplied via external SVGImages). |
| 5538 (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto. |
| 5539 (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need t
o track/override the viewport size anymore, all done in coputeReplacedLogical* n
ow. |
| 5540 (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always ma
tches the previously computed m_viewportSize. |
| 5541 (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto. |
| 5542 * rendering/svg/RenderSVGRoot.h: Move "override container size" from SVG
SVGElement into RenderSVGRoot, where it belongs. |
| 5543 (WebCore::RenderSVGRoot::containerSize): |
| 5544 (WebCore::RenderSVGRoot::setContainerSize): |
| 5545 * svg/SVGLength.cpp: |
| 5546 (WebCore::SVGLength::determineViewport): Resolve lengths against overrid
e container size in documents embedded through SVGImage. |
| 5547 * svg/SVGSVGElement.cpp: Remove "override container size" handling from
SVGSVGElement. |
| 5548 (WebCore::SVGSVGElement::SVGSVGElement): Ditto. |
| 5549 (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBo
x, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition. |
| 5550 * svg/SVGSVGElement.h: |
| 5551 * svg/graphics/SVGImage.cpp: |
| 5552 (WebCore::SVGImageChromeClient::setObserver): Helper function. |
| 5553 (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, us
ed to identify whether RenderSVGRoot is embedded through SVGImage. |
| 5554 (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFac
tor. |
| 5555 (WebCore::SVGImage::setContainerSize): Assert that container size is not
empty. We should never receive an empty container size. |
| 5556 (WebCore::SVGImage::usesContainerSize): Adapt to override container size
changes, it now lives in RenderSVGRoot instead of SVGSVGElement. |
| 5557 (WebCore::SVGImage::size): New algorithm to figure out the size of an em
bedded SVG, as demanded by the CSS/SVG specs. |
| 5558 (WebCore::SVGImage::draw): Stop calling layout() while painting! |
| 5559 (WebCore::SVGImage::embeddedContentBox): Add helper which returns the Re
nderSVGRoot of the document. |
| 5560 (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic rat
io calculation. |
| 5561 (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScr
ollbars(false), as SVG images now always synthesize a viewBox, and thus never re
ceive scrollbars. |
| 5562 * svg/graphics/SVGImage.h: |
| 5563 |
| 5564 2011-10-26 Kenneth Rohde Christiansen <kenneth@webkit.org> |
| 5565 |
| 5566 Properly suspend/resume Geolocation/DeviceMotion/DeviceOrientation objec
ts |
| 5567 https://bugs.webkit.org/show_bug.cgi?id=70328 |
| 5568 |
| 5569 Reviewed by Simon Hausmann. |
| 5570 |
| 5571 Also remove checks for m_client in DeviceMotionController as it can neve
r be null. |
| 5572 |
| 5573 No new tests, as the suspend/resume functionality is not fully working y
et. |
| 5574 |
| 5575 * dom/DeviceMotionController.cpp: |
| 5576 (WebCore::DeviceMotionController::timerFired): |
| 5577 (WebCore::DeviceMotionController::addListener): |
| 5578 (WebCore::DeviceMotionController::removeListener): |
| 5579 (WebCore::DeviceMotionController::removeAllListeners): |
| 5580 (WebCore::DeviceMotionController::suspend): |
| 5581 (WebCore::DeviceMotionController::resume): |
| 5582 * dom/DeviceMotionController.h: |
| 5583 * dom/DeviceOrientationController.cpp: |
| 5584 (WebCore::DeviceOrientationController::suspend): |
| 5585 (WebCore::DeviceOrientationController::resume): |
| 5586 * dom/DeviceOrientationController.h: |
| 5587 * dom/Document.cpp: |
| 5588 (WebCore::Document::suspendActiveDOMObjects): |
| 5589 (WebCore::Document::resumeActiveDOMObjects): |
| 5590 (WebCore::Document::stopActiveDOMObjects): |
| 5591 * dom/Document.h: |
| 5592 * dom/ScriptExecutionContext.h: |
| 5593 * page/GeolocationController.cpp: |
| 5594 (WebCore::GeolocationController::GeolocationController): |
| 5595 (WebCore::GeolocationController::removeObserver): |
| 5596 (WebCore::GeolocationController::suspend): |
| 5597 (WebCore::GeolocationController::resume): |
| 5598 * page/GeolocationController.h: |
| 5599 |
| 5600 2011-10-26 Pavel Feldman <pfeldman@google.com> |
| 5601 |
| 5602 Not reviewed: follow up to 98236 - moved inspector settings initializati
on earlier to unbreak settings panel. |
| 5603 |
| 5604 * inspector/front-end/TextEditorModel.js: |
| 5605 (WebInspector.TextEditorModel): |
| 5606 |
| 5607 2011-10-26 Zalan Bujtas <zbujtas@gmail.com> |
| 5608 |
| 5609 Name viewport change event consistently. |
| 5610 https://bugs.webkit.org/show_bug.cgi?id=70901 |
| 5611 |
| 5612 Reviewed by Kenneth Rohde Christiansen. |
| 5613 |
| 5614 Use ViewportPropertiesDidChange term consistently throughout WebKit. |
| 5615 |
| 5616 No tests needed as the change is only method renaming. |
| 5617 |
| 5618 * page/Chrome.cpp: |
| 5619 (WebCore::Chrome::dispatchViewportPropertiesDidChange): |
| 5620 * page/Chrome.h: |
| 5621 * page/ChromeClient.h: |
| 5622 (WebCore::ChromeClient::dispatchViewportPropertiesDidChange): |
| 5623 * page/Page.cpp: |
| 5624 (WebCore::Page::updateViewportArguments): |
| 5625 |
| 5626 2011-10-25 Stephen White <senorblanco@chromium.org> |
| 5627 |
| 5628 [chromium] Canvas2D should rate-limit drawing to prevent swamping the GP
U process. |
| 5629 https://bugs.webkit.org/show_bug.cgi?id=70367 |
| 5630 |
| 5631 Reviewed by James Robinson. |
| 5632 |
| 5633 Sadly, we don't have infrastructure to test this kind of GPU swamping |
| 5634 yet. |
| 5635 |
| 5636 * WebCore.gypi: |
| 5637 Add RateLimiter.* to the Chromium build. |
| 5638 * platform/graphics/chromium/Canvas2DLayerChromium.cpp: |
| 5639 (WebCore::Canvas2DLayerChromium::contentChanged): |
| 5640 When the layer is notified that the contents have changed, ping the |
| 5641 rate limiter. |
| 5642 * platform/graphics/chromium/Canvas2DLayerChromium.h: |
| 5643 * platform/graphics/chromium/GraphicsLayerChromium.cpp: |
| 5644 (WebCore::GraphicsLayerChromium::setContentsNeedsDisplay): |
| 5645 Call (new) virtual contentChanged() on a layer when its contents have |
| 5646 been changed (e.g., by a drawing call). |
| 5647 * platform/graphics/chromium/LayerChromium.h: |
| 5648 (WebCore::LayerChromium::contentChanged): |
| 5649 New virtual contentChanged(). |
| 5650 * platform/graphics/chromium/RateLimiter.cpp: Added. |
| 5651 (WebCore::RateLimiter::create): |
| 5652 Rate limiter factory function. |
| 5653 (WebCore::RateLimiter::RateLimiter): |
| 5654 (WebCore::RateLimiter::start): |
| 5655 Public API to start rate limiting a context. |
| 5656 (WebCore::RateLimiter::stop): |
| 5657 Public API to stop rate limiting a context. |
| 5658 (WebCore::RateLimiter::rateLimitContext): |
| 5659 Internal timer callback when a context should be rate limited. |
| 5660 * platform/graphics/chromium/RateLimiter.h: Added. |
| 5661 * platform/graphics/chromium/WebGLLayerChromium.cpp: |
| 5662 (WebCore::WebGLLayerChromium::WebGLLayerChromium): |
| 5663 Remove rate limiting timer and extension check (moved to RateLimiter). |
| 5664 (WebCore::WebGLLayerChromium::contentChanged): |
| 5665 The function formerly known as setTextureUpdated(), now renamed to |
| 5666 match the base class virtual contentChanged(). Call rate limiter in |
| 5667 CCLayerTreeHost (local implementation removed). |
| 5668 (WebCore::WebGLLayerChromium::setContext): |
| 5669 When the context is changed, stop the pending rate limiter on the old |
| 5670 context. Remove extension check (moved to RateLimiter). |
| 5671 * platform/graphics/chromium/WebGLLayerChromium.h: |
| 5672 Remove rate limiting timer and extension check (moved to RateLimiter). |
| 5673 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
| 5674 (WebCore::CCLayerTreeHost::startRateLimiter): |
| 5675 Public API for starting per-context rate limiter. |
| 5676 (WebCore::CCLayerTreeHost::stopRateLimiter): |
| 5677 Public API for stopping per-context rate limiter. |
| 5678 * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
| 5679 Implementation of per-GraphicsContext3D RateLimiter. |
| 5680 |
| 5681 |
| 5682 2011-10-26 Pavel Feldman <pfeldman@chromium.org> |
| 5683 |
| 5684 Not reviewed: fixing inspector extensions tests. |
| 5685 |
| 5686 * inspector/front-end/ConsoleMessage.js: |
| 5687 (WebInspector.ConsoleMessageImpl): |
| 5688 * inspector/front-end/ExtensionServer.js: |
| 5689 (WebInspector.ExtensionServer.prototype._onAddConsoleMessage): |
| 5690 |
| 5691 2011-10-26 Balazs Kelemen <kbalazs@webkit.org> |
| 5692 |
| 5693 ParallelJobs path of FEConvolveMatrix is erroneous |
| 5694 https://bugs.webkit.org/show_bug.cgi?id=70409 |
| 5695 |
| 5696 Reviewed by Zoltan Herczeg. |
| 5697 |
| 5698 Covered by existing tests. |
| 5699 |
| 5700 * platform/graphics/filters/FEConvolveMatrix.cpp: |
| 5701 (WebCore::FEConvolveMatrix::fastSetInteriorPixels): |
| 5702 Reject the silly idea that bytes per pixel ratio is 3 in preserveAlphaVa
lues mode. |
| 5703 The bug was hidden so far because that computation has no effect when we
are going |
| 5704 with the full inferior area in one round (in that case clipBottom and yE
nd are equals |
| 5705 and the value of the expression is always 0). With ParallelJobs we proce
ss sub-areas |
| 5706 on each thread which has triggered the issue. |
| 5707 |
| 5708 2011-10-26 Sheriff Bot <webkit.review.bot@gmail.com> |
| 5709 |
| 5710 Unreviewed, rolling out r98393. |
| 5711 http://trac.webkit.org/changeset/98393 |
| 5712 https://bugs.webkit.org/show_bug.cgi?id=70892 |
| 5713 |
| 5714 "Compilation is broken on Chromium Webkit Mac Builder (dbg) " |
| 5715 (Requested by yurys on #webkit). |
| 5716 |
| 5717 * platform/graphics/chromium/LayerChromium.h: |
| 5718 (WebCore::LayerChromium::setMasksToBounds): |
| 5719 (WebCore::LayerChromium::setMaskLayer): |
| 5720 |
| 5721 2011-10-26 Pavel Feldman <pfeldman@google.com> |
| 5722 |
| 5723 Web Inspector: order console message parameters for better optional para
meters handling. |
| 5724 https://bugs.webkit.org/show_bug.cgi?id=70809 |
| 5725 |
| 5726 Reviewed by Yury Semikhatsky. |
| 5727 |
| 5728 * inspector/Inspector.json: |
| 5729 * inspector/front-end/ConsoleMessage.js: |
| 5730 (WebInspector.ConsoleMessageImpl): |
| 5731 (WebInspector.ConsoleMessageImpl.prototype._formatMessage): |
| 5732 * inspector/front-end/ConsoleModel.js: |
| 5733 (WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated): |
| 5734 (WebInspector.ConsoleMessage.create): |
| 5735 (WebInspector.ConsoleDispatcher.prototype.messageAdded): |
| 5736 * inspector/front-end/ConsoleView.js: |
| 5737 (WebInspector.ConsoleCommandResult): |
| 5738 (WebInspector.ConsoleMessage.create): |
| 5739 * inspector/front-end/ExtensionServer.js: |
| 5740 (WebInspector.ExtensionServer.prototype._onAddConsoleMessage): |
| 5741 * inspector/front-end/NetworkManager.js: |
| 5742 (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse): |
| 5743 * inspector/front-end/inspector.js: |
| 5744 (WebInspector.log.logMessage): |
| 5745 (WebInspector.log): |
| 5746 |
| 5747 2011-10-26 Vsevolod Vlasov <vsevik@chromium.org> |
| 5748 |
| 5749 Web Inspector: Debugger fails when there is an invalid watch expression. |
| 5750 https://bugs.webkit.org/show_bug.cgi?id=70718 |
| 5751 |
| 5752 Reviewed by Pavel Feldman. |
| 5753 |
| 5754 Test: inspector/debugger/watch-expressions-panel-switch.html |
| 5755 |
| 5756 * inspector/front-end/ScriptsPanel.js: |
| 5757 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): |
| 5758 |
| 5759 2011-10-26 Fady Samuel <fsamuel@chromium.org> |
| 5760 |
| 5761 Page Scale Factor broken when navigating history on pages with child fra
mes |
| 5762 https://bugs.webkit.org/show_bug.cgi?id=70459 |
| 5763 |
| 5764 Reviewed by Darin Fisher. |
| 5765 |
| 5766 With frameScaleFactor now always returning 1.0 for subframes and pageSca
leFactor for the mainFrame, |
| 5767 and there being only a single pageScaleFactor, history for scaling is br
oken. Scaling history is |
| 5768 saved on a per frame basis but restored, overriding the per-page pageSca
leFactor multiple times. |
| 5769 As a result, sometimes pages that have subframes end up getting a scale
factor of 1.0 instead |
| 5770 of the correct scale factor that was assigned to the main frame. |
| 5771 |
| 5772 No new tests because I don't know how to test this. |
| 5773 |
| 5774 * loader/HistoryController.cpp: |
| 5775 (WebCore::HistoryController::restoreScrollPositionAndViewState): |
| 5776 |
| 5777 2011-10-26 Sheriff Bot <webkit.review.bot@gmail.com> |
| 5778 |
| 5779 Unreviewed, rolling out r98429. |
| 5780 http://trac.webkit.org/changeset/98429 |
| 5781 https://bugs.webkit.org/show_bug.cgi?id=70881 |
| 5782 |
| 5783 "webkit_gpu_tests fail in Chromium" (Requested by yurys on |
| 5784 #webkit). |
| 5785 |
| 5786 * platform/graphics/chromium/LayerRendererChromium.cpp: |
| 5787 (WebCore::LayerRendererChromium::initialize): |
| 5788 * platform/graphics/chromium/WebGLLayerChromium.cpp: |
| 5789 (WebCore::WebGLLayerChromium::layerRendererContext): |
| 5790 * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: |
| 5791 (WebCore::CCHeadsUpDisplay::enabled): |
| 5792 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
| 5793 (WebCore::CCLayerTreeHost::initialize): |
| 5794 (WebCore::CCLayerTreeHost::context): |
| 5795 (WebCore::CCLayerTreeHost::setNeedsAnimate): |
| 5796 (WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw): |
| 5797 (WebCore::CCLayerTreeHost::setNeedsRedraw): |
| 5798 (WebCore::CCLayerTreeHost::composite): |
| 5799 * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
| 5800 (WebCore::CCSettings::CCSettings): |
| 5801 * platform/graphics/chromium/cc/CCThreadProxy.cpp: |
| 5802 (WebCore::CCThreadProxy::setThread): |
| 5803 * platform/graphics/chromium/cc/CCThreadProxy.h: |
| 5804 |
| 5805 2011-10-26 Ben Wells <benwells@chromium.org> |
| 5806 |
| 5807 Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAto
p and Copy have errors |
| 5808 https://bugs.webkit.org/show_bug.cgi?id=66920 |
| 5809 |
| 5810 Reviewed by James Robinson. |
| 5811 |
| 5812 Test: fast/canvas/canvas-composite-image.html |
| 5813 |
| 5814 Use the same method as fills to handle composited drawImage calls that w
ill affect the whole |
| 5815 canvas. To do this code used when doing fills has been factored into sep
erate functions and |
| 5816 used by drawImage. Some functions used to do these types of operations h
ave also been renamed. |
| 5817 |
| 5818 * html/canvas/CanvasRenderingContext2D.cpp: |
| 5819 (WebCore::isFullCanvasCompositeMode): |
| 5820 (WebCore::CanvasRenderingContext2D::fill): |
| 5821 (WebCore::CanvasRenderingContext2D::fillRect): |
| 5822 (WebCore::CanvasRenderingContext2D::drawImage): |
| 5823 (WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect): |
| 5824 (WebCore::CanvasRenderingContext2D::createCompositingBuffer): |
| 5825 (WebCore::CanvasRenderingContext2D::compositeBuffer): |
| 5826 (WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage): |
| 5827 (WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill): |
| 5828 * html/canvas/CanvasRenderingContext2D.h: |
| 5829 |
| 5830 2011-10-25 Sheriff Bot <webkit.review.bot@gmail.com> |
| 5831 |
| 5832 Unreviewed, rolling out r98379. |
| 5833 http://trac.webkit.org/changeset/98379 |
| 5834 https://bugs.webkit.org/show_bug.cgi?id=70875 |
| 5835 |
| 5836 Did not pass on JSC ports (Requested by abarth on #webkit). |
| 5837 |
| 5838 * bindings/scripts/CodeGeneratorJS.pm: |
| 5839 (GenerateHeader): |
| 5840 (GenerateImplementation): |
| 5841 * bindings/scripts/CodeGeneratorV8.pm: |
| 5842 (GenerateHeader): |
| 5843 (GenerateArgumentsCountCheck): |
| 5844 (GenerateImplementation): |
| 5845 * html/canvas/CanvasRenderingContext2D.idl: |
| 5846 * page/DOMWindow.idl: |
| 5847 |
| 5848 2011-10-25 Sheriff Bot <webkit.review.bot@gmail.com> |
| 5849 |
| 5850 Unreviewed, rolling out r98346. |
| 5851 http://trac.webkit.org/changeset/98346 |
| 5852 https://bugs.webkit.org/show_bug.cgi?id=70874 |
| 5853 |
| 5854 Breaks JSC-based bots. (Requested by pfeldman on #webkit). |
| 5855 |
| 5856 * inspector/front-end/ScriptsPanel.js: |
| 5857 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): |
| 5858 |
| 5859 2011-10-25 Nat Duca <nduca@chromium.org> |
| 5860 |
| 5861 [chromium] Enable threaded compositing via CCThreadProxy::hasThread only |
| 5862 https://bugs.webkit.org/show_bug.cgi?id=70838 |
| 5863 |
| 5864 Reviewed by James Robinson. |
| 5865 |
| 5866 * platform/graphics/chromium/LayerRendererChromium.cpp: |
| 5867 (WebCore::LayerRendererChromium::initialize): |
| 5868 * platform/graphics/chromium/WebGLLayerChromium.cpp: |
| 5869 (WebCore::WebGLLayerChromium::layerRendererContext): |
| 5870 * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: |
| 5871 (WebCore::CCHeadsUpDisplay::enabled): |
| 5872 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
| 5873 (WebCore::CCLayerTreeHost::initialize): |
| 5874 (WebCore::CCLayerTreeHost::context): |
| 5875 (WebCore::CCLayerTreeHost::setNeedsAnimate): |
| 5876 (WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw): |
| 5877 (WebCore::CCLayerTreeHost::setNeedsRedraw): |
| 5878 (WebCore::CCLayerTreeHost::composite): |
| 5879 * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
| 5880 (WebCore::CCSettings::CCSettings): |
| 5881 * platform/graphics/chromium/cc/CCThreadProxy.cpp: |
| 5882 (WebCore::CCThreadProxy::hasThread): |
| 5883 * platform/graphics/chromium/cc/CCThreadProxy.h: |
| 5884 |
| 5885 2011-10-25 Xiaomei Ji <xji@chromium.org> |
| 5886 |
| 5887 --webkit-visual-word does not work in multi-line |
| 5888 https://bugs.webkit.org/show_bug.cgi?id=61344 |
| 5889 |
| 5890 Reviewed by Ryosuke Niwa. |
| 5891 |
| 5892 Get next or previous root inline box (which is not in the same |
| 5893 render object as the current root inline box) by traversing DOM node. |
| 5894 |
| 5895 Test: editing/selection/move-by-word-visually-inline-block-positioned-el
ement.html |
| 5896 |
| 5897 * editing/visible_units.cpp: |
| 5898 (WebCore::previousRootInlineBox): |
| 5899 (WebCore::nextRootInlineBox): |
| 5900 (WebCore::leftInlineBox): |
| 5901 (WebCore::rightInlineBox): |
| 5902 |
| 5903 2011-10-25 Adam Barth <abarth@webkit.org> |
| 5904 |
| 5905 JSEventTarget.cpp has a bunch of unnessary includes |
| 5906 https://bugs.webkit.org/show_bug.cgi?id=70865 |
| 5907 |
| 5908 Reviewed by Eric Seidel. |
| 5909 |
| 5910 In the process of removing these includes, I noticed we had a bunch of |
| 5911 non-autogenerated code in this file, which I've now autogenerated. |
| 5912 |
| 5913 * bindings/js/JSEventTarget.cpp: |
| 5914 (WebCore::toEventTarget): |
| 5915 - One subtly here is the outter static_cast, which is caused by an |
| 5916 inheritance infelicity in JavaScriptAudioNode, which I've noted |
| 5917 with a FIXME. In any case, the extra static_cast shouldn't cause |
| 5918 any trouble. |
| 5919 * webaudio/JavaScriptAudioNode.h: |
| 5920 |
| 5921 2011-10-25 Adam Barth <abarth@webkit.org> |
| 5922 |
| 5923 V8DOMWrapper.cpp has unneeded header includes |
| 5924 https://bugs.webkit.org/show_bug.cgi?id=70863 |
| 5925 |
| 5926 Reviewed by Eric Seidel. |
| 5927 |
| 5928 * bindings/v8/V8DOMWrapper.cpp: |
| 5929 |
| 5930 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com> |
| 5931 |
| 5932 Resetting baseline for test bindings |
| 5933 |
| 5934 Unreviewed preemptive build fix |
| 5935 |
| 5936 No new tests. |
| 5937 |
| 5938 * bindings/scripts/test/JS/JSTestObj.cpp: |
| 5939 * bindings/scripts/test/JS/JSTestObj.h: |
| 5940 |
| 5941 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com> |
| 5942 |
| 5943 Remove deletePropertyVirtual |
| 5944 https://bugs.webkit.org/show_bug.cgi?id=70738 |
| 5945 |
| 5946 Reviewed by Geoffrey Garen. |
| 5947 |
| 5948 No new tests. |
| 5949 |
| 5950 Removed all declarations and definitions of deletePropertyVirtual. |
| 5951 Also replaced all call sites to deletePropertyVirtual with a |
| 5952 corresponding lookup in the MethodTable. |
| 5953 |
| 5954 * WebCore.exp.in: |
| 5955 * bindings/js/JSDOMStringMapCustom.cpp: |
| 5956 (WebCore::JSDOMStringMap::deleteProperty): |
| 5957 * bindings/js/JSDOMWindowCustom.cpp: |
| 5958 (WebCore::JSDOMWindow::deleteProperty): |
| 5959 * bindings/js/JSDOMWindowShell.cpp: |
| 5960 (WebCore::JSDOMWindowShell::deleteProperty): |
| 5961 * bindings/js/JSDOMWindowShell.h: |
| 5962 * bindings/js/JSHistoryCustom.cpp: |
| 5963 (WebCore::JSHistory::deleteProperty): |
| 5964 * bindings/js/JSLocationCustom.cpp: |
| 5965 (WebCore::JSLocation::deleteProperty): |
| 5966 * bindings/js/JSStorageCustom.cpp: |
| 5967 (WebCore::JSStorage::deleteProperty): |
| 5968 * bindings/js/ScriptObject.cpp: |
| 5969 (WebCore::ScriptGlobalObject::remove): |
| 5970 * bindings/objc/WebScriptObject.mm: |
| 5971 (-[WebScriptObject removeWebScriptKey:]): |
| 5972 * bindings/scripts/CodeGeneratorJS.pm: |
| 5973 (GenerateHeader): |
| 5974 * bridge/NP_jsobject.cpp: |
| 5975 (_NPN_RemoveProperty): |
| 5976 * bridge/jni/jni_jsobject.mm: |
| 5977 (JavaJSObject::removeMember): |
| 5978 * bridge/objc/objc_runtime.h: |
| 5979 * bridge/objc/objc_runtime.mm: |
| 5980 * bridge/runtime_array.cpp: |
| 5981 * bridge/runtime_array.h: |
| 5982 * bridge/runtime_object.cpp: |
| 5983 * bridge/runtime_object.h: |
| 5984 |
| 5985 2011-10-25 Chris Fleizach <cfleizach@apple.com> |
| 5986 |
| 5987 AX: WebKit does not expose HTML label for slider elements |
| 5988 https://bugs.webkit.org/show_bug.cgi?id=70856 |
| 5989 |
| 5990 Reviewed by Darin Adler. |
| 5991 |
| 5992 Test: platform/mac/accessibility/slider-allows-title-ui-element.html |
| 5993 |
| 5994 * accessibility/AccessibilitySlider.h: |
| 5995 (WebCore::AccessibilitySlider::isControl): |
| 5996 * accessibility/mac/WebAccessibilityObjectWrapper.mm: |
| 5997 (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]): |
| 5998 |
| 5999 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com> |
| 6000 |
| 6001 Remove putVirtual |
| 6002 https://bugs.webkit.org/show_bug.cgi?id=70740 |
| 6003 |
| 6004 Reviewed by Geoffrey Garen. |
| 6005 |
| 6006 No new tests. |
| 6007 |
| 6008 Removed all declarations and definitions of putVirtual. |
| 6009 Also replaced all call sites to putVirtual with a |
| 6010 corresponding lookup in the MethodTable. |
| 6011 |
| 6012 * WebCore.exp.in: |
| 6013 * bindings/js/JSDOMWindowCustom.cpp: |
| 6014 * bindings/js/JSDOMWindowShell.cpp: |
| 6015 (WebCore::JSDOMWindowShell::put): |
| 6016 * bindings/js/JSDOMWindowShell.h: |
| 6017 * bindings/js/JSPluginElementFunctions.cpp: |
| 6018 (WebCore::runtimeObjectCustomPut): |
| 6019 * bindings/js/SerializedScriptValue.cpp: |
| 6020 (WebCore::CloneDeserializer::putProperty): |
| 6021 * bindings/objc/WebScriptObject.mm: |
| 6022 (-[WebScriptObject setValue:forKey:]): |
| 6023 (-[WebScriptObject setWebScriptValueAtIndex:value:]): |
| 6024 * bindings/scripts/CodeGeneratorJS.pm: |
| 6025 (GenerateHeader): |
| 6026 (GenerateImplementation): |
| 6027 * bridge/NP_jsobject.cpp: |
| 6028 (_NPN_SetProperty): |
| 6029 * bridge/jni/jni_jsobject.mm: |
| 6030 (JavaJSObject::setMember): |
| 6031 (JavaJSObject::setSlot): |
| 6032 * bridge/objc/objc_runtime.h: |
| 6033 * bridge/objc/objc_runtime.mm: |
| 6034 * bridge/qt/qt_runtime.cpp: |
| 6035 (JSC::Bindings::convertQVariantToValue): |
| 6036 * bridge/runtime_array.cpp: |
| 6037 * bridge/runtime_array.h: |
| 6038 * bridge/runtime_object.cpp: |
| 6039 * bridge/runtime_object.h: |
| 6040 * bridge/testqtbindings.cpp: |
| 6041 (main): |
| 6042 |
| 6043 2011-10-25 Adam Barth <abarth@webkit.org> |
| 6044 |
| 6045 EventTargetFactory.in is not sorted |
| 6046 https://bugs.webkit.org/show_bug.cgi?id=70855 |
| 6047 |
| 6048 Reviewed by Eric Seidel. |
| 6049 |
| 6050 This patch sorts the file. I was not able to measure a performance |
| 6051 difference using the microbenchmark included with this patch. |
| 6052 |
| 6053 * dom/EventTargetFactory.in: |
| 6054 |
| 6055 2011-10-25 Adam Barth <abarth@webkit.org> |
| 6056 |
| 6057 Attempt to fix the Windows build. Windows mashes all these files into |
| 6058 one, which doesn't respect the compilation unit rules of C++. |
| 6059 |
| 6060 * bindings/js/JSEventCustom.cpp: |
| 6061 * bindings/js/JSEventTarget.cpp: |
| 6062 |
| 6063 2011-10-25 Ryosuke Niwa <rniwa@webkit.org> |
| 6064 |
| 6065 Moving to the start of line should not place the caret outside of the ta
ble |
| 6066 https://bugs.webkit.org/show_bug.cgi?id=70757 |
| 6067 |
| 6068 Reviewed by Chang Shu. |
| 6069 |
| 6070 The bug was caused by positionAvoidingFirstPositionInTable. Get rid of t
he function. |
| 6071 |
| 6072 Test: editing/selection/table-lineboundary.html |
| 6073 |
| 6074 * editing/visible_units.cpp: |
| 6075 (WebCore::startPositionForLine): |
| 6076 |
| 6077 2011-10-25 Beth Dakin <bdakin@apple.com> |
| 6078 |
| 6079 https://bugs.webkit.org/show_bug.cgi?id=70852 |
| 6080 Setting up a HiDPI base-level GraphicsContext should be more straightfor
ward for |
| 6081 WebKit2 |
| 6082 |
| 6083 Reviewed by Dan Bernstein. |
| 6084 |
| 6085 This patch removes the old cg-only GraphicsContext::setBaseCTM() api, an
d adds |
| 6086 platform-independent GraphicsContext::applyDeviceScaleFactor(). |
| 6087 * WebCore.exp.in: |
| 6088 * platform/graphics/GraphicsContext.cpp: |
| 6089 (WebCore::GraphicsContext::platformApplyDeviceScaleFactor): |
| 6090 (WebCore::GraphicsContext::applyDeviceScaleFactor): |
| 6091 * platform/graphics/GraphicsContext.h: |
| 6092 * platform/graphics/cg/GraphicsContextCG.cpp: |
| 6093 (WebCore::GraphicsContext::platformApplyDeviceScaleFactor): |
| 6094 |
| 6095 Since this patch removes GraphicsContext::setBaseCTM(), this code has be
en |
| 6096 reverted to do what it used to do before that was added; it just calls i
nto |
| 6097 WebCoreSystemInterface directly. |
| 6098 * platform/graphics/cg/ImageCG.cpp: |
| 6099 (WebCore::Image::drawPattern): |
| 6100 |
| 6101 2011-10-25 Anders Carlsson <andersca@apple.com> |
| 6102 |
| 6103 Plug-ins have to use JavaScript to find out the current device scale fac
tor |
| 6104 https://bugs.webkit.org/show_bug.cgi?id=67225 |
| 6105 |
| 6106 Reviewed by Darin Adler. |
| 6107 |
| 6108 Test: platform/mac-wk2/plugins/contents-scale-factor.html |
| 6109 |
| 6110 Add NPNVcontentsScaleFactor, as per https://wiki.mozilla.org/NPAPI:Conte
ntsScaleFactor. |
| 6111 |
| 6112 * plugins/npapi.h: |
| 6113 |
| 6114 2011-10-25 Adam Klein <adamk@chromium.org> |
| 6115 |
| 6116 Forward declare MutationObserverEntry as a struct to fix clang build |
| 6117 https://bugs.webkit.org/show_bug.cgi?id=70853 |
| 6118 |
| 6119 Reviewed by Ryosuke Niwa. |
| 6120 |
| 6121 Node.h forward declared MutationObserverEntry as a class, and clang |
| 6122 complains if the two declarations don't match. |
| 6123 |
| 6124 * dom/Node.h: |
| 6125 |
| 6126 2011-10-25 Dan Bernstein <mitz@apple.com> |
| 6127 |
| 6128 Caret can be positioned or repainted incorrectly in flipped-blocks multi
-column blocks |
| 6129 https://bugs.webkit.org/show_bug.cgi?id=70851 |
| 6130 |
| 6131 Reviewed by Dave Hyatt. |
| 6132 |
| 6133 * manual-tests/caret-in-columns-flipped.html: Added. |
| 6134 * rendering/RenderBlock.cpp: |
| 6135 (WebCore::RenderBlock::adjustForColumns): Removed flipped-blocks writing
mode considerations |
| 6136 from this function, since not all callers were expecting it to account f
or flippedness. This makes |
| 6137 it similar to adjustRectForColumns() in not adjusting for flippedness. |
| 6138 * rendering/RenderBox.cpp: |
| 6139 (WebCore::RenderBox::offsetFromContainer): In the columns case, account
for flipped-blocks modes |
| 6140 by first mapping the point and the offset to non-flipped, non-columns sp
ace, then adjusting for |
| 6141 columns, then flipping. |
| 6142 |
| 6143 2011-10-25 Michal Mocny <mmocny@google.com> |
| 6144 |
| 6145 LayerRendererChromium::setVisible called needlessly without a visibility
change |
| 6146 https://bugs.webkit.org/show_bug.cgi?id=70766 |
| 6147 |
| 6148 Reviewed by Kenneth Russell. |
| 6149 |
| 6150 Check that visibility has actually changed before calling LayerRendererC
hromium::setVisible |
| 6151 |
| 6152 * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: |
| 6153 (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl): |
| 6154 (WebCore::CCLayerTreeHostImpl::setVisible): |
| 6155 * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: |
| 6156 |
| 6157 2011-10-25 Anders Carlsson <andersca@apple.com> |
| 6158 |
| 6159 REGRESSION(97821): HistoryController::itemsAreClones crashes a lot |
| 6160 https://bugs.webkit.org/show_bug.cgi?id=70827 |
| 6161 <rdar://problem/10342925> |
| 6162 |
| 6163 Reviewed by Adam Barth. |
| 6164 |
| 6165 Check that m_currentItem is non-null before passing it to itemsAreClones
. While I wasn't |
| 6166 able to make a test case that would reproduce this crash, we do check m_
currentItem for null |
| 6167 everywhere else, and the crash log indicates that this would fix the cra
sh. |
| 6168 |
| 6169 * loader/HistoryController.cpp: |
| 6170 (WebCore::HistoryController::recursiveUpdateForCommit): |
| 6171 |
| 6172 2011-10-25 Adam Barth <abarth@webkit.org> |
| 6173 |
| 6174 EventTarget.h shouldn't need to know about every feature and ifdef |
| 6175 https://bugs.webkit.org/show_bug.cgi?id=70659 |
| 6176 |
| 6177 Reviewed by Darin Adler. |
| 6178 |
| 6179 This patch follows the approach of Event.h and introduces an |
| 6180 interfaceName virtual function that returns the name of the DOM |
| 6181 interface for the concrete type of the object. This function lets us |
| 6182 remove a large number of fake dynamic casts. |
| 6183 |
| 6184 * CMakeLists.txt: |
| 6185 * CodeGenerators.pri: |
| 6186 * DerivedSources.make: |
| 6187 * GNUmakefile.am: |
| 6188 * WebCore.gyp/WebCore.gyp: |
| 6189 * WebCore.gyp/scripts/action_makenames.py: |
| 6190 - Teach action_makenames how to handle the new "in" file. |
| 6191 * WebCore.gypi: |
| 6192 * WebCore.vcproj/WebCore.vcproj: |
| 6193 * WebCore.xcodeproj/project.pbxproj: |
| 6194 * bindings/js/JSEventTarget.cpp: |
| 6195 (WebCore::toJS): |
| 6196 - Use the new autogenerated macro to remove a large amount of |
| 6197 feature-specific code. |
| 6198 * bindings/js/WorkerScriptController.cpp: |
| 6199 (WebCore::WorkerScriptController::initScript): |
| 6200 * bindings/objc/DOM.mm: |
| 6201 (kit): |
| 6202 - The SVGElementInstance branch was never taken previously because |
| 6203 SVGElementInstance::toNode returns a non-NULL value. This code |
| 6204 was introduced in http://trac.webkit.org/changeset/42618 and |
| 6205 doesn't appear to have ever worked as the author intended. |
| 6206 * bindings/v8/V8DOMWrapper.cpp: |
| 6207 (WebCore::V8DOMWrapper::convertEventTargetToV8Object): |
| 6208 - Use the new autogenerated macro to remove a large amount of |
| 6209 feature-specific code. |
| 6210 * dom/EventNames.cpp: |
| 6211 (WebCore::EventNames::EventNames): |
| 6212 * dom/EventNames.h: |
| 6213 * dom/EventTarget.cpp: |
| 6214 * dom/EventTarget.h: |
| 6215 * dom/EventTargetFactory.in: Added. |
| 6216 - Add a new "in" file that lists all the EventTargets. |
| 6217 * dom/LocalMediaStream.cpp: |
| 6218 (WebCore::LocalMediaStream::interfaceName): |
| 6219 * dom/LocalMediaStream.h: |
| 6220 * dom/MediaStream.cpp: |
| 6221 (WebCore::MediaStream::interfaceName): |
| 6222 * dom/MediaStream.h: |
| 6223 * dom/MessagePort.cpp: |
| 6224 (WebCore::MessagePort::interfaceName): |
| 6225 * dom/MessagePort.h: |
| 6226 * dom/Node.cpp: |
| 6227 (WebCore::Node::toNode): |
| 6228 (WebCore::Node::interfaceName): |
| 6229 * dom/Node.h: |
| 6230 * dom/make_event_factory.pl: |
| 6231 - Generalize make_event_factory.pl to be able to generate |
| 6232 interfaces for different namespaces. |
| 6233 * fileapi/FileReader.cpp: |
| 6234 (WebCore::FileReader::interfaceName): |
| 6235 * fileapi/FileReader.h: |
| 6236 * fileapi/FileWriter.cpp: |
| 6237 (WebCore::FileWriter::interfaceName): |
| 6238 * fileapi/FileWriter.h: |
| 6239 * loader/appcache/DOMApplicationCache.cpp: |
| 6240 (WebCore::DOMApplicationCache::interfaceName): |
| 6241 * loader/appcache/DOMApplicationCache.h: |
| 6242 * notifications/Notification.cpp: |
| 6243 (WebCore::Notification::interfaceName): |
| 6244 * notifications/Notification.h: |
| 6245 (WebCore::Notification::scriptExecutionContext): |
| 6246 * p2p/PeerConnection.cpp: |
| 6247 (WebCore::PeerConnection::interfaceName): |
| 6248 * p2p/PeerConnection.h: |
| 6249 * page/DOMWindow.cpp: |
| 6250 (WebCore::DOMWindow::interfaceName): |
| 6251 (WebCore::DOMWindow::toDOMWindow): |
| 6252 * page/DOMWindow.h: |
| 6253 * page/EventSource.cpp: |
| 6254 (WebCore::EventSource::interfaceName): |
| 6255 * page/EventSource.h: |
| 6256 * storage/IDBDatabase.cpp: |
| 6257 (WebCore::IDBDatabase::interfaceName): |
| 6258 * storage/IDBDatabase.h: |
| 6259 * storage/IDBRequest.cpp: |
| 6260 (WebCore::IDBRequest::interfaceName): |
| 6261 * storage/IDBRequest.h: |
| 6262 * storage/IDBTransaction.cpp: |
| 6263 (WebCore::IDBTransaction::interfaceName): |
| 6264 * storage/IDBTransaction.h: |
| 6265 * storage/IDBVersionChangeRequest.cpp: |
| 6266 (WebCore::IDBVersionChangeRequest::interfaceName): |
| 6267 * storage/IDBVersionChangeRequest.h: |
| 6268 * svg/SVGElementInstance.cpp: |
| 6269 (WebCore::SVGElementInstance::interfaceName): |
| 6270 * svg/SVGElementInstance.h: |
| 6271 (WebCore::SVGElementInstance::toNode): |
| 6272 * webaudio/AudioContext.cpp: |
| 6273 (WebCore::AudioContext::interfaceName): |
| 6274 (WebCore::AudioContext::scriptExecutionContext): |
| 6275 * webaudio/AudioContext.h: |
| 6276 * webaudio/JavaScriptAudioNode.cpp: |
| 6277 (WebCore::JavaScriptAudioNode::interfaceName): |
| 6278 * webaudio/JavaScriptAudioNode.h: |
| 6279 * websockets/WebSocket.cpp: |
| 6280 (WebCore::WebSocket::interfaceName): |
| 6281 * websockets/WebSocket.h: |
| 6282 * workers/DedicatedWorkerContext.cpp: |
| 6283 (WebCore::DedicatedWorkerContext::interfaceName): |
| 6284 * workers/DedicatedWorkerContext.h: |
| 6285 * workers/DefaultSharedWorkerRepository.cpp: |
| 6286 (WebCore::SharedWorkerConnectTask::performTask): |
| 6287 * workers/SharedWorker.cpp: |
| 6288 (WebCore::SharedWorker::interfaceName): |
| 6289 * workers/SharedWorker.h: |
| 6290 * workers/SharedWorkerContext.cpp: |
| 6291 (WebCore::SharedWorkerContext::interfaceName): |
| 6292 * workers/SharedWorkerContext.h: |
| 6293 * workers/Worker.cpp: |
| 6294 (WebCore::Worker::interfaceName): |
| 6295 * workers/Worker.h: |
| 6296 * xml/XMLHttpRequest.cpp: |
| 6297 (WebCore::XMLHttpRequest::interfaceName): |
| 6298 * xml/XMLHttpRequest.h: |
| 6299 * xml/XMLHttpRequestUpload.cpp: |
| 6300 (WebCore::XMLHttpRequestUpload::interfaceName): |
| 6301 * xml/XMLHttpRequestUpload.h: |
| 6302 |
| 6303 2011-10-25 Pavel Podivilov <podivilov@chromium.org> |
| 6304 |
| 6305 Fix several minor problems in idls. |
| 6306 https://bugs.webkit.org/show_bug.cgi?id=70811 |
| 6307 |
| 6308 Reviewed by Adam Barth. |
| 6309 |
| 6310 This patch does not have any effect on generated bindings. |
| 6311 |
| 6312 * dom/DataTransferItems.idl: |
| 6313 * page/History.idl: |
| 6314 * storage/IDBIndex.idl: |
| 6315 * xml/XMLHttpRequest.idl: |
| 6316 |
| 6317 2011-10-25 Nate Chapin <japhet@chromium.org> |
| 6318 |
| 6319 Make DocumentThreadableLoader a CachedResourceClient. |
| 6320 This will allow us to cache ThreadableLoaderClients as |
| 6321 appropriate in a later patch. |
| 6322 https://bugs.webkit.org/show_bug.cgi?id=61225 |
| 6323 |
| 6324 Reviewed by Antti Koivisto. |
| 6325 |
| 6326 No new tests, no functionality change intended. |
| 6327 |
| 6328 * WebCore.gypi: |
| 6329 * loader/DocumentThreadableLoader.cpp: |
| 6330 (WebCore::DocumentThreadableLoader::notifyFinished): CachedResourceClien
ts don't send separate callbacks |
| 6331 for didFail() and didFinishLoading(), so we need to differentiate he
re. |
| 6332 (WebCore::DocumentThreadableLoader::loadRequest): Call CachedResourceLoa
der::requestRawResource() |
| 6333 instead of ResourceLoadScheduler::scheduleSubresourceLoad(). |
| 6334 * loader/DocumentThreadableLoader.h: |
| 6335 * loader/cache/CachedRawResource.cpp: |
| 6336 (WebCore::CachedRawResource::data): Handle the complexity of some Thread
ableLoaderClients setting |
| 6337 DoNotBufferData in ResoureLoaderOptions. If the DataBufferingPolicy
is BufferData, then the |
| 6338 'data' input parameter will contain all data received so far, and we
need to determine the |
| 6339 incremental data to forward to the clients. If the policy is DoNotBu
fferData, 'data' is just |
| 6340 the incremental data. |
| 6341 * loader/cache/CachedRawResource.h: |
| 6342 * loader/cache/CachedResource.cpp: |
| 6343 * loader/cache/CachedResource.h: |
| 6344 (WebCore::CachedResource::preloadResult): |
| 6345 (WebCore::CachedResource::didSendData): |
| 6346 (WebCore::CachedResource::didDownloadData): |
| 6347 (WebCore::CachedResource::setLoadFinishTime): |
| 6348 (WebCore::CachedResource::loadFinishTime): |
| 6349 * loader/cache/CachedResourceClient.h: Add several new callbacks needed
by DocumentThreadableLoader. |
| 6350 * loader/cache/CachedResourceRequest.cpp: |
| 6351 (WebCore::CachedResourceRequest::didReceiveResponse): CachedResource::se
tResponse() can now cancel |
| 6352 the request, so protect appropriately. |
| 6353 * loader/cache/CachedResourceRequest.h: |
| 6354 * loader/chromium/CachedRawResourceChromium.cpp: Added (plumb didDownloa
dData() to DocumentThreadableLoader). |
| 6355 * loader/chromium/CachedResourceRequestChromium.cpp: Added (plumb didDow
nloadData() to DocumentThreadableLoader). |
| 6356 * loader/chromium/DocumentThreadableLoaderChromium.cpp: |
| 6357 * platform/network/BlobResourceHandle.cpp: |
| 6358 (WebCore::BlobResourceHandle::notifyResponse): Protect before setting re
sponse, since it might kill us. |
| 6359 |
| 6360 2011-10-25 Pavel Podivilov <podivilov@chromium.org> |
| 6361 |
| 6362 Get rid of optional parameters in the middle in IDLs. |
| 6363 https://bugs.webkit.org/show_bug.cgi?id=70816 |
| 6364 |
| 6365 Reviewed by Adam Barth. |
| 6366 |
| 6367 Optional parameters in the middle are prohibited by WebIDL spec. |
| 6368 |
| 6369 * bindings/scripts/CodeGeneratorJS.pm: |
| 6370 (GenerateHeader): |
| 6371 (GenerateImplementation): |
| 6372 * bindings/scripts/CodeGeneratorV8.pm: |
| 6373 (GenerateHeader): |
| 6374 (GenerateArgumentsCountCheck): |
| 6375 (GenerateImplementation): |
| 6376 * html/canvas/CanvasRenderingContext2D.idl: |
| 6377 * page/DOMWindow.idl: |
| 6378 |
| 6379 2011-10-25 Chris Evans <cevans@google.com> |
| 6380 |
| 6381 Manage the CSS property array length correctly |
| 6382 https://bugs.webkit.org/show_bug.cgi?id=70783 |
| 6383 |
| 6384 Reviewed by Adam Barth. |
| 6385 |
| 6386 * css/CSSParser.cpp: |
| 6387 (WebCore::CSSParser::addProperty): don't allow max length to get out of
sync with the buffer. |
| 6388 |
| 6389 2011-10-25 Tony Chang <tony@chromium.org> |
| 6390 |
| 6391 avoid unnecessary layouts of flex items during the flex pass |
| 6392 https://bugs.webkit.org/show_bug.cgi?id=70557 |
| 6393 |
| 6394 Reviewed by Ojan Vafai. |
| 6395 |
| 6396 If the preferred size of a flex item is provided, we don't need to |
| 6397 layout the flex item when computing the preferred size. This allows |
| 6398 us to only call layout on each flex item once in the common case. |
| 6399 |
| 6400 No new tests, covered by existing tests. |
| 6401 |
| 6402 * rendering/RenderFlexibleBox.cpp: |
| 6403 (WebCore::RenderFlexibleBox::flowAwareLogicalWidthLengthForChild): |
| 6404 (WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem): |
| 6405 (WebCore::RenderFlexibleBox::computePreferredLogicalWidth): |
| 6406 (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): |
| 6407 * rendering/RenderFlexibleBox.h: |
| 6408 |
| 6409 2011-10-25 Fady Samuel <fsamuel@chromium.org> |
| 6410 |
| 6411 Crash in WebCore::RenderTableSection::addChild due to assert failure |
| 6412 https://bugs.webkit.org/show_bug.cgi?id=70678 |
| 6413 |
| 6414 Reviewed by David Hyatt. |
| 6415 |
| 6416 Tests: fast/table/table-anonymous-cell-bug.html |
| 6417 fast/table/table-anonymous-row-bug.html |
| 6418 fast/table/table-anonymous-section-bug.html |
| 6419 |
| 6420 If the child being added is not a Section/Row/Cell, and the previous sib
ling is not anonymous, |
| 6421 we need to create a new anonymous Section/Row/Cell respectively, instead
of failing an |
| 6422 assert. |
| 6423 |
| 6424 * rendering/RenderTable.cpp: |
| 6425 (WebCore::RenderTable::addChild): |
| 6426 * rendering/RenderTableRow.cpp: |
| 6427 (WebCore::RenderTableRow::addChild): |
| 6428 * rendering/RenderTableSection.cpp: |
| 6429 (WebCore::RenderTableSection::addChild): |
| 6430 |
| 6431 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com> |
| 6432 |
| 6433 Add getOwnPropertySlot to MethodTable |
| 6434 https://bugs.webkit.org/show_bug.cgi?id=69807 |
| 6435 |
| 6436 Reviewed by Oliver Hunt. |
| 6437 |
| 6438 No new tests. |
| 6439 |
| 6440 * bridge/runtime_method.h: Changed getOwnPropertySlot to be protected so
|
| 6441 subclasses can reference it in their MethodTables. |
| 6442 |
| 6443 2011-10-25 Simon Fraser <simon.fraser@apple.com> |
| 6444 |
| 6445 REGRESSION (r88580): Cursor fails to change to pointer on embedded Googl
e maps popups |
| 6446 https://bugs.webkit.org/show_bug.cgi?id=62797 |
| 6447 |
| 6448 Reviewed by Chris Marrin. |
| 6449 |
| 6450 When hit testing through transformed layers, RenderLayer would simply us
e |
| 6451 the composited bounds of the layer as the localHitTestRect for hit testi
ng sublayers. |
| 6452 However, this broke hit testing on pages that have a composited, non-tra
nsformed layer |
| 6453 which falls outside the bounds of its parent, composited-transformed lay
er, like Google |
| 6454 Maps. |
| 6455 |
| 6456 Fix by mapping the hitTestRect through transforms. However this is trick
y, because |
| 6457 mapping a rect into the coordinate system of a layer can result in inval
id rectangles |
| 6458 when point projection results in a negative w component. Fix Transformat
ionMatrix::projectPoint() |
| 6459 to detect this case and replace X and Y with large values, and add bound
sOfProjectedQuad(), which |
| 6460 maps rectangles with possibly-infinite location or bounds into rects whi
ch are representable |
| 6461 in an IntRect. |
| 6462 |
| 6463 Tests: transforms/3d/hit-testing/composited-hit-test.html |
| 6464 transforms/3d/hit-testing/rotated-hit-test-with-child.html |
| 6465 transforms/3d/hit-testing/rotated-hit-test2.html |
| 6466 |
| 6467 * platform/graphics/transforms/TransformationMatrix.cpp: |
| 6468 (WebCore::TransformationMatrix::projectPoint): |
| 6469 (WebCore::TransformationMatrix::projectQuad): |
| 6470 (WebCore::clampEdgeValue): |
| 6471 (WebCore::TransformationMatrix::boundsOfProjectedQuad): |
| 6472 * platform/graphics/transforms/TransformationMatrix.h: |
| 6473 * rendering/HitTestingTransformState.cpp: |
| 6474 (WebCore::HitTestingTransformState::boundsOfMappedQuad): |
| 6475 * rendering/HitTestingTransformState.h: |
| 6476 * rendering/RenderLayer.cpp: |
| 6477 (WebCore::RenderLayer::hitTestLayer): |
| 6478 |
| 6479 2011-10-25 Adrienne Walker <enne@google.com> |
| 6480 |
| 6481 [chromium] Batch up texture uploads so that they can be updated incremen
tally |
| 6482 https://bugs.webkit.org/show_bug.cgi?id=70454 |
| 6483 |
| 6484 Reviewed by James Robinson. |
| 6485 |
| 6486 Because texture uploads can sometimes take more than a frame to |
| 6487 complete, collect all the uploads that need to occur in a |
| 6488 CCTextureUpdater so that we can easily incrementally upload some of |
| 6489 them, interleaving input and drawing so that the compositor thread |
| 6490 continues to appear responsive during a commit. |
| 6491 |
| 6492 This change doesn't actually interleave the commits, it just pushes |
| 6493 the infrastructure for doing so up to the CCProxy level so that a |
| 6494 future scheduler can make this decision. |
| 6495 |
| 6496 VideoLayerChromium is the only layer type to not use this system. It |
| 6497 needs to be converted to use a texture updater first and it is less of |
| 6498 a priority than the tiled layers. |
| 6499 |
| 6500 * WebCore.gypi: |
| 6501 * platform/graphics/chromium/Canvas2DLayerChromium.cpp: |
| 6502 (WebCore::Canvas2DLayerChromium::updateCompositorResources): |
| 6503 * platform/graphics/chromium/Canvas2DLayerChromium.h: |
| 6504 * platform/graphics/chromium/LayerChromium.h: |
| 6505 (WebCore::LayerChromium::updateCompositorResources): |
| 6506 * platform/graphics/chromium/TiledLayerChromium.cpp: |
| 6507 (WebCore::TiledLayerChromium::updateCompositorResources): |
| 6508 * platform/graphics/chromium/TiledLayerChromium.h: |
| 6509 * platform/graphics/chromium/VideoLayerChromium.cpp: |
| 6510 (WebCore::VideoLayerChromium::updateCompositorResources): |
| 6511 * platform/graphics/chromium/VideoLayerChromium.h: |
| 6512 * platform/graphics/chromium/WebGLLayerChromium.cpp: |
| 6513 (WebCore::WebGLLayerChromium::updateCompositorResources): |
| 6514 * platform/graphics/chromium/WebGLLayerChromium.h: |
| 6515 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
| 6516 (WebCore::CCLayerTreeHost::beginCommitOnImplThread): |
| 6517 (WebCore::CCLayerTreeHost::finishCommitOnImplThread): |
| 6518 (WebCore::CCLayerTreeHost::updateCompositorResources): |
| 6519 * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
| 6520 * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: |
| 6521 (WebCore::CCSingleThreadProxy::setNeedsCommit): |
| 6522 (WebCore::CCSingleThreadProxy::doCommit): |
| 6523 (WebCore::CCSingleThreadProxy::commitIfNeeded): |
| 6524 * platform/graphics/chromium/cc/CCSingleThreadProxy.h: |
| 6525 * platform/graphics/chromium/cc/CCTextureUpdater.cpp: Added. |
| 6526 (WebCore::CCTextureUpdater::CCTextureUpdater): |
| 6527 (WebCore::CCTextureUpdater::~CCTextureUpdater): |
| 6528 (WebCore::CCTextureUpdater::append): |
| 6529 (WebCore::CCTextureUpdater::update): |
| 6530 (WebCore::CCTextureUpdater::clear): |
| 6531 * platform/graphics/chromium/cc/CCTextureUpdater.h: Added. |
| 6532 (WebCore::CCTextureUpdater::allocator): |
| 6533 * platform/graphics/chromium/cc/CCThreadProxy.cpp: |
| 6534 (WebCore::CCThreadProxy::commitOnImplThread): |
| 6535 |
| 6536 2011-10-24 Jer Noble <jer.noble@apple.com> |
| 6537 |
| 6538 compositing/video tests time out on Lion |
| 6539 https://bugs.webkit.org/show_bug.cgi?id=70448 |
| 6540 |
| 6541 Reviewed by Simon Fraser. |
| 6542 |
| 6543 AVFoundation will not begin loading or decoding media until a consumer f
or that media is present. |
| 6544 For video-only media, this means that an AVPlayerLayer must be created a
nd attached to the |
| 6545 AVPlayer before the load state will ever reach "canPlayThrough". Once th
e metadata for a media |
| 6546 is loaded, create a AVPlayerLayer if the media has a video track. |
| 6547 |
| 6548 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: |
| 6549 (WebCore::MediaPlayerPrivateAVFoundation::updateStates): |
| 6550 |
| 6551 2011-10-24 Ryosuke Niwa <rniwa@webkit.org> |
| 6552 |
| 6553 Merge endOfLine with logicalEndOfLine and startOfLine with logicalStartO
fLine |
| 6554 https://bugs.webkit.org/show_bug.cgi?id=70755 |
| 6555 |
| 6556 Reviewed by Chang Shu. |
| 6557 |
| 6558 Merged endOfLine with logicalEndOfLine, and startOfLine with logicalStar
tOfLine |
| 6559 to reduce the code duplication. |
| 6560 |
| 6561 * editing/visible_units.cpp: |
| 6562 (WebCore::startPositionForLine): |
| 6563 (WebCore::startOfLine): |
| 6564 (WebCore::logicalStartOfLine): |
| 6565 (WebCore::endPositionForLine): |
| 6566 (WebCore::inSameLogicalLine): |
| 6567 (WebCore::endOfLine): |
| 6568 (WebCore::logicalEndOfLine): |
| 6569 * editing/visible_units.h: |
| 6570 |
| 6571 2011-10-25 Arko Saha <arko@motorola.com> |
| 6572 |
| 6573 Microdata: itemtype attribute should be space-separated list to allow mu
ltiple types. |
| 6574 https://bugs.webkit.org/show_bug.cgi?id=70501 |
| 6575 |
| 6576 Reviewed by Ryosuke Niwa. |
| 6577 |
| 6578 Tests: fast/dom/MicroData/getitems-multiple-itemtypes.html |
| 6579 fast/dom/MicroData/itemtype-add-remove-tokens.html |
| 6580 fast/dom/MicroData/itemtype-attribute-test.html |
| 6581 |
| 6582 * dom/MicroDataItemList.cpp: |
| 6583 (WebCore::MicroDataItemList::nodeMatches): |
| 6584 * html/DOMSettableTokenList.h: |
| 6585 (WebCore::DOMSettableTokenList::tokens): |
| 6586 * html/HTMLElement.cpp: |
| 6587 (WebCore::HTMLElement::parseMappedAttribute): |
| 6588 (WebCore::HTMLElement::setItemValueText): |
| 6589 (WebCore::HTMLElement::itemType): |
| 6590 (WebCore::HTMLElement::setItemType): |
| 6591 * html/HTMLElement.h: |
| 6592 * html/HTMLElement.idl: |
| 6593 |
| 6594 2011-10-25 Dan Bernstein <mitz@apple.com> |
| 6595 |
| 6596 <rdar://problem/10337033> DOMRangeOfString:relativeTo:options has proble
ms with -webkit-user-select: none |
| 6597 |
| 6598 Reviewed by Adam Roben. |
| 6599 |
| 6600 Test: added to TestWebKitAPI/Tests/mac/DOMRangeOfString.mm |
| 6601 |
| 6602 * page/Page.cpp: |
| 6603 (WebCore::Page::rangeOfString): This function was incorrectly adding the
StartInSelection option to |
| 6604 the initial search. |
| 6605 |
| 6606 2011-10-25 Yury Semikhatsky <yurys@chromium.org> |
| 6607 |
| 6608 Web Inspector: redesign workers sidebar pane |
| 6609 https://bugs.webkit.org/show_bug.cgi?id=70815 |
| 6610 |
| 6611 Changed workers sidebar pane design. |
| 6612 |
| 6613 Now there is a link to worker inspector for each dedicated worker create
d |
| 6614 by inspected page. The sidebar display a link to a page with list of all |
| 6615 shared workers if there one is supported by the WebKit port. Also there |
| 6616 is a checkbox that allows pause all new workers on first statements. |
| 6617 |
| 6618 Reviewed by Pavel Feldman. |
| 6619 |
| 6620 * inspector/front-end/Settings.js: |
| 6621 * inspector/front-end/StylesSidebarPane.js: |
| 6622 (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules)
: |
| 6623 * inspector/front-end/WorkerManager.js: |
| 6624 (WebInspector.WorkerManager.prototype.openWorkerInspector): |
| 6625 (WebInspector.WorkerManager.prototype._workerInspectorClosing): |
| 6626 * inspector/front-end/WorkersSidebarPane.js: |
| 6627 (WebInspector.WorkerListSidebarPane): |
| 6628 (WebInspector.WorkerListSidebarPane.prototype._workerRemoved): |
| 6629 (WebInspector.WorkerListSidebarPane.prototype._workersCleared): |
| 6630 (WebInspector.WorkerListSidebarPane.prototype._addWorker): |
| 6631 (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked): |
| 6632 (WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicke
d): |
| 6633 (WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink.l
ink.onclick): |
| 6634 (WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink): |
| 6635 * inspector/front-end/elementsPanel.css: |
| 6636 * inspector/front-end/inspectorCommon.css: |
| 6637 (.sidebar-separator): |
| 6638 (.sidebar-label): |
| 6639 * inspector/front-end/scriptsPanel.css: |
| 6640 (.dedicated-worker-item): |
| 6641 (#shared-workers-list): |
| 6642 (#pause-workers-checkbox > input): |
| 6643 |
| 6644 2011-10-25 Nico Weber <thakis@chromium.org> |
| 6645 |
| 6646 [chromium/mac] Fix an ODR violation. |
| 6647 https://bugs.webkit.org/show_bug.cgi?id=70753 |
| 6648 |
| 6649 Reviewed by Anders Carlsson. |
| 6650 |
| 6651 Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::cre
ate() on OS X. |
| 6652 Remove the unused one. |
| 6653 |
| 6654 * WebCore.gyp/WebCore.gyp: |
| 6655 |
| 6656 2011-10-25 Vsevolod Vlasov <vsevik@chromium.org> |
| 6657 |
| 6658 Web Inspector: Debugger fails when there is an invalid watch expression. |
| 6659 https://bugs.webkit.org/show_bug.cgi?id=70718 |
| 6660 |
| 6661 Reviewed by Pavel Feldman. |
| 6662 |
| 6663 Test: inspector/debugger/watch-expressions-panel-switch.html |
| 6664 |
| 6665 * inspector/front-end/ScriptsPanel.js: |
| 6666 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): |
| 6667 |
| 6668 2011-10-24 Pavel Podivilov <podivilov@chromium.org> |
| 6669 |
| 6670 Web Inspector: fix empty line handling in source maps. |
| 6671 https://bugs.webkit.org/show_bug.cgi?id=70726 |
| 6672 |
| 6673 Reviewed by Yury Semikhatsky. |
| 6674 |
| 6675 * inspector/front-end/CompilerSourceMapping.js: |
| 6676 (WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings): |
| 6677 |
| 6678 2011-10-25 Justin Schuh <jschuh@chromium.org> |
| 6679 |
| 6680 Check for empty string in parseArcFlag |
| 6681 https://bugs.webkit.org/show_bug.cgi?id=70763 |
| 6682 |
| 6683 Reviewed by Dirk Schulze. |
| 6684 |
| 6685 Test: svg/path-invalid.html |
| 6686 |
| 6687 * svg/SVGParserUtilities.cpp: |
| 6688 (WebCore::parseArcFlag): |
| 6689 |
| 6690 2011-10-24 Pavel Podivilov <podivilov@chromium.org> |
| 6691 |
| 6692 Web Inspector: keep old source mapping when new one could not be loaded. |
| 6693 https://bugs.webkit.org/show_bug.cgi?id=70729 |
| 6694 |
| 6695 Reviewed by Yury Semikhatsky. |
| 6696 |
| 6697 * inspector/front-end/RawSourceCode.js: |
| 6698 (WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSour
ceMapping): |
| 6699 (WebInspector.RawSourceCode.prototype._updateSourceMapping): |
| 6700 (WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSource
Mapping): |
| 6701 |
| 6702 2011-10-25 Sachin Puranik <sachin.puranik@motorola.com> |
| 6703 |
| 6704 Double number step=.5 should be considered valid in <input type="number"
step=".5"> |
| 6705 https://bugs.webkit.org/show_bug.cgi?id=70320 |
| 6706 |
| 6707 Reviewed by Kent Tamura. |
| 6708 |
| 6709 Test: fast/forms/input-step-as-double.html |
| 6710 |
| 6711 * html/parser/HTMLParserIdioms.cpp: |
| 6712 (WebCore::parseToDoubleForNumberType): Changed the function to consider |
| 6713 step as valid even if it starts with "." |
| 6714 |
| 6715 2011-10-25 Alexander Pavlov <apavlov@chromium.org> |
| 6716 |
| 6717 Web Inspector: [Chromium] Audits panel context menu for links not workin
g properly |
| 6718 https://bugs.webkit.org/show_bug.cgi?id=70813 |
| 6719 |
| 6720 Reviewed by Pavel Feldman. |
| 6721 |
| 6722 * inspector/front-end/AuditResultView.js: |
| 6723 (WebInspector.AuditResultView): |
| 6724 (WebInspector.AuditResultView.prototype._contextMenuEventFired): |
| 6725 |
| 6726 2011-10-25 Vsevolod Vlasov <vsevik@chromium.org> |
| 6727 |
| 6728 Web Inspector: Resources panel: display the current search match index i
n the toolbar. |
| 6729 https://bugs.webkit.org/show_bug.cgi?id=66050 |
| 6730 |
| 6731 Reviewed by Pavel Feldman. |
| 6732 |
| 6733 Test: http/tests/inspector/search/resources-search-match-index.html |
| 6734 |
| 6735 * inspector/front-end/ResourcesPanel.js: |
| 6736 (WebInspector.ResourcesPanel.prototype.performSearch.callback): |
| 6737 (WebInspector.ResourcesPanel.prototype.performSearch): |
| 6738 (WebInspector.ResourcesPanel.prototype._showSearchResult.callback): |
| 6739 (WebInspector.ResourcesPanel.prototype._showSearchResult): |
| 6740 (WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount): |
| 6741 (WebInspector.ResourcesSearchController): |
| 6742 (WebInspector.ResourcesSearchController.prototype.nextSearchResult): |
| 6743 (WebInspector.ResourcesSearchController.prototype.previousSearchResult): |
| 6744 (WebInspector.ResourcesSearchController.prototype._searchResult): |
| 6745 (WebInspector.SearchResultsTreeElementsTraverser.prototype.next): |
| 6746 (WebInspector.SearchResultsTreeElementsTraverser.prototype.previous): |
| 6747 (WebInspector.SearchResultsTreeElementsTraverser.prototype.matchIndex): |
| 6748 (WebInspector.SearchResultsTreeElementsTraverser.prototype._elementSearc
hMatchesCount): |
| 6749 (WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext
): |
| 6750 (WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrev
ious): |
| 6751 * inspector/front-end/treeoutline.js: |
| 6752 |
| 6753 2011-10-25 Andrey Kosyakov <caseq@chromium.org> |
| 6754 |
| 6755 Web Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showO
bjectPopover() |
| 6756 https://bugs.webkit.org/show_bug.cgi?id=70812 |
| 6757 |
| 6758 Reviewed by Pavel Feldman. |
| 6759 |
| 6760 Check if highlighted element is present while displaying object popover. |
| 6761 |
| 6762 * inspector/front-end/JavaScriptSourceFrame.js: |
| 6763 (WebInspector.JavaScriptSourceFrame.prototype.onShowPopover.showObjectPo
pover): |
| 6764 (WebInspector.JavaScriptSourceFrame.prototype.onShowPopover): |
| 6765 |
| 6766 2011-10-21 Nat Duca <nduca@chromium.org> |
| 6767 |
| 6768 [chromium] Route Console::time and Console::timeEnd to trace_event |
| 6769 https://bugs.webkit.org/show_bug.cgi?id=70620 |
| 6770 |
| 6771 Reviewed by Pavel Feldman. |
| 6772 |
| 6773 * page/Console.cpp: |
| 6774 (WebCore::Console::time): |
| 6775 (WebCore::Console::timeEnd): |
| 6776 |
| 6777 2011-10-21 Andrey Kosyakov <caseq@chromium.org> |
| 6778 |
| 6779 Web Inspector: [Extensions API] allow extensions to specify script to be
injected on reload |
| 6780 https://bugs.webkit.org/show_bug.cgi?id=70600 |
| 6781 |
| 6782 Reviewed by Pavel Feldman. |
| 6783 |
| 6784 - change webInspector.inspectedPage.reload() to accept multiple options
in an object |
| 6785 - add an ability to inject a script upon a page reload |
| 6786 - return script id in addScriptToEvaluateOnLoad() |
| 6787 - provide removeScriptToEvaluateOnLoad() |
| 6788 - store scripts to evaluate on load in inspector state cookie |
| 6789 |
| 6790 Test: inspector/extensions/extensions-reload.html |
| 6791 |
| 6792 * inspector/Inspector.json: |
| 6793 * inspector/InspectorPageAgent.cpp: |
| 6794 (WebCore::InspectorPageAgent::InspectorPageAgent): |
| 6795 (WebCore::InspectorPageAgent::restore): |
| 6796 (WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad): |
| 6797 (WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad): |
| 6798 (WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad): |
| 6799 (WebCore::InspectorPageAgent::didClearWindowObjectInWorld): |
| 6800 (WebCore::InspectorPageAgent::frameNavigated): |
| 6801 * inspector/InspectorPageAgent.h: |
| 6802 * inspector/front-end/ExtensionAPI.js: |
| 6803 (injectedExtensionAPI.InspectedWindow.prototype.reload): |
| 6804 * inspector/front-end/ExtensionServer.js: |
| 6805 (WebInspector.ExtensionServer.prototype._onReload): |
| 6806 * inspector/front-end/WorkersSidebarPane.js: |
| 6807 (WebInspector.WorkersSidebarPane.prototype.setInstrumentation.callback): |
| 6808 (WebInspector.WorkersSidebarPane.prototype.setInstrumentation): |
| 6809 |
| 6810 2011-10-24 Pavel Feldman <pfeldman@google.com> |
| 6811 |
| 6812 Web Inspector: print expired message count before remaining messages. |
| 6813 https://bugs.webkit.org/show_bug.cgi?id=70736 |
| 6814 |
| 6815 Reviewed by Yury Semikhatsky. |
| 6816 |
| 6817 * inspector/Inspector-0.1.json: |
| 6818 * inspector/Inspector.json: |
| 6819 * inspector/InspectorConsoleAgent.cpp: |
| 6820 (WebCore::InspectorConsoleAgent::enable): |
| 6821 (WebCore::InspectorConsoleAgent::restore): |
| 6822 * inspector/InspectorConsoleAgent.h: |
| 6823 * inspector/front-end/ConsoleModel.js: |
| 6824 |
| 6825 2011-10-25 Sheriff Bot <webkit.review.bot@gmail.com> |
| 6826 |
| 6827 Unreviewed, rolling out r98309. |
| 6828 http://trac.webkit.org/changeset/98309 |
| 6829 https://bugs.webkit.org/show_bug.cgi?id=70801 |
| 6830 |
| 6831 Test fails on mac (Requested by benwells on #webkit). |
| 6832 |
| 6833 * html/canvas/CanvasRenderingContext2D.cpp: |
| 6834 (WebCore::CanvasRenderingContext2D::fill): |
| 6835 (WebCore::CanvasRenderingContext2D::fillRect): |
| 6836 (WebCore::CanvasRenderingContext2D::drawImage): |
| 6837 (WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere): |
| 6838 (WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere)
: |
| 6839 * html/canvas/CanvasRenderingContext2D.h: |
| 6840 |
| 6841 2011-10-24 Geoffrey Garen <ggaren@apple.com> |
| 6842 |
| 6843 Chromium build fix: #include window.h for HANDLE. |
| 6844 |
| 6845 * platform/graphics/opentype/OpenTypeUtilities.h: |
| 6846 |
| 6847 2011-10-24 Ryosuke Niwa <rniwa@webkit.org> |
| 6848 |
| 6849 Include ThreadSafeRefCounted.h since the class declared in this header f
ile |
| 6850 inherits from ThreadSafeRefCounted. |
| 6851 |
| 6852 * storage/IDBIndexBackendInterface.h: |
| 6853 |
| 6854 2011-10-24 Ryosuke Niwa <rniwa@webkit.org> |
| 6855 |
| 6856 Fix a typo. |
| 6857 |
| 6858 * bindings/v8/JavaScriptCallFrame.h: |
| 6859 |
| 6860 2011-10-24 Geoffrey Garen <ggaren@apple.com> |
| 6861 |
| 6862 Removed SharedUChar and tightened language around its previous uses |
| 6863 https://bugs.webkit.org/show_bug.cgi?id=70698 |
| 6864 |
| 6865 Reviewed by David Levin. |
| 6866 |
| 6867 - Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" becau
se |
| 6868 the former names gave the dangerous misimpression that the resulting obj
ect |
| 6869 was thread-safe, which is not true. |
| 6870 |
| 6871 - Updated a bunch of files for header dependency changes, now that |
| 6872 CrossThreadRefCounted is gone. |
| 6873 |
| 6874 * ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed. |
| 6875 * WebCore.exp.in: |
| 6876 * bindings/js/ScriptHeapSnapshot.h: |
| 6877 * bindings/v8/SerializedScriptValue.cpp: |
| 6878 (WebCore::SerializedScriptValue::release): |
| 6879 (WebCore::SerializedScriptValue::SerializedScriptValue): |
| 6880 * css/CSSPropertySourceData.h: |
| 6881 * css/CSSValue.h: |
| 6882 * css/StyleMedia.h: |
| 6883 * css/WebKitCSSMatrix.h: |
| 6884 * dom/QualifiedName.h: |
| 6885 * fileapi/LocalFileSystem.h: |
| 6886 (WebCore::LocalFileSystem::SystemBasePath::operator String): |
| 6887 * history/CachedFrame.h: |
| 6888 * history/CachedPage.h: |
| 6889 * history/HistoryItem.h: |
| 6890 * html/canvas/CanvasStyle.h: |
| 6891 * inspector/InspectorResourceAgent.h: |
| 6892 * loader/FormState.h: |
| 6893 * loader/TextResourceDecoder.h: |
| 6894 * loader/WorkerThreadableLoader.cpp: |
| 6895 (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): |
| 6896 * loader/icon/IconDatabase.cpp: |
| 6897 (WebCore::IconDatabase::open): |
| 6898 (WebCore::IconDatabase::synchronousIconForPageURL): |
| 6899 (WebCore::IconDatabase::synchronousIconURLForPageURL): |
| 6900 (WebCore::IconDatabase::retainIconForPageURL): |
| 6901 (WebCore::IconDatabase::releaseIconForPageURL): |
| 6902 (WebCore::IconDatabase::setIconDataForIconURL): |
| 6903 (WebCore::IconDatabase::setIconURLForPageURL): |
| 6904 (WebCore::IconDatabase::databasePath): |
| 6905 (WebCore::IconDatabase::defaultDatabaseFilename): |
| 6906 (WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWo
rkItem): |
| 6907 (WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURL
WorkItem): |
| 6908 * page/ContentSecurityPolicy.h: |
| 6909 * page/Coordinates.h: |
| 6910 (WebCore::Coordinates::isolatedCopy): |
| 6911 * page/Geoposition.h: |
| 6912 (WebCore::Geoposition::isolatedCopy): |
| 6913 * page/SecurityOrigin.cpp: |
| 6914 (WebCore::SecurityOrigin::SecurityOrigin): |
| 6915 (WebCore::SecurityOrigin::isolatedCopy): |
| 6916 * page/SecurityOrigin.h: |
| 6917 * page/animation/AnimationBase.h: |
| 6918 * platform/CrossThreadCopier.cpp: |
| 6919 (WebCore::::copy): |
| 6920 * platform/FileChooser.h: |
| 6921 * platform/KURL.cpp: |
| 6922 (WebCore::KURL::copy): |
| 6923 * platform/cf/SchedulePair.h: |
| 6924 * platform/network/BlobData.cpp: |
| 6925 (WebCore::BlobDataItem::detachFromCurrentThread): |
| 6926 (WebCore::BlobData::detachFromCurrentThread): |
| 6927 * platform/network/HTTPHeaderMap.cpp: |
| 6928 (WebCore::HTTPHeaderMap::copyData): |
| 6929 * platform/network/MIMEHeader.h: |
| 6930 * platform/network/ResourceErrorBase.cpp: |
| 6931 (WebCore::ResourceErrorBase::copy): |
| 6932 * platform/network/ResourceLoadInfo.h: |
| 6933 * platform/network/ResourceRequestBase.cpp: |
| 6934 (WebCore::ResourceRequestBase::copyData): |
| 6935 * platform/network/ResourceResponseBase.cpp: |
| 6936 (WebCore::ResourceResponseBase::copyData): |
| 6937 * platform/sql/SQLValue.cpp: |
| 6938 (WebCore::SQLValue::SQLValue): |
| 6939 (WebCore::SQLValue::string): |
| 6940 * rendering/style/QuotesData.h: |
| 6941 * storage/AbstractDatabase.cpp: |
| 6942 (WebCore::updateGuidVersionMap): |
| 6943 (WebCore::AbstractDatabase::AbstractDatabase): |
| 6944 (WebCore::AbstractDatabase::performOpenAndVerify): |
| 6945 (WebCore::AbstractDatabase::stringIdentifier): |
| 6946 (WebCore::AbstractDatabase::displayName): |
| 6947 (WebCore::AbstractDatabase::fileName): |
| 6948 (WebCore::AbstractDatabase::setExpectedVersion): |
| 6949 (WebCore::AbstractDatabase::getCachedVersion): |
| 6950 * storage/ChangeVersionWrapper.cpp: |
| 6951 (WebCore::ChangeVersionWrapper::ChangeVersionWrapper): |
| 6952 * storage/Database.cpp: |
| 6953 (WebCore::Database::Database): |
| 6954 (WebCore::Database::tableNames): |
| 6955 * storage/DatabaseDetails.h: |
| 6956 * storage/DatabaseTracker.cpp: |
| 6957 (WebCore::DatabaseTracker::setDatabaseDirectoryPath): |
| 6958 (WebCore::DatabaseTracker::databaseDirectoryPath): |
| 6959 (WebCore::DatabaseTracker::trackerDatabasePath): |
| 6960 (WebCore::DatabaseTracker::canEstablishDatabase): |
| 6961 (WebCore::DatabaseTracker::originPath): |
| 6962 (WebCore::DatabaseTracker::fullPathForDatabase): |
| 6963 (WebCore::DatabaseTracker::populateOrigins): |
| 6964 (WebCore::DatabaseTracker::databaseNamesForOrigin): |
| 6965 (WebCore::DatabaseTracker::addOpenDatabase): |
| 6966 (WebCore::DatabaseTracker::setQuota): |
| 6967 (WebCore::DatabaseTracker::recordCreatingDatabase): |
| 6968 (WebCore::DatabaseTracker::recordDeletingDatabase): |
| 6969 (WebCore::DatabaseTracker::recordDeletingOrigin): |
| 6970 (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): |
| 6971 * storage/OriginQuotaManager.cpp: |
| 6972 (WebCore::OriginQuotaManager::trackOrigin): |
| 6973 (WebCore::OriginQuotaManager::addDatabase): |
| 6974 * storage/SQLError.h: |
| 6975 (WebCore::SQLError::message): |
| 6976 (WebCore::SQLError::SQLError): |
| 6977 * storage/SQLResultSetRowList.h: |
| 6978 * storage/SQLStatement.cpp: |
| 6979 (WebCore::SQLStatement::SQLStatement): |
| 6980 * storage/StorageAreaSync.cpp: |
| 6981 (WebCore::StorageAreaSync::StorageAreaSync): |
| 6982 (WebCore::StorageAreaSync::syncTimerFired): |
| 6983 * storage/StorageAreaSync.h: |
| 6984 * storage/StorageMap.cpp: |
| 6985 (WebCore::StorageMap::importItem): |
| 6986 * storage/StorageNamespaceImpl.cpp: |
| 6987 (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): |
| 6988 * storage/StorageSyncManager.cpp: |
| 6989 (WebCore::StorageSyncManager::StorageSyncManager): |
| 6990 * storage/StorageTracker.cpp: |
| 6991 (WebCore::StorageTracker::StorageTracker): |
| 6992 (WebCore::StorageTracker::syncImportOriginIdentifiers): |
| 6993 (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase): |
| 6994 (WebCore::StorageTracker::setOriginDetails): |
| 6995 (WebCore::StorageTracker::willDeleteAllOrigins): |
| 6996 * svg/SVGPathSeg.h: |
| 6997 * workers/DefaultSharedWorkerRepository.cpp: |
| 6998 (WebCore::SharedWorkerProxy::url): |
| 6999 (WebCore::SharedWorkerProxy::name): |
| 7000 (WebCore::SharedWorkerProxy::SharedWorkerProxy): |
| 7001 (WebCore::DefaultSharedWorkerRepository::getProxy): |
| 7002 * workers/SharedWorkerThread.cpp: |
| 7003 (WebCore::SharedWorkerThread::SharedWorkerThread): |
| 7004 * workers/WorkerMessagingProxy.cpp: |
| 7005 (WebCore::WorkerExceptionTask::WorkerExceptionTask): |
| 7006 (WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask
): |
| 7007 * workers/WorkerRunLoop.cpp: |
| 7008 (WebCore::WorkerRunLoop::postTaskForMode): |
| 7009 (WebCore::WorkerRunLoop::Task::Task): |
| 7010 * workers/WorkerThread.cpp: |
| 7011 (WebCore::WorkerThreadStartupData::WorkerThreadStartupData): |
| 7012 |
| 7013 2011-10-24 Adam Barth <abarth@webkit.org> |
| 7014 |
| 7015 Remove empty directory. |
| 7016 |
| 7017 * p2p: Removed. |
| 7018 |
| 7019 2011-10-24 Shawn Singh <shawnsingh@chromium.org> |
| 7020 |
| 7021 [chromium] Refactor painting/updating/drawing code. |
| 7022 https://bugs.webkit.org/show_bug.cgi?id=70057 |
| 7023 |
| 7024 Reviewed by James Robinson. |
| 7025 |
| 7026 This refactoring separates the "early exits" from the actual loop |
| 7027 that draws layers. As part of this, it was also appropriate to |
| 7028 clean up the way that masks and replicas are dealt with when |
| 7029 painting and updating. The purpose of all this is to make things |
| 7030 easier to test, and for a scissoring optimization that needs to |
| 7031 know exatly what gets drawn. Existing layout tests were able to |
| 7032 verify the refactoring did not change behavior. |
| 7033 |
| 7034 * platform/graphics/chromium/LayerRendererChromium.cpp: |
| 7035 (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces): |
| 7036 (WebCore::LayerRendererChromium::drawLayersInternal): |
| 7037 (WebCore::LayerRendererChromium::drawLayer): |
| 7038 * platform/graphics/chromium/LayerRendererChromium.h: |
| 7039 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
| 7040 (WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface): |
| 7041 (WebCore::CCLayerTreeHost::paintLayerContents): |
| 7042 (WebCore::CCLayerTreeHost::updateCompositorResources): |
| 7043 * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
| 7044 * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: |
| 7045 (WebCore::layerShouldBeAppended): |
| 7046 (WebCore::calculateDrawTransformsAndVisibilityInternal): |
| 7047 * platform/graphics/chromium/cc/CCLayerTreeHostCommon.h: |
| 7048 (WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect): |
| 7049 |
| 7050 2011-10-24 Luke Macpherson <macpherson@chromium.org> |
| 7051 |
| 7052 REGRESSION(80893): HTML5 spec takes 2s longer to load due to time spent
in CSSStyleSelector |
| 7053 https://bugs.webkit.org/show_bug.cgi?id=68944 |
| 7054 |
| 7055 Reviewed by Antti Koivisto. |
| 7056 |
| 7057 No new tests / Covered by existing tests. |
| 7058 |
| 7059 Removes all virtual dispatch from CSSStyleApplyProperty by converting to
use static function pointers for dispatch. |
| 7060 Uses class templates instead of function templates to allow default para
meters and also to share parameter declarations across static functions. |
| 7061 All constructor parameters become template parameters. This improves the
level of compiler optimization that can be achieved. |
| 7062 Overall this achieved a ~2% overall speedup on run-safari PerformanceTes
ts/Parser/html5-full-render.html, |
| 7063 and profiling showed a reduction in the time spent inside CSSStyleSelect
or::applyProperty(). |
| 7064 |
| 7065 * css/CSSStyleApplyProperty.cpp: |
| 7066 (WebCore::ApplyPropertyExpanding::applyInheritValue): |
| 7067 (WebCore::ApplyPropertyExpanding::applyInitialValue): |
| 7068 (WebCore::ApplyPropertyExpanding::applyValue): |
| 7069 (WebCore::ApplyPropertyExpanding::createHandler): |
| 7070 (WebCore::ApplyPropertyDefaultBase::setValue): |
| 7071 (WebCore::ApplyPropertyDefaultBase::value): |
| 7072 (WebCore::ApplyPropertyDefaultBase::initial): |
| 7073 (WebCore::ApplyPropertyDefaultBase::applyInheritValue): |
| 7074 (WebCore::ApplyPropertyDefaultBase::applyInitialValue): |
| 7075 (WebCore::ApplyPropertyDefaultBase::applyValue): |
| 7076 (WebCore::ApplyPropertyDefaultBase::createHandler): |
| 7077 (WebCore::ApplyPropertyDefault::setValue): |
| 7078 (WebCore::ApplyPropertyDefault::applyValue): |
| 7079 (WebCore::ApplyPropertyDefault::createHandler): |
| 7080 (WebCore::ApplyPropertyStyleImage::applyValue): |
| 7081 (WebCore::ApplyPropertyStyleImage::createHandler): |
| 7082 (WebCore::ApplyPropertyAuto::setValue): |
| 7083 (WebCore::ApplyPropertyAuto::value): |
| 7084 (WebCore::ApplyPropertyAuto::hasAuto): |
| 7085 (WebCore::ApplyPropertyAuto::setAuto): |
| 7086 (WebCore::ApplyPropertyAuto::applyInheritValue): |
| 7087 (WebCore::ApplyPropertyAuto::applyInitialValue): |
| 7088 (WebCore::ApplyPropertyAuto::applyValue): |
| 7089 (WebCore::ApplyPropertyAuto::createHandler): |
| 7090 (WebCore::defaultInitialColor): |
| 7091 (WebCore::ApplyPropertyColor::applyInheritValue): |
| 7092 (WebCore::ApplyPropertyColor::applyInitialValue): |
| 7093 (WebCore::ApplyPropertyColor::applyValue): |
| 7094 (WebCore::ApplyPropertyColor::createHandler): |
| 7095 (WebCore::ApplyPropertyDirection::applyValue): |
| 7096 (WebCore::ApplyPropertyDirection::createHandler): |
| 7097 (WebCore::ApplyPropertyLength::setValue): |
| 7098 (WebCore::ApplyPropertyLength::applyValue): |
| 7099 (WebCore::ApplyPropertyLength::createHandler): |
| 7100 (WebCore::ApplyPropertyString::setValue): |
| 7101 (WebCore::ApplyPropertyString::applyValue): |
| 7102 (WebCore::ApplyPropertyString::createHandler): |
| 7103 (WebCore::ApplyPropertyBorderRadius::setValue): |
| 7104 (WebCore::ApplyPropertyBorderRadius::applyValue): |
| 7105 (WebCore::ApplyPropertyBorderRadius::createHandler): |
| 7106 (WebCore::ApplyPropertyFillLayer::applyInheritValue): |
| 7107 (WebCore::ApplyPropertyFillLayer::applyInitialValue): |
| 7108 (WebCore::ApplyPropertyFillLayer::applyValue): |
| 7109 (WebCore::ApplyPropertyFillLayer::createHandler): |
| 7110 (WebCore::ApplyPropertyComputeLength::setValue): |
| 7111 (WebCore::ApplyPropertyComputeLength::applyValue): |
| 7112 (WebCore::ApplyPropertyComputeLength::createHandler): |
| 7113 (WebCore::ApplyPropertyFont::applyInheritValue): |
| 7114 (WebCore::ApplyPropertyFont::applyInitialValue): |
| 7115 (WebCore::ApplyPropertyFont::applyValue): |
| 7116 (WebCore::ApplyPropertyFont::createHandler): |
| 7117 (WebCore::ApplyPropertyFontWeight::applyValue): |
| 7118 (WebCore::ApplyPropertyFontWeight::createHandler): |
| 7119 (WebCore::ApplyPropertyCounter::emptyFunction): |
| 7120 (WebCore::ApplyPropertyCounter::applyValue): |
| 7121 (WebCore::ApplyPropertyCounter::createHandler): |
| 7122 (WebCore::ApplyPropertyCursor::applyInheritValue): |
| 7123 (WebCore::ApplyPropertyCursor::applyInitialValue): |
| 7124 (WebCore::ApplyPropertyCursor::applyValue): |
| 7125 (WebCore::ApplyPropertyCursor::createHandler): |
| 7126 (WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue): |
| 7127 (WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue): |
| 7128 (WebCore::ApplyPropertyTextEmphasisStyle::applyValue): |
| 7129 (WebCore::ApplyPropertyTextEmphasisStyle::createHandler): |
| 7130 (WebCore::ApplyPropertyAnimation::setValue): |
| 7131 (WebCore::ApplyPropertyAnimation::value): |
| 7132 (WebCore::ApplyPropertyAnimation::test): |
| 7133 (WebCore::ApplyPropertyAnimation::clear): |
| 7134 (WebCore::ApplyPropertyAnimation::initial): |
| 7135 (WebCore::ApplyPropertyAnimation::map): |
| 7136 (WebCore::ApplyPropertyAnimation::accessAnimations): |
| 7137 (WebCore::ApplyPropertyAnimation::animations): |
| 7138 (WebCore::ApplyPropertyAnimation::applyInheritValue): |
| 7139 (WebCore::ApplyPropertyAnimation::applyInitialValue): |
| 7140 (WebCore::ApplyPropertyAnimation::applyValue): |
| 7141 (WebCore::ApplyPropertyAnimation::createHandler): |
| 7142 (WebCore::ApplyPropertyOutlineStyle::applyInheritValue): |
| 7143 (WebCore::ApplyPropertyOutlineStyle::applyInitialValue): |
| 7144 (WebCore::ApplyPropertyOutlineStyle::applyValue): |
| 7145 (WebCore::ApplyPropertyOutlineStyle::createHandler): |
| 7146 (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): |
| 7147 * css/CSSStyleApplyProperty.h: |
| 7148 (WebCore::PropertyHandler::PropertyHandler): |
| 7149 (WebCore::PropertyHandler::applyInheritValue): |
| 7150 (WebCore::PropertyHandler::applyInitialValue): |
| 7151 (WebCore::PropertyHandler::applyValue): |
| 7152 (WebCore::PropertyHandler::isValid): |
| 7153 (WebCore::PropertyHandler::inheritFunction): |
| 7154 (WebCore::PropertyHandler::initialFunction): |
| 7155 (WebCore::PropertyHandler::applyFunction): |
| 7156 (WebCore::CSSStyleApplyProperty::propertyHandler): |
| 7157 (WebCore::CSSStyleApplyProperty::setPropertyHandler): |
| 7158 * css/CSSStyleSelector.cpp: |
| 7159 (WebCore::CSSStyleSelector::applyProperty): |
| 7160 * rendering/style/RenderStyle.h: |
| 7161 (WebCore::InheritedFlags::invalidColor): |
| 7162 |
| 7163 2011-10-24 Ben Wells <benwells@chromium.org> |
| 7164 |
| 7165 Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAto
p and Copy have errors |
| 7166 https://bugs.webkit.org/show_bug.cgi?id=66920 |
| 7167 |
| 7168 Reviewed by James Robinson. |
| 7169 |
| 7170 Test: fast/canvas/canvas-composite-image.html |
| 7171 |
| 7172 Use the same method as fills to handle composited drawImage calls that w
ill affect the whole |
| 7173 canvas. To do this code used when doing fills has been factored into sep
erate functions and |
| 7174 used by drawImage. Some functions used to do these types of operations h
ave also been renamed. |
| 7175 |
| 7176 * html/canvas/CanvasRenderingContext2D.cpp: |
| 7177 (WebCore::isFullCanvasCompositeMode): |
| 7178 (WebCore::CanvasRenderingContext2D::fill): |
| 7179 (WebCore::CanvasRenderingContext2D::fillRect): |
| 7180 (WebCore::CanvasRenderingContext2D::drawImage): |
| 7181 (WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect): |
| 7182 (WebCore::CanvasRenderingContext2D::createCompositingBuffer): |
| 7183 (WebCore::CanvasRenderingContext2D::compositeBuffer): |
| 7184 (WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage): |
| 7185 (WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill): |
| 7186 * html/canvas/CanvasRenderingContext2D.h: |
| 7187 |
| 7188 2011-10-24 Sheriff Bot <webkit.review.bot@gmail.com> |
| 7189 |
| 7190 Unreviewed, rolling out r98294 and r98306. |
| 7191 http://trac.webkit.org/changeset/98294 |
| 7192 http://trac.webkit.org/changeset/98306 |
| 7193 https://bugs.webkit.org/show_bug.cgi?id=70790 |
| 7194 |
| 7195 the first patch broke chromium-mac and the second gclient |
| 7196 (Requested by jchaffraix on #webkit). |
| 7197 |
| 7198 * WebCore.gyp/WebCore.gyp: |
| 7199 |
| 7200 2011-10-24 Ryosuke Niwa <rniwa@webkit.org> |
| 7201 |
| 7202 Build fix after r98300. |
| 7203 |
| 7204 * WebCore.gypi: |
| 7205 * WebCore.pro: |
| 7206 |
| 7207 2011-10-24 Anders Carlsson <andersca@apple.com> |
| 7208 |
| 7209 It should be possible for Widget subclasses to control whether transform
s affect the frame rect |
| 7210 https://bugs.webkit.org/show_bug.cgi?id=70787 |
| 7211 |
| 7212 Reviewed by Sam Weinig. |
| 7213 |
| 7214 Currently RenderWidget sets the frame rect of it's hosted widget to the
bounding box of the transformed |
| 7215 content box rect (unless the Widget is a frame view). It should be possi
ble for Widget subclasses to override |
| 7216 this behavior and have the frame rect set to the absolute content box wi
thout any transforms applied. |
| 7217 |
| 7218 * platform/Widget.h: |
| 7219 (WebCore::Widget::transformsAffectFrameRect): |
| 7220 Add new member function. |
| 7221 |
| 7222 * rendering/RenderWidget.cpp: |
| 7223 (WebCore::RenderWidget::updateWidgetGeometry): |
| 7224 Move shared code from setWidget and updateWidgetPosition out into a new
function. If transformsAffectFrameRect returns |
| 7225 false, just set the frame rect to the absolute content box. |
| 7226 |
| 7227 (WebCore::RenderWidget::setWidget): |
| 7228 (WebCore::RenderWidget::updateWidgetPosition): |
| 7229 Call updateWidgetGeometry. |
| 7230 |
| 7231 * rendering/RenderWidget.h: |
| 7232 |
| 7233 2011-10-24 Arko Saha <arko@motorola.com> |
| 7234 |
| 7235 Microdata: Add itemprop, itemref, itemvalue attributes. |
| 7236 https://bugs.webkit.org/show_bug.cgi?id=69839 |
| 7237 |
| 7238 Reviewed by Ryosuke Niwa. |
| 7239 |
| 7240 Tests: fast/dom/MicroData/itemprop-add-remove-tokens.html |
| 7241 fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html |
| 7242 fast/dom/MicroData/itemprop-must-be-read-only.html |
| 7243 fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html |
| 7244 fast/dom/MicroData/itemref-add-remove-tokens.html |
| 7245 fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-propert
y.html |
| 7246 fast/dom/MicroData/itemref-for-an-element-must-be-correct.html |
| 7247 fast/dom/MicroData/itemref-must-be-read-only.html |
| 7248 fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element
.html |
| 7249 fast/dom/MicroData/itemvalue-reflects-href-attr.html |
| 7250 fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-elemen
t.html |
| 7251 fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-el
ement.html |
| 7252 fast/dom/MicroData/itemvalue-reflects-the-src-attr.html |
| 7253 fast/dom/MicroData/itemvalue-returns-element-itself.html |
| 7254 fast/dom/MicroData/itemvalue-returns-null.html |
| 7255 fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html |
| 7256 fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html |
| 7257 |
| 7258 * CMakeLists.txt: |
| 7259 * GNUmakefile.list.am: |
| 7260 * WebCore.gypi: |
| 7261 * WebCore.pro: |
| 7262 * WebCore.vcproj/WebCore.vcproj: |
| 7263 * bindings/js/JSHTMLElementCustom.cpp: |
| 7264 (WebCore::toJS): |
| 7265 (WebCore::JSHTMLElement::itemValue): |
| 7266 (WebCore::JSHTMLElement::setItemValue): |
| 7267 * bindings/v8/custom/V8HTMLElementCustom.cpp: |
| 7268 (WebCore::toV8Object): |
| 7269 (WebCore::V8HTMLElement::itemValueAccessorGetter): |
| 7270 (WebCore::V8HTMLElement::itemValueAccessorSetter): |
| 7271 * dom/MicroDataItemList.cpp: |
| 7272 * html/HTMLAnchorElement.cpp: |
| 7273 (WebCore::HTMLAnchorElement::itemValueText): |
| 7274 (WebCore::HTMLAnchorElement::setItemValueText): |
| 7275 * html/HTMLAnchorElement.h: |
| 7276 * html/HTMLAreaElement.cpp: |
| 7277 (WebCore::HTMLAreaElement::itemValueText): |
| 7278 (WebCore::HTMLAreaElement::setItemValueText): |
| 7279 * html/HTMLAreaElement.h: |
| 7280 * html/HTMLAttributeNames.in: |
| 7281 * html/HTMLElement.cpp: |
| 7282 (WebCore::HTMLElement::parseMappedAttribute): |
| 7283 (WebCore::HTMLElement::itemProp): Returns element's itemprop content att
ribute. |
| 7284 (WebCore::HTMLElement::setItemProp): Sets itemprop value on changing ele
met's |
| 7285 itemprop attribute. |
| 7286 (WebCore::HTMLElement::itemRef): Returns element's itemref content attri
bute. |
| 7287 (WebCore::HTMLElement::setItemRef): Sets itemref value on changing eleme
t's |
| 7288 itemref attribute. |
| 7289 (WebCore::HTMLElement::setItemValue): Sets element's itemvalue. If the e
lement has no |
| 7290 itemprop attribute or if element has an itemscope attribute, it throws I
NVALID_ACCESS_ERR |
| 7291 exception. |
| 7292 (WebCore::HTMLElement::itemValue): Returns the elements itemvalue. |
| 7293 |
| 7294 If the element has no itemprop attribute it returns null. |
| 7295 If the element has an itemscope attribute, it returns the element itself
. |
| 7296 If the element is a meta element: It acts as it would if it was reflecti
ng the element's |
| 7297 content content attribute. |
| 7298 If the element is an audio, embed, iframe, img, source, track, or video
element: It acts |
| 7299 as it would if it was reflecting the element's src content attribute. |
| 7300 If the element is an a, area, or link element: It act as it would if it
was reflecting the |
| 7301 href content attribute. |
| 7302 If the element is an object element: It acts as it would if it was refl
ecting the element's |
| 7303 data content attribute. |
| 7304 |
| 7305 (WebCore::HTMLElement::itemValueText): |
| 7306 (WebCore::HTMLElement::setItemValueText): |
| 7307 * html/HTMLElement.h: |
| 7308 * html/HTMLElement.idl: |
| 7309 * html/HTMLEmbedElement.cpp: |
| 7310 (WebCore::HTMLEmbedElement::itemValueText): |
| 7311 (WebCore::HTMLEmbedElement::setItemValueText): |
| 7312 * html/HTMLEmbedElement.h: |
| 7313 * html/HTMLIFrameElement.cpp: |
| 7314 (WebCore::HTMLIFrameElement::itemValueText): |
| 7315 (WebCore::HTMLIFrameElement::setItemValueText): |
| 7316 * html/HTMLIFrameElement.h: |
| 7317 * html/HTMLImageElement.cpp: |
| 7318 (WebCore::HTMLImageElement::itemValueText): |
| 7319 (WebCore::HTMLImageElement::setItemValueText): |
| 7320 * html/HTMLImageElement.h: |
| 7321 * html/HTMLLinkElement.cpp: |
| 7322 (WebCore::HTMLLinkElement::itemValueText): |
| 7323 (WebCore::HTMLLinkElement::setItemValueText): |
| 7324 * html/HTMLLinkElement.h: |
| 7325 * html/HTMLMediaElement.cpp: |
| 7326 (WebCore::HTMLMediaElement::itemValueText): |
| 7327 (WebCore::HTMLMediaElement::setItemValueText): |
| 7328 * html/HTMLMediaElement.h: |
| 7329 * html/HTMLMetaElement.cpp: |
| 7330 (WebCore::HTMLMetaElement::itemValueText): |
| 7331 (WebCore::HTMLMetaElement::setItemValueText): |
| 7332 * html/HTMLMetaElement.h: |
| 7333 * html/HTMLObjectElement.cpp: |
| 7334 (WebCore::HTMLObjectElement::itemValueText): |
| 7335 (WebCore::HTMLObjectElement::setItemValueText): |
| 7336 * html/HTMLObjectElement.h: |
| 7337 * html/HTMLSourceElement.cpp: |
| 7338 (WebCore::HTMLSourceElement::itemValueText): |
| 7339 (WebCore::HTMLSourceElement::setItemValueText): |
| 7340 * html/HTMLSourceElement.h: |
| 7341 * html/HTMLTrackElement.cpp: |
| 7342 (WebCore::HTMLTrackElement::itemValueText): |
| 7343 (WebCore::HTMLTrackElement::setItemValueText): |
| 7344 * html/HTMLTrackElement.h: |
| 7345 * html/MicroDataItemValue.cpp: Added. |
| 7346 (WebCore::MicroDataItemValue::MicroDataItemValue): |
| 7347 (WebCore::MicroDataItemValue::createFromString): |
| 7348 (WebCore::MicroDataItemValue::createFromNode): |
| 7349 * html/MicroDataItemValue.h: Added. |
| 7350 (WebCore::MicroDataItemValue::isNode): |
| 7351 (WebCore::MicroDataItemValue::getNode): |
| 7352 (WebCore::MicroDataItemValue::getString): |
| 7353 |
| 7354 2011-10-24 Joseph Pecoraro <joepeck@webkit.org> |
| 7355 |
| 7356 Remove unused instance variable |
| 7357 https://bugs.webkit.org/show_bug.cgi?id=70750 |
| 7358 |
| 7359 Reviewed by Dimitri Glazkov. |
| 7360 |
| 7361 * rendering/RenderTextControl.h: |
| 7362 |
| 7363 2011-10-24 Nico Weber <thakis@chromium.org> |
| 7364 |
| 7365 [chromium/mac] Fix an ODR violation. |
| 7366 https://bugs.webkit.org/show_bug.cgi?id=70753 |
| 7367 |
| 7368 Reviewed by Anders Carlsson. |
| 7369 |
| 7370 Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::cre
ate() on OS X. |
| 7371 Remove the unused one. |
| 7372 |
| 7373 * WebCore.gyp/WebCore.gyp: |
| 7374 |
| 7375 2011-10-24 Tim Horton <timothy_horton@apple.com> |
| 7376 |
| 7377 feColorMatrix doesn't use the correct default "matrix" type when no type
attribute is specified |
| 7378 https://bugs.webkit.org/show_bug.cgi?id=70035 |
| 7379 <rdar://problem/10280177> |
| 7380 |
| 7381 Reviewed by Nikolas Zimmermann. |
| 7382 |
| 7383 Make feColorMatrix's type attribute be "matrix" by default. |
| 7384 |
| 7385 Test: svg/filters/feColorMatrix-default-type.svg |
| 7386 |
| 7387 * svg/SVGFEColorMatrixElement.cpp: |
| 7388 (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): |
| 7389 |
| 7390 2011-10-24 Joshua Bell <jsbell@chromium.org> |
| 7391 |
| 7392 Unbreak binding generation tests |
| 7393 https://bugs.webkit.org/show_bug.cgi?id=70768 |
| 7394 |
| 7395 Reviewed by Darin Adler. |
| 7396 |
| 7397 Update the expected output of V8 binding tests to match |
| 7398 results c/o https://bugs.webkit.org/show_bug.cgi?id=70065 |
| 7399 |
| 7400 * bindings/scripts/test/V8/V8TestObj.cpp: |
| 7401 (WebCore::TestObjInternal::idbKeyCallback): |
| 7402 |
| 7403 2011-10-21 Nat Duca <nduca@chromium.org> |
| 7404 |
| 7405 [chromium] Add isTraceEventEnabled to PlatformSupport. |
| 7406 https://bugs.webkit.org/show_bug.cgi?id=70618 |
| 7407 |
| 7408 Reviewed by Darin Fisher. |
| 7409 |
| 7410 * platform/chromium/PlatformSupport.h: |
| 7411 |
| 7412 2011-10-24 Mihnea Ovidenie <mihnea@adobe.com> |
| 7413 |
| 7414 Use StringBuilder in CSSRuleList::rulesText()/CSSSelectorList::selectors
Text() |
| 7415 https://bugs.webkit.org/show_bug.cgi?id=70746 |
| 7416 |
| 7417 Reviewed by Tony Chang. |
| 7418 |
| 7419 Covered by existing tests. |
| 7420 |
| 7421 * css/CSSRuleList.cpp: |
| 7422 (WebCore::CSSRuleList::rulesText): |
| 7423 * css/CSSSelectorList.cpp: |
| 7424 (WebCore::CSSSelectorList::selectorsText): |
| 7425 * css/WebKitCSSKeyframesRule.cpp: |
| 7426 (WebCore::WebKitCSSKeyframesRule::cssText): Use CSSRuleList::rulesText()
method instead of explicit loop. |
| 7427 |
| 7428 2011-10-24 Michael Saboff <msaboff@apple.com> |
| 7429 |
| 7430 WebKit doesn't build with recent changes to libdispatch |
| 7431 https://bugs.webkit.org/show_bug.cgi?id=70737 |
| 7432 |
| 7433 Added initialization for new WebKitSystemInterface function |
| 7434 CreateVMPressureDispatchOnMainQueue. Changed MemoryPressureHandler::ins
tall |
| 7435 to use new function. |
| 7436 |
| 7437 Reviewed by Geoffrey Garen. |
| 7438 |
| 7439 No new tests. Moved functionality to WebKitSystemInterface. |
| 7440 |
| 7441 * WebCore.exp.in: |
| 7442 * platform/mac/MemoryPressureHandlerMac.mm: |
| 7443 (WebCore::MemoryPressureHandler::install): |
| 7444 * platform/mac/WebCoreSystemInterface.h: |
| 7445 * platform/mac/WebCoreSystemInterface.mm: |
| 7446 |
| 7447 2011-10-24 Joshua Bell <jsbell@chromium.org> |
| 7448 |
| 7449 IndexedDB: Throw DATA_ERR on invalid keys, remove null key support |
| 7450 https://bugs.webkit.org/show_bug.cgi?id=70065 |
| 7451 |
| 7452 Reviewed by Tony Chang. |
| 7453 |
| 7454 Part 1 of a two-sided commit. Renames IDBKey::NullType to |
| 7455 IDBKey::InvalidType. JS binding yields this type rather |
| 7456 than throwing immediately so the correct exception type can |
| 7457 be raised. Checks for invalid keys added to front-end classes. |
| 7458 |
| 7459 * bindings/js/JSIDBKeyCustom.cpp: |
| 7460 (WebCore::toJS): |
| 7461 * bindings/scripts/CodeGeneratorV8.pm: |
| 7462 (TypeCanFailConversion): |
| 7463 * bindings/v8/IDBBindingUtilities.cpp: |
| 7464 (WebCore::createIDBKeyFromValue): |
| 7465 * bindings/v8/custom/V8IDBKeyCustom.cpp: |
| 7466 (WebCore::toV8): |
| 7467 * storage/IDBCursor.cpp: |
| 7468 (WebCore::IDBCursor::continueFunction): |
| 7469 * storage/IDBFactory.cpp: |
| 7470 (WebCore::IDBFactory::cmp): |
| 7471 * storage/IDBIndex.cpp: |
| 7472 (WebCore::IDBIndex::get): |
| 7473 (WebCore::IDBIndex::getKey): |
| 7474 * storage/IDBKey.cpp: |
| 7475 (WebCore::IDBKey::IDBKey): |
| 7476 (WebCore::IDBKey::compare): |
| 7477 * storage/IDBKey.h: |
| 7478 (WebCore::IDBKey::createInvalid): |
| 7479 * storage/IDBKeyRange.cpp: |
| 7480 (WebCore::IDBKeyRange::only): |
| 7481 (WebCore::IDBKeyRange::lowerBound): |
| 7482 (WebCore::IDBKeyRange::upperBound): |
| 7483 (WebCore::IDBKeyRange::bound): |
| 7484 * storage/IDBKeyRange.h: |
| 7485 (WebCore::IDBKeyRange::lowerBound): |
| 7486 (WebCore::IDBKeyRange::upperBound): |
| 7487 (WebCore::IDBKeyRange::bound): |
| 7488 * storage/IDBKeyRange.idl: |
| 7489 * storage/IDBLevelDBCoding.cpp: |
| 7490 (WebCore::IDBLevelDBCoding::encodeIDBKey): |
| 7491 (WebCore::IDBLevelDBCoding::decodeIDBKey): |
| 7492 * storage/IDBObjectStore.cpp: |
| 7493 (WebCore::IDBObjectStore::get): |
| 7494 (WebCore::IDBObjectStore::add): |
| 7495 (WebCore::IDBObjectStore::put): |
| 7496 (WebCore::IDBObjectStore::deleteFunction): |
| 7497 * storage/IDBObjectStoreBackendImpl.cpp: |
| 7498 (WebCore::IDBObjectStoreBackendImpl::put): |
| 7499 (WebCore::IDBObjectStoreBackendImpl::putInternal): |
| 7500 (WebCore::IDBObjectStoreBackendImpl::deleteFunction): |
| 7501 * storage/IDBSQLiteBackingStore.cpp: |
| 7502 (WebCore::whereSyntaxForKey): |
| 7503 (WebCore::bindKeyToQuery): |
| 7504 (WebCore::lowerCursorWhereFragment): |
| 7505 (WebCore::upperCursorWhereFragment): |
| 7506 (WebCore::bindKeyToQueryWithNulls): |
| 7507 (WebCore::keyFromQuery): |
| 7508 |
| 7509 2011-10-24 Alok Priyadarshi <alokp@chromium.org> |
| 7510 |
| 7511 [chromium] Make accelerated drawing work with threaded compositing |
| 7512 https://bugs.webkit.org/show_bug.cgi?id=70656 |
| 7513 |
| 7514 Reviewed by James Robinson. |
| 7515 |
| 7516 Make sure that the compositor context is not used outside LayerTextureUp
dater::updateTextureRect(). |
| 7517 Created a FrameBuffer class that wraps skia gpu canvas and manages GL re
sources. |
| 7518 |
| 7519 * platform/graphics/chromium/ContentLayerChromium.cpp: |
| 7520 (WebCore::ContentLayerChromium::createTextureUpdater): |
| 7521 * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: |
| 7522 (WebCore::FrameBuffer::FrameBuffer::FrameBuffer): |
| 7523 (WebCore::FrameBuffer::FrameBuffer::~FrameBuffer): |
| 7524 (WebCore::FrameBuffer::FrameBuffer::initialize): |
| 7525 (WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture): |
| 7526 (WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture): |
| 7527 (WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate): |
| 7528 (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect): |
| 7529 * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: |
| 7530 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: |
| 7531 (WebCore::CCLayerTreeHost::initialize): |
| 7532 |
| 7533 2011-10-24 Adam Klein <adamk@chromium.org> |
| 7534 |
| 7535 Optimize Node::isInShadowTree to execute in constant-time |
| 7536 https://bugs.webkit.org/show_bug.cgi?id=67686 |
| 7537 |
| 7538 Reviewed by Dimitri Glazkov. |
| 7539 |
| 7540 No expected change in behavior, so no new tests. |
| 7541 |
| 7542 * dom/Node.cpp: |
| 7543 (WebCore::Node::isInShadowTree): |
| 7544 |
| 7545 2011-10-24 Nat Duca <nduca@chromium.org> |
| 7546 |
| 7547 [chromium] Expose WebThread::postDelayedTask to CCThread |
| 7548 https://bugs.webkit.org/show_bug.cgi?id=70712 |
| 7549 |
| 7550 Reviewed by James Robinson. |
| 7551 |
| 7552 * platform/graphics/chromium/cc/CCThread.h: |
| 7553 |
| 7554 2011-10-24 Levi Weintraub <leviw@chromium.org> |
| 7555 |
| 7556 <svg> fails to use explicit width and height inside <html> inside IFRAME |
| 7557 https://bugs.webkit.org/show_bug.cgi?id=64823 |
| 7558 |
| 7559 Reviewed by Nikolas Zimmermann. |
| 7560 |
| 7561 Checking that embedded SVG is in an SVG document before negotiating size |
| 7562 with the host document. |
| 7563 |
| 7564 Test: svg/as-object/svg-embedded-in-html-in-iframe.html |
| 7565 |
| 7566 * rendering/svg/RenderSVGRoot.cpp: |
| 7567 (WebCore::isEmbeddedThroughFrameContainingSVGDocument): |
| 7568 (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): |
| 7569 (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): |
| 7570 |
| 7571 2011-10-24 Rafael Weinstein <rafaelw@chromium.org> |
| 7572 |
| 7573 Node::registeredMutationObserversOfType should be prefixed by "get" |
| 7574 https://bugs.webkit.org/show_bug.cgi?id=70359 |
| 7575 |
| 7576 Reviewed by Ojan Vafai. |
| 7577 |
| 7578 This change renames Node::registeredMutationObserversOfType to |
| 7579 Node::getRegisteredMutationObserversOfType per the WebKit style guide. |
| 7580 |
| 7581 No tests needed as the change is only method renaming. |
| 7582 |
| 7583 * dom/CharacterData.cpp: |
| 7584 (WebCore::CharacterData::dispatchModifiedEvent): |
| 7585 * dom/ChildListMutationScope.cpp: |
| 7586 (WebCore::MutationAccumulationRouter::MutationAccumulationRouter::increm
entScopingLevel): |
| 7587 * dom/Element.cpp: |
| 7588 (WebCore::enqueueAttributesMutationRecord): |
| 7589 * dom/Node.cpp: |
| 7590 (WebCore::Node::getRegisteredMutationObserversOfType): |
| 7591 * dom/Node.h: |
| 7592 |
| 7593 2011-10-24 Mark Hahnenberg <mhahnenberg@apple.com> |
| 7594 |
| 7595 Rename static getOwnPropertySlot to getOwnPropertySlotByIndex |
| 7596 https://bugs.webkit.org/show_bug.cgi?id=70271 |
| 7597 |
| 7598 Reviewed by Darin Adler. |
| 7599 |
| 7600 No new tests. |
| 7601 |
| 7602 Renaming versions of getOwnPropertySlot that use an unsigned as the prop
erty |
| 7603 name to "getOwnPropertySlotByIndex" in preparation for adding them to th
e |
| 7604 MethodTable, which requires unique names for each method. |
| 7605 |
| 7606 * bindings/js/SerializedScriptValue.cpp: |
| 7607 (WebCore::CloneSerializer::getSparseIndex): |
| 7608 * bindings/scripts/CodeGeneratorJS.pm: |
| 7609 (GenerateHeader): |
| 7610 (GenerateImplementation): |
| 7611 * bridge/runtime_array.cpp: |
| 7612 (JSC::RuntimeArray::getOwnPropertySlotVirtual): |
| 7613 (JSC::RuntimeArray::getOwnPropertySlotByIndex): |
| 7614 * bridge/runtime_array.h: |
| 7615 |
| 7616 2011-10-24 Joshua Bell <jsbell@chromium.org> |
| 7617 |
| 7618 IndexedDB add should fail adding an inline and passed key simultaneously |
| 7619 https://bugs.webkit.org/show_bug.cgi?id=58598 |
| 7620 |
| 7621 Reviewed by Tony Chang. |
| 7622 |
| 7623 Test: storage/indexeddb/mozilla/key-requirements-inline-and-passed.html |
| 7624 |
| 7625 Implement the spec clause: passing a key into add() or put() when |
| 7626 the object store has a key path ("inline key") is an error. |
| 7627 |
| 7628 * storage/IDBObjectStoreBackendImpl.cpp: |
| 7629 (WebCore::IDBObjectStoreBackendImpl::put): |
| 7630 |
| 7631 2011-10-24 Simon Fraser <simon.fraser@apple.com> |
| 7632 |
| 7633 Improve debug compositing border colors |
| 7634 https://bugs.webkit.org/show_bug.cgi?id=70742 |
| 7635 |
| 7636 Reviewed by Dean Jackson. |
| 7637 |
| 7638 Improve the appearance of the debug borders used to indicate compositing
: |
| 7639 1. Use green for normal layers, orange for tiled layers |
| 7640 2. Make the repaint counter translucent |
| 7641 3. Change the color of the repaint counter to show when accelerated draw
ing is enabled. |
| 7642 |
| 7643 * platform/graphics/GraphicsLayer.cpp: |
| 7644 (WebCore::GraphicsLayer::updateDebugIndicators): |
| 7645 * platform/graphics/mac/WebLayer.mm: |
| 7646 (drawLayerContents): |
| 7647 |
| 7648 2011-10-24 Carlos Garcia Campos <cgarcia@igalia.com> |
| 7649 |
| 7650 [GTK] Fix make distcheck build |
| 7651 https://bugs.webkit.org/show_bug.cgi?id=69745 |
| 7652 |
| 7653 Reviewed by Martin Robinson. |
| 7654 |
| 7655 * GNUmakefile.am: |
| 7656 * GNUmakefile.list.am: |
| 7657 |
| 7658 2011-10-24 Alexander Pavlov <apavlov@chromium.org> |
| 7659 |
| 7660 Web Inspector: [Styles] Adding a new style rule breaks things |
| 7661 https://bugs.webkit.org/show_bug.cgi?id=70721 |
| 7662 |
| 7663 Reviewed by Pavel Feldman. |
| 7664 |
| 7665 We had used to swap BlankStylePropertiesSection prototype and recently g
ot rid of this hack, |
| 7666 but still had dependencies on the old behavior. |
| 7667 |
| 7668 * inspector/front-end/StylesSidebarPane.js: |
| 7669 (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): |
| 7670 (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTr
ace): |
| 7671 (WebInspector.BlankStylePropertiesSection.prototype.get isBlank): |
| 7672 (WebInspector.BlankStylePropertiesSection.prototype.expand): |
| 7673 (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommi
tted.successCallback): |
| 7674 (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommi
tted): |
| 7675 (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCance
lled): |
| 7676 (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): |
| 7677 |
| 7678 2011-10-24 Pavel Feldman <pfeldman@google.com> |
| 7679 |
| 7680 Web Inspector: do not force document loading on reload (should happen on
demand). |
| 7681 https://bugs.webkit.org/show_bug.cgi?id=70724 |
| 7682 |
| 7683 Reviewed by Yury Semikhatsky. |
| 7684 |
| 7685 * inspector/front-end/ConsoleMessage.js: |
| 7686 (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode): |
| 7687 * inspector/front-end/DOMAgent.js: |
| 7688 (WebInspector.DOMAgent.prototype._documentUpdated): |
| 7689 * inspector/front-end/ElementsPanel.js: |
| 7690 (WebInspector.ElementsPanel.prototype.wasShown): |
| 7691 * inspector/front-end/ElementsTreeOutline.js: |
| 7692 (WebInspector.ElementsTreeOutline.prototype.setVisible): |
| 7693 |
| 7694 2011-10-24 Eric Carlson <eric.carlson@apple.com> |
| 7695 |
| 7696 Drop MutableTextTrack and make TextTrack always mutable |
| 7697 https://bugs.webkit.org/show_bug.cgi?id=62890 |
| 7698 |
| 7699 The MutableTextTrack type was removed from the spec, all text tracks are
now mutable. |
| 7700 |
| 7701 Reviewed by Sam Weinig. |
| 7702 |
| 7703 No new tests needed, the changes just refactor existing code. |
| 7704 |
| 7705 * CMakeLists.txt: Remove all traces of MutableTextTrack. |
| 7706 * CodeGenerators.pri: Ditto. |
| 7707 * DerivedSources.cpp: Ditto. |
| 7708 * DerivedSources.make: Ditto. |
| 7709 * GNUmakefile.list.am: Ditto. |
| 7710 * WebCore.gypi: Ditto. |
| 7711 * WebCore.pro: Ditto. |
| 7712 * WebCore.xcodeproj/project.pbxproj: Ditto. |
| 7713 * bindings/gobject/GNUmakefile.am: Ditto. |
| 7714 * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Ditto. |
| 7715 * bindings/js/JSBindingsAllInOne.cpp: Ditto. |
| 7716 |
| 7717 * bindings/js/JSTextTrackCustom.cpp: Removed. |
| 7718 |
| 7719 * html/HTMLMediaElement.cpp: |
| 7720 (WebCore::HTMLMediaElement::addTrack): Return a TextTrack instead of a M
utableTextTrack. |
| 7721 * html/HTMLMediaElement.h: |
| 7722 * html/HTMLMediaElement.idl: |
| 7723 |
| 7724 * html/LoadableTextTrack.cpp: |
| 7725 (WebCore::LoadableTextTrack::LoadableTextTrack): Return a TextTrack inst
ead of a MutableTextTrack. |
| 7726 |
| 7727 * html/MutableTextTrack.cpp: Removed. |
| 7728 * html/MutableTextTrack.h: Removed. |
| 7729 * html/MutableTextTrack.idl: Removed. |
| 7730 |
| 7731 * html/TextTrack.cpp: |
| 7732 (WebCore::TextTrack::TextTrack): Remove Type parameter. |
| 7733 (WebCore::TextTrack::addCue): New, moved from MutableTextTrack. |
| 7734 (WebCore::TextTrack::removeCue): Ditto. |
| 7735 (WebCore::TextTrack::newCuesLoaded): Ditto. |
| 7736 (WebCore::TextTrack::fetchNewestCues): Ditto. |
| 7737 * html/TextTrack.h: |
| 7738 (WebCore::TextTrack::create): Remove Type parameter |
| 7739 * html/TextTrack.idl: Add addCue and removeCue. |
| 7740 |
| 7741 2011-10-24 Yury Semikhatsky <yurys@chromium.org> |
| 7742 |
| 7743 Web Inspector: allow debugging dedicated worker initialization |
| 7744 https://bugs.webkit.org/show_bug.cgi?id=70723 |
| 7745 |
| 7746 Now it is possible to pause each new dedicated worker on start. The user |
| 7747 needs to select a checkbox and then each newly created dedicated worker |
| 7748 will be paused on the first statement until the user resumes it explicit
ely. |
| 7749 |
| 7750 Reviewed by Pavel Feldman. |
| 7751 |
| 7752 * inspector/Inspector.json: resume command is added. It is similar to GD
B's run |
| 7753 command, i.e. worker execution will be paused until explicit "resume" co
mmand is |
| 7754 received. |
| 7755 * inspector/InspectorInstrumentation.cpp: |
| 7756 (WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStartImp
l): |
| 7757 * inspector/InspectorInstrumentation.h: |
| 7758 (WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart): |
| 7759 * inspector/InspectorRuntimeAgent.cpp: |
| 7760 (WebCore::InspectorRuntimeAgent::resume): |
| 7761 (WebCore::InspectorRuntimeAgent::pauseWorkerContext): |
| 7762 * inspector/InspectorRuntimeAgent.h: |
| 7763 * inspector/InspectorWorkerAgent.cpp: |
| 7764 (WebCore::InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart): retu
rns true |
| 7765 if the user chose to automatically pause all new workers. |
| 7766 * inspector/InspectorWorkerAgent.h: |
| 7767 * inspector/WorkerInspectorController.cpp: |
| 7768 (WebCore::WorkerInspectorController::resume): |
| 7769 * inspector/front-end/WorkerManager.js: |
| 7770 (WebInspector.WorkerManager.loaded): |
| 7771 (WebInspector.WorkerManager.loadCompleted): |
| 7772 (WebInspector.WorkerManager.prototype._workerCreated): |
| 7773 (WebInspector.WorkerManager.prototype.openWorkerInspector): |
| 7774 (WebInspector.WorkerManager.prototype._openInspectorWindow): |
| 7775 * inspector/front-end/inspector.js: |
| 7776 (WebInspector.loaded): |
| 7777 * workers/Worker.cpp: |
| 7778 (WebCore::Worker::notifyFinished): |
| 7779 * workers/WorkerContextProxy.h: |
| 7780 * workers/WorkerMessagingProxy.cpp: |
| 7781 (WebCore::WorkerMessagingProxy::startWorkerContext): additional flag spe
cifying |
| 7782 worker initial state(paused/not paused) is added to the factory method.
The flag |
| 7783 will be carried to the corresponding WorkerThread. |
| 7784 (WebCore::WorkerMessagingProxy::connectToInspector): |
| 7785 * workers/WorkerMessagingProxy.h: |
| 7786 |
| 7787 2011-10-21 Nikita Vasilyev <me@elv1s.ru> |
| 7788 |
| 7789 Web Inspector: Make indent configurable |
| 7790 https://bugs.webkit.org/show_bug.cgi?id=69986 |
| 7791 |
| 7792 Add a setting to choose an indent from "8 spaces", "4 spaces" (default),
"2 spaces", or "Tab character". |
| 7793 |
| 7794 Reviewed by Pavel Feldman. |
| 7795 |
| 7796 * English.lproj/localizedStrings.js: |
| 7797 * inspector/front-end/SettingsScreen.js: |
| 7798 (WebInspector.SettingsScreen): |
| 7799 (WebInspector.SettingsScreen.prototype._createSelectSetting.get p): |
| 7800 (WebInspector.SettingsScreen.prototype._createSelectSetting.changeListen
er): |
| 7801 * inspector/front-end/TextEditorModel.js: |
| 7802 (WebInspector.TextEditorModel): |
| 7803 * inspector/front-end/TextViewer.js: |
| 7804 |
| 7805 2011-10-17 Andrey Kosyakov <caseq@chromium.org> |
| 7806 |
| 7807 Web Inspector: add "Add to Watch" option to context menu on selection in
source frame |
| 7808 https://bugs.webkit.org/show_bug.cgi?id=69924 |
| 7809 |
| 7810 Reviewed by Pavel Feldman. |
| 7811 |
| 7812 - added 'Add to Watch' context menu item in scripts panel; |
| 7813 - include both default and custom items into a context menu if selection
is present; |
| 7814 |
| 7815 * inspector/front-end/ScriptsPanel.js: |
| 7816 (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFile
Name): |
| 7817 (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.addToWatch): |
| 7818 * inspector/front-end/SourceFrame.js: |
| 7819 (WebInspector.SourceFrame.prototype.populateSelectionContextMenu): |
| 7820 (WebInspector.TextViewerDelegateForSourceFrame.prototype.populateSelecti
onContextMenu): |
| 7821 (WebInspector.SourceFrameDelegate.prototype.suggestedFileName): |
| 7822 (WebInspector.SourceFrameDelegate.prototype.addToWatch): |
| 7823 * inspector/front-end/TextViewer.js: |
| 7824 (WebInspector.TextViewer.prototype._contextMenu): |
| 7825 (WebInspector.TextViewerDelegate.prototype.populateSelectionContextMenu)
: |
| 7826 * inspector/front-end/WatchExpressionsSidebarPane.js: |
| 7827 (WebInspector.WatchExpressionsSidebarPane.prototype.addExpression): |
| 7828 (WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked): |
| 7829 (WebInspector.WatchExpressionsSection.prototype.addExpression): |
| 7830 (WebInspector.WatchExpressionsSection.prototype.addNewExpressionAndEdit)
: |
| 7831 * page/ContextMenuController.cpp: |
| 7832 (WebCore::ContextMenuController::showContextMenu): |
| 7833 |
| 7834 2011-10-21 Alexander Pavlov <apavlov@chromium.org> |
| 7835 |
| 7836 Web Inspector: Audits hang on pages without img[src] elements |
| 7837 https://bugs.webkit.org/show_bug.cgi?id=70604 |
| 7838 |
| 7839 Reviewed by Pavel Feldman. |
| 7840 |
| 7841 Test: inspector/audits/audits-panel-noimages-functional.html |
| 7842 |
| 7843 * inspector/front-end/AuditRules.js: |
| 7844 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles): |
| 7845 |
| 7846 2011-10-24 Deepak Sherveghar <bpwv64@motorola.com> |
| 7847 |
| 7848 [Qt] fast/events/media-focus-in-standalone-media-document.html fails |
| 7849 https://bugs.webkit.org/show_bug.cgi?id=70110 |
| 7850 |
| 7851 Reviewed by Simon Hausmann. |
| 7852 |
| 7853 ExtensionMap should also include media files mapping. |
| 7854 |
| 7855 * platform/qt/MIMETypeRegistryQt.cpp: Added media files mapping. |
| 7856 |
| 7857 2011-10-24 Pavel Feldman <pfeldman@google.com> |
| 7858 |
| 7859 Not reviewed: [chromium] follow up to 98228 - added missing css. |
| 7860 |
| 7861 * WebCore.gypi: |
| 7862 |
| 7863 2011-10-24 Pavel Feldman <pfeldman@chromium.org> |
| 7864 |
| 7865 Web Inspector: Make CSS files load upon View demand; split inspector.css
into views. |
| 7866 https://bugs.webkit.org/show_bug.cgi?id=70694 |
| 7867 |
| 7868 Reviewed by Yury Semikhatsky. |
| 7869 |
| 7870 * WebCore.gypi: |
| 7871 * WebCore.vcproj/WebCore.vcproj: |
| 7872 * inspector/front-end/AuditsPanel.js: |
| 7873 (WebInspector.AuditsPanel): |
| 7874 * inspector/front-end/DataGrid.js: |
| 7875 (WebInspector.DataGrid): |
| 7876 * inspector/front-end/ElementsPanel.js: |
| 7877 * inspector/front-end/NetworkPanel.js: |
| 7878 (WebInspector.NetworkLogView): |
| 7879 * inspector/front-end/PanelEnablerView.js: |
| 7880 * inspector/front-end/ProfilesPanel.js: |
| 7881 * inspector/front-end/ResourceView.js: |
| 7882 (WebInspector.ResourceView): |
| 7883 * inspector/front-end/ResourcesPanel.js: |
| 7884 * inspector/front-end/ScriptsPanel.js: |
| 7885 * inspector/front-end/TextViewer.js: |
| 7886 * inspector/front-end/TimelinePanel.js: |
| 7887 (WebInspector.TimelinePanel): |
| 7888 * inspector/front-end/WebKit.qrc: |
| 7889 * inspector/front-end/WelcomeView.js: |
| 7890 (WebInspector.WelcomeView): |
| 7891 * inspector/front-end/auditsPanel.css: Renamed from Source/WebCore/inspe
ctor/front-end/audits.css. |
| 7892 |
| 7893 2011-10-24 Pavel Feldman <pfeldman@chromium.org> |
| 7894 |
| 7895 Web Inspector: make view load CSS files upon show. |
| 7896 https://bugs.webkit.org/show_bug.cgi?id=70696 |
| 7897 |
| 7898 Reviewed by Yury Semikhatsky. |
| 7899 |
| 7900 Test: inspector/view-css.html |
| 7901 |
| 7902 * inspector/front-end/View.js: |
| 7903 (WebInspector.View): |
| 7904 (WebInspector.View.prototype._callOnVisibleChildren): |
| 7905 (WebInspector.View.prototype._processWillShow): |
| 7906 (WebInspector.View.prototype._processWasShown): |
| 7907 (WebInspector.View.prototype._processWillHide): |
| 7908 (WebInspector.View.prototype._processWasHidden): |
| 7909 (WebInspector.View.prototype._processOnResize): |
| 7910 (WebInspector.View.prototype.show): |
| 7911 (WebInspector.View.prototype.detach): |
| 7912 (WebInspector.View.prototype.registerRequiredCSS): |
| 7913 (WebInspector.View.prototype._loadCSSIfNeeded): |
| 7914 (WebInspector.View.prototype._doLoadCSS): |
| 7915 (WebInspector.View.prototype._disableCSSIfNeeded): |
| 7916 (WebInspector.View.prototype._doUnloadCSS): |
| 7917 |
| 7918 2011-10-24 Pavel Feldman <pfeldman@chromium.org> |
| 7919 |
| 7920 Web Inspector: make DataGrid a view |
| 7921 https://bugs.webkit.org/show_bug.cgi?id=70695 |
| 7922 |
| 7923 Reviewed by Yury Semikhatsky. |
| 7924 |
| 7925 * inspector/front-end/ApplicationCacheItemsView.js: |
| 7926 (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid): |
| 7927 * inspector/front-end/CookieItemsView.js: |
| 7928 (WebInspector.CookieItemsView.prototype._updateWithCookies): |
| 7929 (WebInspector.SimpleCookiesTable): |
| 7930 (WebInspector.SimpleCookiesTable.prototype.setCookies): |
| 7931 * inspector/front-end/CookiesTable.js: |
| 7932 (WebInspector.CookiesTable): |
| 7933 * inspector/front-end/DOMStorageItemsView.js: |
| 7934 (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries): |
| 7935 * inspector/front-end/DataGrid.js: |
| 7936 (WebInspector.DataGrid): |
| 7937 (WebInspector.DataGrid.prototype.onResize): |
| 7938 * inspector/front-end/DatabaseQueryView.js: |
| 7939 (WebInspector.DatabaseQueryView.prototype._queryFinished): |
| 7940 (WebInspector.DatabaseQueryView.prototype._queryError): |
| 7941 (WebInspector.DatabaseQueryView.prototype._appendViewQueryResult): |
| 7942 (WebInspector.DatabaseQueryView.prototype._appendErrorQueryResult): |
| 7943 (WebInspector.DatabaseQueryView.prototype._appendQueryResult): |
| 7944 * inspector/front-end/DatabaseTableView.js: |
| 7945 (WebInspector.DatabaseTableView.prototype._queryFinished): |
| 7946 * inspector/front-end/DetailedHeapshotView.js: |
| 7947 (WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2): |
| 7948 (WebInspector.DetailedHeapshotView.prototype.wasShown): |
| 7949 (WebInspector.DetailedHeapshotView.prototype.onResize): |
| 7950 * inspector/front-end/NetworkPanel.js: |
| 7951 (WebInspector.NetworkLogView.prototype.onResize): |
| 7952 (WebInspector.NetworkLogView.prototype._createTable): |
| 7953 * inspector/front-end/ProfileView.js: |
| 7954 * inspector/front-end/ResourceCookiesView.js: |
| 7955 (WebInspector.ResourceCookiesView.prototype._buildCookiesTable): |
| 7956 * inspector/front-end/ResourceView.js: |
| 7957 (WebInspector.ResourceView): |
| 7958 |
| 7959 2011-10-24 Yosifumi Inoue <yosin@chromium.org> |
| 7960 |
| 7961 [Forms] Setting defaultValue should hide an input placeholder. |
| 7962 https://bugs.webkit.org/show_bug.cgi?id=70586 |
| 7963 |
| 7964 Reviewed by Kent Tamura. |
| 7965 |
| 7966 Tests: fast/forms/placeholder-and-default-value-expected.html |
| 7967 fast/forms/placeholder-and-default-value.html |
| 7968 |
| 7969 When input element has default value, we should not display |
| 7970 placeholder. Changing default value should tell rendering engine about |
| 7971 changing display of input element. |
| 7972 |
| 7973 * html/HTMLInputElement.cpp: |
| 7974 (WebCore::HTMLInputElement::parseMappedAttribute): Calls updatePlacehold
erVisibility for valueAttr if it doesn't have dirty value. |
| 7975 |
| 7976 2011-10-23 Darin Adler <darin@apple.com> |
| 7977 |
| 7978 Eliminate OptionElement (second and final part) |
| 7979 https://bugs.webkit.org/show_bug.cgi?id=70710 |
| 7980 |
| 7981 Reviewed by Kent Tamura. |
| 7982 |
| 7983 * CMakeLists.txt: Removed OptionElement.h and OptionElement.cpp. |
| 7984 * GNUmakefile.list.am: Ditto. |
| 7985 * WebCore.gypi: Ditto. |
| 7986 * WebCore.pro: Ditto. |
| 7987 * WebCore.vcproj/WebCore.vcproj: Ditto. |
| 7988 * WebCore.xcodeproj/project.pbxproj: Ditto. |
| 7989 * dom/DOMAllInOne.cpp: Ditto. |
| 7990 |
| 7991 * dom/OptionElement.cpp: Removed. |
| 7992 * dom/OptionElement.h: Removed. |
| 7993 |
| 7994 * html/HTMLSelectElement.cpp: |
| 7995 (WebCore::HTMLSelectElement::saveLastSelection): Eliminate use of the |
| 7996 toOptionElement function. Use hasTagName and toHTMLOptionElement instead
. |
| 7997 (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): Ditto. |
| 7998 (WebCore::HTMLSelectElement::updateListBoxSelection): Ditto. |
| 7999 (WebCore::HTMLSelectElement::listBoxOnChange): Ditto. |
| 8000 (WebCore::HTMLSelectElement::recalcListItems): Ditto. |
| 8001 (WebCore::HTMLSelectElement::selectedIndex): Ditto. |
| 8002 (WebCore::HTMLSelectElement::setSelectedIndex): Ditto. |
| 8003 (WebCore::HTMLSelectElement::deselectItemsWithoutValidation): Ditto. |
| 8004 (WebCore::HTMLSelectElement::saveFormControlState): Ditto. |
| 8005 (WebCore::HTMLSelectElement::restoreFormControlState): Ditto. |
| 8006 (WebCore::HTMLSelectElement::appendFormData): Ditto. |
| 8007 (WebCore::HTMLSelectElement::reset): Ditto. |
| 8008 (WebCore::HTMLSelectElement::updateSelectedState): Ditto. |
| 8009 (WebCore::HTMLSelectElement::lastSelectedListIndex): Ditto. |
| 8010 (WebCore::HTMLSelectElement::typeAheadFind): Ditto. |
| 8011 (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto. |
| 8012 |
| 8013 * html/HTMLSelectElement.h: Changed the argument type of the |
| 8014 deselectItemsWithoutValidation function to HTMLElement* since that's |
| 8015 the type of an item in our items vector now. |
| 8016 |
| 8017 2011-10-23 Yuzo Fujishima <yuzo@google.com> |
| 8018 |
| 8019 [chromium] Attempt to fix compilation error for Chromium OS. |
| 8020 |
| 8021 Unreviewed. |
| 8022 |
| 8023 * mediastream/MediaStreamTrack.cpp: |
| 8024 (WebCore::MediaStreamTrack::kind): |
| 8025 |
| 8026 2011-10-23 Adam Barth <abarth@webkit.org> |
| 8027 |
| 8028 <img crossorigin> should fail to load when CORS check fails |
| 8029 https://bugs.webkit.org/show_bug.cgi?id=69732 |
| 8030 |
| 8031 Reviewed by Darin Adler. |
| 8032 |
| 8033 When loading an image with the crossorigin attribute, the spec says |
| 8034 that we're not supposed to load the image if the CORS check fails. |
| 8035 This "fails fast" behavior is intended to help developers understand |
| 8036 whether they've configured CORS correctly (instead of only catching the |
| 8037 error later when trying to read back the canvas). |
| 8038 |
| 8039 Our new behavior matches the spec and Firefox. |
| 8040 |
| 8041 Test: http/tests/security/img-with-failed-cors-check-fails-to-load.html |
| 8042 |
| 8043 * loader/ImageLoader.cpp: |
| 8044 (WebCore::ImageLoader::notifyFinished): |
| 8045 |
| 8046 2011-10-23 Noel Gordon <noel.gordon@gmail.com> |
| 8047 |
| 8048 [chromium] Remove GeolocationServiceGtk.{h,cpp} from the gyp projects |
| 8049 https://bugs.webkit.org/show_bug.cgi?id=70702 |
| 8050 |
| 8051 Reviewed by Kent Tamura. |
| 8052 |
| 8053 platform/gtk/GeolocationServiceGtk.{h,cpp} were removed in r97746, so |
| 8054 remove references to these files from the gyp files. |
| 8055 |
| 8056 * WebCore.gypi: |
| 8057 |
| 8058 2011-10-23 Andreas Kling <kling@webkit.org> |
| 8059 |
| 8060 Move StyleSheet::addSubresourceStyleURLs() to CSSStyleSheet. |
| 8061 https://bugs.webkit.org/show_bug.cgi?id=70690 |
| 8062 |
| 8063 Reviewed by Antti Koivisto. |
| 8064 |
| 8065 This method isn't part of the StyleSheet DOM interface, nor is it used b
y |
| 8066 XSLStyleSheet, so move it down to CSSStyleSheet and make it non-virtual. |
| 8067 Also remove some nearby unneeded casts from CSSStyleSheet* to StyleSheet
*. |
| 8068 |
| 8069 * css/CSSStyleSheet.h: |
| 8070 * css/StyleSheet.h: |
| 8071 * html/HTMLLinkElement.cpp: |
| 8072 (WebCore::HTMLLinkElement::isLoading): |
| 8073 (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): |
| 8074 * html/HTMLStyleElement.cpp: |
| 8075 (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): |
| 8076 (WebCore::HTMLStyleElement::disabled): |
| 8077 (WebCore::HTMLStyleElement::setDisabled): |
| 8078 |
| 8079 2011-10-23 Andreas Kling <kling@webkit.org> |
| 8080 |
| 8081 Remove style sheet constructors that take a style sheet parent. |
| 8082 https://bugs.webkit.org/show_bug.cgi?id=70692 |
| 8083 |
| 8084 Reviewed by Antti Koivisto. |
| 8085 |
| 8086 Style sheets are never directly parented by other style sheets, they alw
ays |
| 8087 go via a rule (such as @import.) |
| 8088 |
| 8089 * css/CSSStyleSheet.cpp: |
| 8090 * css/CSSStyleSheet.h: |
| 8091 (WebCore::CSSStyleSheet::create): |
| 8092 * css/StyleSheet.cpp: |
| 8093 * css/StyleSheet.h: |
| 8094 |
| 8095 2011-10-23 Mark Hahnenberg <mhahnenberg@apple.com> |
| 8096 |
| 8097 Add deleteProperty to the MethodTable |
| 8098 https://bugs.webkit.org/show_bug.cgi?id=70162 |
| 8099 |
| 8100 Reviewed by Sam Weinig. |
| 8101 |
| 8102 No new tests. |
| 8103 |
| 8104 * WebCore.exp.in: |
| 8105 |
| 8106 2011-10-23 Adam Barth <abarth@webkit.org> |
| 8107 |
| 8108 Update baselines for run-bindings-tests. |
| 8109 |
| 8110 * bindings/scripts/test/JS/JSTestInterface.cpp: |
| 8111 * bindings/scripts/test/JS/JSTestInterface.h: |
| 8112 * bindings/scripts/test/JS/JSTestObj.cpp: |
| 8113 |
| 8114 2011-10-23 Mark Hahnenberg <mhahnenberg@apple.com> |
| 8115 |
| 8116 Remove getConstructDataVirtual |
| 8117 https://bugs.webkit.org/show_bug.cgi?id=70638 |
| 8118 |
| 8119 Reviewed by Darin Adler. |
| 8120 |
| 8121 No new tests. |
| 8122 |
| 8123 Removed all declarations and definitions of getConstructDataVirtual. |
| 8124 Also replaced all call sites to getConstructDataVirtual with a |
| 8125 corresponding lookup in the MethodTable. |
| 8126 |
| 8127 * WebCore.exp.in: |
| 8128 * bindings/js/JSAudioConstructor.cpp: |
| 8129 * bindings/js/JSAudioConstructor.h: |
| 8130 * bindings/js/JSImageConstructor.cpp: |
| 8131 * bindings/js/JSImageConstructor.h: |
| 8132 * bindings/js/JSOptionConstructor.cpp: |
| 8133 * bindings/js/JSOptionConstructor.h: |
| 8134 * bindings/js/ScriptFunctionCall.cpp: |
| 8135 (WebCore::ScriptFunctionCall::construct): |
| 8136 * bindings/scripts/CodeGeneratorJS.pm: |
| 8137 (GenerateConstructorDeclaration): |
| 8138 (GenerateConstructorDefinition): |
| 8139 * bridge/runtime_object.cpp: |
| 8140 * bridge/runtime_object.h: |
| 8141 |
| 8142 2011-10-22 Geoffrey Garen <ggaren@apple.com> |
| 8143 |
| 8144 Separated string lifetime bits from character buffer state bits |
| 8145 https://bugs.webkit.org/show_bug.cgi?id=70673 |
| 8146 |
| 8147 Reviewed by Anders Carlsson. |
| 8148 |
| 8149 * bindings/scripts/CodeGeneratorJS.pm: |
| 8150 (GenerateHashValue): Updated for string hashing changes in JavaScriptCor
e. |
| 8151 |
| 8152 2011-10-22 Pratik Solanki <psolanki@apple.com> |
| 8153 |
| 8154 HTTPBodyStream in NSURLRequest gets lost when using CFNetwork loader |
| 8155 https://bugs.webkit.org/show_bug.cgi?id=70583 |
| 8156 <rdar://problem/10281227> |
| 8157 |
| 8158 Reviewed by Darin Adler. |
| 8159 |
| 8160 Call WebCore::setHTTPBody() only if we actually have a FormData. Uncondi
tionally calling it |
| 8161 results in us passing 0 to wkCFURLRequestSetHTTPRequestBodyParts() which
resets any input |
| 8162 stream specified by the user on the NSURLRequest. This code matches the
behavior in the |
| 8163 Foundation version of doUpdatePlatformRequest(). |
| 8164 |
| 8165 * platform/network/cf/ResourceRequestCFNet.cpp: |
| 8166 (WebCore::ResourceRequest::doUpdatePlatformRequest): |
| 8167 |
| 8168 2011-10-22 Adam Bergkvist <adam.bergkvist@ericsson.com> |
| 8169 |
| 8170 Move all MediaStream and PeerConnection related non-platform files to We
bCore/mediastream |
| 8171 https://bugs.webkit.org/show_bug.cgi?id=70233 |
| 8172 |
| 8173 Reviewed by Adam Barth. |
| 8174 |
| 8175 Removed affected files from build systems that don't have a MEDIA_STREAM
build flag. |
| 8176 |
| 8177 No new tests since we're just moving files. |
| 8178 |
| 8179 * CMakeLists.txt: |
| 8180 * CodeGenerators.pri: |
| 8181 * DerivedSources.cpp: |
| 8182 * DerivedSources.make: |
| 8183 * GNUmakefile.am: |
| 8184 * GNUmakefile.list.am: |
| 8185 * UseJSC.cmake: |
| 8186 * WebCore.gyp/WebCore.gyp: |
| 8187 * WebCore.gypi: |
| 8188 * WebCore.pro: |
| 8189 * WebCore.vcproj/WebCore.vcproj: |
| 8190 * WebCore.xcodeproj/project.pbxproj: |
| 8191 * bindings/js/JSBindingsAllInOne.cpp: |
| 8192 * dom/DOMAllInOne.cpp: |
| 8193 * dom/DispatchTask.h: Removed unused file. |
| 8194 * dom/ScriptExecutionContext.cpp: |
| 8195 * mediastream/LocalMediaStream.cpp: Renamed from Source/WebCore/dom/Loca
lMediaStream.cpp. |
| 8196 (WebCore::LocalMediaStream::create): |
| 8197 (WebCore::LocalMediaStream::LocalMediaStream): |
| 8198 (WebCore::LocalMediaStream::stop): |
| 8199 (WebCore::LocalMediaStream::stopTimerFired): |
| 8200 (WebCore::LocalMediaStream::~LocalMediaStream): |
| 8201 (WebCore::LocalMediaStream::toLocalMediaStream): |
| 8202 * mediastream/LocalMediaStream.h: Renamed from Source/WebCore/dom/LocalM
ediaStream.h. |
| 8203 * mediastream/LocalMediaStream.idl: Renamed from Source/WebCore/dom/Loca
lMediaStream.idl. |
| 8204 * mediastream/MediaStream.cpp: Renamed from Source/WebCore/dom/MediaStre
am.cpp. |
| 8205 (WebCore::MediaStream::create): |
| 8206 (WebCore::MediaStream::MediaStream): |
| 8207 (WebCore::MediaStream::~MediaStream): |
| 8208 (WebCore::MediaStream::readyState): |
| 8209 (WebCore::MediaStream::toMediaStream): |
| 8210 (WebCore::MediaStream::streamEnded): |
| 8211 (WebCore::MediaStream::scriptExecutionContext): |
| 8212 (WebCore::MediaStream::eventTargetData): |
| 8213 (WebCore::MediaStream::ensureEventTargetData): |
| 8214 * mediastream/MediaStream.h: Renamed from Source/WebCore/dom/MediaStream
.h. |
| 8215 (WebCore::MediaStream::label): |
| 8216 (WebCore::MediaStream::tracks): |
| 8217 (WebCore::MediaStream::descriptor): |
| 8218 (WebCore::MediaStream::refEventTarget): |
| 8219 (WebCore::MediaStream::derefEventTarget): |
| 8220 * mediastream/MediaStream.idl: Renamed from Source/WebCore/dom/MediaStre
am.idl. |
| 8221 * mediastream/MediaStreamClient.h: Renamed from Source/WebCore/page/Medi
aStreamClient.h. |
| 8222 (WebCore::MediaStreamClient::~MediaStreamClient): |
| 8223 * mediastream/MediaStreamController.cpp: Renamed from Source/WebCore/pag
e/MediaStreamController.cpp. |
| 8224 (WebCore::MediaStreamController::Request::Request): |
| 8225 (WebCore::MediaStreamController::Request::localId): |
| 8226 (WebCore::MediaStreamController::Request::frameController): |
| 8227 (WebCore::MediaStreamController::MediaStreamController): |
| 8228 (WebCore::MediaStreamController::~MediaStreamController): |
| 8229 (WebCore::MediaStreamController::isClientAvailable): |
| 8230 (WebCore::MediaStreamController::unregisterFrameController): |
| 8231 (WebCore::MediaStreamController::registerRequest): |
| 8232 (WebCore::MediaStreamController::generateStream): |
| 8233 (WebCore::MediaStreamController::streamGenerated): |
| 8234 (WebCore::MediaStreamController::streamGenerationFailed): |
| 8235 * mediastream/MediaStreamController.h: Renamed from Source/WebCore/page/
MediaStreamController.h. |
| 8236 * mediastream/MediaStreamEvent.cpp: Renamed from Source/WebCore/p2p/Medi
aStreamEvent.cpp. |
| 8237 (WebCore::MediaStreamEvent::create): |
| 8238 (WebCore::MediaStreamEvent::MediaStreamEvent): |
| 8239 (WebCore::MediaStreamEvent::~MediaStreamEvent): |
| 8240 (WebCore::MediaStreamEvent::initMediaStreamEvent): |
| 8241 (WebCore::MediaStreamEvent::stream): |
| 8242 * mediastream/MediaStreamEvent.h: Renamed from Source/WebCore/p2p/MediaS
treamEvent.h. |
| 8243 (WebCore::MediaStreamEvent::isMediaStreamEvent): |
| 8244 * mediastream/MediaStreamEvent.idl: Renamed from Source/WebCore/p2p/Medi
aStreamEvent.idl. |
| 8245 * mediastream/MediaStreamFrameController.cpp: Renamed from Source/WebCor
e/page/MediaStreamFrameController.cpp. |
| 8246 (WebCore::MediaStreamFrameController::Request::~Request): |
| 8247 (WebCore::MediaStreamFrameController::Request::scriptExecutionContext): |
| 8248 (WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest): |
| 8249 (WebCore::MediaStreamFrameController::Request::Request): |
| 8250 (WebCore::MediaStreamFrameController::GenerateStreamRequest::create): |
| 8251 (WebCore::MediaStreamFrameController::GenerateStreamRequest::~GenerateSt
reamRequest): |
| 8252 (WebCore::MediaStreamFrameController::GenerateStreamRequest::isGenerateS
treamRequest): |
| 8253 (WebCore::MediaStreamFrameController::GenerateStreamRequest::abort): |
| 8254 (WebCore::MediaStreamFrameController::GenerateStreamRequest::successCall
back): |
| 8255 (WebCore::MediaStreamFrameController::GenerateStreamRequest::errorCallba
ck): |
| 8256 (WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStr
eamRequest): |
| 8257 (WebCore::MediaStreamFrameController::RequestMap::abort): |
| 8258 (WebCore::MediaStreamFrameController::RequestMap::abortAll): |
| 8259 (WebCore::MediaStreamFrameController::MediaStreamFrameController): |
| 8260 (WebCore::MediaStreamFrameController::~MediaStreamFrameController): |
| 8261 (WebCore::MediaStreamFrameController::securityOrigin): |
| 8262 (WebCore::MediaStreamFrameController::scriptExecutionContext): |
| 8263 (WebCore::MediaStreamFrameController::pageController): |
| 8264 (WebCore::MediaStreamFrameController::enterDetachedState): |
| 8265 (WebCore::MediaStreamFrameController::isClientAvailable): |
| 8266 (WebCore::MediaStreamFrameController::disconnectPage): |
| 8267 (WebCore::MediaStreamFrameController::disconnectFrame): |
| 8268 (WebCore::MediaStreamFrameController::transferToNewPage): |
| 8269 (WebCore::MediaStreamFrameController::parseGenerateStreamOptions): |
| 8270 (WebCore::MediaStreamFrameController::generateStream): |
| 8271 (WebCore::MediaStreamFrameController::streamGenerated): |
| 8272 (WebCore::MediaStreamFrameController::streamGenerationFailed): |
| 8273 * mediastream/MediaStreamFrameController.h: Renamed from Source/WebCore/
page/MediaStreamFrameController.h. |
| 8274 (WebCore::MediaStreamFrameController::IdGenerator::IdGenerator): |
| 8275 (WebCore::MediaStreamFrameController::IdGenerator::getNextId): |
| 8276 * mediastream/MediaStreamList.cpp: Renamed from Source/WebCore/dom/Media
StreamList.cpp. |
| 8277 (WebCore::MediaStreamList::create): |
| 8278 (WebCore::MediaStreamList::MediaStreamList): |
| 8279 (WebCore::MediaStreamList::~MediaStreamList): |
| 8280 (WebCore::MediaStreamList::length): |
| 8281 (WebCore::MediaStreamList::item): |
| 8282 (WebCore::MediaStreamList::append): |
| 8283 (WebCore::MediaStreamList::remove): |
| 8284 (WebCore::MediaStreamList::contains): |
| 8285 * mediastream/MediaStreamList.h: Renamed from Source/WebCore/dom/MediaSt
reamList.h. |
| 8286 * mediastream/MediaStreamList.idl: Renamed from Source/WebCore/dom/Media
StreamList.idl. |
| 8287 * mediastream/MediaStreamRegistry.cpp: Renamed from Source/WebCore/platf
orm/MediaStreamRegistry.cpp. |
| 8288 (WebCore::MediaStreamRegistry::registry): |
| 8289 (WebCore::MediaStreamRegistry::registerMediaStreamURL): |
| 8290 (WebCore::MediaStreamRegistry::unregisterMediaStreamURL): |
| 8291 (WebCore::MediaStreamRegistry::mediaStream): |
| 8292 * mediastream/MediaStreamRegistry.h: Renamed from Source/WebCore/platfor
m/MediaStreamRegistry.h. |
| 8293 * mediastream/MediaStreamTrack.cpp: Renamed from Source/WebCore/dom/Medi
aStreamTrack.cpp. |
| 8294 (WebCore::MediaStreamTrack::create): |
| 8295 (WebCore::MediaStreamTrack::MediaStreamTrack): |
| 8296 (WebCore::MediaStreamTrack::~MediaStreamTrack): |
| 8297 (WebCore::MediaStreamTrack::kind): |
| 8298 (WebCore::MediaStreamTrack::label): |
| 8299 (WebCore::MediaStreamTrack::enabled): |
| 8300 (WebCore::MediaStreamTrack::setEnabled): |
| 8301 * mediastream/MediaStreamTrack.h: Renamed from Source/WebCore/dom/MediaS
treamTrack.h. |
| 8302 * mediastream/MediaStreamTrack.idl: Renamed from Source/WebCore/dom/Medi
aStreamTrack.idl. |
| 8303 * mediastream/MediaStreamTrackList.cpp: Renamed from Source/WebCore/dom/
MediaStreamTrackList.cpp. |
| 8304 (WebCore::MediaStreamTrackList::create): |
| 8305 (WebCore::MediaStreamTrackList::MediaStreamTrackList): |
| 8306 (WebCore::MediaStreamTrackList::~MediaStreamTrackList): |
| 8307 (WebCore::MediaStreamTrackList::length): |
| 8308 (WebCore::MediaStreamTrackList::item): |
| 8309 * mediastream/MediaStreamTrackList.h: Renamed from Source/WebCore/dom/Me
diaStreamTrackList.h. |
| 8310 * mediastream/MediaStreamTrackList.idl: Renamed from Source/WebCore/dom/
MediaStreamTrackList.idl. |
| 8311 * mediastream/PeerConnection.cpp: Renamed from Source/WebCore/p2p/PeerCo
nnection.cpp. |
| 8312 (WebCore::PeerConnection::create): |
| 8313 (WebCore::PeerConnection::PeerConnection): |
| 8314 (WebCore::PeerConnection::~PeerConnection): |
| 8315 (WebCore::PeerConnection::processSignalingMessage): |
| 8316 (WebCore::PeerConnection::readyState): |
| 8317 (WebCore::PeerConnection::send): |
| 8318 (WebCore::PeerConnection::addStream): |
| 8319 (WebCore::PeerConnection::removeStream): |
| 8320 (WebCore::PeerConnection::localStreams): |
| 8321 (WebCore::PeerConnection::remoteStreams): |
| 8322 (WebCore::PeerConnection::close): |
| 8323 (WebCore::PeerConnection::iceProcessingCompleted): |
| 8324 (WebCore::PeerConnection::sdpGenerated): |
| 8325 (WebCore::PeerConnection::dataStreamMessageReceived): |
| 8326 (WebCore::PeerConnection::remoteStreamAdded): |
| 8327 (WebCore::PeerConnection::remoteStreamRemoved): |
| 8328 (WebCore::PeerConnection::toPeerConnection): |
| 8329 (WebCore::PeerConnection::scriptExecutionContext): |
| 8330 (WebCore::PeerConnection::stop): |
| 8331 (WebCore::PeerConnection::eventTargetData): |
| 8332 (WebCore::PeerConnection::ensureEventTargetData): |
| 8333 (WebCore::PeerConnection::scheduleInitialNegotiation): |
| 8334 (WebCore::PeerConnection::initialNegotiationTimerFired): |
| 8335 (WebCore::PeerConnection::ensureStreamChangeScheduled): |
| 8336 (WebCore::PeerConnection::streamChangeTimerFired): |
| 8337 (WebCore::PeerConnection::scheduleReadyStateChange): |
| 8338 (WebCore::PeerConnection::readyStateChangeTimerFired): |
| 8339 (WebCore::PeerConnection::changeReadyState): |
| 8340 * mediastream/PeerConnection.h: Renamed from Source/WebCore/p2p/PeerConn
ection.h. |
| 8341 (WebCore::PeerConnection::refEventTarget): |
| 8342 (WebCore::PeerConnection::derefEventTarget): |
| 8343 * mediastream/PeerConnection.idl: Renamed from Source/WebCore/p2p/PeerCo
nnection.idl. |
| 8344 * mediastream/SignalingCallback.h: Renamed from Source/WebCore/p2p/Signa
lingCallback.h. |
| 8345 (WebCore::SignalingCallback::~SignalingCallback): |
| 8346 * mediastream/SignalingCallback.idl: Renamed from Source/WebCore/p2p/Sig
nalingCallback.idl. |
| 8347 * page/Frame.cpp: |
| 8348 * page/Navigator.cpp: |
| 8349 * page/Page.cpp: |
| 8350 |
| 8351 2011-10-20 Pavel Feldman <pfeldman@google.com> |
| 8352 |
| 8353 Web Inspector: get rid of View::hide, View::set visible, View::attach, |
| 8354 View::set visible. |
| 8355 https://bugs.webkit.org/show_bug.cgi?id=70523 |
| 8356 |
| 8357 This change also introduces assetions that forces view attach / detach o
perations |
| 8358 to be performed explicitly. |
| 8359 |
| 8360 Reviewed by Yury Semikhatsky. |
| 8361 |
| 8362 * inspector/front-end/ApplicationCacheItemsView.js: |
| 8363 (WebInspector.ApplicationCacheItemsView.prototype.wasShown): |
| 8364 (WebInspector.ApplicationCacheItemsView.prototype.willHide): |
| 8365 (WebInspector.ApplicationCacheItemsView.prototype._updateCallback): |
| 8366 * inspector/front-end/AuditsPanel.js: |
| 8367 (WebInspector.AuditsPanel.prototype.wasShown): |
| 8368 * inspector/front-end/ConsolePanel.js: |
| 8369 (WebInspector.ConsolePanel.prototype.wasShown): |
| 8370 (WebInspector.ConsolePanel.prototype.willHide): |
| 8371 * inspector/front-end/ConsoleView.js: |
| 8372 (WebInspector.ConsoleView.prototype.wasShown): |
| 8373 * inspector/front-end/CookieItemsView.js: |
| 8374 (WebInspector.CookieItemsView.prototype.wasShown): |
| 8375 (WebInspector.CookieItemsView.prototype.willHide): |
| 8376 (WebInspector.CookieItemsView.prototype._updateWithCookies): |
| 8377 * inspector/front-end/DOMStorageItemsView.js: |
| 8378 (WebInspector.DOMStorageItemsView.prototype.wasShown): |
| 8379 (WebInspector.DOMStorageItemsView.prototype.willHide): |
| 8380 * inspector/front-end/DatabaseQueryView.js: |
| 8381 * inspector/front-end/DatabaseTableView.js: |
| 8382 (WebInspector.DatabaseTableView.prototype.wasShown): |
| 8383 * inspector/front-end/DetailedHeapshotView.js: |
| 8384 (WebInspector.DetailedHeapshotView.prototype.willHide): |
| 8385 (WebInspector.DetailedHeapshotView.prototype._changeView): |
| 8386 * inspector/front-end/Drawer.js: |
| 8387 (WebInspector.Drawer.prototype.hide): |
| 8388 * inspector/front-end/ElementsPanel.js: |
| 8389 (WebInspector.ElementsPanel.prototype.wasShown): |
| 8390 (WebInspector.ElementsPanel.prototype.willHide): |
| 8391 * inspector/front-end/EmptyView.js: |
| 8392 (WebInspector.EmptyView.prototype.wasShown): |
| 8393 * inspector/front-end/FontView.js: |
| 8394 (WebInspector.FontView.prototype.wasShown): |
| 8395 * inspector/front-end/IFrameView.js: |
| 8396 (WebInspector.IFrameView): |
| 8397 * inspector/front-end/ImageView.js: |
| 8398 (WebInspector.ImageView.prototype.wasShown): |
| 8399 * inspector/front-end/NetworkItemView.js: |
| 8400 (WebInspector.NetworkItemView.prototype.wasShown): |
| 8401 (WebInspector.ResourceContentView.prototype.wasShown): |
| 8402 * inspector/front-end/NetworkPanel.js: |
| 8403 (WebInspector.NetworkLogView.prototype.wasShown): |
| 8404 (WebInspector.NetworkLogView.prototype.willHide): |
| 8405 (WebInspector.NetworkPanel.prototype.wasShown): |
| 8406 * inspector/front-end/Panel.js: |
| 8407 (WebInspector.Panel): |
| 8408 (WebInspector.Panel.prototype.show): |
| 8409 (WebInspector.Panel.prototype.wasShown): |
| 8410 (WebInspector.Panel.prototype.willHide): |
| 8411 * inspector/front-end/PanelEnablerView.js: |
| 8412 * inspector/front-end/ProfileView.js: |
| 8413 (WebInspector.CPUProfileView.prototype.willHide): |
| 8414 * inspector/front-end/ProfilesPanel.js: |
| 8415 (WebInspector.ProfilesPanel.prototype.wasShown): |
| 8416 (WebInspector.ProfilesPanel.prototype._addProfileHeader): |
| 8417 (WebInspector.ProfilesPanel.prototype._updateInterface): |
| 8418 (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles): |
| 8419 * inspector/front-end/ResourceCookiesView.js: |
| 8420 (WebInspector.ResourceCookiesView.prototype.wasShown): |
| 8421 * inspector/front-end/ResourceHTMLView.js: |
| 8422 (WebInspector.ResourceHTMLView.prototype.wasShown): |
| 8423 (WebInspector.ResourceHTMLView.prototype.willHide): |
| 8424 * inspector/front-end/ResourceJSONView.js: |
| 8425 (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.p
rototype.wasShown): |
| 8426 * inspector/front-end/ResourceTimingView.js: |
| 8427 (WebInspector.ResourceTimingView.prototype.wasShown): |
| 8428 * inspector/front-end/ResourcesPanel.js: |
| 8429 (WebInspector.ResourcesPanel.prototype.wasShown): |
| 8430 * inspector/front-end/ScriptsPanel.js: |
| 8431 (WebInspector.ScriptsPanel.prototype.wasShown): |
| 8432 (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): |
| 8433 * inspector/front-end/SourceFrame.js: |
| 8434 (WebInspector.SourceFrame.prototype.wasShown): |
| 8435 * inspector/front-end/TimelinePanel.js: |
| 8436 (WebInspector.TimelinePanel.prototype.wasShown): |
| 8437 (WebInspector.TimelinePanel.prototype.willHide): |
| 8438 * inspector/front-end/View.js: |
| 8439 (WebInspector.View): |
| 8440 (WebInspector.View.prototype.get visible): |
| 8441 (WebInspector.View.prototype.setHideOnDetach): |
| 8442 (WebInspector.View.prototype._wasShown): |
| 8443 (WebInspector.View.prototype._willHide): |
| 8444 (WebInspector.View.prototype._onResize): |
| 8445 (WebInspector.View.prototype.wasShown): |
| 8446 (WebInspector.View.prototype.willHide): |
| 8447 (WebInspector.View.prototype.onResize): |
| 8448 (WebInspector.View.prototype.show): |
| 8449 (WebInspector.View.prototype.detach): |
| 8450 (WebInspector.View.prototype.doResize): |
| 8451 (WebInspector.View.prototype.dispatchToSelfAndChildren): |
| 8452 (WebInspector.View.prototype.dispatchToChildren): |
| 8453 (WebInspector.View.prototype._handleInsertedIntoDocument): |
| 8454 |
| 8455 2011-10-22 Kent Tamura <tkent@chromium.org> |
| 8456 |
| 8457 REGRESSION(r92480): Passing uninitialized variable in HTMLElement::calcu
lateAndAdjustDirectionality() |
| 8458 https://bugs.webkit.org/show_bug.cgi?id=70582 |
| 8459 |
| 8460 Reviewed by Darin Adler. |
| 8461 |
| 8462 No new tests. It's very hard to make a reliable test. |
| 8463 |
| 8464 * html/HTMLElement.cpp: |
| 8465 (WebCore::HTMLElement::directionality): |
| 8466 Clear *strongDirectionalityTextNode even if hasStrongDirectionality is f
alse. |
| 8467 |
| 8468 2011-10-21 Dan Bernstein <mitz@apple.com> |
| 8469 |
| 8470 Caret is drawn in the wrong place in multi-column blocks |
| 8471 https://bugs.webkit.org/show_bug.cgi?id=70662 |
| 8472 |
| 8473 Reviewed by Gavin Barraclough. |
| 8474 |
| 8475 * manual-tests/caret-in-columns.html: Added. |
| 8476 * rendering/RenderBlock.cpp: |
| 8477 (WebCore::RenderBlock::paintCaret): Removed the call to offsetForContent
s(). That function takes |
| 8478 a point in local coordinates, whereas this function was applying it to a
point in painting root |
| 8479 coordinates. The desired effect was only to undo the scroll adjustment d
one by the caller, |
| 8480 paintObject(). |
| 8481 (WebCore::RenderBlock::paintObject): Pass the original, rather than scro
ll-adjusted, paint offset |
| 8482 to paintCaret(). |
| 8483 |
| 8484 2011-10-21 Nat Duca <nduca@chromium.org> |
| 8485 |
| 8486 [chromium] Make setVisibility extension- and thread-correct |
| 8487 https://bugs.webkit.org/show_bug.cgi?id=70635 |
| 8488 |
| 8489 Reviewed by Kenneth Russell. |
| 8490 |
| 8491 * platform/graphics/chromium/Extensions3DChromium.h: |
| 8492 * platform/graphics/chromium/LayerRendererChromium.cpp: |
| 8493 (WebCore::LayerRendererChromium::initialize): |
| 8494 (WebCore::LayerRendererChromium::setVisible): |
| 8495 * platform/graphics/chromium/LayerRendererChromium.h: |
| 8496 * platform/graphics/chromium/cc/CCLayerTreeHost.h: |
| 8497 (WebCore::LayerRendererCapabilities::LayerRendererCapabilities): |
| 8498 * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: |
| 8499 (WebCore::CCLayerTreeHostImpl::setVisible): |
| 8500 |
| 8501 2011-10-21 Beth Dakin <bdakin@apple.com> |
| 8502 |
| 8503 https://bugs.webkit.org/show_bug.cgi?id=70647 |
| 8504 Common but unreproducible crash under [ScrollbarPartAnimation setCurrent
Progress:] |
| 8505 -and corresponding- |
| 8506 <rdar://problem/9542018> |
| 8507 |
| 8508 Reviewed by Sam Weinig. |
| 8509 |
| 8510 This patch implements two speculative fixes for this crash. |
| 8511 |
| 8512 First, block exceptions around all of the code responsible for calling |
| 8513 stopAnimation. If that code throws any exceptions, we want to make sure
the other |
| 8514 animations are still stopped. |
| 8515 * platform/mac/ScrollAnimatorMac.mm: |
| 8516 (-[WebScrollbarPartAnimation scrollAnimatorDestroyed]): |
| 8517 (-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]): |
| 8518 (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac): |
| 8519 |
| 8520 Only send AppKit these notifications for active pages. I originally made
these |
| 8521 assertions, and I found that they were hit a surprising number of times.
If we |
| 8522 only send notifications for active pages, then we should greatly reduce
and |
| 8523 possibly eliminate our chances of hitting this crash. |
| 8524 (WebCore::ScrollAnimatorMac::notifyPositionChanged): |
| 8525 (WebCore::ScrollAnimatorMac::contentAreaWillPaint): |
| 8526 (WebCore::ScrollAnimatorMac::mouseEnteredContentArea): |
| 8527 (WebCore::ScrollAnimatorMac::mouseExitedContentArea): |
| 8528 (WebCore::ScrollAnimatorMac::mouseMovedInContentArea): |
| 8529 (WebCore::ScrollAnimatorMac::willStartLiveResize): |
| 8530 (WebCore::ScrollAnimatorMac::contentsResized): |
| 8531 (WebCore::ScrollAnimatorMac::willEndLiveResize): |
| 8532 (WebCore::ScrollAnimatorMac::contentAreaDidShow): |
| 8533 (WebCore::ScrollAnimatorMac::contentAreaDidHide): |
| 8534 (WebCore::ScrollAnimatorMac::didBeginScrollGesture): |
| 8535 (WebCore::ScrollAnimatorMac::didEndScrollGesture): |
| 8536 |
| 8537 2011-10-21 Mark Hahnenberg <mhahnenberg@apple.com> |
| 8538 |
| 8539 Add put to the MethodTable |
| 8540 https://bugs.webkit.org/show_bug.cgi?id=70439 |
| 8541 |
| 8542 Reviewed by Oliver Hunt. |
| 8543 |
| 8544 No new tests. |
| 8545 |
| 8546 * WebCore.exp.in: |
| 8547 * bindings/js/JSDOMWindowCustom.cpp: Added static put since it was overl
ooked in |
| 8548 previous patches. |
| 8549 (WebCore::JSDOMWindow::putVirtual): |
| 8550 (WebCore::JSDOMWindow::put): |
| 8551 * bindings/js/JSDOMWindowShell.cpp: Ditto. |
| 8552 (WebCore::JSDOMWindowShell::putVirtual): |
| 8553 (WebCore::JSDOMWindowShell::put): |
| 8554 * bindings/js/JSDOMWindowShell.h: |
| 8555 |
| 8556 2011-10-21 Dmitry Lomov <dslomov@google.com> |
| 8557 |
| 8558 https://bugs.webkit.org/show_bug.cgi?id=70580 |
| 8559 [Chromium] Implement MessagePort transfer in chromium port of webkit. |
| 8560 |
| 8561 Reviewed by David Levin. |
| 8562 |
| 8563 * bindings/v8/SerializedScriptValue.cpp: |
| 8564 (WebCore::V8ObjectMap::Writer::writeTransferredMessagePort): |
| 8565 (WebCore::V8ObjectMap::Serializer::Serializer): |
| 8566 (WebCore::V8ObjectMap::Serializer::doSerialize): |
| 8567 (WebCore::V8ObjectMap::Reader::read): |
| 8568 (WebCore::V8ObjectMap::Deserializer::Deserializer): |
| 8569 (WebCore::V8ObjectMap::Deserializer::tryGetTransferredMessagePort): |
| 8570 (WebCore::SerializedScriptValue::SerializedScriptValue): |
| 8571 (WebCore::SerializedScriptValue::deserialize): |
| 8572 |
| 8573 2011-10-21 Ojan Vafai <ojan@chromium.org> |
| 8574 |
| 8575 r97693 caused 42 failures on the chromium mac bots |
| 8576 https://bugs.webkit.org/show_bug.cgi?id=70300 |
| 8577 |
| 8578 Can't test this until https://bugs.webkit.org/show_bug.cgi?id=70660 |
| 8579 is fixed. The fix for that bug will test this codepath as well though. |
| 8580 |
| 8581 * rendering/RenderBlock.cpp: |
| 8582 (WebCore::RenderBlock::computeBlockPreferredLogicalWidths): |
| 8583 |
| 8584 2011-10-21 Vineet Chaudhary <vineet.chaudhary@motorola.com> |
| 8585 |
| 8586 Setting form.enctype reflected attribute behaves strangely. |
| 8587 https://bugs.webkit.org/show_bug.cgi?id=44879 |
| 8588 |
| 8589 Reviewed by Darin Adler. |
| 8590 |
| 8591 The spec says form.enctype should be application/x-www-form-urlencoded, |
| 8592 So as "text", "plain", "multipart" or "form-data" these are not a valid
value so must be ignored. |
| 8593 |
| 8594 * loader/FormSubmission.cpp: |
| 8595 (WebCore::FormSubmission::Attributes::parseEncodingType): |
| 8596 |
| 8597 2011-10-21 Matthew Delaney <mdelaney@apple.com> |
| 8598 |
| 8599 Ensure periodic flushing of canvas drawing context |
| 8600 https://bugs.webkit.org/show_bug.cgi?id=70646 |
| 8601 |
| 8602 Reviewed by Simon Fraser. |
| 8603 |
| 8604 No new tests. No current way to track tests that cause hangs or |
| 8605 non-deterministic drops in performance. |
| 8606 |
| 8607 * platform/graphics/cg/ImageBufferDataCG.h: Adds a timestamp of last tra
cked flush. |
| 8608 * platform/graphics/cg/ImageBufferCG.cpp: Ensures periodic flushes on th
e drawing context. |
| 8609 (WebCore::ImageBuffer::ImageBuffer): |
| 8610 (WebCore::ImageBuffer::context): Flushes context if we're beyond flush i
nterval. |
| 8611 (WebCore::ImageBuffer::copyNativeImage): Updates last flush timestamp. |
| 8612 (WebCore::ImageBuffer::getUnmultipliedImageData): Updates last flush tim
estamp. |
| 8613 (WebCore::ImageBuffer::getPremultipliedImageData): Updates last flush ti
mestamp. |
| 8614 (WebCore::ImageBuffer::putUnmultipliedImageData): Updates last flush tim
estamp. |
| 8615 (WebCore::ImageBuffer::putPremultipliedImageData): Updates last flush ti
mestamp. |
| 8616 |
| 8617 2011-10-21 Adam Barth <abarth@webkit.org> |
| 8618 |
| 8619 Introduce Event::hasInterface to make uses of interfaceName more readabl
e |
| 8620 https://bugs.webkit.org/show_bug.cgi?id=70652 |
| 8621 |
| 8622 Reviewed by Eric Seidel. |
| 8623 |
| 8624 Eric felt that this approach would be more readable because it requires |
| 8625 less syntax at each callsite. |
| 8626 |
| 8627 * bindings/js/JSErrorHandler.cpp: |
| 8628 (WebCore::JSErrorHandler::handleEvent): |
| 8629 * bindings/objc/DOMEvents.mm: |
| 8630 (kitClass): |
| 8631 * bindings/v8/V8WindowErrorHandler.cpp: |
| 8632 (WebCore::V8WindowErrorHandler::callListenerFunction): |
| 8633 * bindings/v8/V8WorkerContextErrorHandler.cpp: |
| 8634 (WebCore::V8WorkerContextErrorHandler::callListenerFunction): |
| 8635 * dom/Event.cpp: |
| 8636 (WebCore::Event::hasInterface): |
| 8637 * dom/Event.h: |
| 8638 * dom/EventDispatcher.cpp: |
| 8639 (WebCore::EventDispatcher::determineDispatchBehavior): |
| 8640 * dom/Node.cpp: |
| 8641 (WebCore::Node::defaultEventHandler): |
| 8642 * html/HTMLInputElement.cpp: |
| 8643 (WebCore::HTMLInputElement::defaultEventHandler): |
| 8644 * html/HTMLTextAreaElement.cpp: |
| 8645 (WebCore::HTMLTextAreaElement::defaultEventHandler): |
| 8646 * html/TextFieldInputType.cpp: |
| 8647 (WebCore::TextFieldInputType::forwardEvent): |
| 8648 (WebCore::TextFieldInputType::shouldSubmitImplicitly): |
| 8649 * inspector/InspectorDOMStorageResource.cpp: |
| 8650 (WebCore::InspectorDOMStorageResource::handleEvent): |
| 8651 |
| 8652 2011-10-21 Adam Klein <adamk@chromium.org> |
| 8653 |
| 8654 [MutationObservers] Implement basic subtree observation |
| 8655 https://bugs.webkit.org/show_bug.cgi?id=70436 |
| 8656 |
| 8657 Reviewed by Ryosuke Niwa. |
| 8658 |
| 8659 Note that this patch only implements "basic" subtree semantics, |
| 8660 not the fully robust semantics described in |
| 8661 http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html. |
| 8662 Most importantly, this change does not handle the case where mutations |
| 8663 occur in a temporarily detached subtree. |
| 8664 |
| 8665 The plan is to implement those semantics in a followup to avoid |
| 8666 blocking other parts of the MutationObserver spec that rely on |
| 8667 the existence of subtree observation but not its specific |
| 8668 implementation. |
| 8669 |
| 8670 Test: fast/mutation/observe-subtree.html |
| 8671 |
| 8672 * dom/Node.cpp: |
| 8673 (WebCore::addMatchingObservers): Static helper method for registeredMuta
tionObserversOfType(). |
| 8674 (WebCore::Node::registeredMutationObserversOfType): Walk up the tree loo
king for observers. |
| 8675 * dom/NodeRareData.h: |
| 8676 (WebCore::MutationObserverEntry::hasAllOptions): A stricter, renamed fro
m matches(). |
| 8677 |
| 8678 2011-10-21 Joshua Bell <jsbell@chromium.org> |
| 8679 |
| 8680 IndexedDB: objectStore.transaction property should be readonly |
| 8681 https://bugs.webkit.org/show_bug.cgi?id=62395 |
| 8682 |
| 8683 Reviewed by Tony Chang. |
| 8684 |
| 8685 Implement the IDBObjectStore.transaction property defined by the spec. |
| 8686 |
| 8687 Test: storage/indexeddb/readonly-properties.html |
| 8688 |
| 8689 * storage/IDBObjectStore.cpp: |
| 8690 (WebCore::IDBObjectStore::transaction): |
| 8691 * storage/IDBObjectStore.h: |
| 8692 * storage/IDBObjectStore.idl: |
| 8693 |
| 8694 2011-10-21 Adam Barth <abarth@webkit.org> |
| 8695 |
| 8696 Event.h has too many virtual isMumbleEvent() functions |
| 8697 https://bugs.webkit.org/show_bug.cgi?id=70636 |
| 8698 |
| 8699 Reviewed by Dimitri Glazkov. |
| 8700 |
| 8701 We should use the new interfaceName() way of doing run-time type inferen
ce. |
| 8702 |
| 8703 * bindings/js/JSErrorHandler.cpp: |
| 8704 (WebCore::JSErrorHandler::handleEvent): |
| 8705 * bindings/js/JSEventCustom.cpp: |
| 8706 (WebCore::JSEvent::clipboardData): |
| 8707 * bindings/objc/DOMEvents.mm: |
| 8708 (kitClass): |
| 8709 * bindings/v8/V8WindowErrorHandler.cpp: |
| 8710 (WebCore::V8WindowErrorHandler::callListenerFunction): |
| 8711 * bindings/v8/V8WorkerContextErrorHandler.cpp: |
| 8712 (WebCore::V8WorkerContextErrorHandler::callListenerFunction): |
| 8713 * bindings/v8/custom/V8EventCustom.cpp: |
| 8714 (WebCore::V8Event::clipboardDataAccessorGetter): |
| 8715 * dom/BeforeLoadEvent.h: |
| 8716 (WebCore::BeforeLoadEvent::interfaceName): |
| 8717 * dom/BeforeTextInsertedEvent.h: |
| 8718 * dom/ClipboardEvent.cpp: |
| 8719 * dom/ClipboardEvent.h: |
| 8720 * dom/CompositionEvent.cpp: |
| 8721 * dom/CompositionEvent.h: |
| 8722 * dom/ErrorEvent.cpp: |
| 8723 * dom/ErrorEvent.h: |
| 8724 * dom/Event.cpp: |
| 8725 (WebCore::Event::storesResultAsString): |
| 8726 (WebCore::Event::storeResult): |
| 8727 (WebCore::Event::clipboardData): |
| 8728 * dom/Event.h: |
| 8729 * dom/Event.idl: |
| 8730 - Remove this interface from the CPP bindings because this function |
| 8731 no longer exists. It's unclear to me how strong our API |
| 8732 commitments are in the CPP bindings. |
| 8733 * dom/EventDispatcher.cpp: |
| 8734 (WebCore::EventDispatcher::determineDispatchBehavior): |
| 8735 * dom/MessageEvent.cpp: |
| 8736 * dom/MessageEvent.h: |
| 8737 * dom/MutationEvent.cpp: |
| 8738 * dom/MutationEvent.h: |
| 8739 * dom/Node.cpp: |
| 8740 (WebCore::Node::defaultEventHandler): |
| 8741 * dom/OverflowEvent.cpp: |
| 8742 * dom/OverflowEvent.h: |
| 8743 * dom/PageTransitionEvent.h: |
| 8744 * dom/ProgressEvent.h: |
| 8745 * dom/TextEvent.cpp: |
| 8746 * dom/TextEvent.h: |
| 8747 * dom/WheelEvent.cpp: |
| 8748 * dom/WheelEvent.h: |
| 8749 * html/HTMLInputElement.cpp: |
| 8750 (WebCore::HTMLInputElement::defaultEventHandler): |
| 8751 * html/HTMLTextAreaElement.cpp: |
| 8752 (WebCore::HTMLTextAreaElement::defaultEventHandler): |
| 8753 * html/TextFieldInputType.cpp: |
| 8754 (WebCore::TextFieldInputType::forwardEvent): |
| 8755 (WebCore::TextFieldInputType::shouldSubmitImplicitly): |
| 8756 * html/shadow/TextControlInnerElements.cpp: |
| 8757 (WebCore::TextControlInnerTextElement::defaultEventHandler): |
| 8758 * svg/SVGZoomEvent.cpp: |
| 8759 * svg/SVGZoomEvent.h: |
| 8760 |
| 8761 2011-10-21 Raymond Toy <rtoy@google.com> |
| 8762 |
| 8763 Flush denormals in Biquad, ZeroPole, and DynamicsCompressor. |
| 8764 |
| 8765 We only flush when saving the state variables instead of in the |
| 8766 loops so that we don't impact performance too much when there are |
| 8767 no denormals. This will at least not propagate the denormals any |
| 8768 further within the class. |
| 8769 |
| 8770 https://bugs.webkit.org/show_bug.cgi?id=70626 |
| 8771 |
| 8772 Reviewed by Kenneth Russell. |
| 8773 |
| 8774 * platform/audio/Biquad.cpp: |
| 8775 (WebCore::Biquad::process): |
| 8776 Flush denormals when storing the filter state back in to class |
| 8777 filter state. |
| 8778 * platform/audio/DynamicsCompressorKernel.cpp: |
| 8779 (WebCore::DynamicsCompressorKernel::process): |
| 8780 Ditto. |
| 8781 * platform/audio/ZeroPole.cpp: |
| 8782 (WebCore::ZeroPole::process): |
| 8783 Ditto. |
| 8784 |
| 8785 2011-10-21 Vsevolod Vlasov <vsevik@chromium.org> |
| 8786 |
| 8787 Web Inspector: Advanced search results should be cleared on navigation. |
| 8788 https://bugs.webkit.org/show_bug.cgi?id=70627 |
| 8789 |
| 8790 Reviewed by Pavel Feldman. |
| 8791 |
| 8792 * inspector/front-end/AdvancedSearchController.js: |
| 8793 (WebInspector.AdvancedSearchController): |
| 8794 (WebInspector.AdvancedSearchController.prototype._frameNavigated): |
| 8795 |
| 8796 2011-10-21 Rafael Weinstein <rafaelw@chromium.org> |
| 8797 |
| 8798 [MutationObservers] Implement WebKitMutationObserver.observe for childLi
st changes |
| 8799 https://bugs.webkit.org/show_bug.cgi?id=68955 |
| 8800 |
| 8801 Reviewed by Ryosuke Niwa. |
| 8802 |
| 8803 This patch adds a ChildListMutationScope object which manages the coales
cing of |
| 8804 multiple child removals and additions within DOM operations into single
childList |
| 8805 mutation records. |
| 8806 |
| 8807 Note that this patch doesn't cover all the cases which can be coalesced
(it only |
| 8808 covers ContainerNode.*, and Node.innerHTML/innerText). A separate bug, |
| 8809 https://bugs.webkit.org/show_bug.cgi?id=70385, has been opened to track
the |
| 8810 remaining cases. |
| 8811 |
| 8812 Test: fast/mutation/observe-childList.html |
| 8813 |
| 8814 * CMakeLists.txt: |
| 8815 * GNUmakefile.list.am: |
| 8816 * WebCore.gypi: |
| 8817 * WebCore.pro: |
| 8818 * WebCore.vcproj/WebCore.vcproj: |
| 8819 * WebCore.xcodeproj/project.pbxproj: |
| 8820 * dom/ChildListMutationScope.cpp: Added. |
| 8821 (WebCore::ChildListAccumulation::ChildListAccumulation::ChildListAccumul
ation): |
| 8822 (WebCore::ChildListAccumulation::ChildListAccumulation::~ChildListAccumu
lation): |
| 8823 (WebCore::ChildListAccumulation::ChildListAccumulation::childAdded): |
| 8824 (WebCore::ChildListAccumulation::ChildListAccumulation::willRemoveChild)
: |
| 8825 (WebCore::ChildListAccumulation::ChildListAccumulation::dispatch): |
| 8826 (WebCore::ChildListAccumulation::ChildListAccumulation::clear): |
| 8827 (WebCore::ChildListAccumulation::ChildListAccumulation::isEmpty): |
| 8828 (WebCore::ChildListAccumulation::ChildListAccumulator::ChildListAccumula
tor): |
| 8829 (WebCore::ChildListAccumulation::ChildListAccumulator::~ChildListAccumul
ator): |
| 8830 (WebCore::ChildListAccumulation::ChildListAccumulator::initialize): |
| 8831 (WebCore::ChildListAccumulation::ChildListAccumulator::instance): |
| 8832 (WebCore::ChildListAccumulation::ChildListAccumulator::childAdded): |
| 8833 (WebCore::ChildListAccumulation::ChildListAccumulator::willRemoveChild): |
| 8834 (WebCore::ChildListAccumulation::ChildListAccumulator::incrementScopingL
evel): |
| 8835 (WebCore::ChildListAccumulation::ChildListAccumulator::decrementScopingL
evel): |
| 8836 (WebCore::ChildListMutationScope::ChildListMutationScope): |
| 8837 (WebCore::ChildListMutationScope::~ChildListMutationScope): |
| 8838 (WebCore::ChildListMutationScope::childAdded): |
| 8839 (WebCore::ChildListMutationScope::willRemoveChild): |
| 8840 * dom/ChildListMutationScope.h: Added. |
| 8841 * dom/ContainerNode.cpp: |
| 8842 (WebCore::ContainerNode::insertBefore): |
| 8843 (WebCore::ContainerNode::replaceChild): |
| 8844 (WebCore::willRemoveChildren): |
| 8845 (WebCore::dispatchChildInsertionEvents): |
| 8846 (WebCore::dispatchChildRemovalEvents): |
| 8847 * dom/Element.cpp: |
| 8848 (WebCore::enqueueAttributesMutationRecord): |
| 8849 * dom/Node.cpp: |
| 8850 (WebCore::Node::setTextContent): |
| 8851 (WebCore::Node::registeredMutationObserversOfType): |
| 8852 * dom/WebKitMutationObserver.cpp: |
| 8853 (WebCore::WebKitMutationObserver::disconnect): |
| 8854 * html/HTMLElement.cpp: |
| 8855 (WebCore::replaceChildrenWithFragment): |
| 8856 (WebCore::replaceChildrenWithText): |
| 8857 |
| 8858 2011-10-21 Sheriff Bot <webkit.review.bot@gmail.com> |
| 8859 |
| 8860 Unreviewed, rolling out r98079. |
| 8861 http://trac.webkit.org/changeset/98079 |
| 8862 https://bugs.webkit.org/show_bug.cgi?id=70624 |
| 8863 |
| 8864 The extensions tests enabled are failing on the Chromium Win |
| 8865 Dbg bot (Requested by jchaffraix on #webkit). |
| 8866 |
| 8867 * inspector/front-end/ExtensionAPI.js: |
| 8868 (buildExtensionAPIInjectedScript): |
| 8869 |
| 8870 2011-10-21 Dan Bernstein <mitz@apple.com> |
| 8871 |
| 8872 Column rules positioned incorrectly in vertical-rl block with horizontal
border or padding |
| 8873 https://bugs.webkit.org/show_bug.cgi?id=70622 |
| 8874 |
| 8875 Reviewed by Beth Dakin. |
| 8876 |
| 8877 Tests: fast/multicol/vertical-lr/rules-with-border-before.html |
| 8878 fast/multicol/vertical-rl/rules-with-border-before.html |
| 8879 |
| 8880 * rendering/RenderBlock.cpp: |
| 8881 (WebCore::RenderBlock::paintColumnRules): Changed to use the physical le
ft border and padding for the |
| 8882 left edge of the horizontal column rule. |
| 8883 |
1 2011-10-21 Simon Fraser <simon.fraser@apple.com> | 8884 2011-10-21 Simon Fraser <simon.fraser@apple.com> |
2 | 8885 |
3 Fix Windows build. | 8886 Fix Windows build. |
4 | 8887 |
5 * rendering/RenderLayerCompositor.cpp: | 8888 * rendering/RenderLayerCompositor.cpp: |
6 (WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers): | 8889 (WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers): |
7 | 8890 |
8 2011-10-21 Devdatta Deshpande <pwjd73@motorola.com> | 8891 2011-10-21 Devdatta Deshpande <pwjd73@motorola.com> |
9 | 8892 |
10 [Gtk] mousemove event always has metaKey == true | 8893 [Gtk] mousemove event always has metaKey == true |
(...skipping 1798 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
1809 (WebCore::MessageEvent::dataAsArrayBuffer): Ditto. | 10692 (WebCore::MessageEvent::dataAsArrayBuffer): Ditto. |
1810 * dom/MessageEvent.idl: Changed SerializedScriptValue to DOMObject (i.e.
ScriptValue). This patch does not touch an ObjC part. Removed [CachedAttribute]
from MessageEvent.data, since it is now a DOMObject and needs not to be cached. | 10693 * dom/MessageEvent.idl: Changed SerializedScriptValue to DOMObject (i.e.
ScriptValue). This patch does not touch an ObjC part. Removed [CachedAttribute]
from MessageEvent.data, since it is now a DOMObject and needs not to be cached. |
1811 | 10694 |
1812 2011-10-19 Adam Barth <abarth@webkit.org> | 10695 2011-10-19 Adam Barth <abarth@webkit.org> |
1813 | 10696 |
1814 Attempt to fix GTK build. | 10697 Attempt to fix GTK build. |
1815 | 10698 |
1816 * GNUmakefile.am: | 10699 * GNUmakefile.am: |
1817 | 10700 |
1818 == Rolled over to ChangeLog-2011-10-19 == | 10701 == Rolled over to ChangeLog-2011-10-19 == |
OLD | NEW |