Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: runtime/vm/dart_api_impl.h

Issue 8492015: Allow printf-style arguments for Dart_Error and Api::Error. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/dart_api_impl.h
===================================================================
--- runtime/vm/dart_api_impl.h (revision 1265)
+++ runtime/vm/dart_api_impl.h (working copy)
@@ -17,39 +17,41 @@
class Api : AllStatic {
public:
- // Create new local handles.
+ // Creates a new local handle.
static Dart_Handle NewLocalHandle(const Object& object);
- // Unwrap the raw object from the handle.
+ // Unwraps the raw object from the handle.
static RawObject* UnwrapHandle(Dart_Handle object);
- // Validate and convert the passed in handle as a local handle.
+ // Validates and converts the passed in handle as a local handle.
static LocalHandle* UnwrapAsLocalHandle(const ApiState& state,
Dart_Handle object);
- // Validate and convert the passed in handle as a persistent handle.
+ // Validates and converts the passed in handle as a persistent handle.
static PersistentHandle* UnwrapAsPersistentHandle(const ApiState& state,
Dart_Handle object);
- // Get the handle used to designate successful return.
+ // Gets the handle used to designate successful return.
static Dart_Handle Success();
- // Generate a handle used to designate an error return.
- static Dart_Handle Error(const char* msg);
+ // Generates a handle used to designate an error return.
+ static Dart_Handle Error(const char* format, ...);
- // Get a handle to Null.
+ static Dart_Handle VError(const char* format, va_list args);
+
+ // Gets a handle to Null.
static Dart_Handle Null();
- // Get a handle to True.
+ // Gets a handle to True.
static Dart_Handle True();
- // Get a handle to False
+ // Gets a handle to False
static Dart_Handle False();
- // Allocate space in the local zone.
+ // Allocates space in the local zone.
static uword Allocate(intptr_t size);
- // Reallocate space in the local zone.
+ // Reallocates space in the local zone.
static uword Reallocate(uword ptr, intptr_t old_size, intptr_t new_size);
};

Powered by Google App Engine
This is Rietveld 408576698