Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1909)

Unified Diff: tests/standalone/src/TestRunnerTest.dart

Issue 8492013: Add asynchronous test suite runner to Dart rewrite of test scripts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix TestRunnerTest to use new TestCase constructor. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/src/TestRunnerTest.dart
diff --git a/tests/standalone/src/TestRunnerTest.dart b/tests/standalone/src/TestRunnerTest.dart
index 5892bda005dc2ff5a2cea90abe6a72aa0ee71806..d3ad97b265aac107b89245c6eef46d7369185650 100644
--- a/tests/standalone/src/TestRunnerTest.dart
+++ b/tests/standalone/src/TestRunnerTest.dart
@@ -44,7 +44,7 @@ TestCase MakeTestCase(String testName, List<String> expectations) {
test_path = "../tests/standalone/src/${testName}.dart";
}
- return new TestCase(getDartShellFileName(),
+ return new TestCase(testName, getDartShellFileName(),
Mads Ager (google) 2011/11/08 14:58:21 I would move argument two to a separate line.
<String>["--ignore-unrecognized-flags",
"--enable_type_checks",
test_path],
@@ -73,7 +73,7 @@ void main() {
new RunningProcess(MakeTestCase("FailTest", [FAIL]), timeout).start();
new RunningProcess(MakeTestCase("TimeoutTest", [TIMEOUT]), timeout).start();
- new RunningProcess(new TestCase(getProcessTestFileName(),
+ new RunningProcess(new TestCase("CrashTest", getProcessTestFileName(),
Mads Ager (google) 2011/11/08 14:58:21 Ditto.
const ["0", "0", "1", "1"],
TestController.processCompletedTest,
new Set<String>.from([CRASH])),

Powered by Google App Engine
This is Rietveld 408576698